[INFO] crate cpp_demangle 0.2.12 is already in cache [INFO] extracting crate cpp_demangle 0.2.12 into work/ex/clippy-test-run/sources/stable/reg/cpp_demangle/0.2.12 [INFO] extracting crate cpp_demangle 0.2.12 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cpp_demangle/0.2.12 [INFO] validating manifest of cpp_demangle-0.2.12 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cpp_demangle-0.2.12 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cpp_demangle-0.2.12 [INFO] finished frobbing cpp_demangle-0.2.12 [INFO] frobbed toml for cpp_demangle-0.2.12 written to work/ex/clippy-test-run/sources/stable/reg/cpp_demangle/0.2.12/Cargo.toml [INFO] started frobbing cpp_demangle-0.2.12 [INFO] finished frobbing cpp_demangle-0.2.12 [INFO] frobbed toml for cpp_demangle-0.2.12 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cpp_demangle/0.2.12/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cpp_demangle-0.2.12 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cpp_demangle/0.2.12:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 992013aa5c9f9779d5386a7ebf0f195468f143fdaa39b7779e33592dc4ef7d74 [INFO] running `"docker" "start" "-a" "992013aa5c9f9779d5386a7ebf0f195468f143fdaa39b7779e33592dc4ef7d74"` [INFO] [stderr] Compiling cpp_demangle v0.2.12 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `inline_always` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:36:10 [INFO] [stderr] | [INFO] [stderr] 36 | #![allow(inline_always)] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::inline_always` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/ast.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/ast.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:390:13 [INFO] [stderr] | [INFO] [stderr] 390 | item: item, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `item` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:520:13 [INFO] [stderr] | [INFO] [stderr] 520 | subs: subs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `subs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:522:13 [INFO] [stderr] | [INFO] [stderr] 522 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:523:13 [INFO] [stderr] | [INFO] [stderr] 523 | out: out, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:527:13 [INFO] [stderr] | [INFO] [stderr] 527 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:636:13 [INFO] [stderr] | [INFO] [stderr] 636 | ctx: ctx, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:637:13 [INFO] [stderr] | [INFO] [stderr] 637 | saved_inner: saved_inner, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `saved_inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/ast.rs:887:31 [INFO] [stderr] | [INFO] [stderr] 887 | write!(ctx, "{}", ')')?; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:3488:13 [INFO] [stderr] | [INFO] [stderr] 3488 | restrict: restrict, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `restrict` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:3489:13 [INFO] [stderr] | [INFO] [stderr] 3489 | volatile: volatile, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `volatile` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:3490:13 [INFO] [stderr] | [INFO] [stderr] 3490 | const_: const_, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `const_` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:3761:13 [INFO] [stderr] | [INFO] [stderr] 3761 | cv_qualifiers: cv_qualifiers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cv_qualifiers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:3762:13 [INFO] [stderr] | [INFO] [stderr] 3762 | transaction_safe: transaction_safe, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transaction_safe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:3763:13 [INFO] [stderr] | [INFO] [stderr] 3763 | extern_c: extern_c, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `extern_c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:3764:13 [INFO] [stderr] | [INFO] [stderr] 3764 | bare: bare, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bare` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:3765:13 [INFO] [stderr] | [INFO] [stderr] 3765 | ref_qualifier: ref_qualifier, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ref_qualifier` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `cyclomatic_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/ast.rs:5003:13 [INFO] [stderr] | [INFO] [stderr] 5003 | #[allow(cyclomatic_complexity)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cyclomatic_complexity` [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index_str.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | string: string, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `string` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:161:13 [INFO] [stderr] | [INFO] [stderr] 161 | raw: raw, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `raw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | substitutions: substitutions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `substitutions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:163:13 [INFO] [stderr] | [INFO] [stderr] 163 | parsed: parsed, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:247:13 [INFO] [stderr] | [INFO] [stderr] 247 | substitutions: substitutions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `substitutions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:248:13 [INFO] [stderr] | [INFO] [stderr] 248 | parsed: parsed, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `inline_always` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:36:10 [INFO] [stderr] | [INFO] [stderr] 36 | #![allow(inline_always)] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::inline_always` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/ast.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/ast.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:390:13 [INFO] [stderr] | [INFO] [stderr] 390 | item: item, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `item` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:520:13 [INFO] [stderr] | [INFO] [stderr] 520 | subs: subs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `subs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:522:13 [INFO] [stderr] | [INFO] [stderr] 522 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:523:13 [INFO] [stderr] | [INFO] [stderr] 523 | out: out, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:527:13 [INFO] [stderr] | [INFO] [stderr] 527 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:636:13 [INFO] [stderr] | [INFO] [stderr] 636 | ctx: ctx, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:637:13 [INFO] [stderr] | [INFO] [stderr] 637 | saved_inner: saved_inner, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `saved_inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/ast.rs:887:31 [INFO] [stderr] | [INFO] [stderr] 887 | write!(ctx, "{}", ')')?; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:3488:13 [INFO] [stderr] | [INFO] [stderr] 3488 | restrict: restrict, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `restrict` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:3489:13 [INFO] [stderr] | [INFO] [stderr] 3489 | volatile: volatile, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `volatile` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:3490:13 [INFO] [stderr] | [INFO] [stderr] 3490 | const_: const_, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `const_` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:3761:13 [INFO] [stderr] | [INFO] [stderr] 3761 | cv_qualifiers: cv_qualifiers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cv_qualifiers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:3762:13 [INFO] [stderr] | [INFO] [stderr] 3762 | transaction_safe: transaction_safe, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transaction_safe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:3763:13 [INFO] [stderr] | [INFO] [stderr] 3763 | extern_c: extern_c, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `extern_c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:3764:13 [INFO] [stderr] | [INFO] [stderr] 3764 | bare: bare, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bare` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:3765:13 [INFO] [stderr] | [INFO] [stderr] 3765 | ref_qualifier: ref_qualifier, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ref_qualifier` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `cyclomatic_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/ast.rs:5003:13 [INFO] [stderr] | [INFO] [stderr] 5003 | #[allow(cyclomatic_complexity)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cyclomatic_complexity` [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/index_str.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | string: string, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `string` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:161:13 [INFO] [stderr] | [INFO] [stderr] 161 | raw: raw, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `raw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | substitutions: substitutions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `substitutions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:163:13 [INFO] [stderr] | [INFO] [stderr] 163 | parsed: parsed, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:247:13 [INFO] [stderr] | [INFO] [stderr] 247 | substitutions: substitutions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `substitutions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:248:13 [INFO] [stderr] | [INFO] [stderr] 248 | parsed: parsed, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `inline_always` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:36:10 [INFO] [stderr] | [INFO] [stderr] 36 | #![allow(inline_always)] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::inline_always` [INFO] [stderr] [INFO] [stderr] warning: lint name `ptr_arg` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/ast.rs:776:21 [INFO] [stderr] | [INFO] [stderr] 776 | #[allow(ptr_arg)] [INFO] [stderr] | ^^^^^^^ help: change it to: `clippy::ptr_arg` [INFO] [stderr] ... [INFO] [stderr] 813 | reference_newtype!(FunctionArgList, Vec); [INFO] [stderr] | ----------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: lint name `ptr_arg` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/ast.rs:776:21 [INFO] [stderr] | [INFO] [stderr] 776 | #[allow(ptr_arg)] [INFO] [stderr] | ^^^^^^^ help: change it to: `clippy::ptr_arg` [INFO] [stderr] ... [INFO] [stderr] 817 | reference_newtype!(FunctionArgListAndReturnType, Vec); [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: lint name `ptr_arg` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/ast.rs:776:21 [INFO] [stderr] | [INFO] [stderr] 776 | #[allow(ptr_arg)] [INFO] [stderr] | ^^^^^^^ help: change it to: `clippy::ptr_arg` [INFO] [stderr] ... [INFO] [stderr] 821 | reference_newtype!(FunctionArgSlice, [TypeHandle]); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ast.rs:1763:18 [INFO] [stderr] | [INFO] [stderr] 1763 | _ => return Err(error::Error::UnexpectedText), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error::Error::UnexpectedText)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: lint name `inline_always` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:36:10 [INFO] [stderr] | [INFO] [stderr] 36 | #![allow(inline_always)] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::inline_always` [INFO] [stderr] [INFO] [stderr] warning: lint name `ptr_arg` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/ast.rs:776:21 [INFO] [stderr] | [INFO] [stderr] 776 | #[allow(ptr_arg)] [INFO] [stderr] | ^^^^^^^ help: change it to: `clippy::ptr_arg` [INFO] [stderr] ... [INFO] [stderr] 813 | reference_newtype!(FunctionArgList, Vec); [INFO] [stderr] | ----------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: lint name `ptr_arg` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/ast.rs:776:21 [INFO] [stderr] | [INFO] [stderr] 776 | #[allow(ptr_arg)] [INFO] [stderr] | ^^^^^^^ help: change it to: `clippy::ptr_arg` [INFO] [stderr] ... [INFO] [stderr] 817 | reference_newtype!(FunctionArgListAndReturnType, Vec); [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: lint name `ptr_arg` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/ast.rs:776:21 [INFO] [stderr] | [INFO] [stderr] 776 | #[allow(ptr_arg)] [INFO] [stderr] | ^^^^^^^ help: change it to: `clippy::ptr_arg` [INFO] [stderr] ... [INFO] [stderr] 821 | reference_newtype!(FunctionArgSlice, [TypeHandle]); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ast.rs:1763:18 [INFO] [stderr] | [INFO] [stderr] 1763 | _ => return Err(error::Error::UnexpectedText), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error::Error::UnexpectedText)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ast.rs:395:9 [INFO] [stderr] | [INFO] [stderr] 395 | / match self { [INFO] [stderr] 396 | | &None => true, [INFO] [stderr] 397 | | &Some(s) => s.prev.is_none(), [INFO] [stderr] 398 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 395 | match *self { [INFO] [stderr] 396 | None => true, [INFO] [stderr] 397 | Some(s) => s.prev.is_none(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/ast.rs:561:12 [INFO] [stderr] | [INFO] [stderr] 561 | if { [INFO] [stderr] | ____________^ [INFO] [stderr] 562 | | let last = match self.inner.last() { [INFO] [stderr] 563 | | None => return false, [INFO] [stderr] 564 | | Some(last) => *last, [INFO] [stderr] 565 | | }; [INFO] [stderr] 566 | | ptr::eq(last, inner) [INFO] [stderr] 567 | | } { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: try [INFO] [stderr] let res = { [INFO] [stderr] let last = match self.inner.last() { [INFO] [stderr] None => return false, [INFO] [stderr] Some(last) => *last, [INFO] [stderr] }; [INFO] [stderr] ptr::eq(last, inner) [INFO] [stderr] }; [INFO] [stderr] if res { [INFO] [stderr] self.inner.pop(); [INFO] [stderr] true [INFO] [stderr] } ... [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/ast.rs:785:21 [INFO] [stderr] | [INFO] [stderr] 785 | mem::transmute(types) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(types as *const std::vec::Vec as *const ast::FunctionArgList)` [INFO] [stderr] ... [INFO] [stderr] 813 | reference_newtype!(FunctionArgList, Vec); [INFO] [stderr] | ----------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/ast.rs:785:21 [INFO] [stderr] | [INFO] [stderr] 785 | mem::transmute(types) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(types as *const std::vec::Vec as *const ast::FunctionArgListAndReturnType)` [INFO] [stderr] ... [INFO] [stderr] 817 | reference_newtype!(FunctionArgListAndReturnType, Vec); [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/ast.rs:785:21 [INFO] [stderr] | [INFO] [stderr] 785 | mem::transmute(types) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(types as *const [ast::TypeHandle] as *const ast::FunctionArgSlice)` [INFO] [stderr] ... [INFO] [stderr] 821 | reference_newtype!(FunctionArgSlice, [TypeHandle]); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/ast.rs:1305:31 [INFO] [stderr] | [INFO] [stderr] 1305 | debug_assert!(fun_ty.0.len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!fun_ty.0.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ast.rs:1925:9 [INFO] [stderr] | [INFO] [stderr] 1925 | / fn save<'a, 'b>( [INFO] [stderr] 1926 | | subs: &'a mut SubstitutionTable, [INFO] [stderr] 1927 | | prefix: Prefix, [INFO] [stderr] 1928 | | tail_tail: IndexStr<'b>, [INFO] [stderr] ... | [INFO] [stderr] 1941 | | } [INFO] [stderr] 1942 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ast.rs:2602:9 [INFO] [stderr] | [INFO] [stderr] 2602 | / match self { [INFO] [stderr] 2603 | | &OperatorName::Cast(_) | [INFO] [stderr] 2604 | | &OperatorName::Conversion(_) | [INFO] [stderr] 2605 | | &OperatorName::Literal(_) => 1, [INFO] [stderr] 2606 | | &OperatorName::Simple(ref s) => s.arity(), [INFO] [stderr] 2607 | | &OperatorName::VendorExtension(arity, _) => arity, [INFO] [stderr] 2608 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2602 | match *self { [INFO] [stderr] 2603 | OperatorName::Cast(_) | [INFO] [stderr] 2604 | OperatorName::Conversion(_) | [INFO] [stderr] 2605 | OperatorName::Literal(_) => 1, [INFO] [stderr] 2606 | OperatorName::Simple(ref s) => s.arity(), [INFO] [stderr] 2607 | OperatorName::VendorExtension(arity, _) => arity, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ast.rs:395:9 [INFO] [stderr] | [INFO] [stderr] 395 | / match self { [INFO] [stderr] 396 | | &None => true, [INFO] [stderr] 397 | | &Some(s) => s.prev.is_none(), [INFO] [stderr] 398 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 395 | match *self { [INFO] [stderr] 396 | None => true, [INFO] [stderr] 397 | Some(s) => s.prev.is_none(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/ast.rs:561:12 [INFO] [stderr] | [INFO] [stderr] 561 | if { [INFO] [stderr] | ____________^ [INFO] [stderr] 562 | | let last = match self.inner.last() { [INFO] [stderr] 563 | | None => return false, [INFO] [stderr] 564 | | Some(last) => *last, [INFO] [stderr] 565 | | }; [INFO] [stderr] 566 | | ptr::eq(last, inner) [INFO] [stderr] 567 | | } { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: try [INFO] [stderr] let res = { [INFO] [stderr] let last = match self.inner.last() { [INFO] [stderr] None => return false, [INFO] [stderr] Some(last) => *last, [INFO] [stderr] }; [INFO] [stderr] ptr::eq(last, inner) [INFO] [stderr] }; [INFO] [stderr] if res { [INFO] [stderr] self.inner.pop(); [INFO] [stderr] true [INFO] [stderr] } ... [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/ast.rs:785:21 [INFO] [stderr] | [INFO] [stderr] 785 | mem::transmute(types) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(types as *const std::vec::Vec as *const ast::FunctionArgList)` [INFO] [stderr] ... [INFO] [stderr] 813 | reference_newtype!(FunctionArgList, Vec); [INFO] [stderr] | ----------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/ast.rs:785:21 [INFO] [stderr] | [INFO] [stderr] 785 | mem::transmute(types) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(types as *const std::vec::Vec as *const ast::FunctionArgListAndReturnType)` [INFO] [stderr] ... [INFO] [stderr] 817 | reference_newtype!(FunctionArgListAndReturnType, Vec); [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/ast.rs:785:21 [INFO] [stderr] | [INFO] [stderr] 785 | mem::transmute(types) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(types as *const [ast::TypeHandle] as *const ast::FunctionArgSlice)` [INFO] [stderr] ... [INFO] [stderr] 821 | reference_newtype!(FunctionArgSlice, [TypeHandle]); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/ast.rs:1305:31 [INFO] [stderr] | [INFO] [stderr] 1305 | debug_assert!(fun_ty.0.len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!fun_ty.0.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ast.rs:1925:9 [INFO] [stderr] | [INFO] [stderr] 1925 | / fn save<'a, 'b>( [INFO] [stderr] 1926 | | subs: &'a mut SubstitutionTable, [INFO] [stderr] 1927 | | prefix: Prefix, [INFO] [stderr] 1928 | | tail_tail: IndexStr<'b>, [INFO] [stderr] ... | [INFO] [stderr] 1941 | | } [INFO] [stderr] 1942 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ast.rs:2602:9 [INFO] [stderr] | [INFO] [stderr] 2602 | / match self { [INFO] [stderr] 2603 | | &OperatorName::Cast(_) | [INFO] [stderr] 2604 | | &OperatorName::Conversion(_) | [INFO] [stderr] 2605 | | &OperatorName::Literal(_) => 1, [INFO] [stderr] 2606 | | &OperatorName::Simple(ref s) => s.arity(), [INFO] [stderr] 2607 | | &OperatorName::VendorExtension(arity, _) => arity, [INFO] [stderr] 2608 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2602 | match *self { [INFO] [stderr] 2603 | OperatorName::Cast(_) | [INFO] [stderr] 2604 | OperatorName::Conversion(_) | [INFO] [stderr] 2605 | OperatorName::Literal(_) => 1, [INFO] [stderr] 2606 | OperatorName::Simple(ref s) => s.arity(), [INFO] [stderr] 2607 | OperatorName::VendorExtension(arity, _) => arity, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:156:28 [INFO] [stderr] | [INFO] [stderr] 156 | return Err(Error::UnexpectedText.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::UnexpectedText` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:199:37 [INFO] [stderr] | [INFO] [stderr] 199 | pub fn demangle(&self, options: &DemangleOptions) -> ::std::result::Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `DemangleOptions` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/lib.rs:257:37 [INFO] [stderr] | [INFO] [stderr] 257 | String::from_utf8_lossy(symbol.raw.as_ref()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `symbol.raw` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_range_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> examples/cppfilt.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | #[allow(needless_range_loop)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_range_loop` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/ast.rs:7220:20 [INFO] [stderr] | [INFO] [stderr] 7220 | if &subs[..] != &expected_subs[..] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 7220 | if subs[..] != expected_subs[..] { [INFO] [stderr] | ^^^^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:156:28 [INFO] [stderr] | [INFO] [stderr] 156 | return Err(Error::UnexpectedText.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::UnexpectedText` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:199:37 [INFO] [stderr] | [INFO] [stderr] 199 | pub fn demangle(&self, options: &DemangleOptions) -> ::std::result::Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `DemangleOptions` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/lib.rs:257:37 [INFO] [stderr] | [INFO] [stderr] 257 | String::from_utf8_lossy(symbol.raw.as_ref()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `symbol.raw` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_range_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> examples/cppfilt.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | #[allow(needless_range_loop)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_range_loop` [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> examples/cppfilt.rs:37:56 [INFO] [stderr] | [INFO] [stderr] 37 | fn demangle_line(out: &mut W, line: &[u8], options: &DemangleOptions) -> io::Result<()> [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `DemangleOptions` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> examples/cppfilt.rs:61:60 [INFO] [stderr] | [INFO] [stderr] 61 | fn demangle_all(input: &mut R, out: &mut W, options: &DemangleOptions) -> io::Result<()> [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `DemangleOptions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.26s [INFO] running `"docker" "inspect" "992013aa5c9f9779d5386a7ebf0f195468f143fdaa39b7779e33592dc4ef7d74"` [INFO] running `"docker" "rm" "-f" "992013aa5c9f9779d5386a7ebf0f195468f143fdaa39b7779e33592dc4ef7d74"` [INFO] [stdout] 992013aa5c9f9779d5386a7ebf0f195468f143fdaa39b7779e33592dc4ef7d74