[INFO] crate cpp-typecheck 0.4.0 is already in cache [INFO] extracting crate cpp-typecheck 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/cpp-typecheck/0.4.0 [INFO] extracting crate cpp-typecheck 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cpp-typecheck/0.4.0 [INFO] validating manifest of cpp-typecheck-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cpp-typecheck-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cpp-typecheck-0.4.0 [INFO] finished frobbing cpp-typecheck-0.4.0 [INFO] frobbed toml for cpp-typecheck-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/cpp-typecheck/0.4.0/Cargo.toml [INFO] started frobbing cpp-typecheck-0.4.0 [INFO] finished frobbing cpp-typecheck-0.4.0 [INFO] frobbed toml for cpp-typecheck-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cpp-typecheck/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cpp-typecheck-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cpp-typecheck/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 98f926e4e7369a4bd753152f53f060ce7e0837f3da778de10f27f4c485ab56b9 [INFO] running `"docker" "start" "-a" "98f926e4e7369a4bd753152f53f060ce7e0837f3da778de10f27f4c485ab56b9"` [INFO] [stderr] Checking error-type v0.1.2 [INFO] [stderr] Checking atomicwrites v0.1.5 [INFO] [stderr] Checking cpp-typecheck v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:121:12 [INFO] [stderr] | [INFO] [stderr] 121 | source_file: source_file, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:122:12 [INFO] [stderr] | [INFO] [stderr] 122 | db_files: db_files, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `db_files` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:201:17 [INFO] [stderr] | [INFO] [stderr] 201 | cpp_file: cpp_file [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `cpp_file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:236:25 [INFO] [stderr] | [INFO] [stderr] 236 | cpp_file: cpp_file, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `cpp_file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cmd.rs:50:53 [INFO] [stderr] | [INFO] [stderr] 50 | Ok(Some(Cmd { directory: dir, command: cmd, file: file })) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cmd.rs:95:48 [INFO] [stderr] | [INFO] [stderr] 95 | Ok(Cmd { directory: dir, command: cmd, file: file }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:121:12 [INFO] [stderr] | [INFO] [stderr] 121 | source_file: source_file, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:122:12 [INFO] [stderr] | [INFO] [stderr] 122 | db_files: db_files, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `db_files` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:201:17 [INFO] [stderr] | [INFO] [stderr] 201 | cpp_file: cpp_file [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `cpp_file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:236:25 [INFO] [stderr] | [INFO] [stderr] 236 | cpp_file: cpp_file, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `cpp_file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cmd.rs:50:53 [INFO] [stderr] | [INFO] [stderr] 50 | Ok(Some(Cmd { directory: dir, command: cmd, file: file })) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cmd.rs:95:48 [INFO] [stderr] | [INFO] [stderr] 95 | Ok(Cmd { directory: dir, command: cmd, file: file }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/dirs.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/dirs.rs:9:14 [INFO] [stderr] | [INFO] [stderr] 9 | .ok_or("Couldn't read home directory!".into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Couldn't read home directory!".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/dirs.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/config.rs:109:20 [INFO] [stderr] | [INFO] [stderr] 109 | .ok_or(format!("Couldn't get directory of source file '{}'!", src_file.display()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Couldn't get directory of source file '{}'!", src_file.display()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/config.rs:132:8 [INFO] [stderr] | [INFO] [stderr] 132 | / match self.source_file { [INFO] [stderr] 133 | | SourceFile::FromHeaderWithTmpSource { ref command, .. } => { [INFO] [stderr] 134 | | let compiler = if let Some(ref c) = self.compiler { [INFO] [stderr] 135 | | c [INFO] [stderr] ... | [INFO] [stderr] 144 | | _ => () [INFO] [stderr] 145 | | }; [INFO] [stderr] | |________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 132 | if let SourceFile::FromHeaderWithTmpSource { ref command, .. } = self.source_file { [INFO] [stderr] 133 | let compiler = if let Some(ref c) = self.compiler { [INFO] [stderr] 134 | c [INFO] [stderr] 135 | } else { [INFO] [stderr] 136 | command.get_compiler()? [INFO] [stderr] 137 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/config.rs:212:14 [INFO] [stderr] | [INFO] [stderr] 212 | .ok_or(format!("Couldn't get directory of source file '{}'!", src_file.display()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Couldn't get directory of source file '{}'!", src_file.display()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cmd.rs:40:14 [INFO] [stderr] | [INFO] [stderr] 40 | .ok_or(format!("Expected directory in first line of string:\n{}", cmd_str))?); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Expected directory in first line of string:\n{}", cmd_str))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cmd.rs:43:14 [INFO] [stderr] | [INFO] [stderr] 43 | .ok_or(format!("Expected command in second line of string:\n{}", cmd_str))?); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Expected command in second line of string:\n{}", cmd_str))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cmd.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | .ok_or(format!("Expected file in third line of string:\n{}", cmd_str))?); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Expected file in third line of string:\n{}", cmd_str))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cmd.rs:61:46 [INFO] [stderr] | [INFO] [stderr] 61 | let objs = json_value.as_array().ok_or(format!("Expected a json array but got: '{}'", json_value))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Expected a json array but got: '{}'", json_value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cmd.rs:64:43 [INFO] [stderr] | [INFO] [stderr] 64 | let obj = obj.as_object().ok_or(format!("Expected a json object but got: '{}'", obj))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Expected a json object but got: '{}'", obj))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cmd.rs:78:14 [INFO] [stderr] | [INFO] [stderr] 78 | .ok_or(format!("Couldn't find string entry 'directory' in json object: '{:?}'", obj))?); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Couldn't find string entry 'directory' in json object: '{:?}'", obj))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cmd.rs:82:18 [INFO] [stderr] | [INFO] [stderr] 82 | .ok_or(format!("Couldn't find string entry 'file' in json object: '{:?}'", obj))?); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Couldn't find string entry 'file' in json object: '{:?}'", obj))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cmd.rs:92:14 [INFO] [stderr] | [INFO] [stderr] 92 | .ok_or(format!("Couldn't find string entry 'command' in json object: '{:?}'", obj))?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Couldn't find string entry 'command' in json object: '{:?}'", obj))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/cmd.rs:134:44 [INFO] [stderr] | [INFO] [stderr] 134 | let mut parts = self.command.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cmd.rs:135:22 [INFO] [stderr] | [INFO] [stderr] 135 | parts.next().ok_or(format!("Unexpected empty parts after command split of: {}!", self.command).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Unexpected empty parts after command split of: {}!", self.command).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/cmd.rs:139:44 [INFO] [stderr] | [INFO] [stderr] 139 | let mut parts = self.command.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/dirs.rs:9:14 [INFO] [stderr] | [INFO] [stderr] 9 | .ok_or("Couldn't read home directory!".into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Couldn't read home directory!".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/config.rs:109:20 [INFO] [stderr] | [INFO] [stderr] 109 | .ok_or(format!("Couldn't get directory of source file '{}'!", src_file.display()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Couldn't get directory of source file '{}'!", src_file.display()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/config.rs:132:8 [INFO] [stderr] | [INFO] [stderr] 132 | / match self.source_file { [INFO] [stderr] 133 | | SourceFile::FromHeaderWithTmpSource { ref command, .. } => { [INFO] [stderr] 134 | | let compiler = if let Some(ref c) = self.compiler { [INFO] [stderr] 135 | | c [INFO] [stderr] ... | [INFO] [stderr] 144 | | _ => () [INFO] [stderr] 145 | | }; [INFO] [stderr] | |________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 132 | if let SourceFile::FromHeaderWithTmpSource { ref command, .. } = self.source_file { [INFO] [stderr] 133 | let compiler = if let Some(ref c) = self.compiler { [INFO] [stderr] 134 | c [INFO] [stderr] 135 | } else { [INFO] [stderr] 136 | command.get_compiler()? [INFO] [stderr] 137 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/config.rs:212:14 [INFO] [stderr] | [INFO] [stderr] 212 | .ok_or(format!("Couldn't get directory of source file '{}'!", src_file.display()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Couldn't get directory of source file '{}'!", src_file.display()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cmd.rs:40:14 [INFO] [stderr] | [INFO] [stderr] 40 | .ok_or(format!("Expected directory in first line of string:\n{}", cmd_str))?); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Expected directory in first line of string:\n{}", cmd_str))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cmd.rs:43:14 [INFO] [stderr] | [INFO] [stderr] 43 | .ok_or(format!("Expected command in second line of string:\n{}", cmd_str))?); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Expected command in second line of string:\n{}", cmd_str))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cmd.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | .ok_or(format!("Expected file in third line of string:\n{}", cmd_str))?); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Expected file in third line of string:\n{}", cmd_str))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cmd.rs:61:46 [INFO] [stderr] | [INFO] [stderr] 61 | let objs = json_value.as_array().ok_or(format!("Expected a json array but got: '{}'", json_value))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Expected a json array but got: '{}'", json_value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cmd.rs:64:43 [INFO] [stderr] | [INFO] [stderr] 64 | let obj = obj.as_object().ok_or(format!("Expected a json object but got: '{}'", obj))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Expected a json object but got: '{}'", obj))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cmd.rs:78:14 [INFO] [stderr] | [INFO] [stderr] 78 | .ok_or(format!("Couldn't find string entry 'directory' in json object: '{:?}'", obj))?); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Couldn't find string entry 'directory' in json object: '{:?}'", obj))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cmd.rs:82:18 [INFO] [stderr] | [INFO] [stderr] 82 | .ok_or(format!("Couldn't find string entry 'file' in json object: '{:?}'", obj))?); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Couldn't find string entry 'file' in json object: '{:?}'", obj))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cmd.rs:92:14 [INFO] [stderr] | [INFO] [stderr] 92 | .ok_or(format!("Couldn't find string entry 'command' in json object: '{:?}'", obj))?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Couldn't find string entry 'command' in json object: '{:?}'", obj))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/cmd.rs:134:44 [INFO] [stderr] | [INFO] [stderr] 134 | let mut parts = self.command.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cmd.rs:135:22 [INFO] [stderr] | [INFO] [stderr] 135 | parts.next().ok_or(format!("Unexpected empty parts after command split of: {}!", self.command).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Unexpected empty parts after command split of: {}!", self.command).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/cmd.rs:139:44 [INFO] [stderr] | [INFO] [stderr] 139 | let mut parts = self.command.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.90s [INFO] running `"docker" "inspect" "98f926e4e7369a4bd753152f53f060ce7e0837f3da778de10f27f4c485ab56b9"` [INFO] running `"docker" "rm" "-f" "98f926e4e7369a4bd753152f53f060ce7e0837f3da778de10f27f4c485ab56b9"` [INFO] [stdout] 98f926e4e7369a4bd753152f53f060ce7e0837f3da778de10f27f4c485ab56b9