[INFO] crate coveralls-api 0.3.3 is already in cache [INFO] extracting crate coveralls-api 0.3.3 into work/ex/clippy-test-run/sources/stable/reg/coveralls-api/0.3.3 [INFO] extracting crate coveralls-api 0.3.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/coveralls-api/0.3.3 [INFO] validating manifest of coveralls-api-0.3.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of coveralls-api-0.3.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing coveralls-api-0.3.3 [INFO] finished frobbing coveralls-api-0.3.3 [INFO] frobbed toml for coveralls-api-0.3.3 written to work/ex/clippy-test-run/sources/stable/reg/coveralls-api/0.3.3/Cargo.toml [INFO] started frobbing coveralls-api-0.3.3 [INFO] finished frobbing coveralls-api-0.3.3 [INFO] frobbed toml for coveralls-api-0.3.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/coveralls-api/0.3.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting coveralls-api-0.3.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/coveralls-api/0.3.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1574f38ea1abd333747797bb3887691910a3d1739f7486804430c93f3269055e [INFO] running `"docker" "start" "-a" "1574f38ea1abd333747797bb3887691910a3d1739f7486804430c93f3269055e"` [INFO] [stderr] Checking deflate v0.7.19 [INFO] [stderr] Checking coveralls-api v0.3.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:213:13 [INFO] [stderr] | [INFO] [stderr] 213 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:213:13 [INFO] [stderr] | [INFO] [stderr] 213 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:37:30 [INFO] [stderr] | [INFO] [stderr] 37 | fn expand_branches(branches: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[BranchData]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:89:20 [INFO] [stderr] | [INFO] [stderr] 89 | let brch = match branches { [INFO] [stderr] | ____________________^ [INFO] [stderr] 90 | | &Some(ref b) => Some(expand_branches(&b)), [INFO] [stderr] 91 | | &None => None, [INFO] [stderr] 92 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 89 | let brch = match *branches { [INFO] [stderr] 90 | Some(ref b) => Some(expand_branches(&b)), [INFO] [stderr] 91 | None => None, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:156:5 [INFO] [stderr] | [INFO] [stderr] 156 | / fn value<'a>(&'a self) -> &'a str { [INFO] [stderr] 157 | | use CiService::*; [INFO] [stderr] 158 | | // Only travis and ruby have special features but the others might gain [INFO] [stderr] 159 | | // those features in future so best to put them all for now. [INFO] [stderr] ... | [INFO] [stderr] 168 | | } [INFO] [stderr] 169 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:37:30 [INFO] [stderr] | [INFO] [stderr] 37 | fn expand_branches(branches: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[BranchData]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:89:20 [INFO] [stderr] | [INFO] [stderr] 89 | let brch = match branches { [INFO] [stderr] | ____________________^ [INFO] [stderr] 90 | | &Some(ref b) => Some(expand_branches(&b)), [INFO] [stderr] 91 | | &None => None, [INFO] [stderr] 92 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 89 | let brch = match *branches { [INFO] [stderr] 90 | Some(ref b) => Some(expand_branches(&b)), [INFO] [stderr] 91 | None => None, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:156:5 [INFO] [stderr] | [INFO] [stderr] 156 | / fn value<'a>(&'a self) -> &'a str { [INFO] [stderr] 157 | | use CiService::*; [INFO] [stderr] 158 | | // Only travis and ruby have special features but the others might gain [INFO] [stderr] 159 | | // those features in future so best to put them all for now. [INFO] [stderr] ... | [INFO] [stderr] 168 | | } [INFO] [stderr] 169 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> tests/fill_in_example.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | Err(_) => panic!("COVERALLS_KEY is not set. Cannot test"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.29s [INFO] running `"docker" "inspect" "1574f38ea1abd333747797bb3887691910a3d1739f7486804430c93f3269055e"` [INFO] running `"docker" "rm" "-f" "1574f38ea1abd333747797bb3887691910a3d1739f7486804430c93f3269055e"` [INFO] [stdout] 1574f38ea1abd333747797bb3887691910a3d1739f7486804430c93f3269055e