[INFO] crate cov 0.0.5 is already in cache [INFO] extracting crate cov 0.0.5 into work/ex/clippy-test-run/sources/stable/reg/cov/0.0.5 [INFO] extracting crate cov 0.0.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cov/0.0.5 [INFO] validating manifest of cov-0.0.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cov-0.0.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cov-0.0.5 [INFO] removed 3 missing examples [INFO] removed 1 missing tests [INFO] finished frobbing cov-0.0.5 [INFO] frobbed toml for cov-0.0.5 written to work/ex/clippy-test-run/sources/stable/reg/cov/0.0.5/Cargo.toml [INFO] started frobbing cov-0.0.5 [INFO] removed 3 missing examples [INFO] removed 1 missing tests [INFO] finished frobbing cov-0.0.5 [INFO] frobbed toml for cov-0.0.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cov/0.0.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cov-0.0.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cov/0.0.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fe65ff8f22ea8bcc1dd367eb9b33d395c5b2b001087b4d6c266a45e99ad656d4 [INFO] running `"docker" "start" "-a" "fe65ff8f22ea8bcc1dd367eb9b33d395c5b2b001087b4d6c266a45e99ad656d4"` [INFO] [stderr] warning: An explicit [[example]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other example targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a example target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/examples/report.rs [INFO] [stderr] * /opt/crater/workdir/examples/graphviz.rs [INFO] [stderr] * /opt/crater/workdir/examples/dump.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a example target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autoexamples = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] warning: An explicit [[test]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other test targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a test target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/tests/gcov.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a test target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autotests = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Checking shawshank v0.2.3 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking cov v0.0.5 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `clippy_pedantic` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:61:54 [INFO] [stderr] | [INFO] [stderr] 61 | #![cfg_attr(feature = "cargo-clippy", warn(warnings, clippy_pedantic))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::pedantic` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `missing_docs_in_private_items` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:62:45 [INFO] [stderr] | [INFO] [stderr] 62 | #![cfg_attr(feature = "cargo-clippy", allow(missing_docs_in_private_items, use_debug, cast_possible_truncation))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::missing_docs_in_private_items` [INFO] [stderr] [INFO] [stderr] warning: lint name `use_debug` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:62:76 [INFO] [stderr] | [INFO] [stderr] 62 | #![cfg_attr(feature = "cargo-clippy", allow(missing_docs_in_private_items, use_debug, cast_possible_truncation))] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::use_debug` [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_possible_truncation` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:62:87 [INFO] [stderr] | [INFO] [stderr] 62 | #![cfg_attr(feature = "cargo-clippy", allow(missing_docs_in_private_items, use_debug, cast_possible_truncation))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cast_possible_truncation` [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/intern.rs:259:13 [INFO] [stderr] | [INFO] [stderr] 259 | interner: interner, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `interner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: binding's name is too similar to existing binding [INFO] [stderr] --> src/reader.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | let decoder = if self.is_big_endian { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:61:54 [INFO] [stderr] | [INFO] [stderr] 61 | #![cfg_attr(feature = "cargo-clippy", warn(warnings, clippy_pedantic))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = note: #[warn(clippy::similar_names)] implied by #[warn(clippy::pedantic)] [INFO] [stderr] note: existing binding defined here [INFO] [stderr] --> src/reader.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | let mut decoded = [0; 8]; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] help: separate the discriminating character by an underscore like: `decode_r` [INFO] [stderr] --> src/reader.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | let decoder = if self.is_big_endian { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#similar_names [INFO] [stderr] [INFO] [stderr] warning: binding's name is too similar to existing binding [INFO] [stderr] --> src/reader.rs:455:13 [INFO] [stderr] | [INFO] [stderr] 455 | let sum = self.read_64()?; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: existing binding defined here [INFO] [stderr] --> src/reader.rs:451:13 [INFO] [stderr] | [INFO] [stderr] 451 | let num = self.read_32()?; [INFO] [stderr] | ^^^ [INFO] [stderr] help: separate the discriminating character by an underscore like: `s_um` [INFO] [stderr] --> src/reader.rs:455:13 [INFO] [stderr] | [INFO] [stderr] 455 | let sum = self.read_64()?; [INFO] [stderr] | ^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#similar_names [INFO] [stderr] [INFO] [stderr] warning: binding's name is too similar to existing binding [INFO] [stderr] --> src/reader.rs:477:25 [INFO] [stderr] | [INFO] [stderr] 477 | let sum = s.read_64()?; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: existing binding defined here [INFO] [stderr] --> src/reader.rs:451:13 [INFO] [stderr] | [INFO] [stderr] 451 | let num = self.read_32()?; [INFO] [stderr] | ^^^ [INFO] [stderr] help: separate the discriminating character by an underscore like: `s_um` [INFO] [stderr] --> src/reader.rs:477:25 [INFO] [stderr] | [INFO] [stderr] 477 | let sum = s.read_64()?; [INFO] [stderr] | ^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#similar_names [INFO] [stderr] [INFO] [stderr] warning: binding's name is too similar to existing binding [INFO] [stderr] --> src/graph.rs:219:21 [INFO] [stderr] | [INFO] [stderr] 219 | let src = er.source(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: existing binding defined here [INFO] [stderr] --> src/graph.rs:214:21 [INFO] [stderr] | [INFO] [stderr] 214 | let arc = er.weight(); [INFO] [stderr] | ^^^ [INFO] [stderr] help: separate the discriminating character by an underscore like: `s_rc` [INFO] [stderr] --> src/graph.rs:219:21 [INFO] [stderr] | [INFO] [stderr] 219 | let src = er.source(); [INFO] [stderr] | ^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#similar_names [INFO] [stderr] [INFO] [stderr] warning: binding's name is too similar to existing binding [INFO] [stderr] --> src/graph.rs:963:17 [INFO] [stderr] | [INFO] [stderr] 963 | let arc = edge_ref.weight(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: existing binding defined here [INFO] [stderr] --> src/graph.rs:955:17 [INFO] [stderr] | [INFO] [stderr] 955 | let src = edge_ref.source(); [INFO] [stderr] | ^^^ [INFO] [stderr] help: separate the discriminating character by an underscore like: `a_rc` [INFO] [stderr] --> src/graph.rs:963:17 [INFO] [stderr] | [INFO] [stderr] 963 | let arc = edge_ref.weight(); [INFO] [stderr] | ^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#similar_names [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy_pedantic` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:61:54 [INFO] [stderr] | [INFO] [stderr] 61 | #![cfg_attr(feature = "cargo-clippy", warn(warnings, clippy_pedantic))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::pedantic` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `missing_docs_in_private_items` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:62:45 [INFO] [stderr] | [INFO] [stderr] 62 | #![cfg_attr(feature = "cargo-clippy", allow(missing_docs_in_private_items, use_debug, cast_possible_truncation))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::missing_docs_in_private_items` [INFO] [stderr] [INFO] [stderr] warning: lint name `use_debug` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:62:76 [INFO] [stderr] | [INFO] [stderr] 62 | #![cfg_attr(feature = "cargo-clippy", allow(missing_docs_in_private_items, use_debug, cast_possible_truncation))] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::use_debug` [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_possible_truncation` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:62:87 [INFO] [stderr] | [INFO] [stderr] 62 | #![cfg_attr(feature = "cargo-clippy", allow(missing_docs_in_private_items, use_debug, cast_possible_truncation))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cast_possible_truncation` [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/intern.rs:259:13 [INFO] [stderr] | [INFO] [stderr] 259 | interner: interner, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `interner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: binding's name is too similar to existing binding [INFO] [stderr] --> src/reader.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | let decoder = if self.is_big_endian { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:61:54 [INFO] [stderr] | [INFO] [stderr] 61 | #![cfg_attr(feature = "cargo-clippy", warn(warnings, clippy_pedantic))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = note: #[warn(clippy::similar_names)] implied by #[warn(clippy::pedantic)] [INFO] [stderr] note: existing binding defined here [INFO] [stderr] --> src/reader.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | let mut decoded = [0; 8]; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] help: separate the discriminating character by an underscore like: `decode_r` [INFO] [stderr] --> src/reader.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | let decoder = if self.is_big_endian { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#similar_names [INFO] [stderr] [INFO] [stderr] warning: binding's name is too similar to existing binding [INFO] [stderr] --> src/reader.rs:455:13 [INFO] [stderr] | [INFO] [stderr] 455 | let sum = self.read_64()?; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: existing binding defined here [INFO] [stderr] --> src/reader.rs:451:13 [INFO] [stderr] | [INFO] [stderr] 451 | let num = self.read_32()?; [INFO] [stderr] | ^^^ [INFO] [stderr] help: separate the discriminating character by an underscore like: `s_um` [INFO] [stderr] --> src/reader.rs:455:13 [INFO] [stderr] | [INFO] [stderr] 455 | let sum = self.read_64()?; [INFO] [stderr] | ^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#similar_names [INFO] [stderr] [INFO] [stderr] warning: binding's name is too similar to existing binding [INFO] [stderr] --> src/reader.rs:477:25 [INFO] [stderr] | [INFO] [stderr] 477 | let sum = s.read_64()?; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: existing binding defined here [INFO] [stderr] --> src/reader.rs:451:13 [INFO] [stderr] | [INFO] [stderr] 451 | let num = self.read_32()?; [INFO] [stderr] | ^^^ [INFO] [stderr] help: separate the discriminating character by an underscore like: `s_um` [INFO] [stderr] --> src/reader.rs:477:25 [INFO] [stderr] | [INFO] [stderr] 477 | let sum = s.read_64()?; [INFO] [stderr] | ^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#similar_names [INFO] [stderr] [INFO] [stderr] warning: binding's name is too similar to existing binding [INFO] [stderr] --> src/graph.rs:219:21 [INFO] [stderr] | [INFO] [stderr] 219 | let src = er.source(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: existing binding defined here [INFO] [stderr] --> src/graph.rs:214:21 [INFO] [stderr] | [INFO] [stderr] 214 | let arc = er.weight(); [INFO] [stderr] | ^^^ [INFO] [stderr] help: separate the discriminating character by an underscore like: `s_rc` [INFO] [stderr] --> src/graph.rs:219:21 [INFO] [stderr] | [INFO] [stderr] 219 | let src = er.source(); [INFO] [stderr] | ^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#similar_names [INFO] [stderr] [INFO] [stderr] warning: binding's name is too similar to existing binding [INFO] [stderr] --> src/graph.rs:963:17 [INFO] [stderr] | [INFO] [stderr] 963 | let arc = edge_ref.weight(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: existing binding defined here [INFO] [stderr] --> src/graph.rs:955:17 [INFO] [stderr] | [INFO] [stderr] 955 | let src = edge_ref.source(); [INFO] [stderr] | ^^^ [INFO] [stderr] help: separate the discriminating character by an underscore like: `a_rc` [INFO] [stderr] --> src/graph.rs:963:17 [INFO] [stderr] | [INFO] [stderr] 963 | let arc = edge_ref.weight(); [INFO] [stderr] | ^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#similar_names [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy_pedantic` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:61:54 [INFO] [stderr] | [INFO] [stderr] 61 | #![cfg_attr(feature = "cargo-clippy", warn(warnings, clippy_pedantic))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::pedantic` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy_pedantic` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:61:54 [INFO] [stderr] | [INFO] [stderr] 61 | #![cfg_attr(feature = "cargo-clippy", warn(warnings, clippy_pedantic))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::pedantic` [INFO] [stderr] [INFO] [stderr] warning: lint name `stutter` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/intern.rs:141:44 [INFO] [stderr] | [INFO] [stderr] 141 | #[cfg_attr(feature = "cargo-clippy", allow(stutter))] [INFO] [stderr] | ^^^^^^^ help: change it to: `clippy::stutter` [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/deserializer.rs:209:48 [INFO] [stderr] | [INFO] [stderr] 209 | #[cfg_attr(feature = "cargo-clippy", allow(type_complexity))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `stutter` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/intern.rs:141:44 [INFO] [stderr] | [INFO] [stderr] 141 | #[cfg_attr(feature = "cargo-clippy", allow(stutter))] [INFO] [stderr] | ^^^^^^^ help: change it to: `clippy::stutter` [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/deserializer.rs:209:48 [INFO] [stderr] | [INFO] [stderr] 209 | #[cfg_attr(feature = "cargo-clippy", allow(type_complexity))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] [INFO] [stderr] warning: integer type suffix should be separated by an underscore [INFO] [stderr] --> src/reader.rs:75:24 [INFO] [stderr] | [INFO] [stderr] 75 | let mut top = [0u8; 5]; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:61:54 [INFO] [stderr] | [INFO] [stderr] 61 | #![cfg_attr(feature = "cargo-clippy", warn(warnings, clippy_pedantic))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = note: #[warn(clippy::unseparated_literal_suffix)] implied by #[warn(clippy::pedantic)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unseparated_literal_suffix [INFO] [stderr] [INFO] [stderr] warning: integer type suffix should be separated by an underscore [INFO] [stderr] --> src/reader.rs:78:27 [INFO] [stderr] | [INFO] [stderr] 78 | let mut bottom = [0u8; 7]; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unseparated_literal_suffix [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/intern.rs:130:27 [INFO] [stderr] | [INFO] [stderr] 130 | fn from(s: Symbol) -> usize { [INFO] [stderr] | ^^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:61:54 [INFO] [stderr] | [INFO] [stderr] 61 | #![cfg_attr(feature = "cargo-clippy", warn(warnings, clippy_pedantic))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = note: #[warn(clippy::use_self)] implied by #[warn(clippy::pedantic)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/intern.rs:146:21 [INFO] [stderr] | [INFO] [stderr] 146 | pub fn new() -> Interner { [INFO] [stderr] | ^^^^^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/intern.rs:200:21 [INFO] [stderr] | [INFO] [stderr] 200 | fn default() -> Interner { [INFO] [stderr] | ^^^^^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/intern.rs:201:9 [INFO] [stderr] | [INFO] [stderr] 201 | Interner::new() [INFO] [stderr] | ^^^^^^^^^^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/intern.rs:343:96 [INFO] [stderr] | [INFO] [stderr] 343 | impl SerializeWithInterner for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 343 | impl SerializeWithInterner for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/raw.rs:59:74 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn open>(p: P, interner: &mut Interner) -> Result { [INFO] [stderr] | ^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/raw.rs:62:55 [INFO] [stderr] | [INFO] [stderr] 62 | Location::File(src.clone()).wrap(|| -> Result { [INFO] [stderr] | ^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/raw.rs:174:49 [INFO] [stderr] | [INFO] [stderr] 174 | pub fn try_from(raw_version: u32) -> Result { [INFO] [stderr] | ^^^^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/raw.rs:203:9 [INFO] [stderr] | [INFO] [stderr] 203 | Version::try_from(raw_version) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/raw.rs:219:9 [INFO] [stderr] | [INFO] [stderr] 219 | Version::from_str(s).map_err(D::Error::custom) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/intern.rs:130:27 [INFO] [stderr] | [INFO] [stderr] 130 | fn from(s: Symbol) -> usize { [INFO] [stderr] | ^^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:61:54 [INFO] [stderr] | [INFO] [stderr] 61 | #![cfg_attr(feature = "cargo-clippy", warn(warnings, clippy_pedantic))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = note: #[warn(clippy::use_self)] implied by #[warn(clippy::pedantic)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/intern.rs:146:21 [INFO] [stderr] | [INFO] [stderr] 146 | pub fn new() -> Interner { [INFO] [stderr] | ^^^^^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/raw.rs:331:105 [INFO] [stderr] | [INFO] [stderr] 331 | <$flags>::from_bits(b).ok_or_else(|| D::Error::custom(ErrorKind::UnsupportedAttr($kind, b as u32))) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(b)` [INFO] [stderr] ... [INFO] [stderr] 382 | / derive_serde_for_attr! { [INFO] [stderr] 383 | | BlockAttr, "block", BlockAttr::UNEXPECTED [INFO] [stderr] 384 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/raw.rs:344:34 [INFO] [stderr] | [INFO] [stderr] 344 | ensure!(flags & !($allowed_from_gcno.bits() as u32) == 0, ErrorKind::UnsupportedAttr($kind, flags)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from($allowed_from_gcno.bits())` [INFO] [stderr] ... [INFO] [stderr] 382 | / derive_serde_for_attr! { [INFO] [stderr] 383 | | BlockAttr, "block", BlockAttr::UNEXPECTED [INFO] [stderr] 384 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/intern.rs:200:21 [INFO] [stderr] | [INFO] [stderr] 200 | fn default() -> Interner { [INFO] [stderr] | ^^^^^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/intern.rs:201:9 [INFO] [stderr] | [INFO] [stderr] 201 | Interner::new() [INFO] [stderr] | ^^^^^^^^^^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/intern.rs:343:96 [INFO] [stderr] | [INFO] [stderr] 343 | impl SerializeWithInterner for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 343 | impl SerializeWithInterner for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/raw.rs:400:31 [INFO] [stderr] | [INFO] [stderr] 400 | fn from(i: BlockIndex) -> usize { [INFO] [stderr] | ^^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/raw.rs:401:16 [INFO] [stderr] | [INFO] [stderr] 401 | i.0 as usize [INFO] [stderr] | ^^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/raw.rs:331:105 [INFO] [stderr] | [INFO] [stderr] 331 | <$flags>::from_bits(b).ok_or_else(|| D::Error::custom(ErrorKind::UnsupportedAttr($kind, b as u32))) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(b)` [INFO] [stderr] ... [INFO] [stderr] 456 | / derive_serde_for_attr! { [INFO] [stderr] 457 | | ArcAttr, "arc", ArcAttr::ON_TREE | ArcAttr::FAKE | ArcAttr::FALLTHROUGH [INFO] [stderr] 458 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/raw.rs:344:34 [INFO] [stderr] | [INFO] [stderr] 344 | ensure!(flags & !($allowed_from_gcno.bits() as u32) == 0, ErrorKind::UnsupportedAttr($kind, flags)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from($allowed_from_gcno.bits())` [INFO] [stderr] ... [INFO] [stderr] 456 | / derive_serde_for_attr! { [INFO] [stderr] 457 | | ArcAttr, "arc", ArcAttr::ON_TREE | ArcAttr::FAKE | ArcAttr::FALLTHROUGH [INFO] [stderr] 458 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/raw.rs:59:74 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn open>(p: P, interner: &mut Interner) -> Result { [INFO] [stderr] | ^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/raw.rs:62:55 [INFO] [stderr] | [INFO] [stderr] 62 | Location::File(src.clone()).wrap(|| -> Result { [INFO] [stderr] | ^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/raw.rs:587:21 [INFO] [stderr] | [INFO] [stderr] 587 | fn default() -> HistogramBucket { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/raw.rs:588:9 [INFO] [stderr] | [INFO] [stderr] 588 | HistogramBucket { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: using `MAX` [INFO] [stderr] --> src/raw.rs:590:18 [INFO] [stderr] | [INFO] [stderr] 590 | min: u64::MAX, [INFO] [stderr] | ^^^^^^^^ help: try this: `u64::max_value()` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:61:54 [INFO] [stderr] | [INFO] [stderr] 61 | #![cfg_attr(feature = "cargo-clippy", warn(warnings, clippy_pedantic))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = note: #[warn(clippy::replace_consts)] implied by #[warn(clippy::pedantic)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#replace_consts [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:163:22 [INFO] [stderr] | [INFO] [stderr] 163 | let length = (self.read_32()? as u64) * 4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.read_32()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/raw.rs:174:49 [INFO] [stderr] | [INFO] [stderr] 174 | pub fn try_from(raw_version: u32) -> Result { [INFO] [stderr] | ^^^^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/raw.rs:203:9 [INFO] [stderr] | [INFO] [stderr] 203 | Version::try_from(raw_version) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/raw.rs:219:9 [INFO] [stderr] | [INFO] [stderr] 219 | Version::from_str(s).map_err(D::Error::custom) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:272:22 [INFO] [stderr] | [INFO] [stderr] 272 | let length = (self.read_32()? as u64) * 4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.read_32()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/graph.rs:36:21 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn new() -> Graph { [INFO] [stderr] | ^^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/graph.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | Graph::default() [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: using `MAX` [INFO] [stderr] --> src/graph.rs:298:61 [INFO] [stderr] | [INFO] [stderr] 298 | const INVALID_FUNCTION_INDEX: FunctionIndex = FunctionIndex(usize::MAX); [INFO] [stderr] | ^^^^^^^^^^ help: try this: `usize::max_value()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#replace_consts [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/raw.rs:331:105 [INFO] [stderr] | [INFO] [stderr] 331 | <$flags>::from_bits(b).ok_or_else(|| D::Error::custom(ErrorKind::UnsupportedAttr($kind, b as u32))) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(b)` [INFO] [stderr] ... [INFO] [stderr] 382 | / derive_serde_for_attr! { [INFO] [stderr] 383 | | BlockAttr, "block", BlockAttr::UNEXPECTED [INFO] [stderr] 384 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/raw.rs:344:34 [INFO] [stderr] | [INFO] [stderr] 344 | ensure!(flags & !($allowed_from_gcno.bits() as u32) == 0, ErrorKind::UnsupportedAttr($kind, flags)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from($allowed_from_gcno.bits())` [INFO] [stderr] ... [INFO] [stderr] 382 | / derive_serde_for_attr! { [INFO] [stderr] 383 | | BlockAttr, "block", BlockAttr::UNEXPECTED [INFO] [stderr] 384 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/raw.rs:400:31 [INFO] [stderr] | [INFO] [stderr] 400 | fn from(i: BlockIndex) -> usize { [INFO] [stderr] | ^^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/raw.rs:401:16 [INFO] [stderr] | [INFO] [stderr] 401 | i.0 as usize [INFO] [stderr] | ^^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/graph.rs:324:70 [INFO] [stderr] | [INFO] [stderr] 324 | fn new(file_checksum: u32, ident: Ident, function: &Function) -> GcdaFunctionIdentity { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/graph.rs:325:9 [INFO] [stderr] | [INFO] [stderr] 325 | GcdaFunctionIdentity { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/graph.rs:345:35 [INFO] [stderr] | [INFO] [stderr] 345 | fn new(function: Function) -> GcnoFunctionIdentity { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/graph.rs:346:9 [INFO] [stderr] | [INFO] [stderr] 346 | GcnoFunctionIdentity { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: using `MAX` [INFO] [stderr] --> src/graph.rs:487:71 [INFO] [stderr] | [INFO] [stderr] 487 | block_status[entry_block.index()].incoming_invalid_arcs = usize::MAX; [INFO] [stderr] | ^^^^^^^^^^ help: try this: `usize::max_value()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#replace_consts [INFO] [stderr] [INFO] [stderr] warning: using `MAX` [INFO] [stderr] --> src/graph.rs:488:70 [INFO] [stderr] | [INFO] [stderr] 488 | block_status[exit_block.index()].outgoing_invalid_arcs = usize::MAX; [INFO] [stderr] | ^^^^^^^^^^ help: try this: `usize::max_value()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#replace_consts [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/raw.rs:331:105 [INFO] [stderr] | [INFO] [stderr] 331 | <$flags>::from_bits(b).ok_or_else(|| D::Error::custom(ErrorKind::UnsupportedAttr($kind, b as u32))) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(b)` [INFO] [stderr] ... [INFO] [stderr] 456 | / derive_serde_for_attr! { [INFO] [stderr] 457 | | ArcAttr, "arc", ArcAttr::ON_TREE | ArcAttr::FAKE | ArcAttr::FALLTHROUGH [INFO] [stderr] 458 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/raw.rs:344:34 [INFO] [stderr] | [INFO] [stderr] 344 | ensure!(flags & !($allowed_from_gcno.bits() as u32) == 0, ErrorKind::UnsupportedAttr($kind, flags)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from($allowed_from_gcno.bits())` [INFO] [stderr] ... [INFO] [stderr] 456 | / derive_serde_for_attr! { [INFO] [stderr] 457 | | ArcAttr, "arc", ArcAttr::ON_TREE | ArcAttr::FAKE | ArcAttr::FALLTHROUGH [INFO] [stderr] 458 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by value, but not consumed in the function body [INFO] [stderr] --> src/graph.rs:718:87 [INFO] [stderr] | [INFO] [stderr] 718 | fn add_lines(&mut self, function: &FunctionInfo, index: FunctionIndex, all_lines: BTreeMap) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider taking a reference instead: `&BTreeMap` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:61:54 [INFO] [stderr] | [INFO] [stderr] 61 | #![cfg_attr(feature = "cargo-clippy", warn(warnings, clippy_pedantic))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = note: #[warn(clippy::needless_pass_by_value)] implied by #[warn(clippy::pedantic)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by value, but not consumed in the function body [INFO] [stderr] --> src/graph.rs:776:60 [INFO] [stderr] | [INFO] [stderr] 776 | fn add_arc_counts(&mut self, index: FunctionIndex, ac: ArcCounts) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^ help: consider taking a reference instead: `&ArcCounts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/raw.rs:587:21 [INFO] [stderr] | [INFO] [stderr] 587 | fn default() -> HistogramBucket { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/raw.rs:588:9 [INFO] [stderr] | [INFO] [stderr] 588 | HistogramBucket { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: using `MAX` [INFO] [stderr] --> src/raw.rs:590:18 [INFO] [stderr] | [INFO] [stderr] 590 | min: u64::MAX, [INFO] [stderr] | ^^^^^^^^ help: try this: `u64::max_value()` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:61:54 [INFO] [stderr] | [INFO] [stderr] 61 | #![cfg_attr(feature = "cargo-clippy", warn(warnings, clippy_pedantic))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = note: #[warn(clippy::replace_consts)] implied by #[warn(clippy::pedantic)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#replace_consts [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:163:22 [INFO] [stderr] | [INFO] [stderr] 163 | let length = (self.read_32()? as u64) * 4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.read_32()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:272:22 [INFO] [stderr] | [INFO] [stderr] 272 | let length = (self.read_32()? as u64) * 4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.read_32()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/graph.rs:36:21 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn new() -> Graph { [INFO] [stderr] | ^^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/graph.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | Graph::default() [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: using `MAX` [INFO] [stderr] --> src/graph.rs:298:61 [INFO] [stderr] | [INFO] [stderr] 298 | const INVALID_FUNCTION_INDEX: FunctionIndex = FunctionIndex(usize::MAX); [INFO] [stderr] | ^^^^^^^^^^ help: try this: `usize::max_value()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#replace_consts [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/graph.rs:324:70 [INFO] [stderr] | [INFO] [stderr] 324 | fn new(file_checksum: u32, ident: Ident, function: &Function) -> GcdaFunctionIdentity { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/graph.rs:325:9 [INFO] [stderr] | [INFO] [stderr] 325 | GcdaFunctionIdentity { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/graph.rs:345:35 [INFO] [stderr] | [INFO] [stderr] 345 | fn new(function: Function) -> GcnoFunctionIdentity { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/graph.rs:346:9 [INFO] [stderr] | [INFO] [stderr] 346 | GcnoFunctionIdentity { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: using `MAX` [INFO] [stderr] --> src/graph.rs:487:71 [INFO] [stderr] | [INFO] [stderr] 487 | block_status[entry_block.index()].incoming_invalid_arcs = usize::MAX; [INFO] [stderr] | ^^^^^^^^^^ help: try this: `usize::max_value()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#replace_consts [INFO] [stderr] [INFO] [stderr] warning: using `MAX` [INFO] [stderr] --> src/graph.rs:488:70 [INFO] [stderr] | [INFO] [stderr] 488 | block_status[exit_block.index()].outgoing_invalid_arcs = usize::MAX; [INFO] [stderr] | ^^^^^^^^^^ help: try this: `usize::max_value()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#replace_consts [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by value, but not consumed in the function body [INFO] [stderr] --> src/graph.rs:718:87 [INFO] [stderr] | [INFO] [stderr] 718 | fn add_lines(&mut self, function: &FunctionInfo, index: FunctionIndex, all_lines: BTreeMap) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider taking a reference instead: `&BTreeMap` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:61:54 [INFO] [stderr] | [INFO] [stderr] 61 | #![cfg_attr(feature = "cargo-clippy", warn(warnings, clippy_pedantic))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = note: #[warn(clippy::needless_pass_by_value)] implied by #[warn(clippy::pedantic)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by value, but not consumed in the function body [INFO] [stderr] --> src/graph.rs:776:60 [INFO] [stderr] | [INFO] [stderr] 776 | fn add_arc_counts(&mut self, index: FunctionIndex, ac: ArcCounts) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^ help: consider taking a reference instead: `&ArcCounts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.66s [INFO] running `"docker" "inspect" "fe65ff8f22ea8bcc1dd367eb9b33d395c5b2b001087b4d6c266a45e99ad656d4"` [INFO] running `"docker" "rm" "-f" "fe65ff8f22ea8bcc1dd367eb9b33d395c5b2b001087b4d6c266a45e99ad656d4"` [INFO] [stdout] fe65ff8f22ea8bcc1dd367eb9b33d395c5b2b001087b4d6c266a45e99ad656d4