[INFO] crate counter64 0.1.0 is already in cache [INFO] extracting crate counter64 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/counter64/0.1.0 [INFO] extracting crate counter64 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/counter64/0.1.0 [INFO] validating manifest of counter64-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of counter64-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing counter64-0.1.0 [INFO] finished frobbing counter64-0.1.0 [INFO] frobbed toml for counter64-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/counter64/0.1.0/Cargo.toml [INFO] started frobbing counter64-0.1.0 [INFO] finished frobbing counter64-0.1.0 [INFO] frobbed toml for counter64-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/counter64/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting counter64-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/counter64/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 057e5320a3244a331f6fb7976218569cc65ae239ef62eb14541a9bec0b6ef946 [INFO] running `"docker" "start" "-a" "057e5320a3244a331f6fb7976218569cc65ae239ef62eb14541a9bec0b6ef946"` [INFO] [stderr] Checking counter64 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] error: a const item should never be interior mutable [INFO] [stderr] --> src/lib.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | pub const COUNTER_INIT: Counter = Counter(ATOMIC_USIZE_INIT); [INFO] [stderr] | -----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: make this a static item: `static` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::declare_interior_mutable_const)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `counter::Counter` [INFO] [stderr] --> src/lib.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new() -> Self { [INFO] [stderr] 24 | | COUNTER_INIT [INFO] [stderr] 25 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | #[derive(Default)] [INFO] [stderr] 18 | pub struct Counter(AtomicUsize); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `counter64`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:263:35 [INFO] [stderr] | [INFO] [stderr] 263 | assert_eq!(counter.get(), 640000); [INFO] [stderr] | ^^^^^^ help: consider: `640_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: a const item should never be interior mutable [INFO] [stderr] --> src/lib.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | pub const COUNTER_INIT: Counter = Counter(ATOMIC_USIZE_INIT); [INFO] [stderr] | -----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: make this a static item: `static` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::declare_interior_mutable_const)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `counter::Counter` [INFO] [stderr] --> src/lib.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new() -> Self { [INFO] [stderr] 24 | | COUNTER_INIT [INFO] [stderr] 25 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | #[derive(Default)] [INFO] [stderr] 18 | pub struct Counter(AtomicUsize); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `counter64`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "057e5320a3244a331f6fb7976218569cc65ae239ef62eb14541a9bec0b6ef946"` [INFO] running `"docker" "rm" "-f" "057e5320a3244a331f6fb7976218569cc65ae239ef62eb14541a9bec0b6ef946"` [INFO] [stdout] 057e5320a3244a331f6fb7976218569cc65ae239ef62eb14541a9bec0b6ef946