[INFO] crate counter 0.4.3 is already in cache [INFO] extracting crate counter 0.4.3 into work/ex/clippy-test-run/sources/stable/reg/counter/0.4.3 [INFO] extracting crate counter 0.4.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/counter/0.4.3 [INFO] validating manifest of counter-0.4.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of counter-0.4.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing counter-0.4.3 [INFO] finished frobbing counter-0.4.3 [INFO] frobbed toml for counter-0.4.3 written to work/ex/clippy-test-run/sources/stable/reg/counter/0.4.3/Cargo.toml [INFO] started frobbing counter-0.4.3 [INFO] finished frobbing counter-0.4.3 [INFO] frobbed toml for counter-0.4.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/counter/0.4.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting counter-0.4.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/counter/0.4.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9c0a97024988d9393d5a6f6623a9affe1135d00cc74b905a957b5c60f8f1d21d [INFO] running `"docker" "start" "-a" "9c0a97024988d9393d5a6f6623a9affe1135d00cc74b905a957b5c60f8f1d21d"` [INFO] [stderr] Checking counter v0.4.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:899:24 [INFO] [stderr] | [INFO] [stderr] 899 | Inty { i: i } [INFO] [stderr] | ^^^^ help: replace it with: `i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:899:24 [INFO] [stderr] | [INFO] [stderr] 899 | Inty { i: i } [INFO] [stderr] | ^^^^ help: replace it with: `i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:168:46 [INFO] [stderr] | [INFO] [stderr] 168 | let entry = self.map.entry(item).or_insert(N::zero()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(N::zero)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the `unequal @ _` pattern can be written as just `unequal` [INFO] [stderr] --> src/lib.rs:256:17 [INFO] [stderr] | [INFO] [stderr] 256 | unequal @ _ => unequal, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:306:53 [INFO] [stderr] | [INFO] [stderr] 306 | let entry = self.map.entry(key.clone()).or_insert(N::zero()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(N::zero)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:445:21 [INFO] [stderr] | [INFO] [stderr] 445 | min(self.map.get(*key).unwrap(), rhs.map.get(*key).unwrap()).clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.map[*key]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:445:50 [INFO] [stderr] | [INFO] [stderr] 445 | min(self.map.get(*key).unwrap(), rhs.map.get(*key).unwrap()).clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&rhs.map[*key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:480:56 [INFO] [stderr] | [INFO] [stderr] 480 | let entry = counter.map.entry(key.clone()).or_insert(N::zero()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(N::zero)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:647:45 [INFO] [stderr] | [INFO] [stderr] 647 | let entry = cnt.map.entry(item).or_insert(N::zero()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(N::zero)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:168:46 [INFO] [stderr] | [INFO] [stderr] 168 | let entry = self.map.entry(item).or_insert(N::zero()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(N::zero)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the `unequal @ _` pattern can be written as just `unequal` [INFO] [stderr] --> src/lib.rs:256:17 [INFO] [stderr] | [INFO] [stderr] 256 | unequal @ _ => unequal, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:306:53 [INFO] [stderr] | [INFO] [stderr] 306 | let entry = self.map.entry(key.clone()).or_insert(N::zero()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(N::zero)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:445:21 [INFO] [stderr] | [INFO] [stderr] 445 | min(self.map.get(*key).unwrap(), rhs.map.get(*key).unwrap()).clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.map[*key]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:445:50 [INFO] [stderr] | [INFO] [stderr] 445 | min(self.map.get(*key).unwrap(), rhs.map.get(*key).unwrap()).clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&rhs.map[*key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:480:56 [INFO] [stderr] | [INFO] [stderr] 480 | let entry = counter.map.entry(key.clone()).or_insert(N::zero()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(N::zero)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:647:45 [INFO] [stderr] | [INFO] [stderr] 647 | let entry = cnt.map.entry(item).or_insert(N::zero()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(N::zero)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/lib.rs:886:52 [INFO] [stderr] | [INFO] [stderr] 886 | let expected: HashMap = items.into_iter().map(|(c, n)| (*c, n * 2)).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `counter`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "9c0a97024988d9393d5a6f6623a9affe1135d00cc74b905a957b5c60f8f1d21d"` [INFO] running `"docker" "rm" "-f" "9c0a97024988d9393d5a6f6623a9affe1135d00cc74b905a957b5c60f8f1d21d"` [INFO] [stdout] 9c0a97024988d9393d5a6f6623a9affe1135d00cc74b905a957b5c60f8f1d21d