[INFO] crate couchdb 0.6.0 is already in cache [INFO] extracting crate couchdb 0.6.0 into work/ex/clippy-test-run/sources/stable/reg/couchdb/0.6.0 [INFO] extracting crate couchdb 0.6.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/couchdb/0.6.0 [INFO] validating manifest of couchdb-0.6.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of couchdb-0.6.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing couchdb-0.6.0 [INFO] finished frobbing couchdb-0.6.0 [INFO] frobbed toml for couchdb-0.6.0 written to work/ex/clippy-test-run/sources/stable/reg/couchdb/0.6.0/Cargo.toml [INFO] started frobbing couchdb-0.6.0 [INFO] finished frobbing couchdb-0.6.0 [INFO] frobbed toml for couchdb-0.6.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/couchdb/0.6.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting couchdb-0.6.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/couchdb/0.6.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ad40b6c42f622e1f000814b0dc7e89b05309f082efd456fd2204acbec65f18fc [INFO] running `"docker" "start" "-a" "ad40b6c42f622e1f000814b0dc7e89b05309f082efd456fd2204acbec65f18fc"` [INFO] [stderr] Checking uuid v0.5.1 [INFO] [stderr] Checking couchdb v0.6.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attachment.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | content_type: content_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `content_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attachment.rs:128:42 [INFO] [stderr] | [INFO] [stderr] 128 | inner: Inner::ClientOrigin { content: content }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attachment.rs:331:17 [INFO] [stderr] | [INFO] [stderr] 331 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attachment.rs:346:17 [INFO] [stderr] | [INFO] [stderr] 346 | encoding: encoding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `encoding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attachment.rs:353:17 [INFO] [stderr] | [INFO] [stderr] 353 | encoding: encoding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `encoding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attachment.rs:367:13 [INFO] [stderr] | [INFO] [stderr] 367 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attachment.rs:498:36 [INFO] [stderr] | [INFO] [stderr] 498 | "md5" => Digest::Md5 { value: value }, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attachment.rs:501:17 [INFO] [stderr] | [INFO] [stderr] 501 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/path.rs:131:26 [INFO] [stderr] | [INFO] [stderr] 131 | Ok(PathDecoder { cursor: cursor }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/path.rs:792:27 [INFO] [stderr] | [INFO] [stderr] 792 | Ok(DatabasePath { db_name: db_name }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `db_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/path.rs:848:13 [INFO] [stderr] | [INFO] [stderr] 848 | db_name: db_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `db_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/path.rs:849:13 [INFO] [stderr] | [INFO] [stderr] 849 | doc_id: doc_id, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `doc_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/path.rs:916:13 [INFO] [stderr] | [INFO] [stderr] 916 | db_name: db_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `db_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/path.rs:917:13 [INFO] [stderr] | [INFO] [stderr] 917 | ddoc_id: ddoc_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `ddoc_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/path.rs:973:13 [INFO] [stderr] | [INFO] [stderr] 973 | db_name: db_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `db_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/path.rs:974:13 [INFO] [stderr] | [INFO] [stderr] 974 | doc_id: doc_id, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `doc_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/path.rs:975:13 [INFO] [stderr] | [INFO] [stderr] 975 | att_name: att_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `att_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/path.rs:1033:13 [INFO] [stderr] | [INFO] [stderr] 1033 | db_name: db_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `db_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/path.rs:1034:13 [INFO] [stderr] | [INFO] [stderr] 1034 | ddoc_id: ddoc_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `ddoc_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/path.rs:1035:13 [INFO] [stderr] | [INFO] [stderr] 1035 | view_name: view_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `view_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/testing/fake_server.rs:173:13 [INFO] [stderr] | [INFO] [stderr] 173 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:27:26 [INFO] [stderr] | [INFO] [stderr] 27 | Error::BadPath { what: what } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `what` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | cause: cause, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cause` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/revision.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | sequence_number: sequence_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sequence_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/revision.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | digest: digest, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `digest` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attachment.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | content_type: content_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `content_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attachment.rs:128:42 [INFO] [stderr] | [INFO] [stderr] 128 | inner: Inner::ClientOrigin { content: content }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attachment.rs:331:17 [INFO] [stderr] | [INFO] [stderr] 331 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attachment.rs:346:17 [INFO] [stderr] | [INFO] [stderr] 346 | encoding: encoding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `encoding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attachment.rs:353:17 [INFO] [stderr] | [INFO] [stderr] 353 | encoding: encoding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `encoding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attachment.rs:367:13 [INFO] [stderr] | [INFO] [stderr] 367 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attachment.rs:498:36 [INFO] [stderr] | [INFO] [stderr] 498 | "md5" => Digest::Md5 { value: value }, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attachment.rs:501:17 [INFO] [stderr] | [INFO] [stderr] 501 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/path.rs:131:26 [INFO] [stderr] | [INFO] [stderr] 131 | Ok(PathDecoder { cursor: cursor }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/path.rs:792:27 [INFO] [stderr] | [INFO] [stderr] 792 | Ok(DatabasePath { db_name: db_name }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `db_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/path.rs:848:13 [INFO] [stderr] | [INFO] [stderr] 848 | db_name: db_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `db_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/path.rs:849:13 [INFO] [stderr] | [INFO] [stderr] 849 | doc_id: doc_id, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `doc_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/path.rs:916:13 [INFO] [stderr] | [INFO] [stderr] 916 | db_name: db_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `db_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/path.rs:917:13 [INFO] [stderr] | [INFO] [stderr] 917 | ddoc_id: ddoc_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `ddoc_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/path.rs:973:13 [INFO] [stderr] | [INFO] [stderr] 973 | db_name: db_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `db_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/path.rs:974:13 [INFO] [stderr] | [INFO] [stderr] 974 | doc_id: doc_id, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `doc_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/path.rs:975:13 [INFO] [stderr] | [INFO] [stderr] 975 | att_name: att_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `att_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/path.rs:1033:13 [INFO] [stderr] | [INFO] [stderr] 1033 | db_name: db_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `db_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/path.rs:1034:13 [INFO] [stderr] | [INFO] [stderr] 1034 | ddoc_id: ddoc_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `ddoc_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/path.rs:1035:13 [INFO] [stderr] | [INFO] [stderr] 1035 | view_name: view_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `view_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/testing/fake_server.rs:173:13 [INFO] [stderr] | [INFO] [stderr] 173 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:27:26 [INFO] [stderr] | [INFO] [stderr] 27 | Error::BadPath { what: what } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `what` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | cause: cause, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cause` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/revision.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | sequence_number: sequence_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sequence_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/revision.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | digest: digest, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `digest` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/database.rs:89:35 [INFO] [stderr] | [INFO] [stderr] 89 | committed_update_seq: 292786, [INFO] [stderr] | ^^^^^^ help: consider: `292_786` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/database.rs:91:24 [INFO] [stderr] | [INFO] [stderr] 91 | data_size: 65031503, [INFO] [stderr] | ^^^^^^^^ help: consider: `65_031_503` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/database.rs:94:24 [INFO] [stderr] | [INFO] [stderr] 94 | disk_size: 137433211, [INFO] [stderr] | ^^^^^^^^^ help: consider: `137_433_211` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/database.rs:97:34 [INFO] [stderr] | [INFO] [stderr] 97 | instance_start_time: 1376269325408900, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `1_376_269_325_408_900` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/database.rs:99:25 [INFO] [stderr] | [INFO] [stderr] 99 | update_seq: 292786, [INFO] [stderr] | ^^^^^^ help: consider: `292_786` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/revision.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | / macro_rules! expect_error { [INFO] [stderr] 190 | | ($input: expr) => { [INFO] [stderr] 191 | | match Revision::from_str($input) { [INFO] [stderr] 192 | | Err(Error::RevisionParse{..}) => (), [INFO] [stderr] ... | [INFO] [stderr] 195 | | } [INFO] [stderr] 196 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/attachment.rs:208:33 [INFO] [stderr] | [INFO] [stderr] 208 | revpos: revpos.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*revpos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/attachment.rs:292:57 [INFO] [stderr] | [INFO] [stderr] 292 | Inner::ServerOrigin { ref encoding, .. } => encoding.as_ref().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `encoding.as_ref()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/path.rs:84:1 [INFO] [stderr] | [INFO] [stderr] 84 | / fn percent_decode<'a>(x: &'a str) -> Result, Error> { [INFO] [stderr] 85 | | use url::percent_encoding; [INFO] [stderr] 86 | | percent_encoding::percent_decode(x.as_bytes()) [INFO] [stderr] 87 | | .decode_utf8() [INFO] [stderr] ... | [INFO] [stderr] 90 | | }) [INFO] [stderr] 91 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/path.rs:161:33 [INFO] [stderr] | [INFO] [stderr] 161 | let slash = p.find('/').unwrap_or(p.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| p.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/path.rs:183:33 [INFO] [stderr] | [INFO] [stderr] 183 | let slash = p.find('/').unwrap_or(p.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| p.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/path.rs:201:33 [INFO] [stderr] | [INFO] [stderr] 201 | let slash = p.find('/').unwrap_or(p.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| p.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/path.rs:212:33 [INFO] [stderr] | [INFO] [stderr] 212 | let slash = p.find('/').unwrap_or(p.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| p.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/path.rs:234:33 [INFO] [stderr] | [INFO] [stderr] 234 | let slash = p.find('/').unwrap_or(p.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| p.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/path.rs:247:37 [INFO] [stderr] | [INFO] [stderr] 247 | let slash = p.find('/').unwrap_or(p.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| p.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/path.rs:515:9 [INFO] [stderr] | [INFO] [stderr] 515 | String::from(doc_id.0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `doc_id.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/path.rs:737:9 [INFO] [stderr] | [INFO] [stderr] 737 | String::from(view_id.0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `view_id.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/root.rs:117:50 [INFO] [stderr] | [INFO] [stderr] 117 | u64::from_str_radix(s, BASE).map(|x| Some(x)).unwrap_or( [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/attachment.rs:208:33 [INFO] [stderr] | [INFO] [stderr] 208 | revpos: revpos.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*revpos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/attachment.rs:292:57 [INFO] [stderr] | [INFO] [stderr] 292 | Inner::ServerOrigin { ref encoding, .. } => encoding.as_ref().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `encoding.as_ref()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/path.rs:84:1 [INFO] [stderr] | [INFO] [stderr] 84 | / fn percent_decode<'a>(x: &'a str) -> Result, Error> { [INFO] [stderr] 85 | | use url::percent_encoding; [INFO] [stderr] 86 | | percent_encoding::percent_decode(x.as_bytes()) [INFO] [stderr] 87 | | .decode_utf8() [INFO] [stderr] ... | [INFO] [stderr] 90 | | }) [INFO] [stderr] 91 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/path.rs:161:33 [INFO] [stderr] | [INFO] [stderr] 161 | let slash = p.find('/').unwrap_or(p.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| p.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/path.rs:183:33 [INFO] [stderr] | [INFO] [stderr] 183 | let slash = p.find('/').unwrap_or(p.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| p.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/path.rs:201:33 [INFO] [stderr] | [INFO] [stderr] 201 | let slash = p.find('/').unwrap_or(p.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| p.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/path.rs:212:33 [INFO] [stderr] | [INFO] [stderr] 212 | let slash = p.find('/').unwrap_or(p.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| p.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/path.rs:234:33 [INFO] [stderr] | [INFO] [stderr] 234 | let slash = p.find('/').unwrap_or(p.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| p.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/path.rs:247:37 [INFO] [stderr] | [INFO] [stderr] 247 | let slash = p.find('/').unwrap_or(p.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| p.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/path.rs:515:9 [INFO] [stderr] | [INFO] [stderr] 515 | String::from(doc_id.0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `doc_id.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/path.rs:737:9 [INFO] [stderr] | [INFO] [stderr] 737 | String::from(view_id.0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `view_id.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/root.rs:117:50 [INFO] [stderr] | [INFO] [stderr] 117 | u64::from_str_radix(s, BASE).map(|x| Some(x)).unwrap_or( [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.07s [INFO] running `"docker" "inspect" "ad40b6c42f622e1f000814b0dc7e89b05309f082efd456fd2204acbec65f18fc"` [INFO] running `"docker" "rm" "-f" "ad40b6c42f622e1f000814b0dc7e89b05309f082efd456fd2204acbec65f18fc"` [INFO] [stdout] ad40b6c42f622e1f000814b0dc7e89b05309f082efd456fd2204acbec65f18fc