[INFO] crate cosworth 0.1.2 is already in cache [INFO] extracting crate cosworth 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/cosworth/0.1.2 [INFO] extracting crate cosworth 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cosworth/0.1.2 [INFO] validating manifest of cosworth-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cosworth-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cosworth-0.1.2 [INFO] finished frobbing cosworth-0.1.2 [INFO] frobbed toml for cosworth-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/cosworth/0.1.2/Cargo.toml [INFO] started frobbing cosworth-0.1.2 [INFO] finished frobbing cosworth-0.1.2 [INFO] frobbed toml for cosworth-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cosworth/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cosworth-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cosworth/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6d2f4c4dd4e836bcd6182252c34bba10f471813b09696c4e0345777b5c537a91 [INFO] running `"docker" "start" "-a" "6d2f4c4dd4e836bcd6182252c34bba10f471813b09696c4e0345777b5c537a91"` [INFO] [stderr] Compiling actix-web v0.7.18 [INFO] [stderr] Compiling actix_derive v0.3.2 [INFO] [stderr] Compiling v_escape_derive v0.2.1 [INFO] [stderr] Compiling diesel_derives v1.4.0 [INFO] [stderr] Checking bigdecimal v0.0.14 [INFO] [stderr] Checking tokio-openssl v0.2.1 [INFO] [stderr] Checking ipnetwork v0.13.1 [INFO] [stderr] Checking trust-dns-proto v0.6.3 [INFO] [stderr] Checking trust-dns-proto v0.5.0 [INFO] [stderr] Checking v_escape v0.3.2 [INFO] [stderr] Checking v_htmlescape v0.3.2 [INFO] [stderr] Checking diesel v1.4.1 [INFO] [stderr] Checking trust-dns-resolver v0.10.3 [INFO] [stderr] Checking actix v0.7.9 [INFO] [stderr] Checking actix-net v0.2.6 [INFO] [stderr] Checking cosworth v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/endpoints/mod.rs:54:7 [INFO] [stderr] | [INFO] [stderr] 54 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/endpoints/mod.rs:54:7 [INFO] [stderr] | [INFO] [stderr] 54 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/endpoints/mod.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | return Ok(Response { status: 405, ..Default::default() }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Response { status: 405, ..Default::default() })` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/endpoints/mod.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | return Ok(Response { status: 405, ..Default::default() }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Response { status: 405, ..Default::default() })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/endpoints/mod.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | return Ok(Response { status: 405, ..Default::default() }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Response { status: 405, ..Default::default() })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/endpoints/mod.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | return Ok(Response { status: 405, ..Default::default() }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Response { status: 405, ..Default::default() })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/endpoints/mod.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | / return Ok(Response { [INFO] [stderr] 53 | | status: 200, [INFO] [stderr] 54 | | headers: headers, [INFO] [stderr] 55 | | ..Default::default() [INFO] [stderr] 56 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 52 | Ok(Response { [INFO] [stderr] 53 | status: 200, [INFO] [stderr] 54 | headers: headers, [INFO] [stderr] 55 | ..Default::default() [INFO] [stderr] 56 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/processor.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | return msg.endpoint.handle(&self, msg.request); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `msg.endpoint.handle(&self, msg.request)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/response.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / return Ok(req [INFO] [stderr] 32 | | .build_response(status) [INFO] [stderr] 33 | | .content_type("application/json") [INFO] [stderr] 34 | | .body(body)); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 31 | Ok(req [INFO] [stderr] 32 | .build_response(status) [INFO] [stderr] 33 | .content_type("application/json") [INFO] [stderr] 34 | .body(body)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utilities.rs:33:7 [INFO] [stderr] | [INFO] [stderr] 33 | / return Response { [INFO] [stderr] 34 | | status: 404, [INFO] [stderr] 35 | | headers: HeaderMap::new(), [INFO] [stderr] 36 | | body: Bytes::new() [INFO] [stderr] 37 | | }; [INFO] [stderr] | |________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 33 | Response { [INFO] [stderr] 34 | status: 404, [INFO] [stderr] 35 | headers: HeaderMap::new(), [INFO] [stderr] 36 | body: Bytes::new() [INFO] [stderr] 37 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utilities.rs:48:3 [INFO] [stderr] | [INFO] [stderr] 48 | / return since_the_epoch.as_secs() * 1000 + [INFO] [stderr] 49 | | since_the_epoch.subsec_nanos() as u64 / 1_000_000 << 22; [INFO] [stderr] | |_________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 48 | since_the_epoch.as_secs() * 1000 + [INFO] [stderr] 49 | since_the_epoch.subsec_nanos() as u64 / 1_000_000 << 22 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/utilities.rs:48:10 [INFO] [stderr] | [INFO] [stderr] 48 | return since_the_epoch.as_secs() * 1000 + [INFO] [stderr] | __________^ [INFO] [stderr] 49 | | since_the_epoch.subsec_nanos() as u64 / 1_000_000 << 22; [INFO] [stderr] | |________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] help: consider parenthesizing your expression [INFO] [stderr] | [INFO] [stderr] 48 | return (since_the_epoch.as_secs() * 1000 + [INFO] [stderr] 49 | since_the_epoch.subsec_nanos() as u64 / 1_000_000) << 22; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:16:21 [INFO] [stderr] | [INFO] [stderr] 16 | pub const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/endpoints/mod.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | return Ok(Response { status: 405, ..Default::default() }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Response { status: 405, ..Default::default() })` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/endpoints/mod.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | return Ok(Response { status: 405, ..Default::default() }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Response { status: 405, ..Default::default() })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/endpoints/mod.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | return Ok(Response { status: 405, ..Default::default() }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Response { status: 405, ..Default::default() })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/endpoints/mod.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | return Ok(Response { status: 405, ..Default::default() }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Response { status: 405, ..Default::default() })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/endpoints/mod.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | / return Ok(Response { [INFO] [stderr] 53 | | status: 200, [INFO] [stderr] 54 | | headers: headers, [INFO] [stderr] 55 | | ..Default::default() [INFO] [stderr] 56 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 52 | Ok(Response { [INFO] [stderr] 53 | status: 200, [INFO] [stderr] 54 | headers: headers, [INFO] [stderr] 55 | ..Default::default() [INFO] [stderr] 56 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/processor.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | return msg.endpoint.handle(&self, msg.request); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `msg.endpoint.handle(&self, msg.request)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/response.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / return Ok(req [INFO] [stderr] 32 | | .build_response(status) [INFO] [stderr] 33 | | .content_type("application/json") [INFO] [stderr] 34 | | .body(body)); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 31 | Ok(req [INFO] [stderr] 32 | .build_response(status) [INFO] [stderr] 33 | .content_type("application/json") [INFO] [stderr] 34 | .body(body)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utilities.rs:33:7 [INFO] [stderr] | [INFO] [stderr] 33 | / return Response { [INFO] [stderr] 34 | | status: 404, [INFO] [stderr] 35 | | headers: HeaderMap::new(), [INFO] [stderr] 36 | | body: Bytes::new() [INFO] [stderr] 37 | | }; [INFO] [stderr] | |________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 33 | Response { [INFO] [stderr] 34 | status: 404, [INFO] [stderr] 35 | headers: HeaderMap::new(), [INFO] [stderr] 36 | body: Bytes::new() [INFO] [stderr] 37 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utilities.rs:48:3 [INFO] [stderr] | [INFO] [stderr] 48 | / return since_the_epoch.as_secs() * 1000 + [INFO] [stderr] 49 | | since_the_epoch.subsec_nanos() as u64 / 1_000_000 << 22; [INFO] [stderr] | |_________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 48 | since_the_epoch.as_secs() * 1000 + [INFO] [stderr] 49 | since_the_epoch.subsec_nanos() as u64 / 1_000_000 << 22 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/utilities.rs:48:10 [INFO] [stderr] | [INFO] [stderr] 48 | return since_the_epoch.as_secs() * 1000 + [INFO] [stderr] | __________^ [INFO] [stderr] 49 | | since_the_epoch.subsec_nanos() as u64 / 1_000_000 << 22; [INFO] [stderr] | |________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] help: consider parenthesizing your expression [INFO] [stderr] | [INFO] [stderr] 48 | return (since_the_epoch.as_secs() * 1000 + [INFO] [stderr] 49 | since_the_epoch.subsec_nanos() as u64 / 1_000_000) << 22; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:16:21 [INFO] [stderr] | [INFO] [stderr] 16 | pub const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utilities.rs:49:10 [INFO] [stderr] | [INFO] [stderr] 49 | since_the_epoch.subsec_nanos() as u64 / 1_000_000 << 22; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(since_the_epoch.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utilities.rs:49:10 [INFO] [stderr] | [INFO] [stderr] 49 | since_the_epoch.subsec_nanos() as u64 / 1_000_000 << 22; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(since_the_epoch.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 36s [INFO] running `"docker" "inspect" "6d2f4c4dd4e836bcd6182252c34bba10f471813b09696c4e0345777b5c537a91"` [INFO] running `"docker" "rm" "-f" "6d2f4c4dd4e836bcd6182252c34bba10f471813b09696c4e0345777b5c537a91"` [INFO] [stdout] 6d2f4c4dd4e836bcd6182252c34bba10f471813b09696c4e0345777b5c537a91