[INFO] crate cosmicbox 0.5.1 is already in cache [INFO] extracting crate cosmicbox 0.5.1 into work/ex/clippy-test-run/sources/stable/reg/cosmicbox/0.5.1 [INFO] extracting crate cosmicbox 0.5.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cosmicbox/0.5.1 [INFO] validating manifest of cosmicbox-0.5.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cosmicbox-0.5.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cosmicbox-0.5.1 [INFO] finished frobbing cosmicbox-0.5.1 [INFO] frobbed toml for cosmicbox-0.5.1 written to work/ex/clippy-test-run/sources/stable/reg/cosmicbox/0.5.1/Cargo.toml [INFO] started frobbing cosmicbox-0.5.1 [INFO] finished frobbing cosmicbox-0.5.1 [INFO] frobbed toml for cosmicbox-0.5.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cosmicbox/0.5.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cosmicbox-0.5.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cosmicbox/0.5.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 78d4425097f2e3158cc8acb494e1f9e6852068b122c1da96585f2663d4c3c483 [INFO] running `"docker" "start" "-a" "78d4425097f2e3158cc8acb494e1f9e6852068b122c1da96585f2663d4c3c483"` [INFO] [stderr] Compiling hidapi v0.5.0 [INFO] [stderr] Checking cosmicbox v0.5.1 (/opt/crater/workdir) [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/hid/logic.rs:22:12 [INFO] [stderr] | [INFO] [stderr] 22 | Ok(self.send(packet)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 22 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hid/logic.rs:62:24 [INFO] [stderr] | [INFO] [stderr] 62 | counters.top = (msb as u16) << 8 | lsb as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(msb)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hid/logic.rs:62:44 [INFO] [stderr] | [INFO] [stderr] 62 | counters.top = (msb as u16) << 8 | lsb as u16; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(lsb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hid/logic.rs:69:27 [INFO] [stderr] | [INFO] [stderr] 69 | counters.bottom = (msb as u16) << 8 | lsb as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(msb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hid/logic.rs:69:47 [INFO] [stderr] | [INFO] [stderr] 69 | counters.bottom = (msb as u16) << 8 | lsb as u16; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(lsb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hid/logic.rs:76:24 [INFO] [stderr] | [INFO] [stderr] 76 | counters.ext = (msb as u16) << 8 | lsb as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(msb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hid/logic.rs:76:44 [INFO] [stderr] | [INFO] [stderr] 76 | counters.ext = (msb as u16) << 8 | lsb as u16; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(lsb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hid/logic.rs:83:26 [INFO] [stderr] | [INFO] [stderr] 83 | counters.coinc = (msb as u16) << 8 | lsb as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(msb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hid/logic.rs:83:46 [INFO] [stderr] | [INFO] [stderr] 83 | counters.coinc = (msb as u16) << 8 | lsb as u16; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(lsb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `hid::packet::HidPacket` [INFO] [stderr] --> src/hid/packet.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> Self { [INFO] [stderr] 13 | | HidPacket { [INFO] [stderr] 14 | | major_cmd: 0, [INFO] [stderr] 15 | | minor_cmd: 0, [INFO] [stderr] ... | [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 2 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/hid/logic.rs:22:12 [INFO] [stderr] | [INFO] [stderr] 22 | Ok(self.send(packet)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 22 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hid/logic.rs:62:24 [INFO] [stderr] | [INFO] [stderr] 62 | counters.top = (msb as u16) << 8 | lsb as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(msb)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hid/logic.rs:62:44 [INFO] [stderr] | [INFO] [stderr] 62 | counters.top = (msb as u16) << 8 | lsb as u16; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(lsb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hid/logic.rs:69:27 [INFO] [stderr] | [INFO] [stderr] 69 | counters.bottom = (msb as u16) << 8 | lsb as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(msb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hid/logic.rs:69:47 [INFO] [stderr] | [INFO] [stderr] 69 | counters.bottom = (msb as u16) << 8 | lsb as u16; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(lsb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hid/logic.rs:76:24 [INFO] [stderr] | [INFO] [stderr] 76 | counters.ext = (msb as u16) << 8 | lsb as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(msb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hid/logic.rs:76:44 [INFO] [stderr] | [INFO] [stderr] 76 | counters.ext = (msb as u16) << 8 | lsb as u16; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(lsb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hid/logic.rs:83:26 [INFO] [stderr] | [INFO] [stderr] 83 | counters.coinc = (msb as u16) << 8 | lsb as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(msb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hid/logic.rs:83:46 [INFO] [stderr] | [INFO] [stderr] 83 | counters.coinc = (msb as u16) << 8 | lsb as u16; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(lsb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `hid::packet::HidPacket` [INFO] [stderr] --> src/hid/packet.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> Self { [INFO] [stderr] 13 | | HidPacket { [INFO] [stderr] 14 | | major_cmd: 0, [INFO] [stderr] 15 | | minor_cmd: 0, [INFO] [stderr] ... | [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 2 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `0b111` [INFO] [stderr] --> src/hid/proto.rs:43:44 [INFO] [stderr] | [INFO] [stderr] 43 | cb.send(HidPacket::write_8(12, !0b000 & 0b111, 0b000)) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.08s [INFO] running `"docker" "inspect" "78d4425097f2e3158cc8acb494e1f9e6852068b122c1da96585f2663d4c3c483"` [INFO] running `"docker" "rm" "-f" "78d4425097f2e3158cc8acb494e1f9e6852068b122c1da96585f2663d4c3c483"` [INFO] [stdout] 78d4425097f2e3158cc8acb494e1f9e6852068b122c1da96585f2663d4c3c483