[INFO] crate cose-c 0.1.5 is already in cache [INFO] extracting crate cose-c 0.1.5 into work/ex/clippy-test-run/sources/stable/reg/cose-c/0.1.5 [INFO] extracting crate cose-c 0.1.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cose-c/0.1.5 [INFO] validating manifest of cose-c-0.1.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cose-c-0.1.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cose-c-0.1.5 [INFO] finished frobbing cose-c-0.1.5 [INFO] frobbed toml for cose-c-0.1.5 written to work/ex/clippy-test-run/sources/stable/reg/cose-c/0.1.5/Cargo.toml [INFO] started frobbing cose-c-0.1.5 [INFO] finished frobbing cose-c-0.1.5 [INFO] frobbed toml for cose-c-0.1.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cose-c/0.1.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cose-c-0.1.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cose-c/0.1.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 252a1564c3671d9a40f679492493b4e1cafe9dc2fc23c942c8c8325e59e9dc81 [INFO] running `"docker" "start" "-a" "252a1564c3671d9a40f679492493b4e1cafe9dc2fc23c942c8c8325e59e9dc81"` [INFO] [stderr] Compiling cose v0.1.4 [INFO] [stderr] Checking moz_cbor v0.1.1 [INFO] [stderr] Checking cose-c v0.1.5 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | / return cose_signatures.into_iter().all(|cose_signature| { [INFO] [stderr] 59 | | let signature_type = cose_signature.signature_type; [INFO] [stderr] 60 | | // ES256 = 0, ES384 = 1, ES512 = 2, PS256 = 3 [INFO] [stderr] 61 | | let signature_type = match signature_type { [INFO] [stderr] ... | [INFO] [stderr] 87 | | ) [INFO] [stderr] 88 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 58 | cose_signatures.into_iter().all(|cose_signature| { [INFO] [stderr] 59 | let signature_type = cose_signature.signature_type; [INFO] [stderr] 60 | // ES256 = 0, ES384 = 1, ES512 = 2, PS256 = 3 [INFO] [stderr] 61 | let signature_type = match signature_type { [INFO] [stderr] 62 | SignatureAlgorithm::ES256 => 0, [INFO] [stderr] 63 | SignatureAlgorithm::ES384 => 1, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | / return cose_signatures.into_iter().all(|cose_signature| { [INFO] [stderr] 59 | | let signature_type = cose_signature.signature_type; [INFO] [stderr] 60 | | // ES256 = 0, ES384 = 1, ES512 = 2, PS256 = 3 [INFO] [stderr] 61 | | let signature_type = match signature_type { [INFO] [stderr] ... | [INFO] [stderr] 87 | | ) [INFO] [stderr] 88 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 58 | cose_signatures.into_iter().all(|cose_signature| { [INFO] [stderr] 59 | let signature_type = cose_signature.signature_type; [INFO] [stderr] 60 | // ES256 = 0, ES384 = 1, ES512 = 2, PS256 = 3 [INFO] [stderr] 61 | let signature_type = match signature_type { [INFO] [stderr] 62 | SignatureAlgorithm::ES256 => 0, [INFO] [stderr] 63 | SignatureAlgorithm::ES384 => 1, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:45:37 [INFO] [stderr] | [INFO] [stderr] 45 | let payload = unsafe { from_raw(payload, payload_len) }; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:46:44 [INFO] [stderr] | [INFO] [stderr] 46 | let cose_signature = unsafe { from_raw(cose_signature, cose_signature_len) }; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:54:8 [INFO] [stderr] | [INFO] [stderr] 54 | if cose_signatures.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `cose_signatures.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `cose-c`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:45:37 [INFO] [stderr] | [INFO] [stderr] 45 | let payload = unsafe { from_raw(payload, payload_len) }; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:46:44 [INFO] [stderr] | [INFO] [stderr] 46 | let cose_signature = unsafe { from_raw(cose_signature, cose_signature_len) }; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:54:8 [INFO] [stderr] | [INFO] [stderr] 54 | if cose_signatures.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `cose_signatures.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `cose-c`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "252a1564c3671d9a40f679492493b4e1cafe9dc2fc23c942c8c8325e59e9dc81"` [INFO] running `"docker" "rm" "-f" "252a1564c3671d9a40f679492493b4e1cafe9dc2fc23c942c8c8325e59e9dc81"` [INFO] [stdout] 252a1564c3671d9a40f679492493b4e1cafe9dc2fc23c942c8c8325e59e9dc81