[INFO] crate cortex-m-rtfm-macros 0.4.0-beta.3 is already in cache [INFO] extracting crate cortex-m-rtfm-macros 0.4.0-beta.3 into work/ex/clippy-test-run/sources/stable/reg/cortex-m-rtfm-macros/0.4.0-beta.3 [INFO] extracting crate cortex-m-rtfm-macros 0.4.0-beta.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cortex-m-rtfm-macros/0.4.0-beta.3 [INFO] validating manifest of cortex-m-rtfm-macros-0.4.0-beta.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cortex-m-rtfm-macros-0.4.0-beta.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cortex-m-rtfm-macros-0.4.0-beta.3 [INFO] finished frobbing cortex-m-rtfm-macros-0.4.0-beta.3 [INFO] frobbed toml for cortex-m-rtfm-macros-0.4.0-beta.3 written to work/ex/clippy-test-run/sources/stable/reg/cortex-m-rtfm-macros/0.4.0-beta.3/Cargo.toml [INFO] started frobbing cortex-m-rtfm-macros-0.4.0-beta.3 [INFO] finished frobbing cortex-m-rtfm-macros-0.4.0-beta.3 [INFO] frobbed toml for cortex-m-rtfm-macros-0.4.0-beta.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cortex-m-rtfm-macros/0.4.0-beta.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cortex-m-rtfm-macros-0.4.0-beta.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cortex-m-rtfm-macros/0.4.0-beta.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 460966b71ef15e140f85946b7eba5db64955b830dfd69c3829fc74cdd508254c [INFO] running `"docker" "start" "-a" "460966b71ef15e140f85946b7eba5db64955b830dfd69c3829fc74cdd508254c"` [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Checking cortex-m-rtfm-macros v0.4.0-beta.3 (/opt/crater/workdir) [INFO] [stderr] error: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/codegen.rs:707:24 [INFO] [stderr] | [INFO] [stderr] 707 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 708 | | if singleton { [INFO] [stderr] 709 | | if kind.runs_once() { [INFO] [stderr] 710 | | needs_unsafe = true; [INFO] [stderr] ... | [INFO] [stderr] 747 | | } [INFO] [stderr] 748 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/codegen.rs:1:9 [INFO] [stderr] | [INFO] [stderr] 1 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::collapsible_if)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 707 | } else if singleton { [INFO] [stderr] 708 | if kind.runs_once() { [INFO] [stderr] 709 | needs_unsafe = true; [INFO] [stderr] 710 | defs.push(quote!(pub #name: #name)); [INFO] [stderr] 711 | exprs.push(quote!(#name: <#name as owned_singleton::Singleton>::new())); [INFO] [stderr] 712 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/codegen.rs:697:28 [INFO] [stderr] | [INFO] [stderr] 697 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 698 | | if mut_.is_none() { [INFO] [stderr] 699 | | defs.push(quote!(pub #name: &'a #ty)); [INFO] [stderr] 700 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 705 | | } [INFO] [stderr] 706 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 697 | } else if mut_.is_none() { [INFO] [stderr] 698 | defs.push(quote!(pub #name: &'a #ty)); [INFO] [stderr] 699 | } else { [INFO] [stderr] 700 | // Generate a resource proxy [INFO] [stderr] 701 | defs.push(quote!(pub #name: resources::#name<'a>)); [INFO] [stderr] 702 | exprs.push(quote!(#name: resources::#name { #priority })); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/codegen.rs:739:28 [INFO] [stderr] | [INFO] [stderr] 739 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 740 | | if ownership.is_owned() || mut_.is_none() { [INFO] [stderr] 741 | | defs.push(quote!(pub #name: &#lt #mut_ #ty)); [INFO] [stderr] 742 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 746 | | } [INFO] [stderr] 747 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 739 | } else if ownership.is_owned() || mut_.is_none() { [INFO] [stderr] 740 | defs.push(quote!(pub #name: &#lt #mut_ #ty)); [INFO] [stderr] 741 | } else { [INFO] [stderr] 742 | exclusive = true; [INFO] [stderr] 743 | may_call_lock = true; [INFO] [stderr] 744 | defs.push(quote!(pub #name: rtfm::Exclusive<#lt, #ty>)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/codegen.rs:707:24 [INFO] [stderr] | [INFO] [stderr] 707 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 708 | | if singleton { [INFO] [stderr] 709 | | if kind.runs_once() { [INFO] [stderr] 710 | | needs_unsafe = true; [INFO] [stderr] ... | [INFO] [stderr] 747 | | } [INFO] [stderr] 748 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/codegen.rs:1:9 [INFO] [stderr] | [INFO] [stderr] 1 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::collapsible_if)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 707 | } else if singleton { [INFO] [stderr] 708 | if kind.runs_once() { [INFO] [stderr] 709 | needs_unsafe = true; [INFO] [stderr] 710 | defs.push(quote!(pub #name: #name)); [INFO] [stderr] 711 | exprs.push(quote!(#name: <#name as owned_singleton::Singleton>::new())); [INFO] [stderr] 712 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/codegen.rs:697:28 [INFO] [stderr] | [INFO] [stderr] 697 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 698 | | if mut_.is_none() { [INFO] [stderr] 699 | | defs.push(quote!(pub #name: &'a #ty)); [INFO] [stderr] 700 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 705 | | } [INFO] [stderr] 706 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 697 | } else if mut_.is_none() { [INFO] [stderr] 698 | defs.push(quote!(pub #name: &'a #ty)); [INFO] [stderr] 699 | } else { [INFO] [stderr] 700 | // Generate a resource proxy [INFO] [stderr] 701 | defs.push(quote!(pub #name: resources::#name<'a>)); [INFO] [stderr] 702 | exprs.push(quote!(#name: resources::#name { #priority })); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/codegen.rs:739:28 [INFO] [stderr] | [INFO] [stderr] 739 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 740 | | if ownership.is_owned() || mut_.is_none() { [INFO] [stderr] 741 | | defs.push(quote!(pub #name: &#lt #mut_ #ty)); [INFO] [stderr] 742 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 746 | | } [INFO] [stderr] 747 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 739 | } else if ownership.is_owned() || mut_.is_none() { [INFO] [stderr] 740 | defs.push(quote!(pub #name: &#lt #mut_ #ty)); [INFO] [stderr] 741 | } else { [INFO] [stderr] 742 | exclusive = true; [INFO] [stderr] 743 | may_call_lock = true; [INFO] [stderr] 744 | defs.push(quote!(pub #name: rtfm::Exclusive<#lt, #ty>)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `cortex-m-rtfm-macros`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `cortex-m-rtfm-macros`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "460966b71ef15e140f85946b7eba5db64955b830dfd69c3829fc74cdd508254c"` [INFO] running `"docker" "rm" "-f" "460966b71ef15e140f85946b7eba5db64955b830dfd69c3829fc74cdd508254c"` [INFO] [stdout] 460966b71ef15e140f85946b7eba5db64955b830dfd69c3829fc74cdd508254c