[INFO] crate cortex-m 0.5.8 is already in cache [INFO] extracting crate cortex-m 0.5.8 into work/ex/clippy-test-run/sources/stable/reg/cortex-m/0.5.8 [INFO] extracting crate cortex-m 0.5.8 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cortex-m/0.5.8 [INFO] validating manifest of cortex-m-0.5.8 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cortex-m-0.5.8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cortex-m-0.5.8 [INFO] finished frobbing cortex-m-0.5.8 [INFO] frobbed toml for cortex-m-0.5.8 written to work/ex/clippy-test-run/sources/stable/reg/cortex-m/0.5.8/Cargo.toml [INFO] started frobbing cortex-m-0.5.8 [INFO] finished frobbing cortex-m-0.5.8 [INFO] frobbed toml for cortex-m-0.5.8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cortex-m/0.5.8/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cortex-m-0.5.8 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cortex-m/0.5.8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fe1c147527295be23d0fc572cab6ccca72dd365e755271a81ee9265009b31e88 [INFO] running `"docker" "start" "-a" "fe1c147527295be23d0fc572cab6ccca72dd365e755271a81ee9265009b31e88"` [INFO] [stderr] Compiling cortex-m v0.5.8 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/peripheral/syst.rs:29:32 [INFO] [stderr] | [INFO] [stderr] 29 | const SYST_COUNTER_MASK: u32 = 0x00ffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u16`) [INFO] [stderr] --> src/itm.rs:55:42 [INFO] [stderr] | [INFO] [stderr] 55 | port.write_u16(ptr::read(ptr as *const u16)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/itm.rs:71:29 [INFO] [stderr] | [INFO] [stderr] 71 | write_aligned(port, mem::transmute(slice::from_raw_parts(ptr, len))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(slice::from_raw_parts(ptr, len) as *const [u8] as *const aligned::Aligned)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/itm.rs:100:35 [INFO] [stderr] | [INFO] [stderr] 100 | slice::from_raw_parts(buffer.as_ptr() as *const u32, split >> 2), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/itm.rs:105:23 [INFO] [stderr] | [INFO] [stderr] 105 | let mut ptr = buffer.as_ptr().offset(split as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `buffer.as_ptr().add(split)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u16`) [INFO] [stderr] --> src/itm.rs:110:38 [INFO] [stderr] | [INFO] [stderr] 110 | port.write_u16(ptr::read(ptr as *const u16)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/peripheral/cbp.rs:81:19 [INFO] [stderr] | [INFO] [stderr] 81 | (((way as u32) & (CBP_SW_WAY_MASK >> CBP_SW_WAY_POS)) << CBP_SW_WAY_POS) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(way)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/peripheral/cbp.rs:82:25 [INFO] [stderr] | [INFO] [stderr] 82 | | (((set as u32) & (CBP_SW_SET_MASK >> CBP_SW_SET_POS)) << CBP_SW_SET_POS), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(set)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/peripheral/cbp.rs:111:19 [INFO] [stderr] | [INFO] [stderr] 111 | (((way as u32) & (CBP_SW_WAY_MASK >> CBP_SW_WAY_POS)) << CBP_SW_WAY_POS) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(way)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/peripheral/cbp.rs:112:25 [INFO] [stderr] | [INFO] [stderr] 112 | | (((set as u32) & (CBP_SW_SET_MASK >> CBP_SW_SET_POS)) << CBP_SW_SET_POS), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(set)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/peripheral/cbp.rs:133:19 [INFO] [stderr] | [INFO] [stderr] 133 | (((way as u32) & (CBP_SW_WAY_MASK >> CBP_SW_WAY_POS)) << CBP_SW_WAY_POS) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(way)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/peripheral/cbp.rs:134:25 [INFO] [stderr] | [INFO] [stderr] 134 | | (((set as u32) & (CBP_SW_SET_MASK >> CBP_SW_SET_POS)) << CBP_SW_SET_POS), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(set)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/peripheral/cpuid.rs:92:19 [INFO] [stderr] | [INFO] [stderr] 92 | (((level as u32) << CSSELR_LEVEL_POS) & CSSELR_LEVEL_MASK) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(level)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/peripheral/scb.rs:233:17 [INFO] [stderr] | [INFO] [stderr] 233 | pub fn irqn(&self) -> i8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/peripheral/scb.rs:710:14 [INFO] [stderr] | [INFO] [stderr] 710 | fn index(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/peripheral/syst.rs:31:30 [INFO] [stderr] | [INFO] [stderr] 31 | const SYST_CSR_ENABLE: u32 = 1 << 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/peripheral/syst.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | / match clk_source_bit { [INFO] [stderr] 86 | | false => SystClkSource::External, [INFO] [stderr] 87 | | true => SystClkSource::Core, [INFO] [stderr] 88 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if clk_source_bit { SystClkSource::Core } else { SystClkSource::External }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/peripheral/syst.rs:131:31 [INFO] [stderr] | [INFO] [stderr] 131 | pub fn is_counter_enabled(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/peripheral/syst.rs:139:33 [INFO] [stderr] | [INFO] [stderr] 139 | pub fn is_interrupt_enabled(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/peripheral/syst.rs:29:32 [INFO] [stderr] | [INFO] [stderr] 29 | const SYST_COUNTER_MASK: u32 = 0x00ffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/control.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn bits(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/control.rs:16:18 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn npriv(&self) -> Npriv { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/register/control.rs:17:24 [INFO] [stderr] | [INFO] [stderr] 17 | if self.bits & (1 << 0) == (1 << 0) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/register/control.rs:17:36 [INFO] [stderr] | [INFO] [stderr] 17 | if self.bits & (1 << 0) == (1 << 0) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/control.rs:25:18 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn spsel(&self) -> Spsel { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/control.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn fpca(&self) -> Fpca { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/control.rs:54:26 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn is_privileged(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/control.rs:59:28 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn is_unprivileged(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/control.rs:75:19 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn is_msp(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/control.rs:80:19 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn is_psp(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/peripheral/test.rs:89:37 [INFO] [stderr] | [INFO] [stderr] 89 | assert_eq!(address(&mpu._type), 0xE000ED90); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xE000_ED90` [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/control.rs:96:22 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn is_active(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/peripheral/test.rs:90:36 [INFO] [stderr] | [INFO] [stderr] 90 | assert_eq!(address(&mpu.ctrl), 0xE000ED94); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xE000_ED94` [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/control.rs:101:26 [INFO] [stderr] | [INFO] [stderr] 101 | pub fn is_not_active(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/peripheral/test.rs:91:35 [INFO] [stderr] | [INFO] [stderr] 91 | assert_eq!(address(&mpu.rnr), 0xE000ED98); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xE000_ED98` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/peripheral/test.rs:92:36 [INFO] [stderr] | [INFO] [stderr] 92 | assert_eq!(address(&mpu.rbar), 0xE000ED9C); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xE000_ED9C` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/peripheral/test.rs:93:36 [INFO] [stderr] | [INFO] [stderr] 93 | assert_eq!(address(&mpu.rasr), 0xE000EDA0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xE000_EDA0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/peripheral/test.rs:94:39 [INFO] [stderr] | [INFO] [stderr] 94 | assert_eq!(address(&mpu.rbar_a1), 0xE000EDA4); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xE000_EDA4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/peripheral/test.rs:95:39 [INFO] [stderr] | [INFO] [stderr] 95 | assert_eq!(address(&mpu.rsar_a1), 0xE000EDA8); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xE000_EDA8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/peripheral/test.rs:96:39 [INFO] [stderr] | [INFO] [stderr] 96 | assert_eq!(address(&mpu.rbar_a2), 0xE000EDAC); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xE000_EDAC` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/peripheral/test.rs:97:39 [INFO] [stderr] | [INFO] [stderr] 97 | assert_eq!(address(&mpu.rsar_a2), 0xE000EDB0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xE000_EDB0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/peripheral/test.rs:98:39 [INFO] [stderr] | [INFO] [stderr] 98 | assert_eq!(address(&mpu.rbar_a3), 0xE000EDB4); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xE000_EDB4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/peripheral/test.rs:99:39 [INFO] [stderr] | [INFO] [stderr] 99 | assert_eq!(address(&mpu.rsar_a3), 0xE000EDB8); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xE000_EDB8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/peripheral/test.rs:106:37 [INFO] [stderr] | [INFO] [stderr] 106 | assert_eq!(address(&nvic.iser), 0xE000E100); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xE000_E100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/peripheral/test.rs:107:37 [INFO] [stderr] | [INFO] [stderr] 107 | assert_eq!(address(&nvic.icer), 0xE000E180); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xE000_E180` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/peripheral/test.rs:108:37 [INFO] [stderr] | [INFO] [stderr] 108 | assert_eq!(address(&nvic.ispr), 0xE000E200); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xE000_E200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/faultmask.rs:14:22 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn is_active(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/peripheral/test.rs:109:37 [INFO] [stderr] | [INFO] [stderr] 109 | assert_eq!(address(&nvic.icpr), 0xE000E280); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xE000_E280` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/faultmask.rs:19:24 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn is_inactive(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/peripheral/test.rs:110:37 [INFO] [stderr] | [INFO] [stderr] 110 | assert_eq!(address(&nvic.iabr), 0xE000E300); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xE000_E300` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/peripheral/test.rs:111:36 [INFO] [stderr] | [INFO] [stderr] 111 | assert_eq!(address(&nvic.ipr), 0xE000E400); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xE000_E400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/primask.rs:14:22 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn is_active(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/primask.rs:19:24 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn is_inactive(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/apsr.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn bits(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/apsr.rs:16:14 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn q(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/apsr.rs:21:14 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn v(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/apsr.rs:26:14 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn c(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/apsr.rs:31:14 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn z(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/apsr.rs:36:14 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn n(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `cortex-m`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u16`) [INFO] [stderr] --> src/itm.rs:55:42 [INFO] [stderr] | [INFO] [stderr] 55 | port.write_u16(ptr::read(ptr as *const u16)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/itm.rs:71:29 [INFO] [stderr] | [INFO] [stderr] 71 | write_aligned(port, mem::transmute(slice::from_raw_parts(ptr, len))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(slice::from_raw_parts(ptr, len) as *const [u8] as *const aligned::Aligned)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/itm.rs:100:35 [INFO] [stderr] | [INFO] [stderr] 100 | slice::from_raw_parts(buffer.as_ptr() as *const u32, split >> 2), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/itm.rs:105:23 [INFO] [stderr] | [INFO] [stderr] 105 | let mut ptr = buffer.as_ptr().offset(split as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `buffer.as_ptr().add(split)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u16`) [INFO] [stderr] --> src/itm.rs:110:38 [INFO] [stderr] | [INFO] [stderr] 110 | port.write_u16(ptr::read(ptr as *const u16)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/peripheral/cbp.rs:81:19 [INFO] [stderr] | [INFO] [stderr] 81 | (((way as u32) & (CBP_SW_WAY_MASK >> CBP_SW_WAY_POS)) << CBP_SW_WAY_POS) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(way)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/peripheral/cbp.rs:82:25 [INFO] [stderr] | [INFO] [stderr] 82 | | (((set as u32) & (CBP_SW_SET_MASK >> CBP_SW_SET_POS)) << CBP_SW_SET_POS), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(set)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/peripheral/cbp.rs:111:19 [INFO] [stderr] | [INFO] [stderr] 111 | (((way as u32) & (CBP_SW_WAY_MASK >> CBP_SW_WAY_POS)) << CBP_SW_WAY_POS) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(way)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/peripheral/cbp.rs:112:25 [INFO] [stderr] | [INFO] [stderr] 112 | | (((set as u32) & (CBP_SW_SET_MASK >> CBP_SW_SET_POS)) << CBP_SW_SET_POS), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(set)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/peripheral/cbp.rs:133:19 [INFO] [stderr] | [INFO] [stderr] 133 | (((way as u32) & (CBP_SW_WAY_MASK >> CBP_SW_WAY_POS)) << CBP_SW_WAY_POS) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(way)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/peripheral/cbp.rs:134:25 [INFO] [stderr] | [INFO] [stderr] 134 | | (((set as u32) & (CBP_SW_SET_MASK >> CBP_SW_SET_POS)) << CBP_SW_SET_POS), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(set)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/peripheral/cpuid.rs:92:19 [INFO] [stderr] | [INFO] [stderr] 92 | (((level as u32) << CSSELR_LEVEL_POS) & CSSELR_LEVEL_MASK) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(level)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/peripheral/scb.rs:233:17 [INFO] [stderr] | [INFO] [stderr] 233 | pub fn irqn(&self) -> i8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/peripheral/scb.rs:710:14 [INFO] [stderr] | [INFO] [stderr] 710 | fn index(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/peripheral/syst.rs:31:30 [INFO] [stderr] | [INFO] [stderr] 31 | const SYST_CSR_ENABLE: u32 = 1 << 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/peripheral/syst.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | / match clk_source_bit { [INFO] [stderr] 86 | | false => SystClkSource::External, [INFO] [stderr] 87 | | true => SystClkSource::Core, [INFO] [stderr] 88 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if clk_source_bit { SystClkSource::Core } else { SystClkSource::External }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/peripheral/syst.rs:131:31 [INFO] [stderr] | [INFO] [stderr] 131 | pub fn is_counter_enabled(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/peripheral/syst.rs:139:33 [INFO] [stderr] | [INFO] [stderr] 139 | pub fn is_interrupt_enabled(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/control.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn bits(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/control.rs:16:18 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn npriv(&self) -> Npriv { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/register/control.rs:17:24 [INFO] [stderr] | [INFO] [stderr] 17 | if self.bits & (1 << 0) == (1 << 0) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/register/control.rs:17:36 [INFO] [stderr] | [INFO] [stderr] 17 | if self.bits & (1 << 0) == (1 << 0) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/control.rs:25:18 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn spsel(&self) -> Spsel { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/control.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn fpca(&self) -> Fpca { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/control.rs:54:26 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn is_privileged(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/control.rs:59:28 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn is_unprivileged(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/control.rs:75:19 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn is_msp(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/control.rs:80:19 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn is_psp(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/control.rs:96:22 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn is_active(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/control.rs:101:26 [INFO] [stderr] | [INFO] [stderr] 101 | pub fn is_not_active(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/faultmask.rs:14:22 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn is_active(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/faultmask.rs:19:24 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn is_inactive(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/primask.rs:14:22 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn is_active(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/primask.rs:19:24 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn is_inactive(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/apsr.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn bits(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/apsr.rs:16:14 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn q(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/apsr.rs:21:14 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn v(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/apsr.rs:26:14 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn c(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/apsr.rs:31:14 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn z(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/register/apsr.rs:36:14 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn n(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `cortex-m`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "fe1c147527295be23d0fc572cab6ccca72dd365e755271a81ee9265009b31e88"` [INFO] running `"docker" "rm" "-f" "fe1c147527295be23d0fc572cab6ccca72dd365e755271a81ee9265009b31e88"` [INFO] [stdout] fe1c147527295be23d0fc572cab6ccca72dd365e755271a81ee9265009b31e88