[INFO] crate corona 0.4.0 is already in cache [INFO] extracting crate corona 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/corona/0.4.0 [INFO] extracting crate corona 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/corona/0.4.0 [INFO] validating manifest of corona-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of corona-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing corona-0.4.0 [INFO] removed 0 missing tests [INFO] finished frobbing corona-0.4.0 [INFO] frobbed toml for corona-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/corona/0.4.0/Cargo.toml [INFO] started frobbing corona-0.4.0 [INFO] removed 0 missing tests [INFO] finished frobbing corona-0.4.0 [INFO] frobbed toml for corona-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/corona/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting corona-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/corona/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c599ed062152913a40d276cd6101e5a2a1302f29df6ee50423c376635bee079e [INFO] running `"docker" "start" "-a" "c599ed062152913a40d276cd6101e5a2a1302f29df6ee50423c376635bee079e"` [INFO] [stderr] Compiling context v2.1.0 [INFO] [stderr] Checking corona v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/coroutine.rs:596:17 [INFO] [stderr] | [INFO] [stderr] 596 | msg [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/coroutine.rs:595:27 [INFO] [stderr] | [INFO] [stderr] 595 | let msg = Coroutine::wait(receiver).unwrap().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/coroutine.rs:719:24 [INFO] [stderr] | [INFO] [stderr] 719 | if let Ok(_) = panic::catch_unwind(|| Coroutine::wait(PanicFuture)) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 720 | | panic!("A panic should fall out of wait"); [INFO] [stderr] 721 | | } [INFO] [stderr] | |_________________- help: try this: `if panic::catch_unwind(|| Coroutine::wait(PanicFuture)).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.05s [INFO] running `"docker" "inspect" "c599ed062152913a40d276cd6101e5a2a1302f29df6ee50423c376635bee079e"` [INFO] running `"docker" "rm" "-f" "c599ed062152913a40d276cd6101e5a2a1302f29df6ee50423c376635bee079e"` [INFO] [stdout] c599ed062152913a40d276cd6101e5a2a1302f29df6ee50423c376635bee079e