[INFO] crate corollary-support 0.2.0 is already in cache [INFO] extracting crate corollary-support 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/corollary-support/0.2.0 [INFO] extracting crate corollary-support 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/corollary-support/0.2.0 [INFO] validating manifest of corollary-support-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of corollary-support-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing corollary-support-0.2.0 [INFO] finished frobbing corollary-support-0.2.0 [INFO] frobbed toml for corollary-support-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/corollary-support/0.2.0/Cargo.toml [INFO] started frobbing corollary-support-0.2.0 [INFO] finished frobbing corollary-support-0.2.0 [INFO] frobbed toml for corollary-support-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/corollary-support/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting corollary-support-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/corollary-support/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 70039ef71ba1e9ca07a8290dd1190d0458a68467c55d7d56f849f51c639a8d51 [INFO] running `"docker" "start" "-a" "70039ef71ba1e9ca07a8290dd1190d0458a68467c55d7d56f849f51c639a8d51"` [INFO] [stderr] Checking corollary-support v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:754:9 [INFO] [stderr] | [INFO] [stderr] 754 | return self.path.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.path.clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:754:9 [INFO] [stderr] | [INFO] [stderr] 754 | return self.path.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.path.clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: field is never used: `idx` [INFO] [stderr] --> src/lib.rs:861:5 [INFO] [stderr] | [INFO] [stderr] 861 | idx: Vec, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `inner` [INFO] [stderr] --> src/lib.rs:862:5 [INFO] [stderr] | [INFO] [stderr] 862 | inner: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:389:17 [INFO] [stderr] | [INFO] [stderr] 389 | if cond(item.clone()) { [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `item` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:417:17 [INFO] [stderr] | [INFO] [stderr] 417 | if cond(item.clone()) && out.is_empty() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `item` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:430:17 [INFO] [stderr] | [INFO] [stderr] 430 | if cond(item.clone()) && right.is_empty() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `item` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:611:12 [INFO] [stderr] | [INFO] [stderr] 611 | if input.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:656:12 [INFO] [stderr] | [INFO] [stderr] 656 | if input.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:797:15 [INFO] [stderr] | [INFO] [stderr] 797 | maybe.map(|x| method(x)).unwrap_or(default_) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `method` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: field is never used: `idx` [INFO] [stderr] --> src/lib.rs:861:5 [INFO] [stderr] | [INFO] [stderr] 861 | idx: Vec, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `inner` [INFO] [stderr] --> src/lib.rs:862:5 [INFO] [stderr] | [INFO] [stderr] 862 | inner: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:389:17 [INFO] [stderr] | [INFO] [stderr] 389 | if cond(item.clone()) { [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `item` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:417:17 [INFO] [stderr] | [INFO] [stderr] 417 | if cond(item.clone()) && out.is_empty() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `item` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:430:17 [INFO] [stderr] | [INFO] [stderr] 430 | if cond(item.clone()) && right.is_empty() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `item` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:611:12 [INFO] [stderr] | [INFO] [stderr] 611 | if input.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:656:12 [INFO] [stderr] | [INFO] [stderr] 656 | if input.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:797:15 [INFO] [stderr] | [INFO] [stderr] 797 | maybe.map(|x| method(x)).unwrap_or(default_) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `method` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.74s [INFO] running `"docker" "inspect" "70039ef71ba1e9ca07a8290dd1190d0458a68467c55d7d56f849f51c639a8d51"` [INFO] running `"docker" "rm" "-f" "70039ef71ba1e9ca07a8290dd1190d0458a68467c55d7d56f849f51c639a8d51"` [INFO] [stdout] 70039ef71ba1e9ca07a8290dd1190d0458a68467c55d7d56f849f51c639a8d51