[INFO] crate coreutils_auth 0.4.0 is already in cache [INFO] extracting crate coreutils_auth 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/coreutils_auth/0.4.0 [INFO] extracting crate coreutils_auth 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/coreutils_auth/0.4.0 [INFO] validating manifest of coreutils_auth-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of coreutils_auth-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing coreutils_auth-0.4.0 [INFO] finished frobbing coreutils_auth-0.4.0 [INFO] frobbed toml for coreutils_auth-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/coreutils_auth/0.4.0/Cargo.toml [INFO] started frobbing coreutils_auth-0.4.0 [INFO] finished frobbing coreutils_auth-0.4.0 [INFO] frobbed toml for coreutils_auth-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/coreutils_auth/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting coreutils_auth-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/coreutils_auth/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3f15b397dbdc2d4c203a29413e5b38cdb04ef6e522100416f8331f505246d30f [INFO] running `"docker" "start" "-a" "3f15b397dbdc2d4c203a29413e5b38cdb04ef6e522100416f8331f505246d30f"` [INFO] [stderr] Checking coreutils_auth v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:845:13 [INFO] [stderr] | [INFO] [stderr] 845 | return self.owner_id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.owner_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:272:48 [INFO] [stderr] | [INFO] [stderr] 272 | let get_by_name = provider.get_by_name(&vec![]); [INFO] [stderr] | ^^^^^^^ help: you can use a slice directly: `&[]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:289:48 [INFO] [stderr] | [INFO] [stderr] 289 | let get_by_name = provider.get_by_name(&vec!["RoleOne".to_string()]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["RoleOne".to_string()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.43s [INFO] running `"docker" "inspect" "3f15b397dbdc2d4c203a29413e5b38cdb04ef6e522100416f8331f505246d30f"` [INFO] running `"docker" "rm" "-f" "3f15b397dbdc2d4c203a29413e5b38cdb04ef6e522100416f8331f505246d30f"` [INFO] [stdout] 3f15b397dbdc2d4c203a29413e5b38cdb04ef6e522100416f8331f505246d30f