[INFO] crate corepack 0.4.0 is already in cache [INFO] extracting crate corepack 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/corepack/0.4.0 [INFO] extracting crate corepack 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/corepack/0.4.0 [INFO] validating manifest of corepack-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of corepack-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing corepack-0.4.0 [INFO] finished frobbing corepack-0.4.0 [INFO] frobbed toml for corepack-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/corepack/0.4.0/Cargo.toml [INFO] started frobbing corepack-0.4.0 [INFO] finished frobbing corepack-0.4.0 [INFO] frobbed toml for corepack-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/corepack/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting corepack-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/corepack/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 49139512a4aacf7aa96f2f294a05dba0ef4c76420646c435622c9d81d0aad3f8 [INFO] running `"docker" "start" "-a" "49139512a4aacf7aa96f2f294a05dba0ef4c76420646c435622c9d81d0aad3f8"` [INFO] [stderr] Checking corepack v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/read.rs:51:22 [INFO] [stderr] | [INFO] [stderr] 51 | BorrowRead { thunk: thunk } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `thunk` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/read.rs:57:20 [INFO] [stderr] | [INFO] [stderr] 57 | CopyRead { thunk: thunk } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `thunk` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/seq_serializer.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | output: output, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map_serializer.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | output: output, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/variant_deserializer.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | de: de, [INFO] [stderr] | ^^^^^^ help: replace it with: `de` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/variant_deserializer.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | variants: variants, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `variants` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ext_deserializer.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ext_deserializer.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/seq_deserializer.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | de: de, [INFO] [stderr] | ^^^^^^ help: replace it with: `de` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/seq_deserializer.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | count: count, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:28:22 [INFO] [stderr] | [INFO] [stderr] 28 | Serializer { output: output } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | read: read, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `read` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/read.rs:51:22 [INFO] [stderr] | [INFO] [stderr] 51 | BorrowRead { thunk: thunk } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `thunk` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/read.rs:57:20 [INFO] [stderr] | [INFO] [stderr] 57 | CopyRead { thunk: thunk } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `thunk` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/seq_serializer.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | output: output, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map_serializer.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | output: output, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/variant_deserializer.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | de: de, [INFO] [stderr] | ^^^^^^ help: replace it with: `de` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/variant_deserializer.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | variants: variants, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `variants` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ext_deserializer.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ext_deserializer.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/seq_deserializer.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | de: de, [INFO] [stderr] | ^^^^^^ help: replace it with: `de` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/seq_deserializer.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | count: count, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:28:22 [INFO] [stderr] | [INFO] [stderr] 28 | Serializer { output: output } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | read: read, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `read` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/defs.rs:10:28 [INFO] [stderr] | [INFO] [stderr] 10 | pub const FIXINT_MAX: u8 = 0b01111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/defs.rs:11:28 [INFO] [stderr] | [INFO] [stderr] 11 | pub const FIXINT_MIN: i8 = 0b11100000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1110_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/defs.rs:10:28 [INFO] [stderr] | [INFO] [stderr] 10 | pub const FIXINT_MAX: u8 = 0b01111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/defs.rs:11:28 [INFO] [stderr] | [INFO] [stderr] 11 | pub const FIXINT_MIN: i8 = 0b11100000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1110_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | / match self { [INFO] [stderr] 49 | | &Error::TooBig => "Overflowing value", [INFO] [stderr] 50 | | &Error::EndOfStream => "End of stream", [INFO] [stderr] 51 | | &Error::BadType => "Invalid type", [INFO] [stderr] ... | [INFO] [stderr] 54 | | &Error::Other(ref message) => &message, [INFO] [stderr] 55 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 48 | match *self { [INFO] [stderr] 49 | Error::TooBig => "Overflowing value", [INFO] [stderr] 50 | Error::EndOfStream => "End of stream", [INFO] [stderr] 51 | Error::BadType => "Invalid type", [INFO] [stderr] 52 | Error::BadLength => "Invalid length", [INFO] [stderr] 53 | Error::Utf8Error(_) => "UTF8 Error", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | / match self { [INFO] [stderr] 73 | | &Error::Utf8Error(ref cause) => Some(cause), [INFO] [stderr] 74 | | _ => None, [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 72 | match *self { [INFO] [stderr] 73 | Error::Utf8Error(ref cause) => Some(cause), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: any number modulo 1 will be 0 [INFO] [stderr] --> src/map_serializer.rs:86:12 [INFO] [stderr] | [INFO] [stderr] 86 | if self.count % 1 != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::modulo_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#modulo_one [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:32:21 [INFO] [stderr] | [INFO] [stderr] 32 | if value >= FIXINT_MIN as i64 && value <= FIXINT_MAX as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(FIXINT_MIN)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:32:51 [INFO] [stderr] | [INFO] [stderr] 32 | if value >= FIXINT_MIN as i64 && value <= FIXINT_MAX as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(FIXINT_MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:36:28 [INFO] [stderr] | [INFO] [stderr] 36 | } else if value >= i8::min_value() as i64 && value <= i8::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(i8::min_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:36:63 [INFO] [stderr] | [INFO] [stderr] 36 | } else if value >= i8::min_value() as i64 && value <= i8::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(i8::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:40:42 [INFO] [stderr] | [INFO] [stderr] 40 | } else if value >= 0 && value <= u8::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(u8::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:44:28 [INFO] [stderr] | [INFO] [stderr] 44 | } else if value >= i16::min_value() as i64 && value <= i16::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(i16::min_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:44:64 [INFO] [stderr] | [INFO] [stderr] 44 | } else if value >= i16::min_value() as i64 && value <= i16::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(i16::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:48:42 [INFO] [stderr] | [INFO] [stderr] 48 | } else if value >= 0 && value <= u16::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(u16::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:52:28 [INFO] [stderr] | [INFO] [stderr] 52 | } else if value >= i32::min_value() as i64 && value <= i32::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(i32::min_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:52:64 [INFO] [stderr] | [INFO] [stderr] 52 | } else if value >= i32::min_value() as i64 && value <= i32::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(i32::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:56:42 [INFO] [stderr] | [INFO] [stderr] 56 | } else if value >= 0 && value <= u32::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(u32::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:68:21 [INFO] [stderr] | [INFO] [stderr] 68 | if value <= FIXINT_MAX as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(FIXINT_MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:70:28 [INFO] [stderr] | [INFO] [stderr] 70 | } else if value <= u8::max_value() as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(u8::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:72:28 [INFO] [stderr] | [INFO] [stderr] 72 | } else if value <= u16::max_value() as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(u16::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:76:28 [INFO] [stderr] | [INFO] [stderr] 76 | } else if value <= u32::max_value() as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(u32::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:158:33 [INFO] [stderr] | [INFO] [stderr] 158 | self.serialize_unsigned(variant_index as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(variant_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:224:44 [INFO] [stderr] | [INFO] [stderr] 224 | Serializer::serialize_signed(self, value as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:228:44 [INFO] [stderr] | [INFO] [stderr] 228 | Serializer::serialize_signed(self, value as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:232:44 [INFO] [stderr] | [INFO] [stderr] 232 | Serializer::serialize_signed(self, value as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:236:46 [INFO] [stderr] | [INFO] [stderr] 236 | Serializer::serialize_unsigned(self, value as u64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:240:46 [INFO] [stderr] | [INFO] [stderr] 240 | Serializer::serialize_unsigned(self, value as u64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:244:46 [INFO] [stderr] | [INFO] [stderr] 244 | Serializer::serialize_unsigned(self, value as u64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/de.rs:58:72 [INFO] [stderr] | [INFO] [stderr] 58 | visitor.visit_borrowed_str(str::from_utf8(buf).map_err(|e| Into::::into(e))?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Into::::into` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/de.rs:61:63 [INFO] [stderr] | [INFO] [stderr] 61 | visitor.visit_str(str::from_utf8(buf).map_err(|e| Into::::into(e))?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Into::::into` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] --> src/lib.rs:49:18 [INFO] [stderr] | [INFO] [stderr] 49 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 49 | for in &mut buf { [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `corepack`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | / match self { [INFO] [stderr] 49 | | &Error::TooBig => "Overflowing value", [INFO] [stderr] 50 | | &Error::EndOfStream => "End of stream", [INFO] [stderr] 51 | | &Error::BadType => "Invalid type", [INFO] [stderr] ... | [INFO] [stderr] 54 | | &Error::Other(ref message) => &message, [INFO] [stderr] 55 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 48 | match *self { [INFO] [stderr] 49 | Error::TooBig => "Overflowing value", [INFO] [stderr] 50 | Error::EndOfStream => "End of stream", [INFO] [stderr] 51 | Error::BadType => "Invalid type", [INFO] [stderr] 52 | Error::BadLength => "Invalid length", [INFO] [stderr] 53 | Error::Utf8Error(_) => "UTF8 Error", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | / match self { [INFO] [stderr] 73 | | &Error::Utf8Error(ref cause) => Some(cause), [INFO] [stderr] 74 | | _ => None, [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 72 | match *self { [INFO] [stderr] 73 | Error::Utf8Error(ref cause) => Some(cause), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: any number modulo 1 will be 0 [INFO] [stderr] --> src/map_serializer.rs:86:12 [INFO] [stderr] | [INFO] [stderr] 86 | if self.count % 1 != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::modulo_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#modulo_one [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:32:21 [INFO] [stderr] | [INFO] [stderr] 32 | if value >= FIXINT_MIN as i64 && value <= FIXINT_MAX as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(FIXINT_MIN)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:32:51 [INFO] [stderr] | [INFO] [stderr] 32 | if value >= FIXINT_MIN as i64 && value <= FIXINT_MAX as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(FIXINT_MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:36:28 [INFO] [stderr] | [INFO] [stderr] 36 | } else if value >= i8::min_value() as i64 && value <= i8::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(i8::min_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:36:63 [INFO] [stderr] | [INFO] [stderr] 36 | } else if value >= i8::min_value() as i64 && value <= i8::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(i8::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:40:42 [INFO] [stderr] | [INFO] [stderr] 40 | } else if value >= 0 && value <= u8::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(u8::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:44:28 [INFO] [stderr] | [INFO] [stderr] 44 | } else if value >= i16::min_value() as i64 && value <= i16::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(i16::min_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:44:64 [INFO] [stderr] | [INFO] [stderr] 44 | } else if value >= i16::min_value() as i64 && value <= i16::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(i16::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:48:42 [INFO] [stderr] | [INFO] [stderr] 48 | } else if value >= 0 && value <= u16::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(u16::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:52:28 [INFO] [stderr] | [INFO] [stderr] 52 | } else if value >= i32::min_value() as i64 && value <= i32::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(i32::min_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:52:64 [INFO] [stderr] | [INFO] [stderr] 52 | } else if value >= i32::min_value() as i64 && value <= i32::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(i32::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:56:42 [INFO] [stderr] | [INFO] [stderr] 56 | } else if value >= 0 && value <= u32::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(u32::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:68:21 [INFO] [stderr] | [INFO] [stderr] 68 | if value <= FIXINT_MAX as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(FIXINT_MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:70:28 [INFO] [stderr] | [INFO] [stderr] 70 | } else if value <= u8::max_value() as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(u8::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:72:28 [INFO] [stderr] | [INFO] [stderr] 72 | } else if value <= u16::max_value() as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(u16::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:76:28 [INFO] [stderr] | [INFO] [stderr] 76 | } else if value <= u32::max_value() as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(u32::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:158:33 [INFO] [stderr] | [INFO] [stderr] 158 | self.serialize_unsigned(variant_index as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(variant_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:224:44 [INFO] [stderr] | [INFO] [stderr] 224 | Serializer::serialize_signed(self, value as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:228:44 [INFO] [stderr] | [INFO] [stderr] 228 | Serializer::serialize_signed(self, value as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:232:44 [INFO] [stderr] | [INFO] [stderr] 232 | Serializer::serialize_signed(self, value as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:236:46 [INFO] [stderr] | [INFO] [stderr] 236 | Serializer::serialize_unsigned(self, value as u64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:240:46 [INFO] [stderr] | [INFO] [stderr] 240 | Serializer::serialize_unsigned(self, value as u64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:244:46 [INFO] [stderr] | [INFO] [stderr] 244 | Serializer::serialize_unsigned(self, value as u64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/de.rs:58:72 [INFO] [stderr] | [INFO] [stderr] 58 | visitor.visit_borrowed_str(str::from_utf8(buf).map_err(|e| Into::::into(e))?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Into::::into` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/de.rs:61:63 [INFO] [stderr] | [INFO] [stderr] 61 | visitor.visit_str(str::from_utf8(buf).map_err(|e| Into::::into(e))?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Into::::into` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/de.rs:479:9 [INFO] [stderr] | [INFO] [stderr] 479 | assert_eq!(value, 100.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/de.rs:479:9 [INFO] [stderr] | [INFO] [stderr] 479 | assert_eq!(value, 100.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/de.rs:524:32 [INFO] [stderr] | [INFO] [stderr] 524 | assert_eq!(map.remove(&format!("one")), Some(1)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `"one".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/de.rs:525:32 [INFO] [stderr] | [INFO] [stderr] 525 | assert_eq!(map.remove(&format!("two")), Some(2)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `"two".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/de.rs:526:32 [INFO] [stderr] | [INFO] [stderr] 526 | assert_eq!(map.remove(&format!("three")), Some(3)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"three".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] --> src/lib.rs:49:18 [INFO] [stderr] | [INFO] [stderr] 49 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 49 | for in &mut buf { [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:130:22 [INFO] [stderr] | [INFO] [stderr] 130 | test_through(format!("Hello World!"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Hello World!".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `corepack`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "49139512a4aacf7aa96f2f294a05dba0ef4c76420646c435622c9d81d0aad3f8"` [INFO] running `"docker" "rm" "-f" "49139512a4aacf7aa96f2f294a05dba0ef4c76420646c435622c9d81d0aad3f8"` [INFO] [stdout] 49139512a4aacf7aa96f2f294a05dba0ef4c76420646c435622c9d81d0aad3f8