[INFO] crate copy_dir 0.1.2 is already in cache [INFO] extracting crate copy_dir 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/copy_dir/0.1.2 [INFO] extracting crate copy_dir 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/copy_dir/0.1.2 [INFO] validating manifest of copy_dir-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of copy_dir-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing copy_dir-0.1.2 [INFO] finished frobbing copy_dir-0.1.2 [INFO] frobbed toml for copy_dir-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/copy_dir/0.1.2/Cargo.toml [INFO] started frobbing copy_dir-0.1.2 [INFO] finished frobbing copy_dir-0.1.2 [INFO] frobbed toml for copy_dir-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/copy_dir/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting copy_dir-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/copy_dir/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c175e191deb5d6da0ef9a7db67692688815a22b83aa7154f7caefb9d8447efd7 [INFO] running `"docker" "start" "-a" "c175e191deb5d6da0ef9a7db67692688815a22b83aa7154f7caefb9d8447efd7"` [INFO] [stderr] Checking copy_dir v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/lib.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | Err(_) => panic!("strip_prefix failed; this is a probably a bug in copy_dir"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / match $expr { [INFO] [stderr] 14 | | Err(e) => $vec.push(e), [INFO] [stderr] 15 | | Ok(_) => (), [INFO] [stderr] 16 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = fs::create_dir(&target_path) { push_error!(fs::create_dir(&target_path), errors); }` [INFO] [stderr] ... [INFO] [stderr] 144 | push_error!(fs::create_dir(&target_path), errors); [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / match $expr { [INFO] [stderr] 14 | | Err(e) => $vec.push(e), [INFO] [stderr] 15 | | Ok(_) => (), [INFO] [stderr] 16 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 145 | / push_error!( [INFO] [stderr] 146 | | fs::set_permissions( [INFO] [stderr] 147 | | &target_path, [INFO] [stderr] 148 | | source_metadata.permissions() [INFO] [stderr] 149 | | ), [INFO] [stderr] 150 | | errors [INFO] [stderr] 151 | | ); [INFO] [stderr] | |______________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | if let Err(e) = fs::set_permissions( [INFO] [stderr] 14 | &target_path, [INFO] [stderr] 15 | source_metadata.permissions() [INFO] [stderr] 16 | ) { push_error!( [INFO] [stderr] 17 | fs::set_permissions( [INFO] [stderr] 18 | &target_path, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / match $expr { [INFO] [stderr] 14 | | Err(e) => $vec.push(e), [INFO] [stderr] 15 | | Ok(_) => (), [INFO] [stderr] 16 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = fs::copy(entry.path(), &target_path) { push_error!(fs::copy(entry.path(), &target_path), errors); }` [INFO] [stderr] ... [INFO] [stderr] 154 | push_error!(fs::copy(entry.path(), &target_path), errors); [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/lib.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | Err(_) => panic!("strip_prefix failed; this is a probably a bug in copy_dir"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / match $expr { [INFO] [stderr] 14 | | Err(e) => $vec.push(e), [INFO] [stderr] 15 | | Ok(_) => (), [INFO] [stderr] 16 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = fs::create_dir(&target_path) { push_error!(fs::create_dir(&target_path), errors); }` [INFO] [stderr] ... [INFO] [stderr] 144 | push_error!(fs::create_dir(&target_path), errors); [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / match $expr { [INFO] [stderr] 14 | | Err(e) => $vec.push(e), [INFO] [stderr] 15 | | Ok(_) => (), [INFO] [stderr] 16 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 145 | / push_error!( [INFO] [stderr] 146 | | fs::set_permissions( [INFO] [stderr] 147 | | &target_path, [INFO] [stderr] 148 | | source_metadata.permissions() [INFO] [stderr] 149 | | ), [INFO] [stderr] 150 | | errors [INFO] [stderr] 151 | | ); [INFO] [stderr] | |______________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | if let Err(e) = fs::set_permissions( [INFO] [stderr] 14 | &target_path, [INFO] [stderr] 15 | source_metadata.permissions() [INFO] [stderr] 16 | ) { push_error!( [INFO] [stderr] 17 | fs::set_permissions( [INFO] [stderr] 18 | &target_path, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / match $expr { [INFO] [stderr] 14 | | Err(e) => $vec.push(e), [INFO] [stderr] 15 | | Ok(_) => (), [INFO] [stderr] 16 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = fs::copy(entry.path(), &target_path) { push_error!(fs::copy(entry.path(), &target_path), errors); }` [INFO] [stderr] ... [INFO] [stderr] 154 | push_error!(fs::copy(entry.path(), &target_path), errors); [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.23s [INFO] running `"docker" "inspect" "c175e191deb5d6da0ef9a7db67692688815a22b83aa7154f7caefb9d8447efd7"` [INFO] running `"docker" "rm" "-f" "c175e191deb5d6da0ef9a7db67692688815a22b83aa7154f7caefb9d8447efd7"` [INFO] [stdout] c175e191deb5d6da0ef9a7db67692688815a22b83aa7154f7caefb9d8447efd7