[INFO] crate copy_arena 0.1.1 is already in cache [INFO] extracting crate copy_arena 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/copy_arena/0.1.1 [INFO] extracting crate copy_arena 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/copy_arena/0.1.1 [INFO] validating manifest of copy_arena-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of copy_arena-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing copy_arena-0.1.1 [INFO] finished frobbing copy_arena-0.1.1 [INFO] frobbed toml for copy_arena-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/copy_arena/0.1.1/Cargo.toml [INFO] started frobbing copy_arena-0.1.1 [INFO] finished frobbing copy_arena-0.1.1 [INFO] frobbed toml for copy_arena-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/copy_arena/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting copy_arena-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/copy_arena/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a47d0d7dbbadc1db543526f922e26ff4065a1afd3220d883c66a3fb2983dac6d [INFO] running `"docker" "start" "-a" "a47d0d7dbbadc1db543526f922e26ff4065a1afd3220d883c66a3fb2983dac6d"` [INFO] [stderr] Checking copy_arena v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'std::mem::min_align_of': use `align_of` instead [INFO] [stderr] --> src/lib.rs:180:58 [INFO] [stderr] | [INFO] [stderr] 180 | let memory = self.alloc_raw(mem::size_of::(), mem::min_align_of::()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::mem::min_align_of': use `align_of` instead [INFO] [stderr] --> src/lib.rs:196:49 [INFO] [stderr] | [INFO] [stderr] 196 | let memory = self.alloc_raw(byte_count, mem::min_align_of::()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:203:13 [INFO] [stderr] | [INFO] [stderr] 203 | let mut slice = self.alloc_slice_raw(elems.len()); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:215:13 [INFO] [stderr] | [INFO] [stderr] 215 | let mut slice = self.alloc_slice_raw(len); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:78:17 [INFO] [stderr] | [INFO] [stderr] 78 | self.data.as_mut_ptr().offset(start as isize) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.data.as_mut_ptr().add(start)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Arena` [INFO] [stderr] --> src/lib.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | / pub fn new() -> Arena { [INFO] [stderr] 97 | | Arena::with_capacity(1000) [INFO] [stderr] 98 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:236:39 [INFO] [stderr] | [INFO] [stderr] 236 | let z: &mut u32 = allocator.alloc(0x11223344); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1122_3344` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:240:20 [INFO] [stderr] | [INFO] [stderr] 240 | assert_eq!(*z, 0x11223344); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1122_3344` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 94 | impl Default for Arena { [INFO] [stderr] 95 | fn default() -> Self { [INFO] [stderr] 96 | Self::new() [INFO] [stderr] 97 | } [INFO] [stderr] 98 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut u8`) to a reference type (`&'a mut u8`) [INFO] [stderr] --> src/lib.rs:167:46 [INFO] [stderr] | [INFO] [stderr] 167 | Some(x) => { return unsafe { mem::transmute(x) } }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `&mut *x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:181:39 [INFO] [stderr] | [INFO] [stderr] 181 | let res: &'a mut T = unsafe { mem::transmute(memory) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(memory as *mut u8 as *mut T)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/lib.rs:197:68 [INFO] [stderr] | [INFO] [stderr] 197 | let res: &'a mut [T] = unsafe { slice::from_raw_parts_mut( mem::transmute(memory), len) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `memory as *mut u8 as *mut T` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::mem::min_align_of': use `align_of` instead [INFO] [stderr] --> src/lib.rs:180:58 [INFO] [stderr] | [INFO] [stderr] 180 | let memory = self.alloc_raw(mem::size_of::(), mem::min_align_of::()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::mem::min_align_of': use `align_of` instead [INFO] [stderr] --> src/lib.rs:196:49 [INFO] [stderr] | [INFO] [stderr] 196 | let memory = self.alloc_raw(byte_count, mem::min_align_of::()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:203:13 [INFO] [stderr] | [INFO] [stderr] 203 | let mut slice = self.alloc_slice_raw(elems.len()); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:215:13 [INFO] [stderr] | [INFO] [stderr] 215 | let mut slice = self.alloc_slice_raw(len); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:78:17 [INFO] [stderr] | [INFO] [stderr] 78 | self.data.as_mut_ptr().offset(start as isize) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.data.as_mut_ptr().add(start)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Arena` [INFO] [stderr] --> src/lib.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | / pub fn new() -> Arena { [INFO] [stderr] 97 | | Arena::with_capacity(1000) [INFO] [stderr] 98 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 94 | impl Default for Arena { [INFO] [stderr] 95 | fn default() -> Self { [INFO] [stderr] 96 | Self::new() [INFO] [stderr] 97 | } [INFO] [stderr] 98 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut u8`) to a reference type (`&'a mut u8`) [INFO] [stderr] --> src/lib.rs:167:46 [INFO] [stderr] | [INFO] [stderr] 167 | Some(x) => { return unsafe { mem::transmute(x) } }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `&mut *x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:181:39 [INFO] [stderr] | [INFO] [stderr] 181 | let res: &'a mut T = unsafe { mem::transmute(memory) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(memory as *mut u8 as *mut T)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/lib.rs:197:68 [INFO] [stderr] | [INFO] [stderr] 197 | let res: &'a mut [T] = unsafe { slice::from_raw_parts_mut( mem::transmute(memory), len) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `memory as *mut u8 as *mut T` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:241:5 [INFO] [stderr] | [INFO] [stderr] 241 | assert_eq!(*w, 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:241:5 [INFO] [stderr] | [INFO] [stderr] 241 | assert_eq!(*w, 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `copy_arena`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "a47d0d7dbbadc1db543526f922e26ff4065a1afd3220d883c66a3fb2983dac6d"` [INFO] running `"docker" "rm" "-f" "a47d0d7dbbadc1db543526f922e26ff4065a1afd3220d883c66a3fb2983dac6d"` [INFO] [stdout] a47d0d7dbbadc1db543526f922e26ff4065a1afd3220d883c66a3fb2983dac6d