[INFO] crate copperline 0.3.0 is already in cache
[INFO] extracting crate copperline 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/copperline/0.3.0
[INFO] extracting crate copperline 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/copperline/0.3.0
[INFO] validating manifest of copperline-0.3.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of copperline-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing copperline-0.3.0
[INFO] finished frobbing copperline-0.3.0
[INFO] frobbed toml for copperline-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/copperline/0.3.0/Cargo.toml
[INFO] started frobbing copperline-0.3.0
[INFO] finished frobbing copperline-0.3.0
[INFO] frobbed toml for copperline-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/copperline/0.3.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting copperline-0.3.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/copperline/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 506d945aba4bc205052344fb232048f3d6560810a2c10b4937dcb3eb0455b0c0
[INFO] running `"docker" "start" "-a" "506d945aba4bc205052344fb232048f3d6560810a2c10b4937dcb3eb0455b0c0"`
[INFO] [stderr]     Checking strcursor v0.1.0
[INFO] [stderr]     Checking nix v0.4.3
[INFO] [stderr]     Checking copperline v0.3.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/term.rs:37:13
[INFO] [stderr]    |
[INFO] [stderr] 37 |             fd: fd,
[INFO] [stderr]    |             ^^^^^^ help: replace it with: `fd`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/term.rs:38:13
[INFO] [stderr]    |
[INFO] [stderr] 38 |             original_termios: original_termios
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `original_termios`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/term.rs:70:13
[INFO] [stderr]    |
[INFO] [stderr] 70 |             in_fd: in_fd,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `in_fd`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/term.rs:71:13
[INFO] [stderr]    |
[INFO] [stderr] 71 |             out_fd: out_fd
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `out_fd`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:152:17
[INFO] [stderr]     |
[INFO] [stderr] 152 |                 prompt: prompt,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^ help: replace it with: `prompt`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:153:17
[INFO] [stderr]     |
[INFO] [stderr] 153 |                 enc: enc
[INFO] [stderr]     |                 ^^^^^^^^ help: replace it with: `enc`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/lib.rs:156:9
[INFO] [stderr]     |
[INFO] [stderr] 156 |         println!("");
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/term.rs:37:13
[INFO] [stderr]    |
[INFO] [stderr] 37 |             fd: fd,
[INFO] [stderr]    |             ^^^^^^ help: replace it with: `fd`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/term.rs:38:13
[INFO] [stderr]    |
[INFO] [stderr] 38 |             original_termios: original_termios
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `original_termios`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/term.rs:70:13
[INFO] [stderr]    |
[INFO] [stderr] 70 |             in_fd: in_fd,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `in_fd`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/term.rs:71:13
[INFO] [stderr]    |
[INFO] [stderr] 71 |             out_fd: out_fd
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `out_fd`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:152:17
[INFO] [stderr]     |
[INFO] [stderr] 152 |                 prompt: prompt,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^ help: replace it with: `prompt`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:153:17
[INFO] [stderr]     |
[INFO] [stderr] 153 |                 enc: enc
[INFO] [stderr]     |                 ^^^^^^^^ help: replace it with: `enc`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/lib.rs:156:9
[INFO] [stderr]     |
[INFO] [stderr] 156 |         println!("");
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/buffer.rs:60:13
[INFO] [stderr]    |
[INFO] [stderr] 60 |             return true;
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/buffer.rs:62:13
[INFO] [stderr]    |
[INFO] [stderr] 62 |             return false;
[INFO] [stderr]    |             ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `for` head expression
[INFO] [stderr]   --> src/lib.rs:61:26
[INFO] [stderr]    |
[INFO] [stderr] 61 |                 for _ in (0..len) {
[INFO] [stderr]    |                          ^^^^^^^^ help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `for` head expression
[INFO] [stderr]    --> src/lib.rs:109:26
[INFO] [stderr]     |
[INFO] [stderr] 109 |                 for _ in (0..len) {
[INFO] [stderr]     |                          ^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `RawDecoder`
[INFO] [stderr]  --> src/parser.rs:3:36
[INFO] [stderr]   |
[INFO] [stderr] 3 | use encoding::types::{EncodingRef, RawDecoder};
[INFO] [stderr]   |                                    ^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `reset`
[INFO] [stderr]   --> src/buffer.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 |     pub fn reset(&mut self) {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `pop`
[INFO] [stderr]   --> src/history.rs:67:5
[INFO] [stderr]    |
[INFO] [stderr] 67 |     pub fn pop(&mut self) -> Option<String> {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/buffer.rs:60:13
[INFO] [stderr]    |
[INFO] [stderr] 60 |             return true;
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/buffer.rs:62:13
[INFO] [stderr]    |
[INFO] [stderr] 62 |             return false;
[INFO] [stderr]    |             ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `for` head expression
[INFO] [stderr]   --> src/lib.rs:61:26
[INFO] [stderr]    |
[INFO] [stderr] 61 |                 for _ in (0..len) {
[INFO] [stderr]    |                          ^^^^^^^^ help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `for` head expression
[INFO] [stderr]    --> src/lib.rs:109:26
[INFO] [stderr]     |
[INFO] [stderr] 109 |                 for _ in (0..len) {
[INFO] [stderr]     |                          ^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: calling `.extend(_.chars())`
[INFO] [stderr]   --> src/buffer.rs:36:9
[INFO] [stderr]    |
[INFO] [stderr] 36 |         self.front_buf.extend(s.chars());
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.front_buf.push_str(s)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::string_extend_chars)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_extend_chars
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/buffer.rs:120:22
[INFO] [stderr]     |
[INFO] [stderr] 120 |     pub fn to_string(self) -> String {
[INFO] [stderr]     |                      ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/parser.rs:52:18
[INFO] [stderr]    |
[INFO] [stderr] 52 | fn match_head(i: &u8) -> Option<Token> {
[INFO] [stderr]    |                  ^^^ help: consider passing by value instead: `u8`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/parser.rs:91:21
[INFO] [stderr]    |
[INFO] [stderr] 91 |             let i = i.clone();
[INFO] [stderr]    |                     ^^^^^^^^^ help: try dereferencing it: `*i`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/parser.rs:97:33
[INFO] [stderr]    |
[INFO] [stderr] 97 |                         let j = j.clone();
[INFO] [stderr]    |                                 ^^^^^^^^^ help: try dereferencing it: `*j`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/parser.rs:126:21
[INFO] [stderr]     |
[INFO] [stderr] 126 |             let i = i.clone();
[INFO] [stderr]     |                     ^^^^^^^^^ help: try dereferencing it: `*i`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]    --> src/parser.rs:131:20
[INFO] [stderr]     |
[INFO] [stderr] 131 |               } else {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 132 | |                 Result::Error(2)
[INFO] [stderr] 133 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::if_same_then_else)] on by default
[INFO] [stderr] note: same as this
[INFO] [stderr]    --> src/parser.rs:129:40
[INFO] [stderr]     |
[INFO] [stderr] 129 |               } else if i as char == '0' {
[INFO] [stderr]     |  ________________________________________^
[INFO] [stderr] 130 | |                 Result::Error(2) // TODO: implement
[INFO] [stderr] 131 | |             } else {
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]   --> src/term.rs:77:57
[INFO] [stderr]    |
[INFO] [stderr] 77 |             Ok(term) => UNSUPPORTED_TERM.iter().any(|x| &&term == x),
[INFO] [stderr]    |                                                         ------^^^^^
[INFO] [stderr]    |                                                         |
[INFO] [stderr]    |                                                         help: use the left value directly: `&term`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:50:1
[INFO] [stderr]     |
[INFO] [stderr] 50  | / fn edit<'a>(ctx: EditCtx<'a>) -> Result<String, Error> {
[INFO] [stderr] 51  | |     let mut buffer = Buffer::new();
[INFO] [stderr] 52  | |     let mut seq: Vec<u8> = Vec::new();
[INFO] [stderr] 53  | |     let mut history_cursor = history::Cursor::new(ctx.history);
[INFO] [stderr] ...   |
[INFO] [stderr] 114 | |     }
[INFO] [stderr] 115 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]   --> src/lib.rs:94:25
[INFO] [stderr]    |
[INFO] [stderr] 94 |                         history_cursor.get().map(|s| buffer.replace(s));
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
[INFO] [stderr]    |                         |
[INFO] [stderr]    |                         help: try this: `if let Some(s) = history_cursor.get() { buffer.replace(s) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/lib.rs:100:25
[INFO] [stderr]     |
[INFO] [stderr] 100 |                         history_cursor.get().map(|s| buffer.replace(s));
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
[INFO] [stderr]     |                         |
[INFO] [stderr]     |                         help: try this: `if let Some(s) = history_cursor.get() { buffer.replace(s) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `Copperline`
[INFO] [stderr]    --> src/lib.rs:125:5
[INFO] [stderr]     |
[INFO] [stderr] 125 | /     pub fn new() -> Copperline {
[INFO] [stderr] 126 | |         Copperline::new_from_raw_fds(libc::STDIN_FILENO, libc::STDOUT_FILENO)
[INFO] [stderr] 127 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 122 | impl Default for Copperline {
[INFO] [stderr] 123 |     fn default() -> Self {
[INFO] [stderr] 124 |         Self::new()
[INFO] [stderr] 125 |     }
[INFO] [stderr] 126 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `copperline`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: unused import: `RawDecoder`
[INFO] [stderr]  --> src/parser.rs:3:36
[INFO] [stderr]   |
[INFO] [stderr] 3 | use encoding::types::{EncodingRef, RawDecoder};
[INFO] [stderr]   |                                    ^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `reset`
[INFO] [stderr]   --> src/buffer.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 |     pub fn reset(&mut self) {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `pop`
[INFO] [stderr]   --> src/history.rs:67:5
[INFO] [stderr]    |
[INFO] [stderr] 67 |     pub fn pop(&mut self) -> Option<String> {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: calling `.extend(_.chars())`
[INFO] [stderr]   --> src/buffer.rs:36:9
[INFO] [stderr]    |
[INFO] [stderr] 36 |         self.front_buf.extend(s.chars());
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.front_buf.push_str(s)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::string_extend_chars)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_extend_chars
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/buffer.rs:120:22
[INFO] [stderr]     |
[INFO] [stderr] 120 |     pub fn to_string(self) -> String {
[INFO] [stderr]     |                      ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/parser.rs:52:18
[INFO] [stderr]    |
[INFO] [stderr] 52 | fn match_head(i: &u8) -> Option<Token> {
[INFO] [stderr]    |                  ^^^ help: consider passing by value instead: `u8`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/parser.rs:91:21
[INFO] [stderr]    |
[INFO] [stderr] 91 |             let i = i.clone();
[INFO] [stderr]    |                     ^^^^^^^^^ help: try dereferencing it: `*i`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/parser.rs:97:33
[INFO] [stderr]    |
[INFO] [stderr] 97 |                         let j = j.clone();
[INFO] [stderr]    |                                 ^^^^^^^^^ help: try dereferencing it: `*j`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/parser.rs:126:21
[INFO] [stderr]     |
[INFO] [stderr] 126 |             let i = i.clone();
[INFO] [stderr]     |                     ^^^^^^^^^ help: try dereferencing it: `*i`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]    --> src/parser.rs:131:20
[INFO] [stderr]     |
[INFO] [stderr] 131 |               } else {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 132 | |                 Result::Error(2)
[INFO] [stderr] 133 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::if_same_then_else)] on by default
[INFO] [stderr] note: same as this
[INFO] [stderr]    --> src/parser.rs:129:40
[INFO] [stderr]     |
[INFO] [stderr] 129 |               } else if i as char == '0' {
[INFO] [stderr]     |  ________________________________________^
[INFO] [stderr] 130 | |                 Result::Error(2) // TODO: implement
[INFO] [stderr] 131 | |             } else {
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]   --> src/term.rs:77:57
[INFO] [stderr]    |
[INFO] [stderr] 77 |             Ok(term) => UNSUPPORTED_TERM.iter().any(|x| &&term == x),
[INFO] [stderr]    |                                                         ------^^^^^
[INFO] [stderr]    |                                                         |
[INFO] [stderr]    |                                                         help: use the left value directly: `&term`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:50:1
[INFO] [stderr]     |
[INFO] [stderr] 50  | / fn edit<'a>(ctx: EditCtx<'a>) -> Result<String, Error> {
[INFO] [stderr] 51  | |     let mut buffer = Buffer::new();
[INFO] [stderr] 52  | |     let mut seq: Vec<u8> = Vec::new();
[INFO] [stderr] 53  | |     let mut history_cursor = history::Cursor::new(ctx.history);
[INFO] [stderr] ...   |
[INFO] [stderr] 114 | |     }
[INFO] [stderr] 115 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]   --> src/lib.rs:94:25
[INFO] [stderr]    |
[INFO] [stderr] 94 |                         history_cursor.get().map(|s| buffer.replace(s));
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
[INFO] [stderr]    |                         |
[INFO] [stderr]    |                         help: try this: `if let Some(s) = history_cursor.get() { buffer.replace(s) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/lib.rs:100:25
[INFO] [stderr]     |
[INFO] [stderr] 100 |                         history_cursor.get().map(|s| buffer.replace(s));
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
[INFO] [stderr]     |                         |
[INFO] [stderr]     |                         help: try this: `if let Some(s) = history_cursor.get() { buffer.replace(s) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `Copperline`
[INFO] [stderr]    --> src/lib.rs:125:5
[INFO] [stderr]     |
[INFO] [stderr] 125 | /     pub fn new() -> Copperline {
[INFO] [stderr] 126 | |         Copperline::new_from_raw_fds(libc::STDIN_FILENO, libc::STDOUT_FILENO)
[INFO] [stderr] 127 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 122 | impl Default for Copperline {
[INFO] [stderr] 123 |     fn default() -> Self {
[INFO] [stderr] 124 |         Self::new()
[INFO] [stderr] 125 |     }
[INFO] [stderr] 126 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `copperline`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "506d945aba4bc205052344fb232048f3d6560810a2c10b4937dcb3eb0455b0c0"`
[INFO] running `"docker" "rm" "-f" "506d945aba4bc205052344fb232048f3d6560810a2c10b4937dcb3eb0455b0c0"`
[INFO] [stdout] 506d945aba4bc205052344fb232048f3d6560810a2c10b4937dcb3eb0455b0c0