[INFO] crate cookie-factory 0.3.0-alpha1 is already in cache [INFO] extracting crate cookie-factory 0.3.0-alpha1 into work/ex/clippy-test-run/sources/stable/reg/cookie-factory/0.3.0-alpha1 [INFO] extracting crate cookie-factory 0.3.0-alpha1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cookie-factory/0.3.0-alpha1 [INFO] validating manifest of cookie-factory-0.3.0-alpha1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cookie-factory-0.3.0-alpha1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cookie-factory-0.3.0-alpha1 [INFO] finished frobbing cookie-factory-0.3.0-alpha1 [INFO] frobbed toml for cookie-factory-0.3.0-alpha1 written to work/ex/clippy-test-run/sources/stable/reg/cookie-factory/0.3.0-alpha1/Cargo.toml [INFO] started frobbing cookie-factory-0.3.0-alpha1 [INFO] finished frobbing cookie-factory-0.3.0-alpha1 [INFO] frobbed toml for cookie-factory-0.3.0-alpha1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cookie-factory/0.3.0-alpha1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cookie-factory-0.3.0-alpha1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cookie-factory/0.3.0-alpha1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2410e62e82d893b124d48889e374787f87df9926ec6499831c195c6db3944bf5 [INFO] running `"docker" "start" "-a" "2410e62e82d893b124d48889e374787f87df9926ec6499831c195c6db3944bf5"` [INFO] [stderr] Checking cookie-factory v0.3.0-alpha1 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / match i.len() <= idx { [INFO] [stderr] 23 | | true => Err(GenError::BufferTooSmall(idx+1)), [INFO] [stderr] 24 | | false => { [INFO] [stderr] 25 | | i[idx] = v; [INFO] [stderr] 26 | | Ok((i,idx+1)) [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 22 | if i.len() <= idx { Err(GenError::BufferTooSmall(idx+1)) } else { [INFO] [stderr] 23 | i[idx] = v; [INFO] [stderr] 24 | Ok((i,idx+1)) [INFO] [stderr] 25 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / match i.len() <= idx+1 { [INFO] [stderr] 36 | | true => Err(GenError::BufferTooSmall(idx+2)), [INFO] [stderr] 37 | | false => { [INFO] [stderr] 38 | | let v1 : u8 = ((v >> 8) & 0xff) as u8; [INFO] [stderr] ... | [INFO] [stderr] 43 | | } [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 35 | if i.len() <= idx+1 { Err(GenError::BufferTooSmall(idx+2)) } else { [INFO] [stderr] 36 | let v1 : u8 = ((v >> 8) & 0xff) as u8; [INFO] [stderr] 37 | let v2 : u8 = ((v ) & 0xff) as u8; [INFO] [stderr] 38 | i[idx ] = v1; [INFO] [stderr] 39 | i[idx+1] = v2; [INFO] [stderr] 40 | Ok((i,idx+2)) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / match i.len() <= idx+3 { [INFO] [stderr] 52 | | true => Err(GenError::BufferTooSmall(idx+4)), [INFO] [stderr] 53 | | false => { [INFO] [stderr] 54 | | let v1 : u8 = ((v >> 24) & 0xff) as u8; [INFO] [stderr] ... | [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 51 | if i.len() <= idx+3 { Err(GenError::BufferTooSmall(idx+4)) } else { [INFO] [stderr] 52 | let v1 : u8 = ((v >> 24) & 0xff) as u8; [INFO] [stderr] 53 | let v2 : u8 = ((v >> 16) & 0xff) as u8; [INFO] [stderr] 54 | let v3 : u8 = ((v >> 8) & 0xff) as u8; [INFO] [stderr] 55 | let v4 : u8 = ((v ) & 0xff) as u8; [INFO] [stderr] 56 | i[idx ] = v1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | / match i.len() <= idx+3 { [INFO] [stderr] 72 | | true => Err(GenError::BufferTooSmall(idx+8)), [INFO] [stderr] 73 | | false => { [INFO] [stderr] 74 | | let v1 : u8 = ((v >> 56) & 0xff) as u8; [INFO] [stderr] ... | [INFO] [stderr] 91 | | } [INFO] [stderr] 92 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 71 | if i.len() <= idx+3 { Err(GenError::BufferTooSmall(idx+8)) } else { [INFO] [stderr] 72 | let v1 : u8 = ((v >> 56) & 0xff) as u8; [INFO] [stderr] 73 | let v2 : u8 = ((v >> 48) & 0xff) as u8; [INFO] [stderr] 74 | let v3 : u8 = ((v >> 40) & 0xff) as u8; [INFO] [stderr] 75 | let v4 : u8 = ((v >> 32) & 0xff) as u8; [INFO] [stderr] 76 | let v5 : u8 = ((v >> 24) & 0xff) as u8; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | / match i.len() <= idx { [INFO] [stderr] 100 | | true => Err(GenError::BufferTooSmall(idx+1)), [INFO] [stderr] 101 | | false => { [INFO] [stderr] 102 | | i[idx] = v; [INFO] [stderr] 103 | | Ok((i,idx+1)) [INFO] [stderr] 104 | | } [INFO] [stderr] 105 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 99 | if i.len() <= idx { Err(GenError::BufferTooSmall(idx+1)) } else { [INFO] [stderr] 100 | i[idx] = v; [INFO] [stderr] 101 | Ok((i,idx+1)) [INFO] [stderr] 102 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | / match i.len() <= idx+1 { [INFO] [stderr] 113 | | true => Err(GenError::BufferTooSmall(idx+2)), [INFO] [stderr] 114 | | false => { [INFO] [stderr] 115 | | let v1 : u8 = ((v >> 8) & 0xff) as u8; [INFO] [stderr] ... | [INFO] [stderr] 120 | | } [INFO] [stderr] 121 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 112 | if i.len() <= idx+1 { Err(GenError::BufferTooSmall(idx+2)) } else { [INFO] [stderr] 113 | let v1 : u8 = ((v >> 8) & 0xff) as u8; [INFO] [stderr] 114 | let v2 : u8 = ((v ) & 0xff) as u8; [INFO] [stderr] 115 | i[idx ] = v2; [INFO] [stderr] 116 | i[idx+1] = v1; [INFO] [stderr] 117 | Ok((i,idx+2)) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | / match i.len() <= idx+3 { [INFO] [stderr] 129 | | true => Err(GenError::BufferTooSmall(idx+4)), [INFO] [stderr] 130 | | false => { [INFO] [stderr] 131 | | let v1 : u8 = ((v >> 24) & 0xff) as u8; [INFO] [stderr] ... | [INFO] [stderr] 140 | | } [INFO] [stderr] 141 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 128 | if i.len() <= idx+3 { Err(GenError::BufferTooSmall(idx+4)) } else { [INFO] [stderr] 129 | let v1 : u8 = ((v >> 24) & 0xff) as u8; [INFO] [stderr] 130 | let v2 : u8 = ((v >> 16) & 0xff) as u8; [INFO] [stderr] 131 | let v3 : u8 = ((v >> 8) & 0xff) as u8; [INFO] [stderr] 132 | let v4 : u8 = ((v ) & 0xff) as u8; [INFO] [stderr] 133 | i[idx ] = v4; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:148:5 [INFO] [stderr] | [INFO] [stderr] 148 | / match i.len() <= idx+3 { [INFO] [stderr] 149 | | true => Err(GenError::BufferTooSmall(idx+8)), [INFO] [stderr] 150 | | false => { [INFO] [stderr] 151 | | let v1 : u8 = ((v >> 56) & 0xff) as u8; [INFO] [stderr] ... | [INFO] [stderr] 168 | | } [INFO] [stderr] 169 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 148 | if i.len() <= idx+3 { Err(GenError::BufferTooSmall(idx+8)) } else { [INFO] [stderr] 149 | let v1 : u8 = ((v >> 56) & 0xff) as u8; [INFO] [stderr] 150 | let v2 : u8 = ((v >> 48) & 0xff) as u8; [INFO] [stderr] 151 | let v3 : u8 = ((v >> 40) & 0xff) as u8; [INFO] [stderr] 152 | let v4 : u8 = ((v >> 32) & 0xff) as u8; [INFO] [stderr] 153 | let v5 : u8 = ((v >> 24) & 0xff) as u8; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/text.rs:9:3 [INFO] [stderr] | [INFO] [stderr] 9 | fn raw<'a>(&'a self) -> Slice<'a>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/text.rs:14:3 [INFO] [stderr] | [INFO] [stderr] 14 | / fn raw<'a>(&'a self) -> Slice<'a> { [INFO] [stderr] 15 | | Slice::new(self.as_ref().as_bytes()) [INFO] [stderr] 16 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/text.rs:24:3 [INFO] [stderr] | [INFO] [stderr] 24 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 25 | | let mut c = Cursor::new(output); [INFO] [stderr] 26 | | match write!(&mut c, "{}", self.value) { [INFO] [stderr] 27 | | //FIXME: maybe return an error here instead of assuming the buffer is too small? [INFO] [stderr] ... | [INFO] [stderr] 30 | | } [INFO] [stderr] 31 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/gen.rs:935:25 [INFO] [stderr] | [INFO] [stderr] 935 | gen_be_u32!(0x05060708) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0506_0708` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/gen.rs:955:25 [INFO] [stderr] | [INFO] [stderr] 955 | gen_be_u32!(0x05060708) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0506_0708` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/text.rs:50:3 [INFO] [stderr] | [INFO] [stderr] 50 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 51 | | let mut c = Cursor::new(output); [INFO] [stderr] 52 | | match write!(&mut c, "{:X}", self.value) { [INFO] [stderr] 53 | | //FIXME: maybe return an error here instead of assuming the buffer is too small? [INFO] [stderr] ... | [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/gen.rs:1037:42 [INFO] [stderr] | [INFO] [stderr] 1037 | let r = gen_be_u64!((&mut mem,0),0x0102030405060708u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x0102_0304_0506_0708u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/binary.rs:22:3 [INFO] [stderr] | [INFO] [stderr] 22 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 23 | | let output_len = output.len(); [INFO] [stderr] 24 | | let self_len = self.value.len() - self.index; [INFO] [stderr] 25 | | if self_len <= output_len { [INFO] [stderr] ... | [INFO] [stderr] 32 | | } [INFO] [stderr] 33 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/binary.rs:63:3 [INFO] [stderr] | [INFO] [stderr] 63 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 64 | | match self.value.serialize(&mut output[self.skip..])? { [INFO] [stderr] 65 | | // we need to write the full length/value structure at once [INFO] [stderr] 66 | | (_, Serialized::Continue) => Ok((0, Serialized::Continue)), [INFO] [stderr] ... | [INFO] [stderr] 73 | | } [INFO] [stderr] 74 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/gen.rs:1051:42 [INFO] [stderr] | [INFO] [stderr] 1051 | let r = gen_be_u64!((&mut mem,0),0x0102030405060708u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x0102_0304_0506_0708u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/gen.rs:1062:42 [INFO] [stderr] | [INFO] [stderr] 1062 | let r = gen_be_u64!((&mut mem,0),0x0102030405060708u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x0102_0304_0506_0708u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/binary.rs:116:3 [INFO] [stderr] | [INFO] [stderr] 116 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 117 | | if output.len() == 0 { [INFO] [stderr] 118 | | Ok((0, Serialized::Continue)) [INFO] [stderr] 119 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 122 | | } [INFO] [stderr] 123 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/gen.rs:1074:42 [INFO] [stderr] | [INFO] [stderr] 1074 | let r = gen_le_u64!((&mut mem,0),0x0102030405060708u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x0102_0304_0506_0708u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/combinators/binary.rs:117:8 [INFO] [stderr] | [INFO] [stderr] 117 | if output.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `output.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/binary.rs:127:3 [INFO] [stderr] | [INFO] [stderr] 127 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 128 | | if output.len() < 2 { [INFO] [stderr] 129 | | Ok((0, Serialized::Continue)) [INFO] [stderr] 130 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 134 | | } [INFO] [stderr] 135 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/binary.rs:139:3 [INFO] [stderr] | [INFO] [stderr] 139 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 140 | | if output.len() < 4 { [INFO] [stderr] 141 | | Ok((0, Serialized::Continue)) [INFO] [stderr] 142 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 148 | | } [INFO] [stderr] 149 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/binary.rs:153:3 [INFO] [stderr] | [INFO] [stderr] 153 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 154 | | if output.len() < 8 { [INFO] [stderr] 155 | | Ok((0, Serialized::Continue)) [INFO] [stderr] 156 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 166 | | } [INFO] [stderr] 167 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/binary.rs:171:3 [INFO] [stderr] | [INFO] [stderr] 171 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 172 | | if output.len() == 0 { [INFO] [stderr] 173 | | Ok((0, Serialized::Continue)) [INFO] [stderr] 174 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 177 | | } [INFO] [stderr] 178 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/combinators/binary.rs:172:8 [INFO] [stderr] | [INFO] [stderr] 172 | if output.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `output.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/binary.rs:182:3 [INFO] [stderr] | [INFO] [stderr] 182 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 183 | | if output.len() < 2 { [INFO] [stderr] 184 | | Ok((0, Serialized::Continue)) [INFO] [stderr] 185 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 189 | | } [INFO] [stderr] 190 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/binary.rs:194:3 [INFO] [stderr] | [INFO] [stderr] 194 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 195 | | if output.len() < 4 { [INFO] [stderr] 196 | | Ok((0, Serialized::Continue)) [INFO] [stderr] 197 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 203 | | } [INFO] [stderr] 204 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/binary.rs:208:3 [INFO] [stderr] | [INFO] [stderr] 208 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 209 | | if output.len() < 8 { [INFO] [stderr] 210 | | Ok((0, Serialized::Continue)) [INFO] [stderr] 211 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 221 | | } [INFO] [stderr] 222 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/mod.rs:45:3 [INFO] [stderr] | [INFO] [stderr] 45 | / fn serialize<'b, 'c>(&'b mut self, _output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 46 | | Ok((0, Serialized::Done)) [INFO] [stderr] 47 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/mod.rs:66:3 [INFO] [stderr] | [INFO] [stderr] 66 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 67 | | if output.len() < self.0 { [INFO] [stderr] 68 | | Ok((0, Serialized::Continue)) [INFO] [stderr] 69 | | } else { [INFO] [stderr] 70 | | Ok((self.0, Serialized::Done)) [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/mod.rs:88:3 [INFO] [stderr] | [INFO] [stderr] 88 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 89 | | (**self).serialize(output) [INFO] [stderr] 90 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/mod.rs:110:3 [INFO] [stderr] | [INFO] [stderr] 110 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 111 | | let mut i = 0; [INFO] [stderr] 112 | | if let Some(mut a) = self.first.take() { [INFO] [stderr] 113 | | match a.serialize(output)? { [INFO] [stderr] ... | [INFO] [stderr] 125 | | self.second.serialize(sl).map(|(index, res)| (index+i, res)) [INFO] [stderr] 126 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/mod.rs:146:3 [INFO] [stderr] | [INFO] [stderr] 146 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 147 | | match &mut self.a { [INFO] [stderr] 148 | | Some(ref mut a) => a.serialize(output), [INFO] [stderr] 149 | | None => self.b.serialize(output) [INFO] [stderr] 150 | | } [INFO] [stderr] 151 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/combinators/mod.rs:156:40 [INFO] [stderr] | [INFO] [stderr] 156 | self.a.as_mut().map(|a| a.reset()).unwrap_or(self.b.reset()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.b.reset())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/mod.rs:177:3 [INFO] [stderr] | [INFO] [stderr] 177 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 178 | | let mut index = 0; [INFO] [stderr] 179 | | [INFO] [stderr] 180 | | loop { [INFO] [stderr] ... | [INFO] [stderr] 199 | | } [INFO] [stderr] 200 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/mod.rs:229:3 [INFO] [stderr] | [INFO] [stderr] 229 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 230 | | let mut index = 0; [INFO] [stderr] 231 | | [INFO] [stderr] 232 | | loop { [INFO] [stderr] ... | [INFO] [stderr] 269 | | } [INFO] [stderr] 270 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `combinators::Stream` [INFO] [stderr] --> src/combinators/mod.rs:279:3 [INFO] [stderr] | [INFO] [stderr] 279 | / pub fn new() -> Self { [INFO] [stderr] 280 | | Stream { [INFO] [stderr] 281 | | queue: VecDeque::new(), [INFO] [stderr] 282 | | } [INFO] [stderr] 283 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 273 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_iter` on this type; consider implementing the `std::iter::FromIterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/combinators/mod.rs:285:3 [INFO] [stderr] | [INFO] [stderr] 285 | / pub fn from_iter>(it: It) -> Self { [INFO] [stderr] 286 | | Stream { [INFO] [stderr] 287 | | queue: it.collect(), [INFO] [stderr] 288 | | } [INFO] [stderr] 289 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/combinators/binary.rs:270:18 [INFO] [stderr] | [INFO] [stderr] 270 | assert_eq!(0x01020304u32.be().serialize(&mut mem), Ok((4, Serialized::Done))); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x0102_0304u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/mod.rs:298:3 [INFO] [stderr] | [INFO] [stderr] 298 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 299 | | let mut index = 0; [INFO] [stderr] 300 | | [INFO] [stderr] 301 | | loop { [INFO] [stderr] ... | [INFO] [stderr] 313 | | } [INFO] [stderr] 314 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/combinators/binary.rs:278:18 [INFO] [stderr] | [INFO] [stderr] 278 | assert_eq!(0x0102030405060708u64.be().serialize(&mut mem), Ok((8, Serialized::Done))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x0102_0304_0506_0708u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/combinators/binary.rs:302:21 [INFO] [stderr] | [INFO] [stderr] 302 | assert_eq!(le(0x01020304u32).serialize(&mut mem), Ok((4, Serialized::Done))); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x0102_0304u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/mod.rs:318:3 [INFO] [stderr] | [INFO] [stderr] 318 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 319 | | match self(output) { [INFO] [stderr] 320 | | Err(e) => Err(e), [INFO] [stderr] 321 | | Ok((_, index)) => Ok((index, Serialized::Done)), [INFO] [stderr] 322 | | } [INFO] [stderr] 323 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/combinators/binary.rs:310:21 [INFO] [stderr] | [INFO] [stderr] 310 | assert_eq!(le(0x0102030405060708u64).serialize(&mut mem), Ok((8, Serialized::Done))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x0102_0304_0506_0708u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / match i.len() <= idx { [INFO] [stderr] 23 | | true => Err(GenError::BufferTooSmall(idx+1)), [INFO] [stderr] 24 | | false => { [INFO] [stderr] 25 | | i[idx] = v; [INFO] [stderr] 26 | | Ok((i,idx+1)) [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 22 | if i.len() <= idx { Err(GenError::BufferTooSmall(idx+1)) } else { [INFO] [stderr] 23 | i[idx] = v; [INFO] [stderr] 24 | Ok((i,idx+1)) [INFO] [stderr] 25 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / match i.len() <= idx+1 { [INFO] [stderr] 36 | | true => Err(GenError::BufferTooSmall(idx+2)), [INFO] [stderr] 37 | | false => { [INFO] [stderr] 38 | | let v1 : u8 = ((v >> 8) & 0xff) as u8; [INFO] [stderr] ... | [INFO] [stderr] 43 | | } [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 35 | if i.len() <= idx+1 { Err(GenError::BufferTooSmall(idx+2)) } else { [INFO] [stderr] 36 | let v1 : u8 = ((v >> 8) & 0xff) as u8; [INFO] [stderr] 37 | let v2 : u8 = ((v ) & 0xff) as u8; [INFO] [stderr] 38 | i[idx ] = v1; [INFO] [stderr] 39 | i[idx+1] = v2; [INFO] [stderr] 40 | Ok((i,idx+2)) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / match i.len() <= idx+3 { [INFO] [stderr] 52 | | true => Err(GenError::BufferTooSmall(idx+4)), [INFO] [stderr] 53 | | false => { [INFO] [stderr] 54 | | let v1 : u8 = ((v >> 24) & 0xff) as u8; [INFO] [stderr] ... | [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 51 | if i.len() <= idx+3 { Err(GenError::BufferTooSmall(idx+4)) } else { [INFO] [stderr] 52 | let v1 : u8 = ((v >> 24) & 0xff) as u8; [INFO] [stderr] 53 | let v2 : u8 = ((v >> 16) & 0xff) as u8; [INFO] [stderr] 54 | let v3 : u8 = ((v >> 8) & 0xff) as u8; [INFO] [stderr] 55 | let v4 : u8 = ((v ) & 0xff) as u8; [INFO] [stderr] 56 | i[idx ] = v1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | / match i.len() <= idx+3 { [INFO] [stderr] 72 | | true => Err(GenError::BufferTooSmall(idx+8)), [INFO] [stderr] 73 | | false => { [INFO] [stderr] 74 | | let v1 : u8 = ((v >> 56) & 0xff) as u8; [INFO] [stderr] ... | [INFO] [stderr] 91 | | } [INFO] [stderr] 92 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 71 | if i.len() <= idx+3 { Err(GenError::BufferTooSmall(idx+8)) } else { [INFO] [stderr] 72 | let v1 : u8 = ((v >> 56) & 0xff) as u8; [INFO] [stderr] 73 | let v2 : u8 = ((v >> 48) & 0xff) as u8; [INFO] [stderr] 74 | let v3 : u8 = ((v >> 40) & 0xff) as u8; [INFO] [stderr] 75 | let v4 : u8 = ((v >> 32) & 0xff) as u8; [INFO] [stderr] 76 | let v5 : u8 = ((v >> 24) & 0xff) as u8; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | / match i.len() <= idx { [INFO] [stderr] 100 | | true => Err(GenError::BufferTooSmall(idx+1)), [INFO] [stderr] 101 | | false => { [INFO] [stderr] 102 | | i[idx] = v; [INFO] [stderr] 103 | | Ok((i,idx+1)) [INFO] [stderr] 104 | | } [INFO] [stderr] 105 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 99 | if i.len() <= idx { Err(GenError::BufferTooSmall(idx+1)) } else { [INFO] [stderr] 100 | i[idx] = v; [INFO] [stderr] 101 | Ok((i,idx+1)) [INFO] [stderr] 102 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | / match i.len() <= idx+1 { [INFO] [stderr] 113 | | true => Err(GenError::BufferTooSmall(idx+2)), [INFO] [stderr] 114 | | false => { [INFO] [stderr] 115 | | let v1 : u8 = ((v >> 8) & 0xff) as u8; [INFO] [stderr] ... | [INFO] [stderr] 120 | | } [INFO] [stderr] 121 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 112 | if i.len() <= idx+1 { Err(GenError::BufferTooSmall(idx+2)) } else { [INFO] [stderr] 113 | let v1 : u8 = ((v >> 8) & 0xff) as u8; [INFO] [stderr] 114 | let v2 : u8 = ((v ) & 0xff) as u8; [INFO] [stderr] 115 | i[idx ] = v2; [INFO] [stderr] 116 | i[idx+1] = v1; [INFO] [stderr] 117 | Ok((i,idx+2)) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | / match i.len() <= idx+3 { [INFO] [stderr] 129 | | true => Err(GenError::BufferTooSmall(idx+4)), [INFO] [stderr] 130 | | false => { [INFO] [stderr] 131 | | let v1 : u8 = ((v >> 24) & 0xff) as u8; [INFO] [stderr] ... | [INFO] [stderr] 140 | | } [INFO] [stderr] 141 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 128 | if i.len() <= idx+3 { Err(GenError::BufferTooSmall(idx+4)) } else { [INFO] [stderr] 129 | let v1 : u8 = ((v >> 24) & 0xff) as u8; [INFO] [stderr] 130 | let v2 : u8 = ((v >> 16) & 0xff) as u8; [INFO] [stderr] 131 | let v3 : u8 = ((v >> 8) & 0xff) as u8; [INFO] [stderr] 132 | let v4 : u8 = ((v ) & 0xff) as u8; [INFO] [stderr] 133 | i[idx ] = v4; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:148:5 [INFO] [stderr] | [INFO] [stderr] 148 | / match i.len() <= idx+3 { [INFO] [stderr] 149 | | true => Err(GenError::BufferTooSmall(idx+8)), [INFO] [stderr] 150 | | false => { [INFO] [stderr] 151 | | let v1 : u8 = ((v >> 56) & 0xff) as u8; [INFO] [stderr] ... | [INFO] [stderr] 168 | | } [INFO] [stderr] 169 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 148 | if i.len() <= idx+3 { Err(GenError::BufferTooSmall(idx+8)) } else { [INFO] [stderr] 149 | let v1 : u8 = ((v >> 56) & 0xff) as u8; [INFO] [stderr] 150 | let v2 : u8 = ((v >> 48) & 0xff) as u8; [INFO] [stderr] 151 | let v3 : u8 = ((v >> 40) & 0xff) as u8; [INFO] [stderr] 152 | let v4 : u8 = ((v >> 32) & 0xff) as u8; [INFO] [stderr] 153 | let v5 : u8 = ((v >> 24) & 0xff) as u8; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | / match $i.len() <= $idx { [INFO] [stderr] 212 | | true => Err(GenError::BufferTooSmall($idx+1)), [INFO] [stderr] 213 | | false => { [INFO] [stderr] 214 | | $i[$idx] = $val; [INFO] [stderr] 215 | | Ok(($i,($idx+1))) [INFO] [stderr] 216 | | } [INFO] [stderr] 217 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 930 | let r = do_gen!( [INFO] [stderr] | _________________- [INFO] [stderr] 931 | | (s,0), [INFO] [stderr] 932 | | gen_be_u8!(1) >> [INFO] [stderr] 933 | | gen_be_u8!(2) >> [INFO] [stderr] 934 | | gen_be_u16!(0x0304) >> [INFO] [stderr] 935 | | gen_be_u32!(0x05060708) [INFO] [stderr] 936 | | ); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 211 | if $i.len() { do_gen!( [INFO] [stderr] 212 | (s,0), [INFO] [stderr] 213 | gen_be_u8!(1) >> [INFO] [stderr] 214 | gen_be_u8!(2) >> [INFO] [stderr] 215 | gen_be_u16!(0x0304) >> [INFO] [stderr] 216 | gen_be_u32!(0x05060708) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | / match $i.len() <= $idx { [INFO] [stderr] 212 | | true => Err(GenError::BufferTooSmall($idx+1)), [INFO] [stderr] 213 | | false => { [INFO] [stderr] 214 | | $i[$idx] = $val; [INFO] [stderr] 215 | | Ok(($i,($idx+1))) [INFO] [stderr] 216 | | } [INFO] [stderr] 217 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 930 | let r = do_gen!( [INFO] [stderr] | _________________- [INFO] [stderr] 931 | | (s,0), [INFO] [stderr] 932 | | gen_be_u8!(1) >> [INFO] [stderr] 933 | | gen_be_u8!(2) >> [INFO] [stderr] 934 | | gen_be_u16!(0x0304) >> [INFO] [stderr] 935 | | gen_be_u32!(0x05060708) [INFO] [stderr] 936 | | ); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 211 | if $i.len() <= $idx { [INFO] [stderr] 212 | true => Err(GenError::BufferTooSmall($idx+1)), [INFO] [stderr] 213 | false => { [INFO] [stderr] 214 | $i[$idx] = $val; [INFO] [stderr] 215 | Ok(($i,($idx+1))) [INFO] [stderr] 216 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:229:9 [INFO] [stderr] | [INFO] [stderr] 229 | / match $i.len() <= $idx + 1 { [INFO] [stderr] 230 | | true => Err(GenError::BufferTooSmall($idx+2)), [INFO] [stderr] 231 | | false => { [INFO] [stderr] 232 | | let v = $val; [INFO] [stderr] ... | [INFO] [stderr] 238 | | } [INFO] [stderr] 239 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 930 | let r = do_gen!( [INFO] [stderr] | _________________- [INFO] [stderr] 931 | | (s,0), [INFO] [stderr] 932 | | gen_be_u8!(1) >> [INFO] [stderr] 933 | | gen_be_u8!(2) >> [INFO] [stderr] 934 | | gen_be_u16!(0x0304) >> [INFO] [stderr] 935 | | gen_be_u32!(0x05060708) [INFO] [stderr] 936 | | ); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 229 | if $i.len() <= $idx + 1 { do_gen!( [INFO] [stderr] 230 | (s,0), [INFO] [stderr] 231 | gen_be_u8!(1) >> [INFO] [stderr] 232 | gen_be_u8!(2) >> [INFO] [stderr] 233 | gen_be_u16!(0x0304) >> [INFO] [stderr] 234 | gen_be_u32!(0x05060708) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:275:9 [INFO] [stderr] | [INFO] [stderr] 275 | / match $i.len() <= $idx + 3 { [INFO] [stderr] 276 | | true => Err(GenError::BufferTooSmall($idx+4)), [INFO] [stderr] 277 | | false => { [INFO] [stderr] 278 | | let v = $val; [INFO] [stderr] ... | [INFO] [stderr] 288 | | } [INFO] [stderr] 289 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 930 | let r = do_gen!( [INFO] [stderr] | _________________- [INFO] [stderr] 931 | | (s,0), [INFO] [stderr] 932 | | gen_be_u8!(1) >> [INFO] [stderr] 933 | | gen_be_u8!(2) >> [INFO] [stderr] 934 | | gen_be_u16!(0x0304) >> [INFO] [stderr] 935 | | gen_be_u32!(0x05060708) [INFO] [stderr] 936 | | ); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 275 | if $i.len() <= $idx + 3 { do_gen!( [INFO] [stderr] 276 | (s,0), [INFO] [stderr] 277 | gen_be_u8!(1) >> [INFO] [stderr] 278 | gen_be_u8!(2) >> [INFO] [stderr] 279 | gen_be_u16!(0x0304) >> [INFO] [stderr] 280 | gen_be_u32!(0x05060708) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | / match $i.len() <= $idx { [INFO] [stderr] 212 | | true => Err(GenError::BufferTooSmall($idx+1)), [INFO] [stderr] 213 | | false => { [INFO] [stderr] 214 | | $i[$idx] = $val; [INFO] [stderr] 215 | | Ok(($i,($idx+1))) [INFO] [stderr] 216 | | } [INFO] [stderr] 217 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 950 | let r = do_gen!( [INFO] [stderr] | _________________- [INFO] [stderr] 951 | | (&mut data,0), [INFO] [stderr] 952 | | gen_be_u8!(1) >> [INFO] [stderr] 953 | | gen_be_u8!(2) >> [INFO] [stderr] 954 | | gen_be_u16!(0x0304) >> [INFO] [stderr] 955 | | gen_be_u32!(0x05060708) [INFO] [stderr] 956 | | ); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 211 | if $i.len() { do_gen!( [INFO] [stderr] 212 | (&mut data,0), [INFO] [stderr] 213 | gen_be_u8!(1) >> [INFO] [stderr] 214 | gen_be_u8!(2) >> [INFO] [stderr] 215 | gen_be_u16!(0x0304) >> [INFO] [stderr] 216 | gen_be_u32!(0x05060708) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/gen.rs:951:14 [INFO] [stderr] | [INFO] [stderr] 951 | (&mut data,0), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | / match $i.len() <= $idx { [INFO] [stderr] 212 | | true => Err(GenError::BufferTooSmall($idx+1)), [INFO] [stderr] 213 | | false => { [INFO] [stderr] 214 | | $i[$idx] = $val; [INFO] [stderr] 215 | | Ok(($i,($idx+1))) [INFO] [stderr] 216 | | } [INFO] [stderr] 217 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 950 | let r = do_gen!( [INFO] [stderr] | _________________- [INFO] [stderr] 951 | | (&mut data,0), [INFO] [stderr] 952 | | gen_be_u8!(1) >> [INFO] [stderr] 953 | | gen_be_u8!(2) >> [INFO] [stderr] 954 | | gen_be_u16!(0x0304) >> [INFO] [stderr] 955 | | gen_be_u32!(0x05060708) [INFO] [stderr] 956 | | ); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 211 | if $i.len() <= $idx { [INFO] [stderr] 212 | true => Err(GenError::BufferTooSmall($idx+1)), [INFO] [stderr] 213 | false => { [INFO] [stderr] 214 | $i[$idx] = $val; [INFO] [stderr] 215 | Ok(($i,($idx+1))) [INFO] [stderr] 216 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:229:9 [INFO] [stderr] | [INFO] [stderr] 229 | / match $i.len() <= $idx + 1 { [INFO] [stderr] 230 | | true => Err(GenError::BufferTooSmall($idx+2)), [INFO] [stderr] 231 | | false => { [INFO] [stderr] 232 | | let v = $val; [INFO] [stderr] ... | [INFO] [stderr] 238 | | } [INFO] [stderr] 239 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 950 | let r = do_gen!( [INFO] [stderr] | _________________- [INFO] [stderr] 951 | | (&mut data,0), [INFO] [stderr] 952 | | gen_be_u8!(1) >> [INFO] [stderr] 953 | | gen_be_u8!(2) >> [INFO] [stderr] 954 | | gen_be_u16!(0x0304) >> [INFO] [stderr] 955 | | gen_be_u32!(0x05060708) [INFO] [stderr] 956 | | ); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 229 | if $i.len() <= $idx + 1 { do_gen!( [INFO] [stderr] 230 | (&mut data,0), [INFO] [stderr] 231 | gen_be_u8!(1) >> [INFO] [stderr] 232 | gen_be_u8!(2) >> [INFO] [stderr] 233 | gen_be_u16!(0x0304) >> [INFO] [stderr] 234 | gen_be_u32!(0x05060708) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:275:9 [INFO] [stderr] | [INFO] [stderr] 275 | / match $i.len() <= $idx + 3 { [INFO] [stderr] 276 | | true => Err(GenError::BufferTooSmall($idx+4)), [INFO] [stderr] 277 | | false => { [INFO] [stderr] 278 | | let v = $val; [INFO] [stderr] ... | [INFO] [stderr] 288 | | } [INFO] [stderr] 289 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 950 | let r = do_gen!( [INFO] [stderr] | _________________- [INFO] [stderr] 951 | | (&mut data,0), [INFO] [stderr] 952 | | gen_be_u8!(1) >> [INFO] [stderr] 953 | | gen_be_u8!(2) >> [INFO] [stderr] 954 | | gen_be_u16!(0x0304) >> [INFO] [stderr] 955 | | gen_be_u32!(0x05060708) [INFO] [stderr] 956 | | ); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 275 | if $i.len() <= $idx + 3 { do_gen!( [INFO] [stderr] 276 | (&mut data,0), [INFO] [stderr] 277 | gen_be_u8!(1) >> [INFO] [stderr] 278 | gen_be_u8!(2) >> [INFO] [stderr] 279 | gen_be_u16!(0x0304) >> [INFO] [stderr] 280 | gen_be_u32!(0x05060708) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:197:9 [INFO] [stderr] | [INFO] [stderr] 197 | / match $i.len() < $idx+$val { [INFO] [stderr] 198 | | true => Err(GenError::BufferTooSmall($idx+$val)), [INFO] [stderr] 199 | | false => { Ok(($i,($idx+$val))) }, [INFO] [stderr] 200 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if $i.len() < $idx { gen_skip!((s,0),5) } else { gen_skip!((s,0),5) }` [INFO] [stderr] ... [INFO] [stderr] 971 | let r = gen_skip!((s,0),5); [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | / match $i.len() <= $idx { [INFO] [stderr] 212 | | true => Err(GenError::BufferTooSmall($idx+1)), [INFO] [stderr] 213 | | false => { [INFO] [stderr] 214 | | $i[$idx] = $val; [INFO] [stderr] 215 | | Ok(($i,($idx+1))) [INFO] [stderr] 216 | | } [INFO] [stderr] 217 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 986 | let r = do_gen!( [INFO] [stderr] | _________________- [INFO] [stderr] 987 | | (s,0), [INFO] [stderr] 988 | | gen_be_u8!(1) >> [INFO] [stderr] 989 | | gen_be_u8!(2) [INFO] [stderr] 990 | | ); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 211 | if $i.len() { do_gen!( [INFO] [stderr] 212 | (s,0), [INFO] [stderr] 213 | gen_be_u8!(1) >> [INFO] [stderr] 214 | gen_be_u8!(2) [INFO] [stderr] 215 | ) } else { do_gen!( [INFO] [stderr] 216 | (s,0), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | / match $i.len() <= $idx { [INFO] [stderr] 212 | | true => Err(GenError::BufferTooSmall($idx+1)), [INFO] [stderr] 213 | | false => { [INFO] [stderr] 214 | | $i[$idx] = $val; [INFO] [stderr] 215 | | Ok(($i,($idx+1))) [INFO] [stderr] 216 | | } [INFO] [stderr] 217 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 986 | let r = do_gen!( [INFO] [stderr] | _________________- [INFO] [stderr] 987 | | (s,0), [INFO] [stderr] 988 | | gen_be_u8!(1) >> [INFO] [stderr] 989 | | gen_be_u8!(2) [INFO] [stderr] 990 | | ); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 211 | if $i.len() <= $idx { [INFO] [stderr] 212 | true => Err(GenError::BufferTooSmall($idx+1)), [INFO] [stderr] 213 | false => { [INFO] [stderr] 214 | $i[$idx] = $val; [INFO] [stderr] 215 | Ok(($i,($idx+1))) [INFO] [stderr] 216 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | / match $i.len() <= $idx { [INFO] [stderr] 212 | | true => Err(GenError::BufferTooSmall($idx+1)), [INFO] [stderr] 213 | | false => { [INFO] [stderr] 214 | | $i[$idx] = $val; [INFO] [stderr] 215 | | Ok(($i,($idx+1))) [INFO] [stderr] 216 | | } [INFO] [stderr] 217 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1005 | let r = do_gen!( [INFO] [stderr] | _________________- [INFO] [stderr] 1006 | | (s,0), [INFO] [stderr] 1007 | | gen_le_u8!(1) >> [INFO] [stderr] 1008 | | gen_le_u8!(2) [INFO] [stderr] 1009 | | ); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 211 | if $i.len() { do_gen!( [INFO] [stderr] 212 | (s,0), [INFO] [stderr] 213 | gen_le_u8!(1) >> [INFO] [stderr] 214 | gen_le_u8!(2) [INFO] [stderr] 215 | ) } else { do_gen!( [INFO] [stderr] 216 | (s,0), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | / match $i.len() <= $idx { [INFO] [stderr] 212 | | true => Err(GenError::BufferTooSmall($idx+1)), [INFO] [stderr] 213 | | false => { [INFO] [stderr] 214 | | $i[$idx] = $val; [INFO] [stderr] 215 | | Ok(($i,($idx+1))) [INFO] [stderr] 216 | | } [INFO] [stderr] 217 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1005 | let r = do_gen!( [INFO] [stderr] | _________________- [INFO] [stderr] 1006 | | (s,0), [INFO] [stderr] 1007 | | gen_le_u8!(1) >> [INFO] [stderr] 1008 | | gen_le_u8!(2) [INFO] [stderr] 1009 | | ); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 211 | if $i.len() <= $idx { [INFO] [stderr] 212 | true => Err(GenError::BufferTooSmall($idx+1)), [INFO] [stderr] 213 | false => { [INFO] [stderr] 214 | $i[$idx] = $val; [INFO] [stderr] 215 | Ok(($i,($idx+1))) [INFO] [stderr] 216 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:275:9 [INFO] [stderr] | [INFO] [stderr] 275 | / match $i.len() <= $idx + 3 { [INFO] [stderr] 276 | | true => Err(GenError::BufferTooSmall($idx+4)), [INFO] [stderr] 277 | | false => { [INFO] [stderr] 278 | | let v = $val; [INFO] [stderr] ... | [INFO] [stderr] 288 | | } [INFO] [stderr] 289 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if $i.len() <= $idx + 3 { gen_be_i32!((&mut mem,0), -1i32) } else { gen_be_i32!((&mut mem,0), -1i32) }` [INFO] [stderr] ... [INFO] [stderr] 1023 | let r = gen_be_i32!((&mut mem,0), -1i32); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/gen.rs:1023:30 [INFO] [stderr] | [INFO] [stderr] 1023 | let r = gen_be_i32!((&mut mem,0), -1i32); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:304:9 [INFO] [stderr] | [INFO] [stderr] 304 | / match $i.len() <= $idx + 7 { [INFO] [stderr] 305 | | true => Err(GenError::BufferTooSmall($idx+8)), [INFO] [stderr] 306 | | false => { [INFO] [stderr] 307 | | let v = $val; [INFO] [stderr] ... | [INFO] [stderr] 325 | | } [INFO] [stderr] 326 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if $i.len() <= $idx + 7 { gen_be_u64!((&mut mem,0),0x0102030405060708u64) } else { gen_be_u64!((&mut mem,0),0x0102030405060708u64) }` [INFO] [stderr] ... [INFO] [stderr] 1037 | let r = gen_be_u64!((&mut mem,0),0x0102030405060708u64); [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/gen.rs:1037:30 [INFO] [stderr] | [INFO] [stderr] 1037 | let r = gen_be_u64!((&mut mem,0),0x0102030405060708u64); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:304:9 [INFO] [stderr] | [INFO] [stderr] 304 | / match $i.len() <= $idx + 7 { [INFO] [stderr] 305 | | true => Err(GenError::BufferTooSmall($idx+8)), [INFO] [stderr] 306 | | false => { [INFO] [stderr] 307 | | let v = $val; [INFO] [stderr] ... | [INFO] [stderr] 325 | | } [INFO] [stderr] 326 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if $i.len() <= $idx + 7 { gen_be_u64!((&mut mem,0),0x0102030405060708u64) } else { gen_be_u64!((&mut mem,0),0x0102030405060708u64) }` [INFO] [stderr] ... [INFO] [stderr] 1051 | let r = gen_be_u64!((&mut mem,0),0x0102030405060708u64); [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/gen.rs:1051:30 [INFO] [stderr] | [INFO] [stderr] 1051 | let r = gen_be_u64!((&mut mem,0),0x0102030405060708u64); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:304:9 [INFO] [stderr] | [INFO] [stderr] 304 | / match $i.len() <= $idx + 7 { [INFO] [stderr] 305 | | true => Err(GenError::BufferTooSmall($idx+8)), [INFO] [stderr] 306 | | false => { [INFO] [stderr] 307 | | let v = $val; [INFO] [stderr] ... | [INFO] [stderr] 325 | | } [INFO] [stderr] 326 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if $i.len() <= $idx + 7 { gen_be_u64!((&mut mem,0),0x0102030405060708u64) } else { gen_be_u64!((&mut mem,0),0x0102030405060708u64) }` [INFO] [stderr] ... [INFO] [stderr] 1062 | let r = gen_be_u64!((&mut mem,0),0x0102030405060708u64); [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/gen.rs:1062:30 [INFO] [stderr] | [INFO] [stderr] 1062 | let r = gen_be_u64!((&mut mem,0),0x0102030405060708u64); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:502:9 [INFO] [stderr] | [INFO] [stderr] 502 | / match $i.len() <= $idx + 7 { [INFO] [stderr] 503 | | true => Err(GenError::BufferTooSmall($idx+8)), [INFO] [stderr] 504 | | false => { [INFO] [stderr] 505 | | let v = $val; [INFO] [stderr] ... | [INFO] [stderr] 523 | | } [INFO] [stderr] 524 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if $i.len() <= $idx + 7 { gen_le_u64!((&mut mem,0),0x0102030405060708u64) } else { gen_le_u64!((&mut mem,0),0x0102030405060708u64) }` [INFO] [stderr] ... [INFO] [stderr] 1074 | let r = gen_le_u64!((&mut mem,0),0x0102030405060708u64); [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/gen.rs:1074:30 [INFO] [stderr] | [INFO] [stderr] 1074 | let r = gen_le_u64!((&mut mem,0),0x0102030405060708u64); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | / match $i.len() <= $idx { [INFO] [stderr] 212 | | true => Err(GenError::BufferTooSmall($idx+1)), [INFO] [stderr] 213 | | false => { [INFO] [stderr] 214 | | $i[$idx] = $val; [INFO] [stderr] 215 | | Ok(($i,($idx+1))) [INFO] [stderr] 216 | | } [INFO] [stderr] 217 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1108 | let r = do_gen!( [INFO] [stderr] | _________________- [INFO] [stderr] 1109 | | (s,0), [INFO] [stderr] 1110 | | gen_be_u8!(1) >> [INFO] [stderr] 1111 | | gen_align!(4) >> [INFO] [stderr] 1112 | | gen_be_u8!(1) [INFO] [stderr] 1113 | | ); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 211 | if $i.len() { do_gen!( [INFO] [stderr] 212 | (s,0), [INFO] [stderr] 213 | gen_be_u8!(1) >> [INFO] [stderr] 214 | gen_align!(4) >> [INFO] [stderr] 215 | gen_be_u8!(1) [INFO] [stderr] 216 | ) } else { do_gen!( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | / match $i.len() <= $idx+aligned { [INFO] [stderr] 182 | | true => Err(GenError::BufferTooSmall($idx+aligned)), [INFO] [stderr] 183 | | false => { Ok(($i,($idx+aligned))) }, [INFO] [stderr] 184 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 1108 | let r = do_gen!( [INFO] [stderr] | _________________- [INFO] [stderr] 1109 | | (s,0), [INFO] [stderr] 1110 | | gen_be_u8!(1) >> [INFO] [stderr] 1111 | | gen_align!(4) >> [INFO] [stderr] 1112 | | gen_be_u8!(1) [INFO] [stderr] 1113 | | ); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 181 | if $i.len() <= $idx+aligned { do_gen!( [INFO] [stderr] 182 | (s,0), [INFO] [stderr] 183 | gen_be_u8!(1) >> [INFO] [stderr] 184 | gen_align!(4) >> [INFO] [stderr] 185 | gen_be_u8!(1) [INFO] [stderr] 186 | ) } else { do_gen!( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | / match $i.len() <= $idx { [INFO] [stderr] 212 | | true => Err(GenError::BufferTooSmall($idx+1)), [INFO] [stderr] 213 | | false => { [INFO] [stderr] 214 | | $i[$idx] = $val; [INFO] [stderr] 215 | | Ok(($i,($idx+1))) [INFO] [stderr] 216 | | } [INFO] [stderr] 217 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1108 | let r = do_gen!( [INFO] [stderr] | _________________- [INFO] [stderr] 1109 | | (s,0), [INFO] [stderr] 1110 | | gen_be_u8!(1) >> [INFO] [stderr] 1111 | | gen_align!(4) >> [INFO] [stderr] 1112 | | gen_be_u8!(1) [INFO] [stderr] 1113 | | ); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 211 | if $i.len() <= $idx { [INFO] [stderr] 212 | true => Err(GenError::BufferTooSmall($idx+1)), [INFO] [stderr] 213 | false => { [INFO] [stderr] 214 | $i[$idx] = $val; [INFO] [stderr] 215 | Ok(($i,($idx+1))) [INFO] [stderr] 216 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:621:9 [INFO] [stderr] | [INFO] [stderr] 621 | / match $i.len() < $idx+$l { [INFO] [stderr] 622 | | true => Err(GenError::BufferTooSmall($idx+$l)), [INFO] [stderr] 623 | | false => { [INFO] [stderr] 624 | | $i[$idx..$idx+$l].clone_from_slice(&$val[0..$l]); [INFO] [stderr] 625 | | Ok(($i,($idx+$l))) [INFO] [stderr] 626 | | } [INFO] [stderr] 627 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if $i.len() < $idx { gen_copy!((s,0),v,v.len()) } else { gen_copy!((s,0),v,v.len()) }` [INFO] [stderr] ... [INFO] [stderr] 1145 | let r = gen_copy!((s,0),v,v.len()); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:621:9 [INFO] [stderr] | [INFO] [stderr] 621 | / match $i.len() < $idx+$l { [INFO] [stderr] 622 | | true => Err(GenError::BufferTooSmall($idx+$l)), [INFO] [stderr] 623 | | false => { [INFO] [stderr] 624 | | $i[$idx..$idx+$l].clone_from_slice(&$val[0..$l]); [INFO] [stderr] 625 | | Ok(($i,($idx+$l))) [INFO] [stderr] 626 | | } [INFO] [stderr] 627 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if $i.len() < $idx { gen_copy!((s, 0), v, v.len()) } else { gen_copy!((s, 0), v, v.len()) }` [INFO] [stderr] ... [INFO] [stderr] 1160 | let r = gen_copy!((s, 0), v, v.len()); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:621:9 [INFO] [stderr] | [INFO] [stderr] 621 | / match $i.len() < $idx+$l { [INFO] [stderr] 622 | | true => Err(GenError::BufferTooSmall($idx+$l)), [INFO] [stderr] 623 | | false => { [INFO] [stderr] 624 | | $i[$idx..$idx+$l].clone_from_slice(&$val[0..$l]); [INFO] [stderr] 625 | | Ok(($i,($idx+$l))) [INFO] [stderr] 626 | | } [INFO] [stderr] 627 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1182 | let r = gen_slice!((s,0),v); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 621 | if $i.len() < $idx+$l { [INFO] [stderr] 622 | true => Err(GenError::BufferTooSmall($idx+$l)), [INFO] [stderr] 623 | false => { [INFO] [stderr] 624 | $i[$idx..$idx+$l].clone_from_slice(&$val[0..$l]); [INFO] [stderr] 625 | Ok(($i,($idx+$l))) [INFO] [stderr] 626 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:621:9 [INFO] [stderr] | [INFO] [stderr] 621 | / match $i.len() < $idx+$l { [INFO] [stderr] 622 | | true => Err(GenError::BufferTooSmall($idx+$l)), [INFO] [stderr] 623 | | false => { [INFO] [stderr] 624 | | $i[$idx..$idx+$l].clone_from_slice(&$val[0..$l]); [INFO] [stderr] 625 | | Ok(($i,($idx+$l))) [INFO] [stderr] 626 | | } [INFO] [stderr] 627 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1197 | let r = gen_slice!((s, 0), v); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 621 | if $i.len() < $idx+$l { [INFO] [stderr] 622 | true => Err(GenError::BufferTooSmall($idx+$l)), [INFO] [stderr] 623 | false => { [INFO] [stderr] 624 | $i[$idx..$idx+$l].clone_from_slice(&$val[0..$l]); [INFO] [stderr] 625 | Ok(($i,($idx+$l))) [INFO] [stderr] 626 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:229:9 [INFO] [stderr] | [INFO] [stderr] 229 | / match $i.len() <= $idx + 1 { [INFO] [stderr] 230 | | true => Err(GenError::BufferTooSmall($idx+2)), [INFO] [stderr] 231 | | false => { [INFO] [stderr] 232 | | let v = $val; [INFO] [stderr] ... | [INFO] [stderr] 238 | | } [INFO] [stderr] 239 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1219 | let r = do_gen!( [INFO] [stderr] | _________________- [INFO] [stderr] 1220 | | (s,0), [INFO] [stderr] 1221 | | gen_length_slice!(gen_be_u16 >> v) [INFO] [stderr] 1222 | | ); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 229 | if $i.len() <= $idx + 1 { do_gen!( [INFO] [stderr] 230 | (s,0), [INFO] [stderr] 231 | gen_length_slice!(gen_be_u16 >> v) [INFO] [stderr] 232 | ) } else { do_gen!( [INFO] [stderr] 233 | (s,0), [INFO] [stderr] 234 | gen_length_slice!(gen_be_u16 >> v) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:621:9 [INFO] [stderr] | [INFO] [stderr] 621 | / match $i.len() < $idx+$l { [INFO] [stderr] 622 | | true => Err(GenError::BufferTooSmall($idx+$l)), [INFO] [stderr] 623 | | false => { [INFO] [stderr] 624 | | $i[$idx..$idx+$l].clone_from_slice(&$val[0..$l]); [INFO] [stderr] 625 | | Ok(($i,($idx+$l))) [INFO] [stderr] 626 | | } [INFO] [stderr] 627 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1219 | let r = do_gen!( [INFO] [stderr] | _________________- [INFO] [stderr] 1220 | | (s,0), [INFO] [stderr] 1221 | | gen_length_slice!(gen_be_u16 >> v) [INFO] [stderr] 1222 | | ); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 621 | if $i.len() < $idx+$l { [INFO] [stderr] 622 | true => Err(GenError::BufferTooSmall($idx+$l)), [INFO] [stderr] 623 | false => { [INFO] [stderr] 624 | $i[$idx..$idx+$l].clone_from_slice(&$val[0..$l]); [INFO] [stderr] 625 | Ok(($i,($idx+$l))) [INFO] [stderr] 626 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | / match $i.len() <= $idx { [INFO] [stderr] 212 | | true => Err(GenError::BufferTooSmall($idx+1)), [INFO] [stderr] 213 | | false => { [INFO] [stderr] 214 | | $i[$idx] = $val; [INFO] [stderr] 215 | | Ok(($i,($idx+1))) [INFO] [stderr] 216 | | } [INFO] [stderr] 217 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1237 | let r = do_gen!( [INFO] [stderr] | _________________- [INFO] [stderr] 1238 | | (s,0), [INFO] [stderr] 1239 | | start: gen_be_u8!(1) >> [INFO] [stderr] 1240 | | gen_align!(4) >> [INFO] [stderr] 1241 | | end: gen_be_u16!(end-start) [INFO] [stderr] 1242 | | ); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 211 | if $i.len() { do_gen!( [INFO] [stderr] 212 | (s,0), [INFO] [stderr] 213 | start: gen_be_u8!(1) >> [INFO] [stderr] 214 | gen_align!(4) >> [INFO] [stderr] 215 | end: gen_be_u16!(end-start) [INFO] [stderr] 216 | ) } else { do_gen!( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | / match $i.len() <= $idx+aligned { [INFO] [stderr] 182 | | true => Err(GenError::BufferTooSmall($idx+aligned)), [INFO] [stderr] 183 | | false => { Ok(($i,($idx+aligned))) }, [INFO] [stderr] 184 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 1237 | let r = do_gen!( [INFO] [stderr] | _________________- [INFO] [stderr] 1238 | | (s,0), [INFO] [stderr] 1239 | | start: gen_be_u8!(1) >> [INFO] [stderr] 1240 | | gen_align!(4) >> [INFO] [stderr] 1241 | | end: gen_be_u16!(end-start) [INFO] [stderr] 1242 | | ); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 181 | if $i.len() <= $idx+aligned { do_gen!( [INFO] [stderr] 182 | (s,0), [INFO] [stderr] 183 | start: gen_be_u8!(1) >> [INFO] [stderr] 184 | gen_align!(4) >> [INFO] [stderr] 185 | end: gen_be_u16!(end-start) [INFO] [stderr] 186 | ) } else { do_gen!( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:229:9 [INFO] [stderr] | [INFO] [stderr] 229 | / match $i.len() <= $idx + 1 { [INFO] [stderr] 230 | | true => Err(GenError::BufferTooSmall($idx+2)), [INFO] [stderr] 231 | | false => { [INFO] [stderr] 232 | | let v = $val; [INFO] [stderr] ... | [INFO] [stderr] 238 | | } [INFO] [stderr] 239 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1237 | let r = do_gen!( [INFO] [stderr] | _________________- [INFO] [stderr] 1238 | | (s,0), [INFO] [stderr] 1239 | | start: gen_be_u8!(1) >> [INFO] [stderr] 1240 | | gen_align!(4) >> [INFO] [stderr] 1241 | | end: gen_be_u16!(end-start) [INFO] [stderr] 1242 | | ); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 229 | if $i.len() <= $idx + 1 { do_gen!( [INFO] [stderr] 230 | (s,0), [INFO] [stderr] 231 | start: gen_be_u8!(1) >> [INFO] [stderr] 232 | gen_align!(4) >> [INFO] [stderr] 233 | end: gen_be_u16!(end-start) [INFO] [stderr] 234 | ) } else { do_gen!( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:197:9 [INFO] [stderr] | [INFO] [stderr] 197 | / match $i.len() < $idx+$val { [INFO] [stderr] 198 | | true => Err(GenError::BufferTooSmall($idx+$val)), [INFO] [stderr] 199 | | false => { Ok(($i,($idx+$val))) }, [INFO] [stderr] 200 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1257 | let r = do_gen!( [INFO] [stderr] | _________________- [INFO] [stderr] 1258 | | (s,0), [INFO] [stderr] 1259 | | gen_skip!(2) >> [INFO] [stderr] 1260 | | gen_at_offset!(4,gen_be_u16!(4)) [INFO] [stderr] 1261 | | ); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 197 | if $i.len() < $idx { do_gen!( [INFO] [stderr] 198 | (s,0), [INFO] [stderr] 199 | gen_skip!(2) >> [INFO] [stderr] 200 | gen_at_offset!(4,gen_be_u16!(4)) [INFO] [stderr] 201 | ) } else { do_gen!( [INFO] [stderr] 202 | (s,0), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:883:9 [INFO] [stderr] | [INFO] [stderr] 883 | / match $i.len() < $offset { [INFO] [stderr] 884 | | false => { [INFO] [stderr] 885 | | match $submac!(($i,$offset), $($args)*) { [INFO] [stderr] 886 | | Ok((r,_)) => Ok((r,($idx))), [INFO] [stderr] ... | [INFO] [stderr] 890 | | true => Err(GenError::BufferTooSmall($offset)), [INFO] [stderr] 891 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1257 | let r = do_gen!( [INFO] [stderr] | _________________- [INFO] [stderr] 1258 | | (s,0), [INFO] [stderr] 1259 | | gen_skip!(2) >> [INFO] [stderr] 1260 | | gen_at_offset!(4,gen_be_u16!(4)) [INFO] [stderr] 1261 | | ); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 883 | if $i.len() { do_gen!( [INFO] [stderr] 884 | (s,0), [INFO] [stderr] 885 | gen_skip!(2) >> [INFO] [stderr] 886 | gen_at_offset!(4,gen_be_u16!(4)) [INFO] [stderr] 887 | ) } else { do_gen!( [INFO] [stderr] 888 | (s,0), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:229:9 [INFO] [stderr] | [INFO] [stderr] 229 | / match $i.len() <= $idx + 1 { [INFO] [stderr] 230 | | true => Err(GenError::BufferTooSmall($idx+2)), [INFO] [stderr] 231 | | false => { [INFO] [stderr] 232 | | let v = $val; [INFO] [stderr] ... | [INFO] [stderr] 238 | | } [INFO] [stderr] 239 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1257 | let r = do_gen!( [INFO] [stderr] | _________________- [INFO] [stderr] 1258 | | (s,0), [INFO] [stderr] 1259 | | gen_skip!(2) >> [INFO] [stderr] 1260 | | gen_at_offset!(4,gen_be_u16!(4)) [INFO] [stderr] 1261 | | ); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 229 | if $i.len() <= $idx + 1 { do_gen!( [INFO] [stderr] 230 | (s,0), [INFO] [stderr] 231 | gen_skip!(2) >> [INFO] [stderr] 232 | gen_at_offset!(4,gen_be_u16!(4)) [INFO] [stderr] 233 | ) } else { do_gen!( [INFO] [stderr] 234 | (s,0), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:197:9 [INFO] [stderr] | [INFO] [stderr] 197 | / match $i.len() < $idx+$val { [INFO] [stderr] 198 | | true => Err(GenError::BufferTooSmall($idx+$val)), [INFO] [stderr] 199 | | false => { Ok(($i,($idx+$val))) }, [INFO] [stderr] 200 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1276 | let r = do_gen!( [INFO] [stderr] | _________________- [INFO] [stderr] 1277 | | (s,0), [INFO] [stderr] 1278 | | gen_skip!(2) >> [INFO] [stderr] 1279 | | gen_at_rel_offset!(4,gen_be_u16!(4)) [INFO] [stderr] 1280 | | ); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 197 | if $i.len() < $idx { do_gen!( [INFO] [stderr] 198 | (s,0), [INFO] [stderr] 199 | gen_skip!(2) >> [INFO] [stderr] 200 | gen_at_rel_offset!(4,gen_be_u16!(4)) [INFO] [stderr] 201 | ) } else { do_gen!( [INFO] [stderr] 202 | (s,0), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:883:9 [INFO] [stderr] | [INFO] [stderr] 883 | / match $i.len() < $offset { [INFO] [stderr] 884 | | false => { [INFO] [stderr] 885 | | match $submac!(($i,$offset), $($args)*) { [INFO] [stderr] 886 | | Ok((r,_)) => Ok((r,($idx))), [INFO] [stderr] ... | [INFO] [stderr] 890 | | true => Err(GenError::BufferTooSmall($offset)), [INFO] [stderr] 891 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1276 | let r = do_gen!( [INFO] [stderr] | _________________- [INFO] [stderr] 1277 | | (s,0), [INFO] [stderr] 1278 | | gen_skip!(2) >> [INFO] [stderr] 1279 | | gen_at_rel_offset!(4,gen_be_u16!(4)) [INFO] [stderr] 1280 | | ); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 883 | if $i.len() < $offset { [INFO] [stderr] 884 | false => { [INFO] [stderr] 885 | match $submac!(($i,$offset), $($args)*) { [INFO] [stderr] 886 | Ok((r,_)) => Ok((r,($idx))), [INFO] [stderr] 887 | Err(e) => Err(e), [INFO] [stderr] 888 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:229:9 [INFO] [stderr] | [INFO] [stderr] 229 | / match $i.len() <= $idx + 1 { [INFO] [stderr] 230 | | true => Err(GenError::BufferTooSmall($idx+2)), [INFO] [stderr] 231 | | false => { [INFO] [stderr] 232 | | let v = $val; [INFO] [stderr] ... | [INFO] [stderr] 238 | | } [INFO] [stderr] 239 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1276 | let r = do_gen!( [INFO] [stderr] | _________________- [INFO] [stderr] 1277 | | (s,0), [INFO] [stderr] 1278 | | gen_skip!(2) >> [INFO] [stderr] 1279 | | gen_at_rel_offset!(4,gen_be_u16!(4)) [INFO] [stderr] 1280 | | ); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 229 | if $i.len() <= $idx + 1 { do_gen!( [INFO] [stderr] 230 | (s,0), [INFO] [stderr] 231 | gen_skip!(2) >> [INFO] [stderr] 232 | gen_at_rel_offset!(4,gen_be_u16!(4)) [INFO] [stderr] 233 | ) } else { do_gen!( [INFO] [stderr] 234 | (s,0), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:197:9 [INFO] [stderr] | [INFO] [stderr] 197 | / match $i.len() < $idx+$val { [INFO] [stderr] 198 | | true => Err(GenError::BufferTooSmall($idx+$val)), [INFO] [stderr] 199 | | false => { Ok(($i,($idx+$val))) }, [INFO] [stderr] 200 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1294 | let r = do_gen!( [INFO] [stderr] | _________________- [INFO] [stderr] 1295 | | (s,0), [INFO] [stderr] 1296 | | gen_skip!(2) >> [INFO] [stderr] 1297 | | gen_at_rel_offset!(-4,gen_be_u16!(4)) [INFO] [stderr] 1298 | | ); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 197 | if $i.len() < $idx { do_gen!( [INFO] [stderr] 198 | (s,0), [INFO] [stderr] 199 | gen_skip!(2) >> [INFO] [stderr] 200 | gen_at_rel_offset!(-4,gen_be_u16!(4)) [INFO] [stderr] 201 | ) } else { do_gen!( [INFO] [stderr] 202 | (s,0), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:883:9 [INFO] [stderr] | [INFO] [stderr] 883 | / match $i.len() < $offset { [INFO] [stderr] 884 | | false => { [INFO] [stderr] 885 | | match $submac!(($i,$offset), $($args)*) { [INFO] [stderr] 886 | | Ok((r,_)) => Ok((r,($idx))), [INFO] [stderr] ... | [INFO] [stderr] 890 | | true => Err(GenError::BufferTooSmall($offset)), [INFO] [stderr] 891 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1294 | let r = do_gen!( [INFO] [stderr] | _________________- [INFO] [stderr] 1295 | | (s,0), [INFO] [stderr] 1296 | | gen_skip!(2) >> [INFO] [stderr] 1297 | | gen_at_rel_offset!(-4,gen_be_u16!(4)) [INFO] [stderr] 1298 | | ); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 883 | if $i.len() < $offset { [INFO] [stderr] 884 | false => { [INFO] [stderr] 885 | match $submac!(($i,$offset), $($args)*) { [INFO] [stderr] 886 | Ok((r,_)) => Ok((r,($idx))), [INFO] [stderr] 887 | Err(e) => Err(e), [INFO] [stderr] 888 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/gen.rs:229:9 [INFO] [stderr] | [INFO] [stderr] 229 | / match $i.len() <= $idx + 1 { [INFO] [stderr] 230 | | true => Err(GenError::BufferTooSmall($idx+2)), [INFO] [stderr] 231 | | false => { [INFO] [stderr] 232 | | let v = $val; [INFO] [stderr] ... | [INFO] [stderr] 238 | | } [INFO] [stderr] 239 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1294 | let r = do_gen!( [INFO] [stderr] | _________________- [INFO] [stderr] 1295 | | (s,0), [INFO] [stderr] 1296 | | gen_skip!(2) >> [INFO] [stderr] 1297 | | gen_at_rel_offset!(-4,gen_be_u16!(4)) [INFO] [stderr] 1298 | | ); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 229 | if $i.len() <= $idx + 1 { do_gen!( [INFO] [stderr] 230 | (s,0), [INFO] [stderr] 231 | gen_skip!(2) >> [INFO] [stderr] 232 | gen_at_rel_offset!(-4,gen_be_u16!(4)) [INFO] [stderr] 233 | ) } else { do_gen!( [INFO] [stderr] 234 | (s,0), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/text.rs:9:3 [INFO] [stderr] | [INFO] [stderr] 9 | fn raw<'a>(&'a self) -> Slice<'a>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/text.rs:14:3 [INFO] [stderr] | [INFO] [stderr] 14 | / fn raw<'a>(&'a self) -> Slice<'a> { [INFO] [stderr] 15 | | Slice::new(self.as_ref().as_bytes()) [INFO] [stderr] 16 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/text.rs:24:3 [INFO] [stderr] | [INFO] [stderr] 24 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 25 | | let mut c = Cursor::new(output); [INFO] [stderr] 26 | | match write!(&mut c, "{}", self.value) { [INFO] [stderr] 27 | | //FIXME: maybe return an error here instead of assuming the buffer is too small? [INFO] [stderr] ... | [INFO] [stderr] 30 | | } [INFO] [stderr] 31 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/text.rs:50:3 [INFO] [stderr] | [INFO] [stderr] 50 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 51 | | let mut c = Cursor::new(output); [INFO] [stderr] 52 | | match write!(&mut c, "{:X}", self.value) { [INFO] [stderr] 53 | | //FIXME: maybe return an error here instead of assuming the buffer is too small? [INFO] [stderr] ... | [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/binary.rs:22:3 [INFO] [stderr] | [INFO] [stderr] 22 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 23 | | let output_len = output.len(); [INFO] [stderr] 24 | | let self_len = self.value.len() - self.index; [INFO] [stderr] 25 | | if self_len <= output_len { [INFO] [stderr] ... | [INFO] [stderr] 32 | | } [INFO] [stderr] 33 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/binary.rs:63:3 [INFO] [stderr] | [INFO] [stderr] 63 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 64 | | match self.value.serialize(&mut output[self.skip..])? { [INFO] [stderr] 65 | | // we need to write the full length/value structure at once [INFO] [stderr] 66 | | (_, Serialized::Continue) => Ok((0, Serialized::Continue)), [INFO] [stderr] ... | [INFO] [stderr] 73 | | } [INFO] [stderr] 74 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/binary.rs:116:3 [INFO] [stderr] | [INFO] [stderr] 116 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 117 | | if output.len() == 0 { [INFO] [stderr] 118 | | Ok((0, Serialized::Continue)) [INFO] [stderr] 119 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 122 | | } [INFO] [stderr] 123 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/combinators/binary.rs:117:8 [INFO] [stderr] | [INFO] [stderr] 117 | if output.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `output.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/binary.rs:127:3 [INFO] [stderr] | [INFO] [stderr] 127 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 128 | | if output.len() < 2 { [INFO] [stderr] 129 | | Ok((0, Serialized::Continue)) [INFO] [stderr] 130 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 134 | | } [INFO] [stderr] 135 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/binary.rs:139:3 [INFO] [stderr] | [INFO] [stderr] 139 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 140 | | if output.len() < 4 { [INFO] [stderr] 141 | | Ok((0, Serialized::Continue)) [INFO] [stderr] 142 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 148 | | } [INFO] [stderr] 149 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/binary.rs:153:3 [INFO] [stderr] | [INFO] [stderr] 153 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 154 | | if output.len() < 8 { [INFO] [stderr] 155 | | Ok((0, Serialized::Continue)) [INFO] [stderr] 156 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 166 | | } [INFO] [stderr] 167 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/binary.rs:171:3 [INFO] [stderr] | [INFO] [stderr] 171 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 172 | | if output.len() == 0 { [INFO] [stderr] 173 | | Ok((0, Serialized::Continue)) [INFO] [stderr] 174 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 177 | | } [INFO] [stderr] 178 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/combinators/binary.rs:172:8 [INFO] [stderr] | [INFO] [stderr] 172 | if output.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `output.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/binary.rs:182:3 [INFO] [stderr] | [INFO] [stderr] 182 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 183 | | if output.len() < 2 { [INFO] [stderr] 184 | | Ok((0, Serialized::Continue)) [INFO] [stderr] 185 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 189 | | } [INFO] [stderr] 190 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/binary.rs:194:3 [INFO] [stderr] | [INFO] [stderr] 194 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 195 | | if output.len() < 4 { [INFO] [stderr] 196 | | Ok((0, Serialized::Continue)) [INFO] [stderr] 197 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 203 | | } [INFO] [stderr] 204 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/binary.rs:208:3 [INFO] [stderr] | [INFO] [stderr] 208 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 209 | | if output.len() < 8 { [INFO] [stderr] 210 | | Ok((0, Serialized::Continue)) [INFO] [stderr] 211 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 221 | | } [INFO] [stderr] 222 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/mod.rs:45:3 [INFO] [stderr] | [INFO] [stderr] 45 | / fn serialize<'b, 'c>(&'b mut self, _output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 46 | | Ok((0, Serialized::Done)) [INFO] [stderr] 47 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/mod.rs:66:3 [INFO] [stderr] | [INFO] [stderr] 66 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 67 | | if output.len() < self.0 { [INFO] [stderr] 68 | | Ok((0, Serialized::Continue)) [INFO] [stderr] 69 | | } else { [INFO] [stderr] 70 | | Ok((self.0, Serialized::Done)) [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/mod.rs:88:3 [INFO] [stderr] | [INFO] [stderr] 88 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 89 | | (**self).serialize(output) [INFO] [stderr] 90 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/mod.rs:110:3 [INFO] [stderr] | [INFO] [stderr] 110 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 111 | | let mut i = 0; [INFO] [stderr] 112 | | if let Some(mut a) = self.first.take() { [INFO] [stderr] 113 | | match a.serialize(output)? { [INFO] [stderr] ... | [INFO] [stderr] 125 | | self.second.serialize(sl).map(|(index, res)| (index+i, res)) [INFO] [stderr] 126 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/mod.rs:146:3 [INFO] [stderr] | [INFO] [stderr] 146 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 147 | | match &mut self.a { [INFO] [stderr] 148 | | Some(ref mut a) => a.serialize(output), [INFO] [stderr] 149 | | None => self.b.serialize(output) [INFO] [stderr] 150 | | } [INFO] [stderr] 151 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/combinators/mod.rs:156:40 [INFO] [stderr] | [INFO] [stderr] 156 | self.a.as_mut().map(|a| a.reset()).unwrap_or(self.b.reset()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.b.reset())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/mod.rs:177:3 [INFO] [stderr] | [INFO] [stderr] 177 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 178 | | let mut index = 0; [INFO] [stderr] 179 | | [INFO] [stderr] 180 | | loop { [INFO] [stderr] ... | [INFO] [stderr] 199 | | } [INFO] [stderr] 200 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/mod.rs:229:3 [INFO] [stderr] | [INFO] [stderr] 229 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 230 | | let mut index = 0; [INFO] [stderr] 231 | | [INFO] [stderr] 232 | | loop { [INFO] [stderr] ... | [INFO] [stderr] 269 | | } [INFO] [stderr] 270 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `combinators::Stream` [INFO] [stderr] --> src/combinators/mod.rs:279:3 [INFO] [stderr] | [INFO] [stderr] 279 | / pub fn new() -> Self { [INFO] [stderr] 280 | | Stream { [INFO] [stderr] 281 | | queue: VecDeque::new(), [INFO] [stderr] 282 | | } [INFO] [stderr] 283 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 273 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_iter` on this type; consider implementing the `std::iter::FromIterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/combinators/mod.rs:285:3 [INFO] [stderr] | [INFO] [stderr] 285 | / pub fn from_iter>(it: It) -> Self { [INFO] [stderr] 286 | | Stream { [INFO] [stderr] 287 | | queue: it.collect(), [INFO] [stderr] 288 | | } [INFO] [stderr] 289 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/mod.rs:298:3 [INFO] [stderr] | [INFO] [stderr] 298 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 299 | | let mut index = 0; [INFO] [stderr] 300 | | [INFO] [stderr] 301 | | loop { [INFO] [stderr] ... | [INFO] [stderr] 313 | | } [INFO] [stderr] 314 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/combinators/mod.rs:318:3 [INFO] [stderr] | [INFO] [stderr] 318 | / fn serialize<'b, 'c>(&'b mut self, output: &'c mut [u8]) -> Result<(usize, Serialized), GenError> { [INFO] [stderr] 319 | | match self(output) { [INFO] [stderr] 320 | | Err(e) => Err(e), [INFO] [stderr] 321 | | Ok((_, index)) => Ok((index, Serialized::Done)), [INFO] [stderr] 322 | | } [INFO] [stderr] 323 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.94s [INFO] running `"docker" "inspect" "2410e62e82d893b124d48889e374787f87df9926ec6499831c195c6db3944bf5"` [INFO] running `"docker" "rm" "-f" "2410e62e82d893b124d48889e374787f87df9926ec6499831c195c6db3944bf5"` [INFO] [stdout] 2410e62e82d893b124d48889e374787f87df9926ec6499831c195c6db3944bf5