[INFO] crate conway-rs 0.1.2 is already in cache [INFO] extracting crate conway-rs 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/conway-rs/0.1.2 [INFO] extracting crate conway-rs 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/conway-rs/0.1.2 [INFO] validating manifest of conway-rs-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of conway-rs-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing conway-rs-0.1.2 [INFO] finished frobbing conway-rs-0.1.2 [INFO] frobbed toml for conway-rs-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/conway-rs/0.1.2/Cargo.toml [INFO] started frobbing conway-rs-0.1.2 [INFO] finished frobbing conway-rs-0.1.2 [INFO] frobbed toml for conway-rs-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/conway-rs/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting conway-rs-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/conway-rs/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b40488698fb60bb475809e22ad45bf6985561a27a75284f01e4d54ada3f532c4 [INFO] running `"docker" "start" "-a" "b40488698fb60bb475809e22ad45bf6985561a27a75284f01e4d54ada3f532c4"` [INFO] [stderr] warning: An explicit [[bin]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other binary targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a binary target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/src/main.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a binary target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autobins = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] warning: path `/opt/crater/workdir/src/main.rs` was erroneously implicitly accepted for binary `conway`, [INFO] [stderr] please set bin.path in Cargo.toml [INFO] [stderr] Checking conway-rs v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | Point { x: x, y: y + 1 }, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:88:21 [INFO] [stderr] | [INFO] [stderr] 88 | Point { x: x, y: y - 1 }, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:89:31 [INFO] [stderr] | [INFO] [stderr] 89 | Point { x: x + 1, y: y }, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:90:31 [INFO] [stderr] | [INFO] [stderr] 90 | Point { x: x - 1, y: y }, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/grid.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | write!(f, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | Point { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell.rs:24:23 [INFO] [stderr] | [INFO] [stderr] 24 | Point { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell.rs:33:28 [INFO] [stderr] | [INFO] [stderr] 33 | point: Point { x: x, y: y }, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell.rs:33:34 [INFO] [stderr] | [INFO] [stderr] 33 | point: Point { x: x, y: y }, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | Point { x: x, y: y + 1 }, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:88:21 [INFO] [stderr] | [INFO] [stderr] 88 | Point { x: x, y: y - 1 }, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:89:31 [INFO] [stderr] | [INFO] [stderr] 89 | Point { x: x + 1, y: y }, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:90:31 [INFO] [stderr] | [INFO] [stderr] 90 | Point { x: x - 1, y: y }, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/grid.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | write!(f, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | Point { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell.rs:24:23 [INFO] [stderr] | [INFO] [stderr] 24 | Point { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell.rs:33:28 [INFO] [stderr] | [INFO] [stderr] 33 | point: Point { x: x, y: y }, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell.rs:33:34 [INFO] [stderr] | [INFO] [stderr] 33 | point: Point { x: x, y: y }, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/grid.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | / if point.x >= 0 && point.x < self.width as i32 && point.y >= 0 && [INFO] [stderr] 99 | | point.y < self.height as i32 [INFO] [stderr] 100 | | { [INFO] [stderr] 101 | | if self.cell(point.x as usize, point.y as usize).alive { [INFO] [stderr] 102 | | neighbors_count += 1; [INFO] [stderr] 103 | | } [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 98 | if point.x >= 0 && point.x < self.width as i32 && point.y >= 0 && [INFO] [stderr] 99 | point.y < self.height as i32 && self.cell(point.x as usize, point.y as usize).alive { [INFO] [stderr] 100 | neighbors_count += 1; [INFO] [stderr] 101 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/cell.rs:59:21 [INFO] [stderr] | [INFO] [stderr] 59 | let state = match self.alive { [INFO] [stderr] | _____________________^ [INFO] [stderr] 60 | | true => !(neighbors < 2 || neighbors > 3), [INFO] [stderr] 61 | | false => (neighbors == 3), [INFO] [stderr] 62 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.alive { !(neighbors < 2 || neighbors > 3) } else { (neighbors == 3) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/grid.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | / if point.x >= 0 && point.x < self.width as i32 && point.y >= 0 && [INFO] [stderr] 99 | | point.y < self.height as i32 [INFO] [stderr] 100 | | { [INFO] [stderr] 101 | | if self.cell(point.x as usize, point.y as usize).alive { [INFO] [stderr] 102 | | neighbors_count += 1; [INFO] [stderr] 103 | | } [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 98 | if point.x >= 0 && point.x < self.width as i32 && point.y >= 0 && [INFO] [stderr] 99 | point.y < self.height as i32 && self.cell(point.x as usize, point.y as usize).alive { [INFO] [stderr] 100 | neighbors_count += 1; [INFO] [stderr] 101 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/cell.rs:59:21 [INFO] [stderr] | [INFO] [stderr] 59 | let state = match self.alive { [INFO] [stderr] | _____________________^ [INFO] [stderr] 60 | | true => !(neighbors < 2 || neighbors > 3), [INFO] [stderr] 61 | | false => (neighbors == 3), [INFO] [stderr] 62 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.alive { !(neighbors < 2 || neighbors > 3) } else { (neighbors == 3) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.12s [INFO] running `"docker" "inspect" "b40488698fb60bb475809e22ad45bf6985561a27a75284f01e4d54ada3f532c4"` [INFO] running `"docker" "rm" "-f" "b40488698fb60bb475809e22ad45bf6985561a27a75284f01e4d54ada3f532c4"` [INFO] [stdout] b40488698fb60bb475809e22ad45bf6985561a27a75284f01e4d54ada3f532c4