[INFO] crate convec 2.0.1 is already in cache [INFO] extracting crate convec 2.0.1 into work/ex/clippy-test-run/sources/stable/reg/convec/2.0.1 [INFO] extracting crate convec 2.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/convec/2.0.1 [INFO] validating manifest of convec-2.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of convec-2.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing convec-2.0.1 [INFO] finished frobbing convec-2.0.1 [INFO] frobbed toml for convec-2.0.1 written to work/ex/clippy-test-run/sources/stable/reg/convec/2.0.1/Cargo.toml [INFO] started frobbing convec-2.0.1 [INFO] finished frobbing convec-2.0.1 [INFO] frobbed toml for convec-2.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/convec/2.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting convec-2.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/convec/2.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 06f9ead7ea89cbe4a45229fbb6878898320931a8e3c000602c72bf2e0cdde5e0 [INFO] running `"docker" "start" "-a" "06f9ead7ea89cbe4a45229fbb6878898320931a8e3c000602c72bf2e0cdde5e0"` [INFO] [stderr] Checking convec v2.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/convec.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | compare = compare << 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `compare <<= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/convec.rs:143:16 [INFO] [stderr] | [INFO] [stderr] 143 | if (*allocation).len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `(*allocation).is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/convec.rs:161:12 [INFO] [stderr] | [INFO] [stderr] 161 | if (*self.allocations[index].get()).len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `(*self.allocations[index].get()).is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/convec.rs:187:16 [INFO] [stderr] | [INFO] [stderr] 187 | if alloc.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!alloc.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: item `ConStack` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | / impl ConStack { [INFO] [stderr] 19 | | /// Creates a new `ConStack` [INFO] [stderr] 20 | | pub fn new() -> Self { [INFO] [stderr] 21 | | ConStack(ConVec::new()) [INFO] [stderr] ... | [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ConStack` [INFO] [stderr] --> src/lib.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> Self { [INFO] [stderr] 21 | | ConStack(ConVec::new()) [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 18 | impl Default for ConStack { [INFO] [stderr] 19 | fn default() -> Self { [INFO] [stderr] 20 | Self::new() [INFO] [stderr] 21 | } [INFO] [stderr] 22 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: item `AoVec` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | / impl AoVec { [INFO] [stderr] 46 | | /// Creates a new `AoVece` [INFO] [stderr] 47 | | pub fn new() -> Self { [INFO] [stderr] 48 | | AoVec(ConVec::new()) [INFO] [stderr] ... | [INFO] [stderr] 65 | | } [INFO] [stderr] 66 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `AoVec` [INFO] [stderr] --> src/lib.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | / pub fn new() -> Self { [INFO] [stderr] 48 | | AoVec(ConVec::new()) [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 45 | impl Default for AoVec { [INFO] [stderr] 46 | fn default() -> Self { [INFO] [stderr] 47 | Self::new() [INFO] [stderr] 48 | } [INFO] [stderr] 49 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/convec.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | compare = compare << 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `compare <<= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/convec.rs:143:16 [INFO] [stderr] | [INFO] [stderr] 143 | if (*allocation).len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `(*allocation).is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/convec.rs:161:12 [INFO] [stderr] | [INFO] [stderr] 161 | if (*self.allocations[index].get()).len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `(*self.allocations[index].get()).is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/convec.rs:187:16 [INFO] [stderr] | [INFO] [stderr] 187 | if alloc.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!alloc.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: item `ConStack` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | / impl ConStack { [INFO] [stderr] 19 | | /// Creates a new `ConStack` [INFO] [stderr] 20 | | pub fn new() -> Self { [INFO] [stderr] 21 | | ConStack(ConVec::new()) [INFO] [stderr] ... | [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ConStack` [INFO] [stderr] --> src/lib.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> Self { [INFO] [stderr] 21 | | ConStack(ConVec::new()) [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 18 | impl Default for ConStack { [INFO] [stderr] 19 | fn default() -> Self { [INFO] [stderr] 20 | Self::new() [INFO] [stderr] 21 | } [INFO] [stderr] 22 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: item `AoVec` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | / impl AoVec { [INFO] [stderr] 46 | | /// Creates a new `AoVece` [INFO] [stderr] 47 | | pub fn new() -> Self { [INFO] [stderr] 48 | | AoVec(ConVec::new()) [INFO] [stderr] ... | [INFO] [stderr] 65 | | } [INFO] [stderr] 66 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `AoVec` [INFO] [stderr] --> src/lib.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | / pub fn new() -> Self { [INFO] [stderr] 48 | | AoVec(ConVec::new()) [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 45 | impl Default for AoVec { [INFO] [stderr] 46 | fn default() -> Self { [INFO] [stderr] 47 | Self::new() [INFO] [stderr] 48 | } [INFO] [stderr] 49 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.00s [INFO] running `"docker" "inspect" "06f9ead7ea89cbe4a45229fbb6878898320931a8e3c000602c72bf2e0cdde5e0"` [INFO] running `"docker" "rm" "-f" "06f9ead7ea89cbe4a45229fbb6878898320931a8e3c000602c72bf2e0cdde5e0"` [INFO] [stdout] 06f9ead7ea89cbe4a45229fbb6878898320931a8e3c000602c72bf2e0cdde5e0