[INFO] crate context 2.1.0 is already in cache [INFO] extracting crate context 2.1.0 into work/ex/clippy-test-run/sources/stable/reg/context/2.1.0 [INFO] extracting crate context 2.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/context/2.1.0 [INFO] validating manifest of context-2.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of context-2.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing context-2.1.0 [INFO] finished frobbing context-2.1.0 [INFO] frobbed toml for context-2.1.0 written to work/ex/clippy-test-run/sources/stable/reg/context/2.1.0/Cargo.toml [INFO] started frobbing context-2.1.0 [INFO] finished frobbing context-2.1.0 [INFO] frobbed toml for context-2.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/context/2.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting context-2.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/context/2.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6943ad1663d83aaa4f3822137e30ecd9dc57659d0878f094f2b9ae18df3a4ce6 [INFO] running `"docker" "start" "-a" "6943ad1663d83aaa4f3822137e30ecd9dc57659d0878f094f2b9ae18df3a4ce6"` [INFO] [stderr] Compiling context v2.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | context: context, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `context` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stack.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | top: top, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `top` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stack.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | bottom: bottom, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bottom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | context: context, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `context` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stack.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | top: top, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `top` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stack.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | bottom: bottom, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bottom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: item `stack::Stack` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/stack.rs:62:1 [INFO] [stderr] | [INFO] [stderr] 62 | / impl Stack { [INFO] [stderr] 63 | | /// Creates a (non-owning) representation of some stack memory. [INFO] [stderr] 64 | | /// [INFO] [stderr] 65 | | /// It is unsafe because it is your reponsibility to make sure that `top` and `buttom` are valid [INFO] [stderr] ... | [INFO] [stderr] 146 | | } [INFO] [stderr] 147 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `stack::Stack` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/stack.rs:62:1 [INFO] [stderr] | [INFO] [stderr] 62 | / impl Stack { [INFO] [stderr] 63 | | /// Creates a (non-owning) representation of some stack memory. [INFO] [stderr] 64 | | /// [INFO] [stderr] 65 | | /// It is unsafe because it is your reponsibility to make sure that `top` and `buttom` are valid [INFO] [stderr] ... | [INFO] [stderr] 146 | | } [INFO] [stderr] 147 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/stack.rs:266:9 [INFO] [stderr] | [INFO] [stderr] 266 | / match FixedSizeStack::new(stack_size) { [INFO] [stderr] 267 | | Err(StackError::ExceedsMaximumSize(..)) => panic!(), [INFO] [stderr] 268 | | _ => {} [INFO] [stderr] 269 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(StackError::ExceedsMaximumSize(..)) = FixedSizeStack::new(stack_size) { panic!() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.50s [INFO] running `"docker" "inspect" "6943ad1663d83aaa4f3822137e30ecd9dc57659d0878f094f2b9ae18df3a4ce6"` [INFO] running `"docker" "rm" "-f" "6943ad1663d83aaa4f3822137e30ecd9dc57659d0878f094f2b9ae18df3a4ce6"` [INFO] [stdout] 6943ad1663d83aaa4f3822137e30ecd9dc57659d0878f094f2b9ae18df3a4ce6