[INFO] crate content-blocker 0.2.3 is already in cache [INFO] extracting crate content-blocker 0.2.3 into work/ex/clippy-test-run/sources/stable/reg/content-blocker/0.2.3 [INFO] extracting crate content-blocker 0.2.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/content-blocker/0.2.3 [INFO] validating manifest of content-blocker-0.2.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of content-blocker-0.2.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing content-blocker-0.2.3 [INFO] finished frobbing content-blocker-0.2.3 [INFO] frobbed toml for content-blocker-0.2.3 written to work/ex/clippy-test-run/sources/stable/reg/content-blocker/0.2.3/Cargo.toml [INFO] started frobbing content-blocker-0.2.3 [INFO] finished frobbing content-blocker-0.2.3 [INFO] frobbed toml for content-blocker-0.2.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/content-blocker/0.2.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting content-blocker-0.2.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/content-blocker/0.2.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 97ffc25be06383ce0a8b031a5ffae728449422f32aba7e5fec3f890be894744c [INFO] running `"docker" "start" "-a" "97ffc25be06383ce0a8b031a5ffae728449422f32aba7e5fec3f890be894744c"` [INFO] [stderr] Checking content-blocker v0.2.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:185:13 [INFO] [stderr] | [INFO] [stderr] 185 | action: action, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `action` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:180:17 [INFO] [stderr] | [INFO] [stderr] 180 | url_filter: url_filter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `url_filter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:181:17 [INFO] [stderr] | [INFO] [stderr] 181 | resource_type: resource_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `resource_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:182:17 [INFO] [stderr] | [INFO] [stderr] 182 | load_type: load_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `load_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:183:17 [INFO] [stderr] | [INFO] [stderr] 183 | domain_constraint: domain_constraint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `domain_constraint` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:185:13 [INFO] [stderr] | [INFO] [stderr] 185 | action: action, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `action` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:180:17 [INFO] [stderr] | [INFO] [stderr] 180 | url_filter: url_filter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `url_filter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:181:17 [INFO] [stderr] | [INFO] [stderr] 181 | resource_type: resource_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `resource_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:182:17 [INFO] [stderr] | [INFO] [stderr] 182 | load_type: load_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `load_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:183:17 [INFO] [stderr] | [INFO] [stderr] 183 | domain_constraint: domain_constraint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `domain_constraint` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/repr.rs:81:21 [INFO] [stderr] | [INFO] [stderr] 81 | / if domain.as_bytes()[domain.len() - suffix.len() - 1] == b'.' { [INFO] [stderr] 82 | | if domain.ends_with(suffix) { [INFO] [stderr] 83 | | return true; [INFO] [stderr] 84 | | } [INFO] [stderr] 85 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 81 | if domain.as_bytes()[domain.len() - suffix.len() - 1] == b'.' && domain.ends_with(suffix) { [INFO] [stderr] 82 | return true; [INFO] [stderr] 83 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/repr.rs:81:21 [INFO] [stderr] | [INFO] [stderr] 81 | / if domain.as_bytes()[domain.len() - suffix.len() - 1] == b'.' { [INFO] [stderr] 82 | | if domain.ends_with(suffix) { [INFO] [stderr] 83 | | return true; [INFO] [stderr] 84 | | } [INFO] [stderr] 85 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 81 | if domain.as_bytes()[domain.len() - suffix.len() - 1] == b'.' && domain.ends_with(suffix) { [INFO] [stderr] 82 | return true; [INFO] [stderr] 83 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parse.rs:47:16 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn new<'a, T, Iter>(iter: Iter) -> DomainMatcher [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parse.rs:54:35 [INFO] [stderr] | [INFO] [stderr] 54 | if domain.starts_with("*") { [INFO] [stderr] | ^^^ help: try using a char instead: `'*'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:39:31 [INFO] [stderr] | [INFO] [stderr] 39 | parse_list_impl(body).map(|r| RuleList(r)) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove closure as shown: `RuleList` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parse.rs:47:16 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn new<'a, T, Iter>(iter: Iter) -> DomainMatcher [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parse.rs:54:35 [INFO] [stderr] | [INFO] [stderr] 54 | if domain.starts_with("*") { [INFO] [stderr] | ^^^ help: try using a char instead: `'*'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/tests.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | url_filter: Regex::new("").unwrap(), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: the regex is unlikely to be useful as it is [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:39:31 [INFO] [stderr] | [INFO] [stderr] 39 | parse_list_impl(body).map(|r| RuleList(r)) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove closure as shown: `RuleList` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.78s [INFO] running `"docker" "inspect" "97ffc25be06383ce0a8b031a5ffae728449422f32aba7e5fec3f890be894744c"` [INFO] running `"docker" "rm" "-f" "97ffc25be06383ce0a8b031a5ffae728449422f32aba7e5fec3f890be894744c"` [INFO] [stdout] 97ffc25be06383ce0a8b031a5ffae728449422f32aba7e5fec3f890be894744c