[INFO] crate container-what 0.1.0 is already in cache [INFO] extracting crate container-what 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/container-what/0.1.0 [INFO] extracting crate container-what 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/container-what/0.1.0 [INFO] validating manifest of container-what-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of container-what-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing container-what-0.1.0 [INFO] finished frobbing container-what-0.1.0 [INFO] frobbed toml for container-what-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/container-what/0.1.0/Cargo.toml [INFO] started frobbing container-what-0.1.0 [INFO] finished frobbing container-what-0.1.0 [INFO] frobbed toml for container-what-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/container-what/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting container-what-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/container-what/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8638e5f475b7ea1bd2f598c04f905771de269cee48ec0b6f448d022001cf3723 [INFO] running `"docker" "start" "-a" "8638e5f475b7ea1bd2f598c04f905771de269cee48ec0b6f448d022001cf3723"` [INFO] [stderr] Checking container-what v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/container/detector.rs:51:17 [INFO] [stderr] | [INFO] [stderr] 51 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/container/detector.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/container/detector.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | return ContainerEngine::Unknown; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ContainerEngine::Unknown` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/container/detector.rs:46:43 [INFO] [stderr] | [INFO] [stderr] 46 | for line in content.split("\x00") { [INFO] [stderr] | ^^^^^^ help: try using a char instead: `'\x00'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/container/detector.rs:51:17 [INFO] [stderr] | [INFO] [stderr] 51 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/container/detector.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/container/detector.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | return ContainerEngine::Unknown; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ContainerEngine::Unknown` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/container/detector.rs:46:43 [INFO] [stderr] | [INFO] [stderr] 46 | for line in content.split("\x00") { [INFO] [stderr] | ^^^^^^ help: try using a char instead: `'\x00'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:17:51 [INFO] [stderr] | [INFO] [stderr] 17 | let mut base_dir = env::var("TESTS_PATH").unwrap_or("/root".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "/root".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:18:32 [INFO] [stderr] | [INFO] [stderr] 18 | if !base_dir.ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | let ref lxc_path = test_case_path_str("lxc"); [INFO] [stderr] | ----^^^^^^^^^^^^----------------------------- help: try: `let lxc_path = &test_case_path_str("lxc");` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | let ref ctx = DetectorContext::new(Path::new(lxc_path)); [INFO] [stderr] | ----^^^^^^^--------------------------------------------- help: try: `let ctx = &DetectorContext::new(Path::new(lxc_path));` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | let ref docker_path = test_case_path_str("docker"); [INFO] [stderr] | ----^^^^^^^^^^^^^^^-------------------------------- help: try: `let docker_path = &test_case_path_str("docker");` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | let ref ctx = DetectorContext::new(Path::new(docker_path)); [INFO] [stderr] | ----^^^^^^^------------------------------------------------ help: try: `let ctx = &DetectorContext::new(Path::new(docker_path));` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.89s [INFO] running `"docker" "inspect" "8638e5f475b7ea1bd2f598c04f905771de269cee48ec0b6f448d022001cf3723"` [INFO] running `"docker" "rm" "-f" "8638e5f475b7ea1bd2f598c04f905771de269cee48ec0b6f448d022001cf3723"` [INFO] [stdout] 8638e5f475b7ea1bd2f598c04f905771de269cee48ec0b6f448d022001cf3723