[INFO] crate constrained 0.1.0 is already in cache [INFO] extracting crate constrained 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/constrained/0.1.0 [INFO] extracting crate constrained 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/constrained/0.1.0 [INFO] validating manifest of constrained-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of constrained-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing constrained-0.1.0 [INFO] finished frobbing constrained-0.1.0 [INFO] frobbed toml for constrained-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/constrained/0.1.0/Cargo.toml [INFO] started frobbing constrained-0.1.0 [INFO] finished frobbing constrained-0.1.0 [INFO] frobbed toml for constrained-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/constrained/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting constrained-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/constrained/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 263f69bd37ebf475fd0130992715937f2cac9b5b111073e835d2c617bcf2fe44 [INFO] running `"docker" "start" "-a" "263f69bd37ebf475fd0130992715937f2cac9b5b111073e835d2c617bcf2fe44"` [INFO] [stderr] Checking dense_mats v0.4.0 [INFO] [stderr] Checking sprs v0.3.3 [INFO] [stderr] Checking constrained v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | v: v, [INFO] [stderr] | ^^^^ help: replace it with: `v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | source_start: source_start, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | target_start: target_start, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `target_start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | target_end: target_end, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `target_end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | target_len: target_len [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `target_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:189:10 [INFO] [stderr] | [INFO] [stderr] 189 | let (m, n) = (a.rows(), a.cols()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:189:13 [INFO] [stderr] | [INFO] [stderr] 189 | let (m, n) = (a.rows(), a.cols()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:200:13 [INFO] [stderr] | [INFO] [stderr] 200 | let mut x = vec![N::one(); n]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:203:13 [INFO] [stderr] | [INFO] [stderr] 203 | let mut z = N::zero(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:207:13 [INFO] [stderr] | [INFO] [stderr] 207 | let mut u = vec![]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 10th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:219:21 [INFO] [stderr] | [INFO] [stderr] 219 | let mut v = dx; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 10th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:224:21 [INFO] [stderr] | [INFO] [stderr] 224 | let mut v = vec![N::zero(); n + m]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 10th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:244:17 [INFO] [stderr] | [INFO] [stderr] 244 | let mut v = combine_vec_2(&(&a.transpose_view() * &as_cs_vec(&y1, &m_ind)), &x, |v, x| x * v); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 10th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:272:17 [INFO] [stderr] | [INFO] [stderr] 272 | let mut v = comp; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 10th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:294:13 [INFO] [stderr] | [INFO] [stderr] 294 | let mut y; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | v: v, [INFO] [stderr] | ^^^^ help: replace it with: `v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | source_start: source_start, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | target_start: target_start, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `target_start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | target_end: target_end, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `target_end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | target_len: target_len [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `target_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:189:10 [INFO] [stderr] | [INFO] [stderr] 189 | let (m, n) = (a.rows(), a.cols()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:189:13 [INFO] [stderr] | [INFO] [stderr] 189 | let (m, n) = (a.rows(), a.cols()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:200:13 [INFO] [stderr] | [INFO] [stderr] 200 | let mut x = vec![N::one(); n]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:203:13 [INFO] [stderr] | [INFO] [stderr] 203 | let mut z = N::zero(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:207:13 [INFO] [stderr] | [INFO] [stderr] 207 | let mut u = vec![]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 10th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:219:21 [INFO] [stderr] | [INFO] [stderr] 219 | let mut v = dx; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 10th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:224:21 [INFO] [stderr] | [INFO] [stderr] 224 | let mut v = vec![N::zero(); n + m]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 10th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:244:17 [INFO] [stderr] | [INFO] [stderr] 244 | let mut v = combine_vec_2(&(&a.transpose_view() * &as_cs_vec(&y1, &m_ind)), &x, |v, x| x * v); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 10th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:272:17 [INFO] [stderr] | [INFO] [stderr] 272 | let mut v = comp; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 10th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:294:13 [INFO] [stderr] | [INFO] [stderr] 294 | let mut y; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:181:23 [INFO] [stderr] | [INFO] [stderr] 181 | fn eps() -> f32 { 1.1920929e-07 } [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1.192_092_9e-07` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:185:23 [INFO] [stderr] | [INFO] [stderr] 185 | fn eps() -> f64 { 2.220446049250313e-16 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `2.220_446_049_250_313e-16` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/lib.rs:297:35 [INFO] [stderr] | [INFO] [stderr] 297 | let mut lambda = N::one().max((obvalue.abs() / N::from(n).unwrap().sqrt().sqrt())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/lib.rs:297:35 [INFO] [stderr] | [INFO] [stderr] 297 | let mut lambda = N::one().max((obvalue.abs() / N::from(n).unwrap().sqrt().sqrt())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unused import: `sprs::sparse::compressed::SpMatView` [INFO] [stderr] --> src/lib.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use sprs::sparse::compressed::SpMatView; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `One` [INFO] [stderr] --> src/lib.rs:19:11 [INFO] [stderr] | [INFO] [stderr] 19 | use num::{One, Zero, Float}; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `lower` is never read [INFO] [stderr] --> src/lib.rs:373:17 [INFO] [stderr] | [INFO] [stderr] 373 | lower = zhis[iter]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:181:23 [INFO] [stderr] | [INFO] [stderr] 181 | fn eps() -> f32 { 1.1920929e-07 } [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1.192_092_9e-07` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:185:23 [INFO] [stderr] | [INFO] [stderr] 185 | fn eps() -> f64 { 2.220446049250313e-16 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `2.220_446_049_250_313e-16` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/lib.rs:297:35 [INFO] [stderr] | [INFO] [stderr] 297 | let mut lambda = N::one().max((obvalue.abs() / N::from(n).unwrap().sqrt().sqrt())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/lib.rs:297:35 [INFO] [stderr] | [INFO] [stderr] 297 | let mut lambda = N::one().max((obvalue.abs() / N::from(n).unwrap().sqrt().sqrt())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: function is never used: `from_iter` [INFO] [stderr] --> src/lib.rs:121:1 [INFO] [stderr] | [INFO] [stderr] 121 | fn from_iter>(itr: I, len: Option) -> CsVecOwned { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:74:61 [INFO] [stderr] | [INFO] [stderr] 74 | fn at(&self, i: usize) -> N { self.at(i).unwrap_or_else(|| N::zero()) } [INFO] [stderr] | ^^^^^^^^^^^^ help: remove closure as shown: `N::zero` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:94:77 [INFO] [stderr] | [INFO] [stderr] 94 | fn at(&self, i: usize, j: usize) -> N { self.at(&(i, j)).unwrap_or_else(|| N::zero()) } [INFO] [stderr] | ^^^^^^^^^^^^ help: remove closure as shown: `N::zero` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/lib.rs:158:50 [INFO] [stderr] | [INFO] [stderr] 158 | r = r.map(|r| if r < v { r } else { v }).or(Some(v)); [INFO] [stderr] | ^^^^^^^^^^^ help: try this: `or_else(|| Some(v))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/lib.rs:166:50 [INFO] [stderr] | [INFO] [stderr] 166 | r = r.map(|r| if r > v { r } else { v }).or(Some(v)); [INFO] [stderr] | ^^^^^^^^^^^ help: try this: `or_else(|| Some(v))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/lib.rs:181:23 [INFO] [stderr] | [INFO] [stderr] 181 | fn eps() -> f32 { 1.1920929e-07 } [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.192_092_9e-7` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:211:35 [INFO] [stderr] | [INFO] [stderr] 211 | (0..n+1).collect(), [INFO] [stderr] | ^^^^^^^^ help: use: `(0..=n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:305:35 [INFO] [stderr] | [INFO] [stderr] 305 | (0..n+1).collect(), [INFO] [stderr] | ^^^^^^^^ help: use: `(0..=n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: unused import: `sprs::sparse::compressed::SpMatView` [INFO] [stderr] --> src/lib.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use sprs::sparse::compressed::SpMatView; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `One` [INFO] [stderr] --> src/lib.rs:19:11 [INFO] [stderr] | [INFO] [stderr] 19 | use num::{One, Zero, Float}; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `lower` is never read [INFO] [stderr] --> src/lib.rs:373:17 [INFO] [stderr] | [INFO] [stderr] 373 | lower = zhis[iter]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `from_iter` [INFO] [stderr] --> src/lib.rs:121:1 [INFO] [stderr] | [INFO] [stderr] 121 | fn from_iter>(itr: I, len: Option) -> CsVecOwned { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:74:61 [INFO] [stderr] | [INFO] [stderr] 74 | fn at(&self, i: usize) -> N { self.at(i).unwrap_or_else(|| N::zero()) } [INFO] [stderr] | ^^^^^^^^^^^^ help: remove closure as shown: `N::zero` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:94:77 [INFO] [stderr] | [INFO] [stderr] 94 | fn at(&self, i: usize, j: usize) -> N { self.at(&(i, j)).unwrap_or_else(|| N::zero()) } [INFO] [stderr] | ^^^^^^^^^^^^ help: remove closure as shown: `N::zero` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/lib.rs:158:50 [INFO] [stderr] | [INFO] [stderr] 158 | r = r.map(|r| if r < v { r } else { v }).or(Some(v)); [INFO] [stderr] | ^^^^^^^^^^^ help: try this: `or_else(|| Some(v))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/lib.rs:166:50 [INFO] [stderr] | [INFO] [stderr] 166 | r = r.map(|r| if r > v { r } else { v }).or(Some(v)); [INFO] [stderr] | ^^^^^^^^^^^ help: try this: `or_else(|| Some(v))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/lib.rs:181:23 [INFO] [stderr] | [INFO] [stderr] 181 | fn eps() -> f32 { 1.1920929e-07 } [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.192_092_9e-7` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:211:35 [INFO] [stderr] | [INFO] [stderr] 211 | (0..n+1).collect(), [INFO] [stderr] | ^^^^^^^^ help: use: `(0..=n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:305:35 [INFO] [stderr] | [INFO] [stderr] 305 | (0..n+1).collect(), [INFO] [stderr] | ^^^^^^^^ help: use: `(0..=n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.44s [INFO] running `"docker" "inspect" "263f69bd37ebf475fd0130992715937f2cac9b5b111073e835d2c617bcf2fe44"` [INFO] running `"docker" "rm" "-f" "263f69bd37ebf475fd0130992715937f2cac9b5b111073e835d2c617bcf2fe44"` [INFO] [stdout] 263f69bd37ebf475fd0130992715937f2cac9b5b111073e835d2c617bcf2fe44