[INFO] crate const_time_enc 0.1.0 is already in cache [INFO] extracting crate const_time_enc 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/const_time_enc/0.1.0 [INFO] extracting crate const_time_enc 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/const_time_enc/0.1.0 [INFO] validating manifest of const_time_enc-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of const_time_enc-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing const_time_enc-0.1.0 [INFO] finished frobbing const_time_enc-0.1.0 [INFO] frobbed toml for const_time_enc-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/const_time_enc/0.1.0/Cargo.toml [INFO] started frobbing const_time_enc-0.1.0 [INFO] finished frobbing const_time_enc-0.1.0 [INFO] frobbed toml for const_time_enc-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/const_time_enc/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting const_time_enc-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/const_time_enc/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ad2d6b1ad5074e81842eb39a0b849a28cbfac1a1851779d0c4e057dd0efbf710 [INFO] running `"docker" "start" "-a" "ad2d6b1ad5074e81842eb39a0b849a28cbfac1a1851779d0c4e057dd0efbf710"` [INFO] [stderr] Checking const_time_enc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/base64.rs:107:12 [INFO] [stderr] | [INFO] [stderr] 107 | if end_len & 3 == 0 && encoded[end_len - 1] == b'=' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `end_len.trailing_zeros() >= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::verbose_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/base64.rs:107:12 [INFO] [stderr] | [INFO] [stderr] 107 | if end_len & 3 == 0 && encoded[end_len - 1] == b'=' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `end_len.trailing_zeros() >= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::verbose_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/base64.rs:182:22 [INFO] [stderr] | [INFO] [stderr] 182 | .map(|x| encode_base64_char(x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `encode_base64_char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/base64.rs:184:14 [INFO] [stderr] | [INFO] [stderr] 184 | ("ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/" [INFO] [stderr] | ______________^ [INFO] [stderr] 185 | | .as_bytes() [INFO] [stderr] | |___________________________^ help: consider using a byte string literal instead: `b"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.10s [INFO] running `"docker" "inspect" "ad2d6b1ad5074e81842eb39a0b849a28cbfac1a1851779d0c4e057dd0efbf710"` [INFO] running `"docker" "rm" "-f" "ad2d6b1ad5074e81842eb39a0b849a28cbfac1a1851779d0c4e057dd0efbf710"` [INFO] [stdout] ad2d6b1ad5074e81842eb39a0b849a28cbfac1a1851779d0c4e057dd0efbf710