[INFO] crate const-sort 0.1.1 is already in cache [INFO] extracting crate const-sort 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/const-sort/0.1.1 [INFO] extracting crate const-sort 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/const-sort/0.1.1 [INFO] validating manifest of const-sort-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of const-sort-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing const-sort-0.1.1 [INFO] finished frobbing const-sort-0.1.1 [INFO] frobbed toml for const-sort-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/const-sort/0.1.1/Cargo.toml [INFO] started frobbing const-sort-0.1.1 [INFO] finished frobbing const-sort-0.1.1 [INFO] frobbed toml for const-sort-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/const-sort/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting const-sort-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/const-sort/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a794e62f8e4c68adbffdb87c0ecedcef3c6caf064cad769c6456baf5178155a3 [INFO] running `"docker" "start" "-a" "a794e62f8e4c68adbffdb87c0ecedcef3c6caf064cad769c6456baf5178155a3"` [INFO] [stderr] Checking subtle v1.0.0 [INFO] [stderr] Checking const-sort v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:21:17 [INFO] [stderr] | [INFO] [stderr] 21 | let mut r = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:22:17 [INFO] [stderr] | [INFO] [stderr] 22 | let mut d = p; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:26:26 [INFO] [stderr] | [INFO] [stderr] 26 | let (f,l) = v.split_at_mut(1+i); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:26:28 [INFO] [stderr] | [INFO] [stderr] 26 | let (f,l) = v.split_at_mut(1+i); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:21:17 [INFO] [stderr] | [INFO] [stderr] 21 | let mut r = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:22:17 [INFO] [stderr] | [INFO] [stderr] 22 | let mut d = p; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:26:26 [INFO] [stderr] | [INFO] [stderr] 26 | let (f,l) = v.split_at_mut(1+i); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:26:28 [INFO] [stderr] | [INFO] [stderr] 26 | let (f,l) = v.split_at_mut(1+i); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/lib.rs:67:32 [INFO] [stderr] | [INFO] [stderr] 67 | let mut a = [1u8 & (x >> 0), 1u8 & (x >> 1), 1u8 & (x >> 2)]; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:69:27 [INFO] [stderr] | [INFO] [stderr] 69 | let mut ans = a.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `a` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `a`. [INFO] [stderr] --> src/lib.rs:82:22 [INFO] [stderr] | [INFO] [stderr] 82 | for i in 0..7919 { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 82 | for in &mut a { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:86:27 [INFO] [stderr] | [INFO] [stderr] 86 | let mut ans = a.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.54s [INFO] running `"docker" "inspect" "a794e62f8e4c68adbffdb87c0ecedcef3c6caf064cad769c6456baf5178155a3"` [INFO] running `"docker" "rm" "-f" "a794e62f8e4c68adbffdb87c0ecedcef3c6caf064cad769c6456baf5178155a3"` [INFO] [stdout] a794e62f8e4c68adbffdb87c0ecedcef3c6caf064cad769c6456baf5178155a3