[INFO] crate conrod_derive 0.1.2 is already in cache [INFO] extracting crate conrod_derive 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/conrod_derive/0.1.2 [INFO] extracting crate conrod_derive 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/conrod_derive/0.1.2 [INFO] validating manifest of conrod_derive-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of conrod_derive-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing conrod_derive-0.1.2 [INFO] finished frobbing conrod_derive-0.1.2 [INFO] frobbed toml for conrod_derive-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/conrod_derive/0.1.2/Cargo.toml [INFO] started frobbing conrod_derive-0.1.2 [INFO] finished frobbing conrod_derive-0.1.2 [INFO] frobbed toml for conrod_derive-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/conrod_derive/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting conrod_derive-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/conrod_derive/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0e66f78fbcb823653da9485a08d4084eeb5345da65b181da9b64534a18a86503 [INFO] running `"docker" "start" "-a" "0e66f78fbcb823653da9485a08d4084eeb5345da65b181da9b64534a18a86503"` [INFO] [stderr] Checking syn v0.13.11 [INFO] [stderr] Checking conrod_derive v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/style.rs:198:9 [INFO] [stderr] | [INFO] [stderr] 198 | fields: fields, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/style.rs:198:9 [INFO] [stderr] | [INFO] [stderr] 198 | fields: fields, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/style.rs:176:17 [INFO] [stderr] | [INFO] [stderr] 176 | ty [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/style.rs:171:26 [INFO] [stderr] | [INFO] [stderr] 171 | let ty = match angle_bracket_data.args.len() { [INFO] [stderr] | __________________________^ [INFO] [stderr] 172 | | 1 => angle_bracket_data.args.first().unwrap(), [INFO] [stderr] 173 | | _ => return Some(Err(Error::NonOptionFieldTy)), [INFO] [stderr] 174 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/style.rs:176:17 [INFO] [stderr] | [INFO] [stderr] 176 | ty [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/style.rs:171:26 [INFO] [stderr] | [INFO] [stderr] 171 | let ty = match angle_bracket_data.args.len() { [INFO] [stderr] | __________________________^ [INFO] [stderr] 172 | | 1 => angle_bracket_data.args.first().unwrap(), [INFO] [stderr] 173 | | _ => return Some(Err(Error::NonOptionFieldTy)), [INFO] [stderr] 174 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/utils.rs:21:17 [INFO] [stderr] | [INFO] [stderr] 21 | / if let &syn::Meta::List(ref _metalist) = &_meta{ [INFO] [stderr] 22 | | if _metalist.ident == syn::Ident::from("conrod"){ [INFO] [stderr] 23 | | let j = _metalist.nested.clone().into_pairs().map(|pair|pair.into_value()).collect::>(); [INFO] [stderr] 24 | | return Some(j); [INFO] [stderr] 25 | | } [INFO] [stderr] 26 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 21 | if let syn::Meta::List(ref _metalist) = _meta{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/utils.rs:21:17 [INFO] [stderr] | [INFO] [stderr] 21 | / if let &syn::Meta::List(ref _metalist) = &_meta{ [INFO] [stderr] 22 | | if _metalist.ident == syn::Ident::from("conrod"){ [INFO] [stderr] 23 | | let j = _metalist.nested.clone().into_pairs().map(|pair|pair.into_value()).collect::>(); [INFO] [stderr] 24 | | return Some(j); [INFO] [stderr] 25 | | } [INFO] [stderr] 26 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 21 | if let syn::Meta::List(ref _metalist) = _meta{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.27s [INFO] running `"docker" "inspect" "0e66f78fbcb823653da9485a08d4084eeb5345da65b181da9b64534a18a86503"` [INFO] running `"docker" "rm" "-f" "0e66f78fbcb823653da9485a08d4084eeb5345da65b181da9b64534a18a86503"` [INFO] [stdout] 0e66f78fbcb823653da9485a08d4084eeb5345da65b181da9b64534a18a86503