[INFO] crate conrod 0.61.1 is already in cache [INFO] extracting crate conrod 0.61.1 into work/ex/clippy-test-run/sources/stable/reg/conrod/0.61.1 [INFO] extracting crate conrod 0.61.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/conrod/0.61.1 [INFO] validating manifest of conrod-0.61.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of conrod-0.61.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing conrod-0.61.1 [INFO] finished frobbing conrod-0.61.1 [INFO] frobbed toml for conrod-0.61.1 written to work/ex/clippy-test-run/sources/stable/reg/conrod/0.61.1/Cargo.toml [INFO] started frobbing conrod-0.61.1 [INFO] finished frobbing conrod-0.61.1 [INFO] frobbed toml for conrod-0.61.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/conrod/0.61.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting conrod-0.61.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/conrod/0.61.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eb136ae03af86efc345f545ba64e430e33a18bfa9cdcdbe861bd001f8f0ba324 [INFO] running `"docker" "start" "-a" "eb136ae03af86efc345f545ba64e430e33a18bfa9cdcdbe861bd001f8f0ba324"` [INFO] [stderr] Checking daggy v0.5.0 [INFO] [stderr] Compiling num-derive v0.2.4 [INFO] [stderr] Checking rusttype v0.4.3 [INFO] [stderr] Checking rusttype v0.5.2 [INFO] [stderr] Checking pistoncore-input v0.21.0 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking gfx_device_gl v0.15.5 [INFO] [stderr] Checking winit v0.12.0 [INFO] [stderr] Checking piston2d-graphics v0.26.0 [INFO] [stderr] Checking gfx_window_glutin v0.25.0 [INFO] [stderr] Checking pistoncore-window v0.32.0 [INFO] [stderr] Checking conrod v0.61.1 (/opt/crater/workdir) [INFO] [stderr] Checking glutin v0.14.0 [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/color.rs:109:22 [INFO] [stderr] | [INFO] [stderr] 109 | let (h, s, l) = rgb_to_hsl(r, g, b); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/color.rs:109:25 [INFO] [stderr] | [INFO] [stderr] 109 | let (h, s, l) = rgb_to_hsl(r, g, b); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/color.rs:109:28 [INFO] [stderr] | [INFO] [stderr] 109 | let (h, s, l) = rgb_to_hsl(r, g, b); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/color.rs:128:25 [INFO] [stderr] | [INFO] [stderr] 128 | let (r, g, b) = hsl_to_rgb(h, s, l); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/color.rs:128:28 [INFO] [stderr] | [INFO] [stderr] 128 | let (r, g, b) = hsl_to_rgb(h, s, l); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/color.rs:145:22 [INFO] [stderr] | [INFO] [stderr] 145 | let (h, s, l) = rgb_to_hsl(r, g, b); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/color.rs:145:25 [INFO] [stderr] | [INFO] [stderr] 145 | let (h, s, l) = rgb_to_hsl(r, g, b); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/color.rs:145:28 [INFO] [stderr] | [INFO] [stderr] 145 | let (h, s, l) = rgb_to_hsl(r, g, b); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/color.rs:156:22 [INFO] [stderr] | [INFO] [stderr] 156 | let (r, g, b) = hsl_to_rgb(h, s, l); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/color.rs:156:25 [INFO] [stderr] | [INFO] [stderr] 156 | let (r, g, b) = hsl_to_rgb(h, s, l); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/color.rs:156:28 [INFO] [stderr] | [INFO] [stderr] 156 | let (r, g, b) = hsl_to_rgb(h, s, l); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/color.rs:368:9 [INFO] [stderr] | [INFO] [stderr] 368 | let m = lightness - chroma / 2.0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/event.rs:335:13 [INFO] [stderr] | [INFO] [stderr] 335 | motion: motion, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `motion` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/event.rs:366:21 [INFO] [stderr] | [INFO] [stderr] 366 | button: button, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `button` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/event.rs:367:21 [INFO] [stderr] | [INFO] [stderr] 367 | xy: xy, [INFO] [stderr] | ^^^^^^ help: replace it with: `xy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/event.rs:379:21 [INFO] [stderr] | [INFO] [stderr] 379 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/event.rs:403:21 [INFO] [stderr] | [INFO] [stderr] 403 | button: button, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `button` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/event.rs:404:21 [INFO] [stderr] | [INFO] [stderr] 404 | xy: xy, [INFO] [stderr] | ^^^^^^ help: replace it with: `xy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/event.rs:416:21 [INFO] [stderr] | [INFO] [stderr] 416 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph/algo.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | xy: xy, [INFO] [stderr] | ^^^^^^ help: replace it with: `xy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph/mod.rs:636:13 [INFO] [stderr] | [INFO] [stderr] 636 | type_id: type_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `type_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph/mod.rs:637:13 [INFO] [stderr] | [INFO] [stderr] 637 | rect: rect, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph/mod.rs:638:13 [INFO] [stderr] | [INFO] [stderr] 638 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph/mod.rs:639:13 [INFO] [stderr] | [INFO] [stderr] 639 | kid_area: kid_area, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `kid_area` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph/mod.rs:640:13 [INFO] [stderr] | [INFO] [stderr] 640 | maybe_floating: maybe_floating, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `maybe_floating` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph/mod.rs:641:13 [INFO] [stderr] | [INFO] [stderr] 641 | crop_kids: crop_kids, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `crop_kids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph/mod.rs:642:13 [INFO] [stderr] | [INFO] [stderr] 642 | maybe_x_scroll_state: maybe_x_scroll_state, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `maybe_x_scroll_state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph/mod.rs:643:13 [INFO] [stderr] | [INFO] [stderr] 643 | maybe_y_scroll_state: maybe_y_scroll_state, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `maybe_y_scroll_state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph/mod.rs:644:13 [INFO] [stderr] | [INFO] [stderr] 644 | instantiation_order_idx: instantiation_order_idx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instantiation_order_idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph/mod.rs:749:17 [INFO] [stderr] | [INFO] [stderr] 749 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph/mod.rs:750:17 [INFO] [stderr] | [INFO] [stderr] 750 | style: style, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input/widget.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | global: global, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `global` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input/widget.rs:172:13 [INFO] [stderr] | [INFO] [stderr] 172 | rect: rect, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input/widget.rs:173:13 [INFO] [stderr] | [INFO] [stderr] 173 | idx: idx, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input/widget.rs:302:13 [INFO] [stderr] | [INFO] [stderr] 302 | button: button, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `button` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input/widget.rs:349:13 [INFO] [stderr] | [INFO] [stderr] 349 | button: button, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `button` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input/widget.rs:376:13 [INFO] [stderr] | [INFO] [stderr] 376 | button: button, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `button` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input/widget.rs:403:13 [INFO] [stderr] | [INFO] [stderr] 403 | button: button, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `button` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/position/range.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/position/range.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/position/range.rs:430:39 [INFO] [stderr] | [INFO] [stderr] 430 | Range { start: value, end: end } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/position/range.rs:432:25 [INFO] [stderr] | [INFO] [stderr] 432 | Range { start: start, end: value } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/position/range.rs:438:25 [INFO] [stderr] | [INFO] [stderr] 438 | Range { start: start, end: value } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/position/range.rs:440:39 [INFO] [stderr] | [INFO] [stderr] 440 | Range { start: value, end: end } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/position/rect.rs:53:85 [INFO] [stderr] | [INFO] [stderr] 53 | self.x.overlap(other.x).and_then(|x| self.y.overlap(other.y).map(|y| Rect { x: x, y: y })) [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/position/rect.rs:53:91 [INFO] [stderr] | [INFO] [stderr] 53 | self.x.overlap(other.x).and_then(|x| self.y.overlap(other.y).map(|y| Rect { x: x, y: y })) [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:277:43 [INFO] [stderr] | [INFO] [stderr] 277 | let point = text::rt::Point { x: x, y: y }; [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:277:49 [INFO] [stderr] | [INFO] [stderr] 277 | let point = text::rt::Point { x: x, y: y }; [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:299:13 [INFO] [stderr] | [INFO] [stderr] 299 | graph: graph, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `graph` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:300:13 [INFO] [stderr] | [INFO] [stderr] 300 | theme: theme, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `theme` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:301:13 [INFO] [stderr] | [INFO] [stderr] 301 | fonts: fonts, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `fonts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:347:67 [INFO] [stderr] | [INFO] [stderr] 347 | let kind = PrimitiveKind::Rectangle { color: color }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:384:25 [INFO] [stderr] | [INFO] [stderr] 384 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:543:25 [INFO] [stderr] | [INFO] [stderr] 543 | triangles: triangles, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `triangles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:565:25 [INFO] [stderr] | [INFO] [stderr] 565 | triangles: triangles, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `triangles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:590:25 [INFO] [stderr] | [INFO] [stderr] 590 | positioned_glyphs: positioned_glyphs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `positioned_glyphs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:594:25 [INFO] [stderr] | [INFO] [stderr] 594 | font: font, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `font` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:595:25 [INFO] [stderr] | [INFO] [stderr] 595 | font_size: font_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `font_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:596:25 [INFO] [stderr] | [INFO] [stderr] 596 | rect: rect, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:597:25 [INFO] [stderr] | [INFO] [stderr] 597 | justify: justify, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `justify` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:598:25 [INFO] [stderr] | [INFO] [stderr] 598 | y_align: y_align, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `y_align` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:599:25 [INFO] [stderr] | [INFO] [stderr] 599 | line_spacing: line_spacing, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_spacing` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:603:25 [INFO] [stderr] | [INFO] [stderr] 603 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:604:25 [INFO] [stderr] | [INFO] [stderr] 604 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:605:25 [INFO] [stderr] | [INFO] [stderr] 605 | font_id: font_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `font_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:616:25 [INFO] [stderr] | [INFO] [stderr] 616 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:646:17 [INFO] [stderr] | [INFO] [stderr] 646 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:647:17 [INFO] [stderr] | [INFO] [stderr] 647 | rect: rect, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:648:17 [INFO] [stderr] | [INFO] [stderr] 648 | scizzor: scizzor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `scizzor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:649:17 [INFO] [stderr] | [INFO] [stderr] 649 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:655:64 [INFO] [stderr] | [INFO] [stderr] 655 | let kind = OwnedPrimitiveKind::Rectangle { color: color }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:664:25 [INFO] [stderr] | [INFO] [stderr] 664 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:682:25 [INFO] [stderr] | [INFO] [stderr] 682 | image_id: image_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `image_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:683:25 [INFO] [stderr] | [INFO] [stderr] 683 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:684:25 [INFO] [stderr] | [INFO] [stderr] 684 | source_rect: source_rect, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_rect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:720:25 [INFO] [stderr] | [INFO] [stderr] 720 | window_dim: window_dim, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `window_dim` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:722:25 [INFO] [stderr] | [INFO] [stderr] 722 | font_size: font_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `font_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:723:25 [INFO] [stderr] | [INFO] [stderr] 723 | rect: rect, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:724:25 [INFO] [stderr] | [INFO] [stderr] 724 | justify: justify, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `justify` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:725:25 [INFO] [stderr] | [INFO] [stderr] 725 | y_align: y_align, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `y_align` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:726:25 [INFO] [stderr] | [INFO] [stderr] 726 | line_spacing: line_spacing, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_spacing` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:730:25 [INFO] [stderr] | [INFO] [stderr] 730 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:731:25 [INFO] [stderr] | [INFO] [stderr] 731 | font_id: font_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `font_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:744:13 [INFO] [stderr] | [INFO] [stderr] 744 | primitives: primitives, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `primitives` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:747:13 [INFO] [stderr] | [INFO] [stderr] 747 | max_glyphs: max_glyphs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_glyphs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:749:13 [INFO] [stderr] | [INFO] [stderr] 749 | texts_string: texts_string, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `texts_string` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:770:13 [INFO] [stderr] | [INFO] [stderr] 770 | triangles_single_color: triangles_single_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `triangles_single_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:771:13 [INFO] [stderr] | [INFO] [stderr] 771 | triangles_multi_color: triangles_multi_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `triangles_multi_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:772:13 [INFO] [stderr] | [INFO] [stderr] 772 | line_infos: line_infos, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_infos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:795:17 [INFO] [stderr] | [INFO] [stderr] 795 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:796:17 [INFO] [stderr] | [INFO] [stderr] 796 | rect: rect, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:797:17 [INFO] [stderr] | [INFO] [stderr] 797 | scizzor: scizzor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `scizzor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:798:17 [INFO] [stderr] | [INFO] [stderr] 798 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:804:59 [INFO] [stderr] | [INFO] [stderr] 804 | let kind = PrimitiveKind::Rectangle { color: color }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:810:25 [INFO] [stderr] | [INFO] [stderr] 810 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:840:25 [INFO] [stderr] | [INFO] [stderr] 840 | positioned_glyphs: positioned_glyphs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `positioned_glyphs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:841:25 [INFO] [stderr] | [INFO] [stderr] 841 | window_dim: window_dim, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `window_dim` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:843:25 [INFO] [stderr] | [INFO] [stderr] 843 | line_infos: line_infos, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_infos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:844:25 [INFO] [stderr] | [INFO] [stderr] 844 | font: font, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `font` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:845:25 [INFO] [stderr] | [INFO] [stderr] 845 | font_size: font_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `font_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:846:25 [INFO] [stderr] | [INFO] [stderr] 846 | rect: rect, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:847:25 [INFO] [stderr] | [INFO] [stderr] 847 | justify: justify, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `justify` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:848:25 [INFO] [stderr] | [INFO] [stderr] 848 | y_align: y_align, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `y_align` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:849:25 [INFO] [stderr] | [INFO] [stderr] 849 | line_spacing: line_spacing, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_spacing` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:853:25 [INFO] [stderr] | [INFO] [stderr] 853 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:854:25 [INFO] [stderr] | [INFO] [stderr] 854 | font_id: font_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `font_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:855:25 [INFO] [stderr] | [INFO] [stderr] 855 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:862:25 [INFO] [stderr] | [INFO] [stderr] 862 | image_id: image_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `image_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:863:25 [INFO] [stderr] | [INFO] [stderr] 863 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:864:25 [INFO] [stderr] | [INFO] [stderr] 864 | source_rect: source_rect, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_rect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:879:9 [INFO] [stderr] | [INFO] [stderr] 879 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:880:9 [INFO] [stderr] | [INFO] [stderr] 880 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:881:9 [INFO] [stderr] | [INFO] [stderr] 881 | scizzor: scizzor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `scizzor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:882:9 [INFO] [stderr] | [INFO] [stderr] 882 | rect: rect, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | ranges: ranges, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `ranges` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:343:13 [INFO] [stderr] | [INFO] [stderr] 343 | lines_with_rects: lines_with_rects, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lines_with_rects` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:344:13 [INFO] [stderr] | [INFO] [stderr] 344 | font: font, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `font` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:345:13 [INFO] [stderr] | [INFO] [stderr] 345 | font_size: font_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `font_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:380:48 [INFO] [stderr] | [INFO] [stderr] 380 | let point = super::rt::Point { x: x, y: y }; [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:380:54 [INFO] [stderr] | [INFO] [stderr] 380 | let point = super::rt::Point { x: x, y: y }; [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:424:21 [INFO] [stderr] | [INFO] [stderr] 424 | enumerated_rects: enumerated_rects, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `enumerated_rects` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:425:21 [INFO] [stderr] | [INFO] [stderr] 425 | end_char_idx: end_char_idx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `end_char_idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:442:24 [INFO] [stderr] | [INFO] [stderr] 442 | Rect { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:442:30 [INFO] [stderr] | [INFO] [stderr] 442 | Rect { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:550:34 [INFO] [stderr] | [INFO] [stderr] 550 | Some(Index { line: line, char: new_char }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:590:38 [INFO] [stderr] | [INFO] [stderr] 590 | Some(Index { line: line, char: new_char }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:614:38 [INFO] [stderr] | [INFO] [stderr] 614 | Some(Index { line: line, char: new_char }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:648:38 [INFO] [stderr] | [INFO] [stderr] 648 | Some(Index { line: line, char: char + 1 }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:667:45 [INFO] [stderr] | [INFO] [stderr] 667 | return Index { line: i, char: char }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:693:13 [INFO] [stderr] | [INFO] [stderr] 693 | lines_with_rects: lines_with_rects, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lines_with_rects` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:694:13 [INFO] [stderr] | [INFO] [stderr] 694 | font: font, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `font` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:695:13 [INFO] [stderr] | [INFO] [stderr] 695 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:696:13 [INFO] [stderr] | [INFO] [stderr] 696 | font_size: font_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `font_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:840:48 [INFO] [stderr] | [INFO] [stderr] 840 | let point = super::rt::Point { x: x, y: y }; [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:840:54 [INFO] [stderr] | [INFO] [stderr] 840 | let point = super::rt::Point { x: x, y: y }; [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:845:21 [INFO] [stderr] | [INFO] [stderr] 845 | layout: layout, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:1207:52 [INFO] [stderr] | [INFO] [stderr] 1207 | let break_ = Break::Wrap { byte: byte, char: char, len_bytes: 1 }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:1207:64 [INFO] [stderr] | [INFO] [stderr] 1207 | let break_ = Break::Wrap { byte: byte, char: char, len_bytes: 1 }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:1257:13 [INFO] [stderr] | [INFO] [stderr] 1257 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:1258:13 [INFO] [stderr] | [INFO] [stderr] 1258 | font: font, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `font` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:1259:13 [INFO] [stderr] | [INFO] [stderr] 1259 | font_size: font_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `font_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:1260:13 [INFO] [stderr] | [INFO] [stderr] 1260 | max_width: max_width, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:1261:13 [INFO] [stderr] | [INFO] [stderr] 1261 | next_break_fn: next_break_fn, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `next_break_fn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:1321:20 [INFO] [stderr] | [INFO] [stderr] 1321 | Rect { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:1321:26 [INFO] [stderr] | [INFO] [stderr] 1321 | Rect { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:1325:13 [INFO] [stderr] | [INFO] [stderr] 1325 | infos: infos, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `infos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:1327:13 [INFO] [stderr] | [INFO] [stderr] 1327 | x_align: x_align, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `x_align` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:1328:13 [INFO] [stderr] | [INFO] [stderr] 1328 | line_spacing: line_spacing, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_spacing` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:1376:33 [INFO] [stderr] | [INFO] [stderr] 1376 | len_bytes: len_bytes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `len_bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:1382:33 [INFO] [stderr] | [INFO] [stderr] 1382 | len_bytes: len_bytes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `len_bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:1391:25 [INFO] [stderr] | [INFO] [stderr] 1391 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:1426:29 [INFO] [stderr] | [INFO] [stderr] 1426 | end_break: end_break, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `end_break` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:1427:29 [INFO] [stderr] | [INFO] [stderr] 1427 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:1465:28 [INFO] [stderr] | [INFO] [stderr] 1465 | Rect { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text.rs:1465:34 [INFO] [stderr] | [INFO] [stderr] 1465 | Rect { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/theme.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | style: style, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/theme.rs:120:21 [INFO] [stderr] | [INFO] [stderr] 120 | style: style, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/theme.rs:121:21 [INFO] [stderr] | [INFO] [stderr] 121 | common: common, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `common` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | window_dimensions: window_dimensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `window_dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:189:13 [INFO] [stderr] | [INFO] [stderr] 189 | widget_graph: widget_graph, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `widget_graph` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 192 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:200:13 [INFO] [stderr] | [INFO] [stderr] 200 | depth_order: depth_order, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `depth_order` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:201:13 [INFO] [stderr] | [INFO] [stderr] 201 | updated_widgets: updated_widgets, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `updated_widgets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:202:13 [INFO] [stderr] | [INFO] [stderr] 202 | prev_updated_widgets: prev_updated_widgets, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prev_updated_widgets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:308:17 [INFO] [stderr] | [INFO] [stderr] 308 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:309:17 [INFO] [stderr] | [INFO] [stderr] 309 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:623:21 [INFO] [stderr] | [INFO] [stderr] 623 | motion: motion, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `motion` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:649:37 [INFO] [stderr] | [INFO] [stderr] 649 | delta_xy: delta_xy, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `delta_xy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:650:37 [INFO] [stderr] | [INFO] [stderr] 650 | total_delta_xy: total_delta_xy, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_delta_xy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:746:37 [INFO] [stderr] | [INFO] [stderr] 746 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:747:37 [INFO] [stderr] | [INFO] [stderr] 747 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:770:45 [INFO] [stderr] | [INFO] [stderr] 770 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:771:45 [INFO] [stderr] | [INFO] [stderr] 771 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:794:21 [INFO] [stderr] | [INFO] [stderr] 794 | string: string, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `string` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:819:25 [INFO] [stderr] | [INFO] [stderr] 819 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:1218:17 [INFO] [stderr] | [INFO] [stderr] 1218 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:1219:17 [INFO] [stderr] | [INFO] [stderr] 1219 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/id.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | widget_graph: widget_graph, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `widget_graph` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/scroll.rs:218:13 [INFO] [stderr] | [INFO] [stderr] 218 | offset_bounds: offset_bounds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset_bounds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/primitive/line.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/primitive/line.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/primitive/line.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | style: style, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/primitive/image.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | image_id: image_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `image_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/primitive/point_path.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | points: points, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/primitive/point_path.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | style: style, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/primitive/point_path.rs:225:9 [INFO] [stderr] | [INFO] [stderr] 225 | points: points, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/primitive/point_path.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | cap: cap, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/primitive/shape/oval.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | style: style, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/primitive/shape/oval.rs:204:13 [INFO] [stderr] | [INFO] [stderr] 204 | num_points: num_points, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/primitive/shape/oval.rs:208:13 [INFO] [stderr] | [INFO] [stderr] 208 | rad_step: rad_step, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `rad_step` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/primitive/shape/polygon.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | points: points, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/primitive/shape/polygon.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | style: style, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/primitive/shape/polygon.rs:284:9 [INFO] [stderr] | [INFO] [stderr] 284 | first: first, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `first` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/primitive/shape/polygon.rs:285:9 [INFO] [stderr] | [INFO] [stderr] 285 | prev: prev, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `prev` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/primitive/shape/polygon.rs:286:9 [INFO] [stderr] | [INFO] [stderr] 286 | points: points, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/primitive/shape/rectangle.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | style: style, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/primitive/shape/triangles.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | style: style, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/primitive/shape/triangles.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | triangles: triangles, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `triangles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/primitive/shape/triangles.rs:241:13 [INFO] [stderr] | [INFO] [stderr] 241 | triangles: triangles, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `triangles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/widget/primitive/shape/triangles.rs:433:16 [INFO] [stderr] | [INFO] [stderr] 433 | let (a, b, c) = (ps[0], ps[1], ps[2]); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/primitive/text.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/button.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | image_id: image_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `image_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/button.rs:233:13 [INFO] [stderr] | [INFO] [stderr] 233 | show: show, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `show` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/canvas.rs:274:17 [INFO] [stderr] | [INFO] [stderr] 274 | rect: rect, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/collapsible_area.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | is_open: is_open, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `is_open` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/collapsible_area.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/widget/collapsible_area.rs:179:17 [INFO] [stderr] | [INFO] [stderr] 179 | let c = [triangle_x - side_offset, triangle_y + point_offset]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/widget/collapsible_area.rs:184:17 [INFO] [stderr] | [INFO] [stderr] 184 | let c = [triangle_x - point_offset, triangle_y - side_offset]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/drop_down_list.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | items: items, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `items` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/drop_down_list.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | selected: selected, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `selected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/envelope_editor.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | env: env, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/envelope_editor.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | min_x: min_x, max_x: max_x, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `min_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/envelope_editor.rs:132:27 [INFO] [stderr] | [INFO] [stderr] 132 | min_x: min_x, max_x: max_x, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `max_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/envelope_editor.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | min_y: min_y, max_y: max_y, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `min_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/envelope_editor.rs:133:27 [INFO] [stderr] | [INFO] [stderr] 133 | min_y: min_y, max_y: max_y, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `max_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/file_navigator/directory_view.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | directory: directory, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/file_navigator/directory_view.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | types: types, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `types` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/file_navigator/mod.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | starting_directory: starting_directory, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `starting_directory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/file_navigator/mod.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | types: types, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `types` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/file_navigator/mod.rs:220:39 [INFO] [stderr] | [INFO] [stderr] 220 | let dir = Directory { path: path, column_width: width }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/file_navigator/mod.rs:373:67 [INFO] [stderr] | [INFO] [stderr] 373 | let dir = Directory { path: path.clone(), column_width: column_width }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `column_width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/grid.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | step: step, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `step` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/grid.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | min_x: min_x, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `min_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/grid.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | max_x: max_x, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `max_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/grid.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | min_y: min_y, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `min_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/grid.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | max_y: max_y, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `max_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | num_items: num_items, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_items` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list.rs:254:13 [INFO] [stderr] | [INFO] [stderr] 254 | item_size: item_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `item_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list.rs:265:13 [INFO] [stderr] | [INFO] [stderr] 265 | common: common, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `common` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list.rs:266:13 [INFO] [stderr] | [INFO] [stderr] 266 | style: style, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list.rs:267:13 [INFO] [stderr] | [INFO] [stderr] 267 | num_items: num_items, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_items` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list.rs:269:32 [INFO] [stderr] | [INFO] [stderr] 269 | item_size: Fixed { length: length }, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list.rs:395:21 [INFO] [stderr] | [INFO] [stderr] 395 | i: i, [INFO] [stderr] | ^^^^ help: replace it with: `i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list.rs:398:21 [INFO] [stderr] | [INFO] [stderr] 398 | scroll_trigger_id: scroll_trigger_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `scroll_trigger_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list.rs:401:21 [INFO] [stderr] | [INFO] [stderr] 401 | first_item_margin: first_item_margin, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `first_item_margin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list.rs:602:13 [INFO] [stderr] | [INFO] [stderr] 602 | item_breadth: item_breadth, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `item_breadth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list.rs:604:13 [INFO] [stderr] | [INFO] [stderr] 604 | first_item_margin: first_item_margin, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `first_item_margin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list.rs:605:13 [INFO] [stderr] | [INFO] [stderr] 605 | item_size: item_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `item_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list.rs:680:13 [INFO] [stderr] | [INFO] [stderr] 680 | item_breadth: item_breadth, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `item_breadth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list.rs:682:13 [INFO] [stderr] | [INFO] [stderr] 682 | first_item_margin: first_item_margin, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `first_item_margin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list.rs:683:13 [INFO] [stderr] | [INFO] [stderr] 683 | item_size: item_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `item_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list_select.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | common: common, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `common` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list_select.rs:200:13 [INFO] [stderr] | [INFO] [stderr] 200 | num_items: num_items, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_items` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list_select.rs:201:13 [INFO] [stderr] | [INFO] [stderr] 201 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list_select.rs:203:13 [INFO] [stderr] | [INFO] [stderr] 203 | item_size: item_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `item_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list_select.rs:204:13 [INFO] [stderr] | [INFO] [stderr] 204 | style: style, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list_select.rs:205:13 [INFO] [stderr] | [INFO] [stderr] 205 | item_instantiation: item_instantiation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `item_instantiation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list_select.rs:213:13 [INFO] [stderr] | [INFO] [stderr] 213 | common: common, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `common` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list_select.rs:214:13 [INFO] [stderr] | [INFO] [stderr] 214 | num_items: num_items, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_items` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list_select.rs:215:13 [INFO] [stderr] | [INFO] [stderr] 215 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list_select.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | item_size: item_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `item_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list_select.rs:218:13 [INFO] [stderr] | [INFO] [stderr] 218 | style: style, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list_select.rs:219:13 [INFO] [stderr] | [INFO] [stderr] 219 | item_instantiation: item_instantiation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `item_instantiation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list_select.rs:227:13 [INFO] [stderr] | [INFO] [stderr] 227 | common: common, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `common` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list_select.rs:228:13 [INFO] [stderr] | [INFO] [stderr] 228 | num_items: num_items, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_items` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list_select.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list_select.rs:231:13 [INFO] [stderr] | [INFO] [stderr] 231 | item_size: item_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `item_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list_select.rs:232:13 [INFO] [stderr] | [INFO] [stderr] 232 | style: style, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list_select.rs:233:13 [INFO] [stderr] | [INFO] [stderr] 233 | item_instantiation: item_instantiation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `item_instantiation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list_select.rs:241:13 [INFO] [stderr] | [INFO] [stderr] 241 | common: common, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `common` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list_select.rs:242:13 [INFO] [stderr] | [INFO] [stderr] 242 | num_items: num_items, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_items` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list_select.rs:243:13 [INFO] [stderr] | [INFO] [stderr] 243 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list_select.rs:245:13 [INFO] [stderr] | [INFO] [stderr] 245 | item_size: item_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `item_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list_select.rs:246:13 [INFO] [stderr] | [INFO] [stderr] 246 | style: style, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list_select.rs:247:13 [INFO] [stderr] | [INFO] [stderr] 247 | item_instantiation: item_instantiation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `item_instantiation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list_select.rs:257:13 [INFO] [stderr] | [INFO] [stderr] 257 | common: common, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `common` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list_select.rs:258:13 [INFO] [stderr] | [INFO] [stderr] 258 | num_items: num_items, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_items` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list_select.rs:259:13 [INFO] [stderr] | [INFO] [stderr] 259 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list_select.rs:260:13 [INFO] [stderr] | [INFO] [stderr] 260 | direction: direction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list_select.rs:262:13 [INFO] [stderr] | [INFO] [stderr] 262 | style: style, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list_select.rs:261:46 [INFO] [stderr] | [INFO] [stderr] 261 | item_size: widget::list::Fixed { length: length }, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list_select.rs:279:13 [INFO] [stderr] | [INFO] [stderr] 279 | num_items: num_items, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_items` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list_select.rs:281:13 [INFO] [stderr] | [INFO] [stderr] 281 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list_select.rs:395:13 [INFO] [stderr] | [INFO] [stderr] 395 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list_select.rs:396:13 [INFO] [stderr] | [INFO] [stderr] 396 | items: items, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `items` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list_select.rs:397:13 [INFO] [stderr] | [INFO] [stderr] 397 | num_items: num_items, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_items` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/list_select.rs:398:13 [INFO] [stderr] | [INFO] [stderr] 398 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/matrix.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | cols: cols, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cols` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/matrix.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | rows: rows, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rows` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/matrix.rs:174:13 [INFO] [stderr] | [INFO] [stderr] 174 | x_min: x_min, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `x_min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/matrix.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | x_max: x_max, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `x_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/matrix.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | y_min: y_min, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `y_min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/matrix.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | y_max: y_max, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `y_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/matrix.rs:226:13 [INFO] [stderr] | [INFO] [stderr] 226 | widget_id: widget_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `widget_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/matrix.rs:227:13 [INFO] [stderr] | [INFO] [stderr] 227 | matrix_id: matrix_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `matrix_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/matrix.rs:232:13 [INFO] [stderr] | [INFO] [stderr] 232 | rel_x: rel_x, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `rel_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/matrix.rs:233:13 [INFO] [stderr] | [INFO] [stderr] 233 | rel_y: rel_y, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `rel_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/graph/mod.rs:563:25 [INFO] [stderr] | [INFO] [stderr] 563 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/graph/mod.rs:564:25 [INFO] [stderr] | [INFO] [stderr] 564 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/graph/mod.rs:781:13 [INFO] [stderr] | [INFO] [stderr] 781 | layout: layout, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/number_dialer.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | min: min, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/number_dialer.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | max: max, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/number_dialer.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | precision: precision, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `precision` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/plot_path.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | min_x: min_x, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `min_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/plot_path.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | max_x: max_x, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `max_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/plot_path.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | min_y: min_y, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `min_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/plot_path.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | max_y: max_y, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `max_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/plot_path.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | f: f, [INFO] [stderr] | ^^^^ help: replace it with: `f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/range_slider.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/range_slider.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/range_slider.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | min: min, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/range_slider.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | max: max, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/rounded_rectangle.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | style: style, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/rounded_rectangle.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | radius: radius, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/scrollbar.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | widget: widget, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `widget` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/slider.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/slider.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | min: min, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/slider.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | max: max, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/slider.rs:187:67 [INFO] [stderr] | [INFO] [stderr] 187 | let slider_rect = Rect { x: Range::new(left, slider), y: y }; [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/slider.rs:188:67 [INFO] [stderr] | [INFO] [stderr] 188 | let blank_rect = Rect { x: Range::new(slider, right), y: y }; [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/slider.rs:195:38 [INFO] [stderr] | [INFO] [stderr] 195 | let slider_rect = Rect { x: x, y: Range::new(bottom, slider) }; [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/slider.rs:196:37 [INFO] [stderr] | [INFO] [stderr] 196 | let blank_rect = Rect { x: x, y: Range::new(slider, top) }; [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/tabs.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | tabs: tabs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tabs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/tabs.rs:254:25 [INFO] [stderr] | [INFO] [stderr] 254 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/tabs.rs:430:13 [INFO] [stderr] | [INFO] [stderr] 430 | tab_dim: tab_dim, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `tab_dim` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/tabs.rs:432:13 [INFO] [stderr] | [INFO] [stderr] 432 | xy_step: xy_step, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `xy_step` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/text_box.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/text_box.rs:146:20 [INFO] [stderr] | [INFO] [stderr] 146 | Rect { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/text_box.rs:146:26 [INFO] [stderr] | [INFO] [stderr] 146 | Rect { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/text_edit.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/text_edit.rs:610:62 [INFO] [stderr] | [INFO] [stderr] 610 | cursor = Cursor::Selection { start: start, end: end }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/text_edit.rs:610:76 [INFO] [stderr] | [INFO] [stderr] 610 | cursor = Cursor::Selection { start: start, end: end }; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/text_edit.rs:622:84 [INFO] [stderr] | [INFO] [stderr] 622 | let new_cursor_idx = text::cursor::Index { line: line, char: char }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/text_edit.rs:622:96 [INFO] [stderr] | [INFO] [stderr] 622 | let new_cursor_idx = text::cursor::Index { line: line, char: char }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/text_edit.rs:638:76 [INFO] [stderr] | [INFO] [stderr] 638 | let new_cursor_idx = text::cursor::Index { line: line, char: char }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/text_edit.rs:638:88 [INFO] [stderr] | [INFO] [stderr] 638 | let new_cursor_idx = text::cursor::Index { line: line, char: char }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/text_edit.rs:651:76 [INFO] [stderr] | [INFO] [stderr] 651 | let new_cursor_idx = text::cursor::Index { line: line, char: char }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/text_edit.rs:651:88 [INFO] [stderr] | [INFO] [stderr] 651 | let new_cursor_idx = text::cursor::Index { line: line, char: char }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/title_bar.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | label: label, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/toggle.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/xy_pad.rs:87:23 [INFO] [stderr] | [INFO] [stderr] 87 | x: x_val, min_x: min_x, max_x: max_x, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `min_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/xy_pad.rs:87:37 [INFO] [stderr] | [INFO] [stderr] 87 | x: x_val, min_x: min_x, max_x: max_x, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `max_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/xy_pad.rs:88:23 [INFO] [stderr] | [INFO] [stderr] 88 | y: y_val, min_y: min_y, max_y: max_y, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `min_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/xy_pad.rs:88:37 [INFO] [stderr] | [INFO] [stderr] 88 | y: y_val, min_y: min_y, max_y: max_y, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `max_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/mod.rs:928:21 [INFO] [stderr] | [INFO] [stderr] 928 | rect: rect, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/mod.rs:929:21 [INFO] [stderr] | [INFO] [stderr] 929 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/mod.rs:930:21 [INFO] [stderr] | [INFO] [stderr] 930 | maybe_floating: maybe_floating, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `maybe_floating` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/mod.rs:931:21 [INFO] [stderr] | [INFO] [stderr] 931 | kid_area: kid_area, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `kid_area` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/mod.rs:932:21 [INFO] [stderr] | [INFO] [stderr] 932 | maybe_x_scroll_state: maybe_x_scroll_state, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `maybe_x_scroll_state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/mod.rs:933:21 [INFO] [stderr] | [INFO] [stderr] 933 | maybe_y_scroll_state: maybe_y_scroll_state, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `maybe_y_scroll_state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/mod.rs:1020:13 [INFO] [stderr] | [INFO] [stderr] 1020 | rect: rect, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/mod.rs:1085:13 [INFO] [stderr] | [INFO] [stderr] 1085 | type_id: type_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `type_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/mod.rs:1086:13 [INFO] [stderr] | [INFO] [stderr] 1086 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/mod.rs:1087:13 [INFO] [stderr] | [INFO] [stderr] 1087 | maybe_parent_id: maybe_parent_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `maybe_parent_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/mod.rs:1088:13 [INFO] [stderr] | [INFO] [stderr] 1088 | maybe_x_positioned_relatively_id: maybe_x_positioned_relatively_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `maybe_x_positioned_relatively_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/mod.rs:1089:13 [INFO] [stderr] | [INFO] [stderr] 1089 | maybe_y_positioned_relatively_id: maybe_y_positioned_relatively_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `maybe_y_positioned_relatively_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/mod.rs:1090:13 [INFO] [stderr] | [INFO] [stderr] 1090 | rect: rect, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/mod.rs:1091:13 [INFO] [stderr] | [INFO] [stderr] 1091 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/mod.rs:1092:13 [INFO] [stderr] | [INFO] [stderr] 1092 | kid_area: kid_area, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `kid_area` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/mod.rs:1093:13 [INFO] [stderr] | [INFO] [stderr] 1093 | maybe_floating: maybe_floating, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `maybe_floating` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/mod.rs:1094:13 [INFO] [stderr] | [INFO] [stderr] 1094 | crop_kids: crop_kids, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `crop_kids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/mod.rs:1095:13 [INFO] [stderr] | [INFO] [stderr] 1095 | maybe_y_scroll_state: maybe_y_scroll_state, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `maybe_y_scroll_state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/mod.rs:1096:13 [INFO] [stderr] | [INFO] [stderr] 1096 | maybe_x_scroll_state: maybe_x_scroll_state, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `maybe_x_scroll_state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/mod.rs:1105:9 [INFO] [stderr] | [INFO] [stderr] 1105 | rect: rect, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/mod.rs:1106:9 [INFO] [stderr] | [INFO] [stderr] 1106 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/mod.rs:1107:9 [INFO] [stderr] | [INFO] [stderr] 1107 | maybe_floating: maybe_floating, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `maybe_floating` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/mod.rs:1108:9 [INFO] [stderr] | [INFO] [stderr] 1108 | kid_area: kid_area, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `kid_area` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/mod.rs:1109:9 [INFO] [stderr] | [INFO] [stderr] 1109 | maybe_x_scroll_state: maybe_x_scroll_state, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `maybe_x_scroll_state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/mod.rs:1110:9 [INFO] [stderr] | [INFO] [stderr] 1110 | maybe_y_scroll_state: maybe_y_scroll_state, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `maybe_y_scroll_state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/mod.rs:1131:17 [INFO] [stderr] | [INFO] [stderr] 1131 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/mod.rs:1132:17 [INFO] [stderr] | [INFO] [stderr] 1132 | maybe_parent_id: maybe_parent_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `maybe_parent_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/mod.rs:1135:17 [INFO] [stderr] | [INFO] [stderr] 1135 | rect: rect, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/mod.rs:1137:17 [INFO] [stderr] | [INFO] [stderr] 1137 | ui: ui, [INFO] [stderr] | ^^^^^^ help: replace it with: `ui` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/mod.rs:1173:9 [INFO] [stderr] | [INFO] [stderr] 1173 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/widget/mod.rs:1174:9 [INFO] [stderr] | [INFO] [stderr] 1174 | maybe_parent_id: maybe_parent_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `maybe_parent_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking pistoncore-event_loop v0.37.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.47.0 [INFO] [stderr] Checking piston v0.37.0 [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/position/range.rs:436:16 [INFO] [stderr] | [INFO] [stderr] 436 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 437 | | if value < end { [INFO] [stderr] 438 | | Range { start: start, end: value } [INFO] [stderr] 439 | | } else if value > start { [INFO] [stderr] ... | [INFO] [stderr] 443 | | } [INFO] [stderr] 444 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 436 | } else if value < end { [INFO] [stderr] 437 | Range { start: start, end: value } [INFO] [stderr] 438 | } else if value > start { [INFO] [stderr] 439 | Range { start: value, end: end } [INFO] [stderr] 440 | } else { [INFO] [stderr] 441 | self [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ui.rs:700:53 [INFO] [stderr] | [INFO] [stderr] 700 | (a - b).abs() < 0.000001 [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/utils.rs:27:12 [INFO] [stderr] | [INFO] [stderr] 27 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 28 | | if n < end { end } else if n > start { start } else { n } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ help: try: `if n < end { end } else if n > start { start } else { n }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/widget/file_navigator/directory_view.rs:135:30 [INFO] [stderr] | [INFO] [stderr] 135 | super::Types::All => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/widget/file_navigator/directory_view.rs:148:17 [INFO] [stderr] | [INFO] [stderr] 148 | return true [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/widget/file_navigator/directory_view.rs:150:17 [INFO] [stderr] | [INFO] [stderr] 150 | return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/widget/file_navigator/directory_view.rs:153:38 [INFO] [stderr] | [INFO] [stderr] 153 | super::Types::Directories => return path.is_dir(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `path.is_dir()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/widget/file_navigator/mod.rs:344:54 [INFO] [stderr] | [INFO] [stderr] 344 | input::Key::Right => if paths.len() == 1 { [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 345 | | if paths[0].is_dir() { [INFO] [stderr] 346 | | // TODO: Select top child of this dir and give keyboard [INFO] [stderr] 347 | | // capturing to newly selected child. [INFO] [stderr] 348 | | } [INFO] [stderr] 349 | | }, [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 344 | input::Key::Right => if paths.len() == 1 && paths[0].is_dir() { [INFO] [stderr] 345 | // TODO: Select top child of this dir and give keyboard [INFO] [stderr] 346 | // capturing to newly selected child. [INFO] [stderr] 347 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/widget/matrix.rs:180:9 [INFO] [stderr] | [INFO] [stderr] 180 | elements [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/widget/matrix.rs:166:24 [INFO] [stderr] | [INFO] [stderr] 166 | let elements = Elements { [INFO] [stderr] | ________________________^ [INFO] [stderr] 167 | | num_rows: rows, [INFO] [stderr] 168 | | num_cols: cols, [INFO] [stderr] 169 | | row: 0, [INFO] [stderr] ... | [INFO] [stderr] 177 | | y_max: y_max, [INFO] [stderr] 178 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/widget/graph/node.rs:307:5 [INFO] [stderr] | [INFO] [stderr] 307 | rect [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/widget/graph/node.rs:306:16 [INFO] [stderr] | [INFO] [stderr] 306 | let rect = Rect::from_xy_dim(xy, socket_dim); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/widget/graph/mod.rs:214:9 [INFO] [stderr] | [INFO] [stderr] 214 | widget_id [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/widget/graph/mod.rs:213:25 [INFO] [stderr] | [INFO] [stderr] 213 | let widget_id = type_widget_ids.next_id(generator); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/widget/number_dialer.rs:130:5 [INFO] [stderr] | [INFO] [stderr] 130 | val_string_w [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/widget/number_dialer.rs:129:24 [INFO] [stderr] | [INFO] [stderr] 129 | let val_string_w = slot_w * val_string.len() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/widget/range_slider.rs:203:13 [INFO] [stderr] | [INFO] [stderr] 203 | unskewed_and_unnormalised [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/widget/range_slider.rs:202:45 [INFO] [stderr] | [INFO] [stderr] 202 | let unskewed_and_unnormalised = unskew_and_unnormalise_value(f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] Checking piston-gfx_texture v0.32.0 [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | Color::Rgba(r as f32 / 255.0, g as f32 / 255.0, b as f32 / 255.0, a) [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:49:35 [INFO] [stderr] | [INFO] [stderr] 49 | Color::Rgba(r as f32 / 255.0, g as f32 / 255.0, b as f32 / 255.0, a) [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:49:53 [INFO] [stderr] | [INFO] [stderr] 49 | Color::Rgba(r as f32 / 255.0, g as f32 / 255.0, b as f32 / 255.0, a) [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/color.rs:341:33 [INFO] [stderr] | [INFO] [stderr] 341 | degrees(60.0) * if c_max == r { fmod((g - b) / c, 6) } [INFO] [stderr] | ^^^^^^^^^^ help: consider comparing them within some error: `(c_max - r).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/color.rs:341:33 [INFO] [stderr] | [INFO] [stderr] 341 | degrees(60.0) * if c_max == r { fmod((g - b) / c, 6) } [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/color.rs:342:33 [INFO] [stderr] | [INFO] [stderr] 342 | else if c_max == g { ((b - r) / c) + 2.0 } [INFO] [stderr] | ^^^^^^^^^^ help: consider comparing them within some error: `(c_max - g).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/color.rs:342:33 [INFO] [stderr] | [INFO] [stderr] 342 | else if c_max == g { ((b - r) / c) + 2.0 } [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/graph/algo.rs:234:34 [INFO] [stderr] | [INFO] [stderr] 234 | let is_not_graphic_kid = !g.graphic_parent(n).is_some(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `g.graphic_parent(n).is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `graph::depth_order::DepthOrder` [INFO] [stderr] --> src/graph/depth_order.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new() -> DepthOrder { [INFO] [stderr] 24 | | DepthOrder { [INFO] [stderr] 25 | | indices: Vec::new(), [INFO] [stderr] 26 | | floating: Vec::new(), [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/graph/depth_order.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | / match graph.widget(idx).is_some() && updated_widgets.contains(&idx) { [INFO] [stderr] 101 | | true => depth_order.push(idx), [INFO] [stderr] 102 | | // If the current node is not an updated widget, we're done with this branch. [INFO] [stderr] 103 | | false => return, [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if graph.widget(idx).is_some() && updated_widgets.contains(&idx) { depth_order.push(idx) } else { return }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/graph/mod.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | Widget(Container), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 118 | Widget(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `graph::Graph` [INFO] [stderr] --> src/graph/mod.rs:201:5 [INFO] [stderr] | [INFO] [stderr] 201 | / pub fn new() -> Self { [INFO] [stderr] 202 | | Graph { [INFO] [stderr] 203 | | dag: Dag::new(), [INFO] [stderr] 204 | | } [INFO] [stderr] 205 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 198 | impl Default for graph::Graph { [INFO] [stderr] 199 | fn default() -> Self { [INFO] [stderr] 200 | Self::new() [INFO] [stderr] 201 | } [INFO] [stderr] 202 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/graph/mod.rs:655:32 [INFO] [stderr] | [INFO] [stderr] 655 | Some(parent_id) => match graph.node(parent_id).is_some() { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 656 | | true => Some(parent_id), [INFO] [stderr] 657 | | false => panic!("No node found for the given parent widget::Id {:?}", parent_id), [INFO] [stderr] 658 | | }, [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if graph.node(parent_id).is_some() { Some(parent_id) } else { panic!("No node found for the given parent widget::Id {:?}", parent_id) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/graph/mod.rs:796:5 [INFO] [stderr] | [INFO] [stderr] 796 | / fn index<'a>(&'a self, id: widget::Id) -> &'a Node { [INFO] [stderr] 797 | | self.node(id).unwrap() [INFO] [stderr] 798 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/graph/mod.rs:802:5 [INFO] [stderr] | [INFO] [stderr] 802 | / fn index_mut<'a>(&'a mut self, id: widget::Id) -> &'a mut Node { [INFO] [stderr] 803 | | self.node_mut(id).unwrap() [INFO] [stderr] 804 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/graph/mod.rs:809:5 [INFO] [stderr] | [INFO] [stderr] 809 | / fn index<'a>(&'a self, idx: EdgeIndex) -> &'a Edge { [INFO] [stderr] 810 | | self.edge(idx).unwrap() [INFO] [stderr] 811 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/graph/mod.rs:815:5 [INFO] [stderr] | [INFO] [stderr] 815 | / fn index_mut<'a>(&'a mut self, idx: EdgeIndex) -> &'a mut Edge { [INFO] [stderr] 816 | | self.edge_mut(idx).unwrap() [INFO] [stderr] 817 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `image::Map` [INFO] [stderr] --> src/image.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | / pub fn new() -> Self { [INFO] [stderr] 59 | | Map { [INFO] [stderr] 60 | | next_index: 0, [INFO] [stderr] 61 | | map: HashMap::::default(), [INFO] [stderr] 62 | | trigger_redraw: std::cell::Cell::new(true), [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/image.rs:129:37 [INFO] [stderr] | [INFO] [stderr] 129 | self.index_range.next().map(|i| Id(i)) [INFO] [stderr] | ^^^^^^^^^ help: remove closure as shown: `Id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `input::state::State` [INFO] [stderr] --> src/input/state.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | / pub fn new() -> State { [INFO] [stderr] 47 | | State{ [INFO] [stderr] 48 | | touch: fnv::FnvHashMap::default(), [INFO] [stderr] 49 | | mouse: Mouse::new(), [INFO] [stderr] ... | [INFO] [stderr] 54 | | } [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 43 | impl Default for input::state::State { [INFO] [stderr] 44 | fn default() -> Self { [INFO] [stderr] 45 | Self::new() [INFO] [stderr] 46 | } [INFO] [stderr] 47 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `input::state::mouse::Mouse` [INFO] [stderr] --> src/input/state.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | / pub fn new() -> Self { [INFO] [stderr] 149 | | Mouse { [INFO] [stderr] 150 | | buttons: ButtonMap::new(), [INFO] [stderr] 151 | | xy: [0.0, 0.0], [INFO] [stderr] 152 | | } [INFO] [stderr] 153 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 146 | impl Default for input::state::mouse::Mouse { [INFO] [stderr] 147 | fn default() -> Self { [INFO] [stderr] 148 | Self::new() [INFO] [stderr] 149 | } [INFO] [stderr] 150 | } [INFO] [stderr] 151 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `input::state::mouse::ButtonMap` [INFO] [stderr] --> src/input/state.rs:205:9 [INFO] [stderr] | [INFO] [stderr] 205 | / pub fn new() -> Self { [INFO] [stderr] 206 | | ButtonMap{ [INFO] [stderr] 207 | | buttons: [ButtonPosition::Up; NUM_BUTTONS] [INFO] [stderr] 208 | | } [INFO] [stderr] 209 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 202 | impl Default for input::state::mouse::ButtonMap { [INFO] [stderr] 203 | fn default() -> Self { [INFO] [stderr] 204 | Self::new() [INFO] [stderr] 205 | } [INFO] [stderr] 206 | } [INFO] [stderr] 207 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `input::global::Global` [INFO] [stderr] --> src/input/global.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / pub fn new() -> Global { [INFO] [stderr] 43 | | Global{ [INFO] [stderr] 44 | | events: Vec::new(), [INFO] [stderr] 45 | | start: input::State::new(), [INFO] [stderr] ... | [INFO] [stderr] 48 | | } [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 39 | impl Default for input::global::Global { [INFO] [stderr] 40 | fn default() -> Self { [INFO] [stderr] 41 | Self::new() [INFO] [stderr] 42 | } [INFO] [stderr] 43 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: item `position::range::Range` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/position/range.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | / impl Range { [INFO] [stderr] 30 | | [INFO] [stderr] 31 | | /// Construct a new `Range` from a given range, i.e. `Range::new(start, end)`. [INFO] [stderr] 32 | | /// [INFO] [stderr] ... | [INFO] [stderr] 628 | | [INFO] [stderr] 629 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `position::rect::Rect` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/position/rect.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | / impl Rect { [INFO] [stderr] 32 | | [INFO] [stderr] 33 | | /// Construct a Rect from a given `Point` and `Dimensions`. [INFO] [stderr] 34 | | pub fn from_xy_dim(xy: Point, dim: Dimensions) -> Self { [INFO] [stderr] ... | [INFO] [stderr] 408 | | [INFO] [stderr] 409 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/position/mod.rs:712:40 [INFO] [stderr] | [INFO] [stderr] 712 | self.x_dimension(Dimension::Of(idx.into(), None)) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `idx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/position/mod.rs:718:40 [INFO] [stderr] | [INFO] [stderr] 718 | self.x_dimension(Dimension::Of(idx.into(), Some(pad))) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/position/mod.rs:723:40 [INFO] [stderr] | [INFO] [stderr] 723 | self.y_dimension(Dimension::Of(idx.into(), None)) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/position/mod.rs:729:40 [INFO] [stderr] | [INFO] [stderr] 729 | self.y_dimension(Dimension::Of(idx.into(), Some(pad))) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/position/mod.rs:745:47 [INFO] [stderr] | [INFO] [stderr] 745 | self.x_dimension(Dimension::KidAreaOf(idx.into(), None)) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/position/mod.rs:751:47 [INFO] [stderr] | [INFO] [stderr] 751 | self.x_dimension(Dimension::KidAreaOf(idx.into(), Some(pad))) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/position/mod.rs:756:47 [INFO] [stderr] | [INFO] [stderr] 756 | self.y_dimension(Dimension::KidAreaOf(idx.into(), None)) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/position/mod.rs:762:47 [INFO] [stderr] | [INFO] [stderr] 762 | self.y_dimension(Dimension::KidAreaOf(idx.into(), Some(pad))) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:263:63 [INFO] [stderr] | [INFO] [stderr] 263 | let trans_x = |x: Scalar| (x + window_dim[0] / 2.0) * dpi_factor as Scalar; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(dpi_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:264:66 [INFO] [stderr] | [INFO] [stderr] 264 | let trans_y = |y: Scalar| ((-y) + window_dim[1] / 2.0) * dpi_factor as Scalar; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(dpi_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/render.rs:309:5 [INFO] [stderr] | [INFO] [stderr] 309 | / pub fn next(&mut self) -> Option { [INFO] [stderr] 310 | | let Primitives { [INFO] [stderr] 311 | | ref mut crop_stack, [INFO] [stderr] 312 | | ref mut depth_order, [INFO] [stderr] ... | [INFO] [stderr] 630 | | None [INFO] [stderr] 631 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/render.rs:309:5 [INFO] [stderr] | [INFO] [stderr] 309 | / pub fn next(&mut self) -> Option { [INFO] [stderr] 310 | | let Primitives { [INFO] [stderr] 311 | | ref mut crop_stack, [INFO] [stderr] 312 | | ref mut depth_order, [INFO] [stderr] ... | [INFO] [stderr] 630 | | None [INFO] [stderr] 631 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/render.rs:555:34 [INFO] [stderr] | [INFO] [stderr] 555 | let points = state.points.iter().map(|&t| t); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `state.points.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/render.rs:783:5 [INFO] [stderr] | [INFO] [stderr] 783 | / pub fn next(&mut self) -> Option { [INFO] [stderr] 784 | | let WalkOwnedPrimitives { [INFO] [stderr] 785 | | ref mut primitives, [INFO] [stderr] 786 | | ref mut positioned_glyphs, [INFO] [stderr] ... | [INFO] [stderr] 869 | | }) [INFO] [stderr] 870 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/render.rs:893:27 [INFO] [stderr] | [INFO] [stderr] 893 | while let Some(&id) = depth_order.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `for &id in depth_order { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/text.rs:51:31 [INFO] [stderr] | [INFO] [stderr] 51 | num_lines as Scalar * font_size as Scalar + (num_lines - 1) as Scalar * line_spacing [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(font_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `text::font::Map` [INFO] [stderr] --> src/text.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | / pub fn new() -> Self { [INFO] [stderr] 146 | | Map { [INFO] [stderr] 147 | | next_index: 0, [INFO] [stderr] 148 | | map: fnv::FnvHashMap::default(), [INFO] [stderr] 149 | | } [INFO] [stderr] 150 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 107 | #[derive(Default)] [INFO] [stderr] 108 | pub struct Map { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/text.rs:223:41 [INFO] [stderr] | [INFO] [stderr] 223 | self.index_range.next().map(|i| Id(i)) [INFO] [stderr] | ^^^^^^^^^ help: remove closure as shown: `Id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/text.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | self.keys.next().map(|&id| id) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.keys.next().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/text.rs:438:31 [INFO] [stderr] | [INFO] [stderr] 438 | .map(|bb| bb.max.x as Scalar) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(bb.max.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/text.rs:439:47 [INFO] [stderr] | [INFO] [stderr] 439 | .unwrap_or_else(|| left + g.unpositioned().h_metrics().advance_width as Scalar); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(g.unpositioned().h_metrics().advance_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/text.rs:491:23 [INFO] [stderr] | [INFO] [stderr] 491 | xys_per_line: XysPerLine<'a, [INFO] [stderr] | _______________________^ [INFO] [stderr] 492 | | std::iter::Zip>, [INFO] [stderr] 493 | | super::line::Rects>>> [INFO] [stderr] 494 | | >, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/text.rs:709:5 [INFO] [stderr] | [INFO] [stderr] 709 | / pub fn xys_per_line_from_text<'a>(text: &'a str, [INFO] [stderr] 710 | | line_infos: &'a [super::line::Info], [INFO] [stderr] 711 | | font: &'a super::Font, [INFO] [stderr] 712 | | font_size: FontSize, [INFO] [stderr] ... | [INFO] [stderr] 725 | | } [INFO] [stderr] 726 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/text.rs:867:38 [INFO] [stderr] | [INFO] [stderr] 867 | .map(|r| r.max.x as Scalar) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(r.max.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/text.rs:869:37 [INFO] [stderr] | [INFO] [stderr] 869 | x + g.unpositioned().h_metrics().advance_width as Scalar [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(g.unpositioned().h_metrics().advance_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/text.rs:1087:9 [INFO] [stderr] | [INFO] [stderr] 1087 | (kern + advance_width) as Scalar [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(kern + advance_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/text.rs:1244:9 [INFO] [stderr] | [INFO] [stderr] 1244 | total_w as Scalar [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(total_w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/text.rs:1318:41 [INFO] [stderr] | [INFO] [stderr] 1318 | let range = Range::new(0.0, font_size as Scalar); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(font_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/ui.rs:190:47 [INFO] [stderr] | [INFO] [stderr] 190 | theme: maybe_theme.unwrap_or_else(|| Theme::default()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Theme::default` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/ui.rs:381:5 [INFO] [stderr] | [INFO] [stderr] 381 | / pub fn handle_event(&mut self, event: event::Input) { [INFO] [stderr] 382 | | use event::{self, Input}; [INFO] [stderr] 383 | | use input::{Button, Key, ModifierKey, Motion}; [INFO] [stderr] 384 | | use input::state::mouse::Button as MouseButton; [INFO] [stderr] ... | [INFO] [stderr] 905 | | } [INFO] [stderr] 906 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ui.rs:603:31 [INFO] [stderr] | [INFO] [stderr] 603 | let (w, h) = (w as Scalar, h as Scalar); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ui.rs:603:44 [INFO] [stderr] | [INFO] [stderr] 603 | let (w, h) = (w as Scalar, h as Scalar); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ui.rs:641:43 [INFO] [stderr] | [INFO] [stderr] 641 | let buttons = self.global_input.current.mouse.buttons.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.global_input.current.mouse.buttons` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/ui.rs:884:48 [INFO] [stderr] | [INFO] [stderr] 884 | .and_then(|widget| match Some(widget) == widget_capturing { [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 885 | | true => Some(widget), [INFO] [stderr] 886 | | false => None, [INFO] [stderr] 887 | | }); [INFO] [stderr] | |_____________________________^ help: consider using an if/else expression: `if Some(widget) == widget_capturing { Some(widget) } else { None }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/ui.rs:953:58 [INFO] [stderr] | [INFO] [stderr] 953 | maybe_id.or(ui.maybe_prev_widget_id).or(Some(ui.window.into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(ui.window.into()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/ui.rs:953:66 [INFO] [stderr] | [INFO] [stderr] 953 | maybe_id.or(ui.maybe_prev_widget_id).or(Some(ui.window.into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ui.window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/ui.rs:974:58 [INFO] [stderr] | [INFO] [stderr] 974 | maybe_id.or(ui.maybe_prev_widget_id).or(Some(ui.window.into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(ui.window.into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/ui.rs:974:66 [INFO] [stderr] | [INFO] [stderr] 974 | maybe_id.or(ui.maybe_prev_widget_id).or(Some(ui.window.into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ui.window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/ui.rs:989:26 [INFO] [stderr] | [INFO] [stderr] 989 | .unwrap_or(ui.window.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| ui.window.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/ui.rs:989:36 [INFO] [stderr] | [INFO] [stderr] 989 | .unwrap_or(ui.window.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ui.window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/ui.rs:990:38 [INFO] [stderr] | [INFO] [stderr] 990 | let maybe_area = match place_on_kid_area { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 991 | | true => ui.widget_graph.widget(parent_id) [INFO] [stderr] 992 | | .map(|w| w.kid_area) [INFO] [stderr] 993 | | .map(|k| (range_from_rect(k.rect), start_and_end_pad(k.pad))), [INFO] [stderr] 994 | | false => ui.rect_of(parent_id) [INFO] [stderr] 995 | | .map(|rect| (range_from_rect(rect), Range::new(0.0, 0.0))), [INFO] [stderr] 996 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 990 | let maybe_area = if place_on_kid_area { ui.widget_graph.widget(parent_id) [INFO] [stderr] 991 | .map(|w| w.kid_area) [INFO] [stderr] 992 | .map(|k| (range_from_rect(k.rect), start_and_end_pad(k.pad))) } else { ui.rect_of(parent_id) [INFO] [stderr] 993 | .map(|rect| (range_from_rect(rect), Range::new(0.0, 0.0))) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/ui.rs:1058:55 [INFO] [stderr] | [INFO] [stderr] 1058 | .color(ui_cell.maybe_background_color.unwrap_or(color::BLACK.alpha(0.0))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| color::BLACK.alpha(0.0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/ui.rs:1062:51 [INFO] [stderr] | [INFO] [stderr] 1062 | ui_cell.ui.maybe_current_parent_id = Some(ui_cell.window.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ui_cell.window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/ui.rs:1327:10 [INFO] [stderr] | [INFO] [stderr] 1327 | .unwrap_or(ui.window.into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| ui.window.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/ui.rs:1327:20 [INFO] [stderr] | [INFO] [stderr] 1327 | .unwrap_or(ui.window.into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ui.window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/widget/id.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | / pub fn next(&mut self) -> Id { [INFO] [stderr] 51 | | self.widget_graph.add_placeholder() [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `widget::id::List` [INFO] [stderr] --> src/widget/id.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | / pub fn new() -> Self { [INFO] [stderr] 61 | | List(Vec::new()) [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `widget::scroll::Scroll` [INFO] [stderr] --> src/widget/scroll.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | / pub fn new() -> Self { [INFO] [stderr] 70 | | Scroll { [INFO] [stderr] 71 | | maybe_initial_alignment: None, [INFO] [stderr] 72 | | } [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `widget::primitive::line::Style` [INFO] [stderr] --> src/widget/primitive/line.rs:157:5 [INFO] [stderr] | [INFO] [stderr] 157 | / pub fn new() -> Self { [INFO] [stderr] 158 | | Style { [INFO] [stderr] 159 | | maybe_pattern: None, [INFO] [stderr] 160 | | maybe_color: None, [INFO] [stderr] ... | [INFO] [stderr] 163 | | } [INFO] [stderr] 164 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/primitive/line.rs:272:9 [INFO] [stderr] | [INFO] [stderr] 272 | self.style.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/widget/primitive/image.rs:39:22 [INFO] [stderr] | [INFO] [stderr] 39 | pub maybe_color: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/primitive/image.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | self.style.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/primitive/point_path.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | self.style.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/primitive/shape/oval.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | self.style.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/primitive/shape/polygon.rs:206:9 [INFO] [stderr] | [INFO] [stderr] 206 | self.style.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/primitive/shape/rectangle.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | self.style.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: defining a method called `add` on this type; consider implementing the `std::ops::Add` trait or choosing a less ambiguous name [INFO] [stderr] --> src/widget/primitive/shape/triangles.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | / pub fn add(self, amount: Point) -> Self { [INFO] [stderr] 105 | | let a = self[0].add(amount); [INFO] [stderr] 106 | | let b = self[1].add(amount); [INFO] [stderr] 107 | | let c = self[2].add(amount); [INFO] [stderr] 108 | | Triangle([a, b, c]) [INFO] [stderr] 109 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/widget/primitive/shape/triangles.rs:219:21 [INFO] [stderr] | [INFO] [stderr] 219 | let v = self.triangle.get(self.index).map(|&v| v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.triangle.get(self.index).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/widget/primitive/text.rs:39:21 [INFO] [stderr] | [INFO] [stderr] 39 | pub maybe_wrap: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/widget/primitive/text.rs:48:18 [INFO] [stderr] | [INFO] [stderr] 48 | pub font_id: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/primitive/text.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | self.style.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/widget/primitive/text.rs:170:14 [INFO] [stderr] | [INFO] [stderr] 170 | .or(ui.fonts.ids().next()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| ui.fonts.ids().next())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/widget/primitive/text.rs:194:14 [INFO] [stderr] | [INFO] [stderr] 194 | .or(ui.fonts.ids().next()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| ui.fonts.ids().next())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/widget/primitive/text.rs:233:14 [INFO] [stderr] | [INFO] [stderr] 233 | .or(ui.fonts.ids().next()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| ui.fonts.ids().next())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/bordered_rectangle.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | self.style.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/widget/bordered_rectangle.rs:220:26 [INFO] [stderr] | [INFO] [stderr] 220 | let next_point = match self.is_next_outer { [INFO] [stderr] | __________________________^ [INFO] [stderr] 221 | | true => self.outer.next().or_else(|| self.outer_end.take()), [INFO] [stderr] 222 | | false => self.inner.next().or_else(|| self.inner_end.take()), [INFO] [stderr] 223 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.is_next_outer { self.outer.next().or_else(|| self.outer_end.take()) } else { self.inner.next().or_else(|| self.inner_end.take()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/widget/button.rs:44:24 [INFO] [stderr] | [INFO] [stderr] 44 | pub label_font_id: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `widget::button::Button<'a, widget::button::Flat>` [INFO] [stderr] --> src/widget/button.rs:199:5 [INFO] [stderr] | [INFO] [stderr] 199 | / pub fn new() -> Self { [INFO] [stderr] 200 | | Self::new_internal(Flat::default()) [INFO] [stderr] 201 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/button.rs:294:9 [INFO] [stderr] | [INFO] [stderr] 294 | self.style.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/button.rs:333:9 [INFO] [stderr] | [INFO] [stderr] 333 | self.style.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/widget/button.rs:369:22 [INFO] [stderr] | [INFO] [stderr] 369 | .or(Some(Some(color))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(Some(color)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/widget/button.rs:421:50 [INFO] [stderr] | [INFO] [stderr] 421 | let font_id = style.label_font_id(&ui.theme).or(ui.fonts.ids().next()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| ui.fonts.ids().next())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/widget/canvas.rs:92:26 [INFO] [stderr] | [INFO] [stderr] 92 | pub title_bar_color: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/widget/canvas.rs:101:31 [INFO] [stderr] | [INFO] [stderr] 101 | pub title_bar_maybe_wrap: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `widget::canvas::Canvas<'a>` [INFO] [stderr] --> src/widget/canvas.rs:144:5 [INFO] [stderr] | [INFO] [stderr] 144 | / pub fn new() -> Self { [INFO] [stderr] 145 | | Canvas { [INFO] [stderr] 146 | | common: widget::CommonBuilder::default(), [INFO] [stderr] 147 | | style: Style::default(), [INFO] [stderr] ... | [INFO] [stderr] 150 | | } [INFO] [stderr] 151 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/canvas.rs:238:9 [INFO] [stderr] | [INFO] [stderr] 238 | self.style.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/widget/collapsible_area.rs:54:26 [INFO] [stderr] | [INFO] [stderr] 54 | pub label_font_size: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/widget/collapsible_area.rs:57:24 [INFO] [stderr] | [INFO] [stderr] 57 | pub label_font_id: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/collapsible_area.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | self.style.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/widget/collapsible_area.rs:137:60 [INFO] [stderr] | [INFO] [stderr] 137 | let label_font_id = style.label_font_id(&ui.theme).or(ui.fonts.ids().next()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| ui.fonts.ids().next())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/widget/collapsible_area.rs:233:20 [INFO] [stderr] | [INFO] [stderr] 233 | pub fn is_open(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/widget/drop_down_list.rs:58:35 [INFO] [stderr] | [INFO] [stderr] 58 | pub maybe_max_visible_height: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/widget/drop_down_list.rs:61:29 [INFO] [stderr] | [INFO] [stderr] 61 | pub scrollbar_position: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/widget/drop_down_list.rs:64:26 [INFO] [stderr] | [INFO] [stderr] 64 | pub scrollbar_width: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/widget/drop_down_list.rs:67:24 [INFO] [stderr] | [INFO] [stderr] 67 | pub label_font_id: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/drop_down_list.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | self.style.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/widget/envelope_editor.rs:62:24 [INFO] [stderr] | [INFO] [stderr] 62 | pub label_font_id: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/envelope_editor.rs:244:9 [INFO] [stderr] | [INFO] [stderr] 244 | self.style.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `env` [INFO] [stderr] --> src/widget/envelope_editor.rs:297:22 [INFO] [stderr] | [INFO] [stderr] 297 | for i in 0..env.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 297 | for (i, ) in env.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/widget/envelope_editor.rs:473:54 [INFO] [stderr] | [INFO] [stderr] 473 | let font_id = style.label_font_id(&ui.theme).or(ui.fonts.ids().next()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| ui.fonts.ids().next())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/widget/file_navigator/directory_view.rs:73:27 [INFO] [stderr] | [INFO] [stderr] 73 | pub unselected_color: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/widget/file_navigator/directory_view.rs:76:21 [INFO] [stderr] | [INFO] [stderr] 76 | pub text_color: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/widget/file_navigator/directory_view.rs:121:51 [INFO] [stderr] | [INFO] [stderr] 121 | return name.to_string_lossy().starts_with("."); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/widget/file_navigator/directory_view.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | / if valid_exts.iter().any(|&valid_ext| &ext == valid_ext) { [INFO] [stderr] 148 | | return true [INFO] [stderr] 149 | | } else { [INFO] [stderr] 150 | | return false [INFO] [stderr] 151 | | } [INFO] [stderr] | |_____________^ help: you can reduce it to: `return valid_exts.iter().any(|&valid_ext| &ext == valid_ext)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/widget/file_navigator/directory_view.rs:147:51 [INFO] [stderr] | [INFO] [stderr] 147 | if valid_exts.iter().any(|&valid_ext| &ext == valid_ext) { [INFO] [stderr] | ----^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `ext` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/file_navigator/directory_view.rs:209:9 [INFO] [stderr] | [INFO] [stderr] 209 | self.style.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/widget/file_navigator/directory_view.rs:216:12 [INFO] [stderr] | [INFO] [stderr] 216 | if directory != &state.directory { [INFO] [stderr] | ^^^^^^^^^^^^^---------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `state.directory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/widget/file_navigator/directory_view.rs:261:22 [INFO] [stderr] | [INFO] [stderr] 261 | let file_h = font_size as Scalar * 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(font_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/widget/file_navigator/directory_view.rs:332:68 [INFO] [stderr] | [INFO] [stderr] 332 | .label_x(Relative::Place(Place::Start(Some(font_size as Scalar)))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(font_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/widget/file_navigator/mod.rs:100:27 [INFO] [stderr] | [INFO] [stderr] 100 | pub unselected_color: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/widget/file_navigator/mod.rs:103:21 [INFO] [stderr] | [INFO] [stderr] 103 | pub text_color: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/file_navigator/mod.rs:206:9 [INFO] [stderr] | [INFO] [stderr] 206 | self.style.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/widget/file_navigator/mod.rs:403:32 [INFO] [stderr] | [INFO] [stderr] 403 | Some(mouse) => match mouse.buttons.left().is_down() { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 404 | | true => resize_color.clicked().alpha(0.5), [INFO] [stderr] 405 | | false => resize_color.highlighted().alpha(0.2), [INFO] [stderr] 406 | | }, [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if mouse.buttons.left().is_down() { resize_color.clicked().alpha(0.5) } else { resize_color.highlighted().alpha(0.2) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/widget/grid.rs:130:5 [INFO] [stderr] | [INFO] [stderr] 130 | / pub fn new(min_x: X, max_x: X, min_y: Y, max_y: Y, lines: I) -> Grid [INFO] [stderr] 131 | | where [INFO] [stderr] 132 | | X: Into, [INFO] [stderr] 133 | | Y: Into, [INFO] [stderr] ... | [INFO] [stderr] 146 | | } [INFO] [stderr] 147 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/grid.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 177 | self.style.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/widget/list.rs:126:30 [INFO] [stderr] | [INFO] [stderr] 126 | pub scrollbar_thickness: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/widget/list.rs:132:29 [INFO] [stderr] | [INFO] [stderr] 132 | pub scrollbar_position: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/list.rs:350:9 [INFO] [stderr] | [INFO] [stderr] 350 | self.style.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/widget/list.rs:382:17 [INFO] [stderr] | [INFO] [stderr] 382 | state.ids.items.get(*next_item_indices_index).map(|&id| id) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `state.ids.items.get(*next_item_indices_index).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/widget/list_select.rs:354:18 [INFO] [stderr] | [INFO] [stderr] 354 | type Event = (Events, Option>); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/list_select.rs:364:9 [INFO] [stderr] | [INFO] [stderr] 364 | self.style.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/list_select.rs:391:22 [INFO] [stderr] | [INFO] [stderr] 391 | list.style = style.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/list_select.rs:494:59 [INFO] [stderr] | [INFO] [stderr] 494 | pending_events.push_back(Event::Click(dummy_click.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `dummy_click` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/widget/list_select.rs:592:33 [INFO] [stderr] | [INFO] [stderr] 592 | let selection = (start..end + 1).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `(start..=end)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/matrix.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | self.style.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/widget/matrix.rs:208:53 [INFO] [stderr] | [INFO] [stderr] 208 | state.indices.get(c).and_then(|col| col.get(r).map(|&id| id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `col.get(r).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/graph/node.rs:450:9 [INFO] [stderr] | [INFO] [stderr] 450 | self.style.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/widget/graph/node.rs:501:27 [INFO] [stderr] | [INFO] [stderr] 501 | .and_then(|m| match m.buttons.left().is_down() { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 502 | | // If the mouse isn't down, we must be hovering over the widget. [INFO] [stderr] 503 | | false => over_socket(m.abs_xy()).map(|(ty, ix)| (ty, ix, Interaction::Hover)), [INFO] [stderr] 504 | | // Otherwise we're currently pressing some part of the widget. [INFO] [stderr] ... | [INFO] [stderr] 515 | | }, [INFO] [stderr] 516 | | }); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 501 | .and_then(|m| if m.buttons.left().is_down() { [INFO] [stderr] 502 | // If the left mouse button was just pressed, check to see if over a socket. [INFO] [stderr] 503 | if ui.widget_input(id).presses().mouse().left().next().is_some() { [INFO] [stderr] 504 | let maybe_socket = over_socket(m.abs_xy()); [INFO] [stderr] 505 | if maybe_socket.is_some() { [INFO] [stderr] 506 | state.update(|state| state.capturing_socket = maybe_socket); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/widget/graph/node.rs:530:28 [INFO] [stderr] | [INFO] [stderr] 530 | let border_color = match maybe_socket_interaction.is_some() { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 531 | | true => border_color, [INFO] [stderr] 532 | | false => { [INFO] [stderr] 533 | | ui.widget_input(id) [INFO] [stderr] ... | [INFO] [stderr] 543 | | }, [INFO] [stderr] 544 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 530 | let border_color = if maybe_socket_interaction.is_some() { border_color } else { [INFO] [stderr] 531 | ui.widget_input(id) [INFO] [stderr] 532 | .mouse() [INFO] [stderr] 533 | .map(|m| match inner_rect.is_over(m.abs_xy()) { [INFO] [stderr] 534 | true => border_color, [INFO] [stderr] 535 | false => match m.buttons.left().is_down() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/widget/graph/node.rs:535:30 [INFO] [stderr] | [INFO] [stderr] 535 | .map(|m| match inner_rect.is_over(m.abs_xy()) { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 536 | | true => border_color, [INFO] [stderr] 537 | | false => match m.buttons.left().is_down() { [INFO] [stderr] 538 | | true => border_color.clicked(), [INFO] [stderr] 539 | | false => border_color.highlighted(), [INFO] [stderr] 540 | | }, [INFO] [stderr] 541 | | }) [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 535 | .map(|m| if inner_rect.is_over(m.abs_xy()) { border_color } else { match m.buttons.left().is_down() { [INFO] [stderr] 536 | true => border_color.clicked(), [INFO] [stderr] 537 | false => border_color.highlighted(), [INFO] [stderr] 538 | } }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/widget/graph/node.rs:537:34 [INFO] [stderr] | [INFO] [stderr] 537 | false => match m.buttons.left().is_down() { [INFO] [stderr] | __________________________________^ [INFO] [stderr] 538 | | true => border_color.clicked(), [INFO] [stderr] 539 | | false => border_color.highlighted(), [INFO] [stderr] 540 | | }, [INFO] [stderr] | |_________________________^ help: consider using an if/else expression: `if m.buttons.left().is_down() { border_color.clicked() } else { border_color.highlighted() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/widget/graph/mod.rs:141:19 [INFO] [stderr] | [INFO] [stderr] 141 | match self.widget_ids.get(self.next_index).map(|&id| id) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.widget_ids.get(self.next_index).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/widget/graph/mod.rs:697:13 [INFO] [stderr] | [INFO] [stderr] 697 | shared.widget_id_map.node_widget_ids.get(&node_id).map(|&id| id) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `shared.widget_id_map.node_widget_ids.get(&node_id).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/widget/graph/mod.rs:718:21 [INFO] [stderr] | [INFO] [stderr] 718 | let a = shared.widget_id_map.node_widget_ids.get(&edge.start.id).map(|&id| id); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `shared.widget_id_map.node_widget_ids.get(&edge.start.id).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/widget/graph/mod.rs:719:21 [INFO] [stderr] | [INFO] [stderr] 719 | let b = shared.widget_id_map.node_widget_ids.get(&edge.end.id).map(|&id| id); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `shared.widget_id_map.node_widget_ids.get(&edge.end.id).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/graph/mod.rs:818:9 [INFO] [stderr] | [INFO] [stderr] 818 | self.style.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/widget/graph/mod.rs:830:9 [INFO] [stderr] | [INFO] [stderr] 830 | / match iter_diff(&shared.node_ids, nodes) { [INFO] [stderr] 831 | | Some(diff) => match diff { [INFO] [stderr] 832 | | IterDiff::FirstMismatch(i, mismatch) => { [INFO] [stderr] 833 | | shared.node_ids.truncate(i); [INFO] [stderr] ... | [INFO] [stderr] 843 | | None => (), [INFO] [stderr] 844 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 830 | if let Some(diff) = iter_diff(&shared.node_ids, nodes) { match diff { [INFO] [stderr] 831 | IterDiff::FirstMismatch(i, mismatch) => { [INFO] [stderr] 832 | shared.node_ids.truncate(i); [INFO] [stderr] 833 | shared.node_ids.extend(mismatch); [INFO] [stderr] 834 | }, [INFO] [stderr] 835 | IterDiff::Longer(remaining) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/widget/graph/mod.rs:847:9 [INFO] [stderr] | [INFO] [stderr] 847 | / match iter_diff(&shared.edges, edges) { [INFO] [stderr] 848 | | Some(diff) => match diff { [INFO] [stderr] 849 | | IterDiff::FirstMismatch(i, mismatch) => { [INFO] [stderr] 850 | | shared.edges.truncate(i); [INFO] [stderr] ... | [INFO] [stderr] 860 | | None => (), [INFO] [stderr] 861 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 847 | if let Some(diff) = iter_diff(&shared.edges, edges) { match diff { [INFO] [stderr] 848 | IterDiff::FirstMismatch(i, mismatch) => { [INFO] [stderr] 849 | shared.edges.truncate(i); [INFO] [stderr] 850 | shared.edges.extend(mismatch); [INFO] [stderr] 851 | }, [INFO] [stderr] 852 | IterDiff::Longer(remaining) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/widget/graph/mod.rs:870:25 [INFO] [stderr] | [INFO] [stderr] 870 | let point = layout.map.get(&node_id).map(|&p| p).unwrap_or([0.0; 2]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `layout.map.get(&node_id).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/widget/graph/mod.rs:873:31 [INFO] [stderr] | [INFO] [stderr] 873 | let point = match shared.widget_id_map.node_widget_ids.get(&node_id).map(|&w| w) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `shared.widget_id_map.node_widget_ids.get(&node_id).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/widget/number_dialer.rs:60:18 [INFO] [stderr] | [INFO] [stderr] 60 | pub font_id: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/widget/number_dialer.rs:123:6 [INFO] [stderr] | [INFO] [stderr] 123 | (size as f64 * 0.75).floor() as f64 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/widget/number_dialer.rs:127:54 [INFO] [stderr] | [INFO] [stderr] 127 | fn val_string_width(font_size: FontSize, val_string: &String) -> f64 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/number_dialer.rs:178:9 [INFO] [stderr] | [INFO] [stderr] 178 | self.style.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: unused label `'events` [INFO] [stderr] --> src/widget/number_dialer.rs:246:9 [INFO] [stderr] | [INFO] [stderr] 246 | / 'events: for widget_event in ui.widget_input(id).events() { [INFO] [stderr] 247 | | use event; [INFO] [stderr] 248 | | use input::{self, MouseButton}; [INFO] [stderr] 249 | | [INFO] [stderr] ... | [INFO] [stderr] 306 | | } [INFO] [stderr] 307 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/widget/number_dialer.rs:193:54 [INFO] [stderr] | [INFO] [stderr] 193 | let font_id = match style.font_id(&ui.theme).or(ui.fonts.ids().next()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| ui.fonts.ids().next())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/widget/number_dialer.rs:199:52 [INFO] [stderr] | [INFO] [stderr] 199 | let label_string = maybe_label.map_or_else(|| String::new(), |text| format!("{}: ", text)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/widget/number_dialer.rs:204:35 [INFO] [stderr] | [INFO] [stderr] 204 | let label_dim = [label_w, font_size as f64]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(font_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/widget/number_dialer.rs:208:73 [INFO] [stderr] | [INFO] [stderr] 208 | let val_string_dim = [val_string_width(font_size, &val_string), font_size as f64]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(font_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/widget/number_dialer.rs:279:55 [INFO] [stderr] | [INFO] [stderr] 279 | clamp(val_f + (10.0).powf(power as f32) as f64, min_f, max_f) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((10.0).powf(power as f32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/widget/number_dialer.rs:282:55 [INFO] [stderr] | [INFO] [stderr] 282 | clamp(val_f - (10.0).powf(power as f32) as f64, min_f, max_f) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((10.0).powf(power as f32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/widget/number_dialer.rs:292:55 [INFO] [stderr] | [INFO] [stderr] 292 | clamp(val_f + (10.0).powf(power as f32) as f64, min_f, max_f) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((10.0).powf(power as f32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/widget/number_dialer.rs:295:55 [INFO] [stderr] | [INFO] [stderr] 295 | clamp(val_f - (10.0).powf(power as f32) as f64, min_f, max_f) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((10.0).powf(power as f32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/widget/number_dialer.rs:359:44 [INFO] [stderr] | [INFO] [stderr] 359 | let glyph_string = &val_string[i..i+1]; [INFO] [stderr] | ^^^^^^ help: use: `i..=i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/plot_path.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | self.style.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/widget/range_slider.rs:53:24 [INFO] [stderr] | [INFO] [stderr] 53 | pub label_font_id: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/range_slider.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | self.style.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/widget/range_slider.rs:190:20 [INFO] [stderr] | [INFO] [stderr] 190 | f.powf(skew as f64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(skew)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/widget/range_slider.rs:194:43 [INFO] [stderr] | [INFO] [stderr] 194 | utils::map_range(f.powf(1.0 / skew as f64), 0.0, 1.0, min, max) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(skew)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/widget/range_slider.rs:249:32 [INFO] [stderr] | [INFO] [stderr] 249 | if distance_from_start == distance_from_end { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(distance_from_start - distance_from_end).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/widget/range_slider.rs:249:32 [INFO] [stderr] | [INFO] [stderr] 249 | if distance_from_start == distance_from_end { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/widget/range_slider.rs:370:58 [INFO] [stderr] | [INFO] [stderr] 370 | let font_id = style.label_font_id(&ui.theme).or(ui.fonts.ids().next()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| ui.fonts.ids().next())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/rounded_rectangle.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | self.style.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/scrollbar.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | self.style.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/widget/slider.rs:59:24 [INFO] [stderr] | [INFO] [stderr] 59 | pub label_font_id: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/slider.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | self.style.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/widget/slider.rs:150:51 [INFO] [stderr] | [INFO] [stderr] 150 | let skewed_perc = (perc).powf(skew as f64); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(skew)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/widget/slider.rs:158:51 [INFO] [stderr] | [INFO] [stderr] 158 | let skewed_perc = (perc).powf(skew as f64); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(skew)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/widget/slider.rs:181:51 [INFO] [stderr] | [INFO] [stderr] 181 | let unskewed_perc = value_perc.powf(1.0 / skew as f64); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(skew)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/widget/slider.rs:240:58 [INFO] [stderr] | [INFO] [stderr] 240 | let font_id = style.label_font_id(&ui.theme).or(ui.fonts.ids().next()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| ui.fonts.ids().next())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/widget/tabs.rs:56:24 [INFO] [stderr] | [INFO] [stderr] 56 | pub bar_thickness: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/widget/tabs.rs:65:18 [INFO] [stderr] | [INFO] [stderr] 65 | pub font_id: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/widget/tabs.rs:49:50 [INFO] [stderr] | [INFO] [stderr] 49 | #[derive(Copy, Clone, Debug, Default, PartialEq, WidgetStyle_)] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/tabs.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | self.style.canvas.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style.canvas` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/tabs.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | self.style.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/widget/tabs.rs:195:69 [INFO] [stderr] | [INFO] [stderr] 195 | let tab_bar_h = horizontal_tab_bar_h(bar_thickness, font_size as Scalar); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(font_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/widget/tabs.rs:203:22 [INFO] [stderr] | [INFO] [stderr] 203 | .or(fonts.ids().next()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| fonts.ids().next())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/widget/tabs.rs:224:14 [INFO] [stderr] | [INFO] [stderr] 224 | .or(ui.fonts.ids().next()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| ui.fonts.ids().next())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/widget/tabs.rs:230:27 [INFO] [stderr] | [INFO] [stderr] 230 | let font_height = font_size as Scalar; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(font_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/widget/tabs.rs:271:32 [INFO] [stderr] | [INFO] [stderr] 271 | .or_else(|| if tabs.len() > 0 { Some(0) } else { None }); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tabs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/widget/text_box.rs:51:18 [INFO] [stderr] | [INFO] [stderr] 51 | pub font_id: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/text_box.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | self.style.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/widget/text_box.rs:143:21 [INFO] [stderr] | [INFO] [stderr] 143 | let h = font_size as Scalar + 1.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(font_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/widget/text_box.rs:163:48 [INFO] [stderr] | [INFO] [stderr] 163 | let font_id = style.font_id(&ui.theme).or(ui.fonts.ids().next()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| ui.fonts.ids().next())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/widget/text_box.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | / match widget_event { [INFO] [stderr] 182 | | event::Widget::Press(press) => match press.button { [INFO] [stderr] 183 | | event::Button::Keyboard(key) => match key { [INFO] [stderr] 184 | | input::Key::Return => events.push(Event::Enter), [INFO] [stderr] ... | [INFO] [stderr] 189 | | _ => (), [INFO] [stderr] 190 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 181 | if let event::Widget::Press(press) = widget_event { match press.button { [INFO] [stderr] 182 | event::Button::Keyboard(key) => match key { [INFO] [stderr] 183 | input::Key::Return => events.push(Event::Enter), [INFO] [stderr] 184 | _ => (), [INFO] [stderr] 185 | }, [INFO] [stderr] 186 | _ => (), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/widget/text_box.rs:182:48 [INFO] [stderr] | [INFO] [stderr] 182 | event::Widget::Press(press) => match press.button { [INFO] [stderr] | ________________________________________________^ [INFO] [stderr] 183 | | event::Button::Keyboard(key) => match key { [INFO] [stderr] 184 | | input::Key::Return => events.push(Event::Enter), [INFO] [stderr] 185 | | _ => (), [INFO] [stderr] 186 | | }, [INFO] [stderr] 187 | | _ => (), [INFO] [stderr] 188 | | }, [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 182 | event::Widget::Press(press) => if let event::Button::Keyboard(key) = press.button { match key { [INFO] [stderr] 183 | input::Key::Return => events.push(Event::Enter), [INFO] [stderr] 184 | _ => (), [INFO] [stderr] 185 | } }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/widget/text_box.rs:183:53 [INFO] [stderr] | [INFO] [stderr] 183 | event::Button::Keyboard(key) => match key { [INFO] [stderr] | _____________________________________________________^ [INFO] [stderr] 184 | | input::Key::Return => events.push(Event::Enter), [INFO] [stderr] 185 | | _ => (), [INFO] [stderr] 186 | | }, [INFO] [stderr] | |_____________________^ help: try this: `if let input::Key::Return = key { events.push(Event::Enter) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/widget/text_edit.rs:53:18 [INFO] [stderr] | [INFO] [stderr] 53 | pub font_id: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/text_edit.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | self.style.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/widget/text_edit.rs:213:14 [INFO] [stderr] | [INFO] [stderr] 213 | .or(ui.fonts.ids().next()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| ui.fonts.ids().next())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 52 [INFO] [stderr] --> src/widget/text_edit.rs:241:5 [INFO] [stderr] | [INFO] [stderr] 241 | / fn update(self, args: widget::UpdateArgs) -> Self::Event { [INFO] [stderr] 242 | | let widget::UpdateArgs { id, state, rect, style, ui, .. } = args; [INFO] [stderr] 243 | | let TextEdit { text, .. } = self; [INFO] [stderr] 244 | | let mut text = std::borrow::Cow::Borrowed(text); [INFO] [stderr] ... | [INFO] [stderr] 876 | | take_if_owned(text) [INFO] [stderr] 877 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/widget/text_edit.rs:250:14 [INFO] [stderr] | [INFO] [stderr] 250 | .or(ui.fonts.ids().next()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| ui.fonts.ids().next())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/widget/text_edit.rs:619:33 [INFO] [stderr] | [INFO] [stderr] 619 | / match line_infos.nth(line) { [INFO] [stderr] 620 | | Some(line_info) => { [INFO] [stderr] 621 | | let char = line_info.end_char() - line_info.start_char; [INFO] [stderr] 622 | | let new_cursor_idx = text::cursor::Index { line: line, char: char }; [INFO] [stderr] ... | [INFO] [stderr] 625 | | _ => (), [INFO] [stderr] 626 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 619 | if let Some(line_info) = line_infos.nth(line) { [INFO] [stderr] 620 | let char = line_info.end_char() - line_info.start_char; [INFO] [stderr] 621 | let new_cursor_idx = text::cursor::Index { line: line, char: char }; [INFO] [stderr] 622 | cursor = Cursor::Idx(new_cursor_idx); [INFO] [stderr] 623 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/widget/text_edit.rs:658:29 [INFO] [stderr] | [INFO] [stderr] 658 | / match insert_text("\n", cursor, &text, &state.line_infos, font) { [INFO] [stderr] 659 | | Some((new_text, new_cursor, new_line_infos)) => { [INFO] [stderr] 660 | | *text.to_mut() = new_text; [INFO] [stderr] 661 | | cursor = new_cursor; [INFO] [stderr] 662 | | state.update(|state| state.line_infos = new_line_infos); [INFO] [stderr] 663 | | }, _ => () [INFO] [stderr] 664 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 658 | if let Some((new_text, new_cursor, new_line_infos)) = insert_text("\n", cursor, &text, &state.line_infos, font) { [INFO] [stderr] 659 | *text.to_mut() = new_text; [INFO] [stderr] 660 | cursor = new_cursor; [INFO] [stderr] 661 | state.update(|state| state.line_infos = new_line_infos); [INFO] [stderr] 662 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/widget/text_edit.rs:700:21 [INFO] [stderr] | [INFO] [stderr] 700 | / match insert_text(&string, cursor, &text, &state.line_infos, font) { [INFO] [stderr] 701 | | Some((new_text, new_cursor, new_line_infos)) => { [INFO] [stderr] 702 | | *text.to_mut() = new_text; [INFO] [stderr] 703 | | cursor = new_cursor; [INFO] [stderr] 704 | | state.update(|state| state.line_infos = new_line_infos); [INFO] [stderr] 705 | | }, _ => () [INFO] [stderr] 706 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 700 | if let Some((new_text, new_cursor, new_line_infos)) = insert_text(&string, cursor, &text, &state.line_infos, font) { [INFO] [stderr] 701 | *text.to_mut() = new_text; [INFO] [stderr] 702 | cursor = new_cursor; [INFO] [stderr] 703 | state.update(|state| state.line_infos = new_line_infos); [INFO] [stderr] 704 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/widget/text_edit.rs:721:29 [INFO] [stderr] | [INFO] [stderr] 721 | / match closest_cursor_index_and_xy(abs_xy, &text, infos, font) { [INFO] [stderr] 722 | | Some((end_cursor_idx, _)) => [INFO] [stderr] 723 | | cursor = Cursor::Selection { [INFO] [stderr] 724 | | start: start_cursor_idx, [INFO] [stderr] ... | [INFO] [stderr] 727 | | _ => (), [INFO] [stderr] 728 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 721 | if let Some((end_cursor_idx, _)) = closest_cursor_index_and_xy(abs_xy, &text, infos, font) { cursor = Cursor::Selection { [INFO] [stderr] 722 | start: start_cursor_idx, [INFO] [stderr] 723 | end: end_cursor_idx, [INFO] [stderr] 724 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/widget/text_edit.rs:744:16 [INFO] [stderr] | [INFO] [stderr] 744 | if let Some(_) = ui.widget_input(id).mouse() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 745 | | ui.set_mouse_cursor(cursor::MouseCursor::Text); [INFO] [stderr] 746 | | } [INFO] [stderr] | |_________- help: try this: `if ui.widget_input(id).mouse().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/widget/text_edit.rs:803:45 [INFO] [stderr] | [INFO] [stderr] 803 | let y = Range::new(0.0, font_size as Scalar).align_to(y_align, rect.y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(font_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/widget/title_bar.rs:53:21 [INFO] [stderr] | [INFO] [stderr] 53 | pub maybe_wrap: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/widget/title_bar.rs:68:18 [INFO] [stderr] | [INFO] [stderr] 68 | pub font_id: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/widget/title_bar.rs:133:5 [INFO] [stderr] | [INFO] [stderr] 133 | font_size as Scalar + LABEL_PADDING * 2.0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(font_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/title_bar.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | self.style.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/widget/title_bar.rs:181:48 [INFO] [stderr] | [INFO] [stderr] 181 | let font_id = style.font_id(&ui.theme).or(ui.fonts.ids().next()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| ui.fonts.ids().next())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/widget/toggle.rs:47:24 [INFO] [stderr] | [INFO] [stderr] 47 | pub label_font_id: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/toggle.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | self.style.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/widget/toggle.rs:186:58 [INFO] [stderr] | [INFO] [stderr] 186 | let font_id = style.label_font_id(&ui.theme).or(ui.fonts.ids().next()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| ui.fonts.ids().next())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/widget/xy_pad.rs:55:24 [INFO] [stderr] | [INFO] [stderr] 55 | pub label_font_id: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/widget/xy_pad.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | self.style.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/widget/xy_pad.rs:185:54 [INFO] [stderr] | [INFO] [stderr] 185 | let font_id = style.label_font_id(&ui.theme).or(ui.fonts.ids().next()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| ui.fonts.ids().next())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/widget/mod.rs:169:26 [INFO] [stderr] | [INFO] [stderr] 169 | pub fn get_unchecked(&self, ui: &Ui, x_pos: Position, y_pos: Position) -> Id { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/widget/mod.rs:172:34 [INFO] [stderr] | [INFO] [stderr] 172 | MaybeParent::None => ui.window.into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ui.window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/widget/mod.rs:179:16 [INFO] [stderr] | [INFO] [stderr] 179 | pub fn get(&self, id: Id, ui: &Ui, x_pos: Position, y_pos: Position) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/widget/mod.rs:865:5 [INFO] [stderr] | [INFO] [stderr] 865 | / fn set<'a, 'b>(self, id: Id, ui_cell: &'a mut UiCell<'b>) -> Self::Event { [INFO] [stderr] 866 | | set_widget(self, id, ui_cell) [INFO] [stderr] 867 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/widget/mod.rs:883:1 [INFO] [stderr] | [INFO] [stderr] 883 | / fn set_widget<'a, 'b, W>(widget: W, id: Id, ui: &'a mut UiCell<'b>) -> W::Event [INFO] [stderr] 884 | | where W: Widget, [INFO] [stderr] 885 | | { [INFO] [stderr] 886 | | let type_id = std::any::TypeId::of::(); [INFO] [stderr] ... | [INFO] [stderr] 1179 | | event [INFO] [stderr] 1180 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/widget/mod.rs:897:21 [INFO] [stderr] | [INFO] [stderr] 897 | / writeln!(std::io::stderr(), [INFO] [stderr] 898 | | "A widget of a different type already exists at the given WidgetId \ [INFO] [stderr] 899 | | ({:?}). You tried to insert a {:?}, however the existing widget is a \ [INFO] [stderr] 900 | | {:?}. Check your widgets' `WidgetId`s for errors.", [INFO] [stderr] 901 | | id, type_id, container.type_id).unwrap(); [INFO] [stderr] | |______________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/widget/mod.rs:1149:12 [INFO] [stderr] | [INFO] [stderr] 1149 | || depth != prev_common.depth [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(depth - prev_common.depth).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/widget/mod.rs:1149:12 [INFO] [stderr] | [INFO] [stderr] 1149 | || depth != prev_common.depth [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/widget/mod.rs:1238:14 [INFO] [stderr] | [INFO] [stderr] 1238 | .unwrap_or(self.default_x_position(ui)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.default_x_position(ui))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/widget/mod.rs:1245:14 [INFO] [stderr] | [INFO] [stderr] 1245 | .unwrap_or(self.default_y_position(ui)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.default_y_position(ui))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `conrod`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "eb136ae03af86efc345f545ba64e430e33a18bfa9cdcdbe861bd001f8f0ba324"` [INFO] running `"docker" "rm" "-f" "eb136ae03af86efc345f545ba64e430e33a18bfa9cdcdbe861bd001f8f0ba324"` [INFO] [stdout] eb136ae03af86efc345f545ba64e430e33a18bfa9cdcdbe861bd001f8f0ba324