[INFO] crate conniecs 0.1.4 is already in cache [INFO] extracting crate conniecs 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/conniecs/0.1.4 [INFO] extracting crate conniecs 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/conniecs/0.1.4 [INFO] validating manifest of conniecs-0.1.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of conniecs-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing conniecs-0.1.4 [INFO] finished frobbing conniecs-0.1.4 [INFO] frobbed toml for conniecs-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/conniecs/0.1.4/Cargo.toml [INFO] started frobbing conniecs-0.1.4 [INFO] finished frobbing conniecs-0.1.4 [INFO] frobbed toml for conniecs-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/conniecs/0.1.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting conniecs-0.1.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/conniecs/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 41ba30934c31e1e1931f902c756fec7f1d379cee5661bb39d240dde6bc61ba27 [INFO] running `"docker" "start" "-a" "41ba30934c31e1e1931f902c756fec7f1d379cee5661bb39d240dde6bc61ba27"` [INFO] [stderr] Checking free-ranges v1.0.7 [INFO] [stderr] Compiling conniecs-derive v0.1.2 [INFO] [stderr] Checking index-pool v1.0.11 [INFO] [stderr] Checking conniecs v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/entity/iter.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | aspect: aspect, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `aspect` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/entity/iter.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | components: components, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `components` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/entity/iter.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | aspect: aspect, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `aspect` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/entity/iter.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | components: components, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `components` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you probably are missing some parameter in your format string [INFO] [stderr] --> src/component.rs:172:20 [INFO] [stderr] | [INFO] [stderr] 172 | panic!("Entity at index {} does not have this component attached") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::panic_params)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic_params [INFO] [stderr] [INFO] [stderr] warning: you probably are missing some parameter in your format string [INFO] [stderr] --> src/component.rs:178:20 [INFO] [stderr] | [INFO] [stderr] 178 | panic!("Entity at index {} does not have this component attached") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic_params [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/entity/iter.rs:60:21 [INFO] [stderr] | [INFO] [stderr] 60 | values: self.values.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 60 | values: &(*self.values).clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 60 | values: &vec_map::VecMap>::clone(self.values), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `entity::manager::EntityManager` [INFO] [stderr] --> src/entity/manager.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn new() -> Self { [INFO] [stderr] 35 | | EntityManager { [INFO] [stderr] 36 | | indices: IndexPool::new(), [INFO] [stderr] 37 | | indexed_entities: VecMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 41 | | } [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 19 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `system::entity::EntitySystem` [INFO] [stderr] --> src/system/entity.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | / pub fn new() -> EntitySystem { [INFO] [stderr] 102 | | EntitySystem { [INFO] [stderr] 103 | | inner: T::build_system(), [INFO] [stderr] 104 | | watcher: Watcher::new(T::create_aspect()), [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 97 | impl Default for system::entity::EntitySystem { [INFO] [stderr] 98 | fn default() -> Self { [INFO] [stderr] 99 | Self::new() [INFO] [stderr] 100 | } [INFO] [stderr] 101 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/system/lazy.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | / self.inner [INFO] [stderr] 93 | | .as_mut() [INFO] [stderr] 94 | | .map(|inner| inner.activated(entity, components, services)); [INFO] [stderr] | |_______________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 92 | if let Some(inner) = self.inner [INFO] [stderr] 93 | .as_mut() { inner.activated(entity, components, services) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/system/lazy.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | / self.inner [INFO] [stderr] 104 | | .as_mut() [INFO] [stderr] 105 | | .map(|inner| inner.reactivated(entity, components, services)); [INFO] [stderr] | |_________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 103 | if let Some(inner) = self.inner [INFO] [stderr] 104 | .as_mut() { inner.reactivated(entity, components, services) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/system/lazy.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | / self.inner [INFO] [stderr] 115 | | .as_mut() [INFO] [stderr] 116 | | .map(|inner| inner.deactivated(entity, components, services)); [INFO] [stderr] | |_________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 114 | if let Some(inner) = self.inner [INFO] [stderr] 115 | .as_mut() { inner.deactivated(entity, components, services) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/system/lazy.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | self.inner.as_mut().map(|inner| inner.process(data)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(inner) = self.inner.as_mut() { inner.process(data) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `world::World` [INFO] [stderr] --> src/world.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | / pub fn new() -> Self [INFO] [stderr] 76 | | where [INFO] [stderr] 77 | | S::Services: Default, [INFO] [stderr] 78 | | { [INFO] [stderr] 79 | | World::with_services(Default::default()) [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 71 | impl Default for world::World { [INFO] [stderr] 72 | fn default() -> Self { [INFO] [stderr] 73 | Self::new() [INFO] [stderr] 74 | } [INFO] [stderr] 75 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `conniecs`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you probably are missing some parameter in your format string [INFO] [stderr] --> src/component.rs:172:20 [INFO] [stderr] | [INFO] [stderr] 172 | panic!("Entity at index {} does not have this component attached") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::panic_params)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic_params [INFO] [stderr] [INFO] [stderr] warning: you probably are missing some parameter in your format string [INFO] [stderr] --> src/component.rs:178:20 [INFO] [stderr] | [INFO] [stderr] 178 | panic!("Entity at index {} does not have this component attached") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic_params [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/entity/iter.rs:60:21 [INFO] [stderr] | [INFO] [stderr] 60 | values: self.values.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 60 | values: &(*self.values).clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 60 | values: &vec_map::VecMap>::clone(self.values), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `entity::manager::EntityManager` [INFO] [stderr] --> src/entity/manager.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn new() -> Self { [INFO] [stderr] 35 | | EntityManager { [INFO] [stderr] 36 | | indices: IndexPool::new(), [INFO] [stderr] 37 | | indexed_entities: VecMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 41 | | } [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 19 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `system::entity::EntitySystem` [INFO] [stderr] --> src/system/entity.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | / pub fn new() -> EntitySystem { [INFO] [stderr] 102 | | EntitySystem { [INFO] [stderr] 103 | | inner: T::build_system(), [INFO] [stderr] 104 | | watcher: Watcher::new(T::create_aspect()), [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 97 | impl Default for system::entity::EntitySystem { [INFO] [stderr] 98 | fn default() -> Self { [INFO] [stderr] 99 | Self::new() [INFO] [stderr] 100 | } [INFO] [stderr] 101 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/system/lazy.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | / self.inner [INFO] [stderr] 93 | | .as_mut() [INFO] [stderr] 94 | | .map(|inner| inner.activated(entity, components, services)); [INFO] [stderr] | |_______________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 92 | if let Some(inner) = self.inner [INFO] [stderr] 93 | .as_mut() { inner.activated(entity, components, services) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/system/lazy.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | / self.inner [INFO] [stderr] 104 | | .as_mut() [INFO] [stderr] 105 | | .map(|inner| inner.reactivated(entity, components, services)); [INFO] [stderr] | |_________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 103 | if let Some(inner) = self.inner [INFO] [stderr] 104 | .as_mut() { inner.reactivated(entity, components, services) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/system/lazy.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | / self.inner [INFO] [stderr] 115 | | .as_mut() [INFO] [stderr] 116 | | .map(|inner| inner.deactivated(entity, components, services)); [INFO] [stderr] | |_________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 114 | if let Some(inner) = self.inner [INFO] [stderr] 115 | .as_mut() { inner.deactivated(entity, components, services) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/system/lazy.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | self.inner.as_mut().map(|inner| inner.process(data)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(inner) = self.inner.as_mut() { inner.process(data) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `world::World` [INFO] [stderr] --> src/world.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | / pub fn new() -> Self [INFO] [stderr] 76 | | where [INFO] [stderr] 77 | | S::Services: Default, [INFO] [stderr] 78 | | { [INFO] [stderr] 79 | | World::with_services(Default::default()) [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 71 | impl Default for world::World { [INFO] [stderr] 72 | fn default() -> Self { [INFO] [stderr] 73 | Self::new() [INFO] [stderr] 74 | } [INFO] [stderr] 75 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `conniecs`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "41ba30934c31e1e1931f902c756fec7f1d379cee5661bb39d240dde6bc61ba27"` [INFO] running `"docker" "rm" "-f" "41ba30934c31e1e1931f902c756fec7f1d379cee5661bb39d240dde6bc61ba27"` [INFO] [stdout] 41ba30934c31e1e1931f902c756fec7f1d379cee5661bb39d240dde6bc61ba27