[INFO] crate connect 0.1.1 is already in cache [INFO] extracting crate connect 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/connect/0.1.1 [INFO] extracting crate connect 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/connect/0.1.1 [INFO] validating manifest of connect-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of connect-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing connect-0.1.1 [INFO] finished frobbing connect-0.1.1 [INFO] frobbed toml for connect-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/connect/0.1.1/Cargo.toml [INFO] started frobbing connect-0.1.1 [INFO] finished frobbing connect-0.1.1 [INFO] frobbed toml for connect-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/connect/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting connect-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/connect/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3252bb68bc105adbba2a2a8a6daa4f83129d13df139bf131c87d8393d798f13b [INFO] running `"docker" "start" "-a" "3252bb68bc105adbba2a2a8a6daa4f83129d13df139bf131c87d8393d798f13b"` [INFO] [stderr] Checking bytes v0.4.11 [INFO] [stderr] Checking mio-extras v2.0.5 [INFO] [stderr] Checking log4rs v0.8.1 [INFO] [stderr] Checking config v0.8.0 [INFO] [stderr] Checking connect v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/consensus/state_machine.rs:788:33 [INFO] [stderr] | [INFO] [stderr] 788 | previous_log_index: previous_log_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `previous_log_index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/consensus/state_machine.rs:789:33 [INFO] [stderr] | [INFO] [stderr] 789 | previous_log_term: previous_log_term, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `previous_log_term` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/consensus/state_machine.rs:788:33 [INFO] [stderr] | [INFO] [stderr] 788 | previous_log_index: previous_log_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `previous_log_index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/consensus/state_machine.rs:789:33 [INFO] [stderr] | [INFO] [stderr] 789 | previous_log_term: previous_log_term, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `previous_log_term` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/cluster/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod cluster; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/server/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | mod server; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused variable: `index` [INFO] [stderr] --> src/consensus/node_state.rs:80:32 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn add_logs(&mut self, index: LogIndex, mut logs: Vec) -> Result<(), Error> { [INFO] [stderr] | ^^^^^ help: consider using `_index` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `match_indexes` [INFO] [stderr] --> src/consensus/state_machine.rs:754:17 [INFO] [stderr] | [INFO] [stderr] 754 | match_indexes, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try ignoring the field: `match_indexes: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `handle` [INFO] [stderr] --> src/executor/client_server_executor.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | let handle = connection.handle(); [INFO] [stderr] | ^^^^^^ help: consider using `_handle` instead [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/cluster/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod cluster; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/server/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | mod server; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_last_applied` [INFO] [stderr] --> src/consensus/node_state.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn get_last_applied(&self) -> LogIndex { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_last_applied` [INFO] [stderr] --> src/consensus/node_state.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn set_last_applied(&mut self, last_applied: LogIndex) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `on_read` [INFO] [stderr] --> src/server/server.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | pub(crate) on_read: R, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `on_write` [INFO] [stderr] --> src/server/server.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | pub(crate) on_write: W, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `service_type` [INFO] [stderr] --> src/server/server.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | pub(crate) service_type: ServiceType, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cluster/cluster.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | / self.members [INFO] [stderr] 39 | | .get(&self.local_node_id) [INFO] [stderr] 40 | | .unwrap() [INFO] [stderr] | |_____________________^ help: try this: `&self.members[&self.local_node_id]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cluster/cluster.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | / self.members [INFO] [stderr] 47 | | .get(&self.local_node_id) [INFO] [stderr] 48 | | .unwrap() [INFO] [stderr] | |_____________________^ help: try this: `&self.members[&self.local_node_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cluster/cluster.rs:62:36 [INFO] [stderr] | [INFO] [stderr] 62 | remote_peer_addrs.push(self.members.get(member_id).unwrap().get_peer_addr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.members[member_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cluster/cluster.rs:78:38 [INFO] [stderr] | [INFO] [stderr] 78 | remote_client_addrs.push(self.members.get(member_id).unwrap().get_client_addr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.members[member_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cluster/cluster.rs:101:44 [INFO] [stderr] | [INFO] [stderr] 101 | pub fn get_peer_addr(&self, member_id: &NodeId) -> Option { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `NodeId` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cluster/cluster.rs:106:46 [INFO] [stderr] | [INFO] [stderr] 106 | pub fn get_client_addr(&self, member_id: &NodeId) -> Option { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `NodeId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cluster/cluster.rs:118:33 [INFO] [stderr] | [INFO] [stderr] 118 | let local_node_id: u8 = config [INFO] [stderr] | _________________________________^ [INFO] [stderr] 119 | | .get_table("local") [INFO] [stderr] 120 | | .unwrap() [INFO] [stderr] 121 | | .get("id") [INFO] [stderr] 122 | | .unwrap() [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 118 | let local_node_id: u8 = &config [INFO] [stderr] 119 | .get_table("local") [INFO] [stderr] 120 | .unwrap()["id"] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cluster/cluster.rs:133:17 [INFO] [stderr] | [INFO] [stderr] 133 | member.get("id").unwrap().clone().try_into().unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&member["id"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cluster/cluster.rs:135:21 [INFO] [stderr] | [INFO] [stderr] 135 | / member [INFO] [stderr] 136 | | .get("ip_addr") [INFO] [stderr] 137 | | .unwrap() [INFO] [stderr] | |_________________________________^ help: try this: `&member["ip_addr"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cluster/cluster.rs:143:21 [INFO] [stderr] | [INFO] [stderr] 143 | / member [INFO] [stderr] 144 | | .get("client_port") [INFO] [stderr] 145 | | .unwrap() [INFO] [stderr] | |_________________________________^ help: try this: `&member["client_port"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cluster/cluster.rs:149:21 [INFO] [stderr] | [INFO] [stderr] 149 | member.get("peer_port").unwrap().clone().try_into().unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&member["peer_port"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 48 [INFO] [stderr] --> src/consensus/state_machine.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | / pub fn handle_peer_request( [INFO] [stderr] 38 | | &self, [INFO] [stderr] 39 | | request: PeerRequest, [INFO] [stderr] 40 | | timeout: Timeout, [INFO] [stderr] ... | [INFO] [stderr] 413 | | } [INFO] [stderr] 414 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/consensus/state_machine.rs:604:29 [INFO] [stderr] | [INFO] [stderr] 604 | *next_index = *next_index - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*next_index -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/consensus/timeout.rs:167:40 [INFO] [stderr] | [INFO] [stderr] 167 | Some((instant, _)) => Some(instant.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `instant` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/consensus/timeout.rs:172:48 [INFO] [stderr] | [INFO] [stderr] 172 | pub fn get_request_timeout(&self, node_id: &NodeId) -> Option { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `NodeId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/consensus/timeout.rs:177:40 [INFO] [stderr] | [INFO] [stderr] 177 | Some((instant, _)) => Some(instant.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*instant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/executor/peer_server_executor.rs:27:30 [INFO] [stderr] | [INFO] [stderr] 27 | fn init_broadcaster() -> ( [INFO] [stderr] | ______________________________^ [INFO] [stderr] 28 | | Sender<(NodeId, PeerRequest)>, [INFO] [stderr] 29 | | Receiver<(NodeId, PeerRequest)>, [INFO] [stderr] 30 | | ) { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: unused variable: `index` [INFO] [stderr] --> src/consensus/node_state.rs:80:32 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn add_logs(&mut self, index: LogIndex, mut logs: Vec) -> Result<(), Error> { [INFO] [stderr] | ^^^^^ help: consider using `_index` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `match_indexes` [INFO] [stderr] --> src/consensus/state_machine.rs:754:17 [INFO] [stderr] | [INFO] [stderr] 754 | match_indexes, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try ignoring the field: `match_indexes: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `handle` [INFO] [stderr] --> src/executor/client_server_executor.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | let handle = connection.handle(); [INFO] [stderr] | ^^^^^^ help: consider using `_handle` instead [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/executor/peer_server_executor.rs:183:5 [INFO] [stderr] | [INFO] [stderr] 183 | / fn readable( [INFO] [stderr] 184 | | index: usize, [INFO] [stderr] 185 | | buf: &mut [u8; BUF_SIZE], [INFO] [stderr] 186 | | poll: &Poll, [INFO] [stderr] ... | [INFO] [stderr] 250 | | } [INFO] [stderr] 251 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_last_applied` [INFO] [stderr] --> src/consensus/node_state.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn get_last_applied(&self) -> LogIndex { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_last_applied` [INFO] [stderr] --> src/consensus/node_state.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn set_last_applied(&mut self, last_applied: LogIndex) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `on_read` [INFO] [stderr] --> src/server/server.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | pub(crate) on_read: R, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `on_write` [INFO] [stderr] --> src/server/server.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | pub(crate) on_write: W, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `service_type` [INFO] [stderr] --> src/server/server.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | pub(crate) service_type: ServiceType, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cluster/cluster.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | / self.members [INFO] [stderr] 39 | | .get(&self.local_node_id) [INFO] [stderr] 40 | | .unwrap() [INFO] [stderr] | |_____________________^ help: try this: `&self.members[&self.local_node_id]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cluster/cluster.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | / self.members [INFO] [stderr] 47 | | .get(&self.local_node_id) [INFO] [stderr] 48 | | .unwrap() [INFO] [stderr] | |_____________________^ help: try this: `&self.members[&self.local_node_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cluster/cluster.rs:62:36 [INFO] [stderr] | [INFO] [stderr] 62 | remote_peer_addrs.push(self.members.get(member_id).unwrap().get_peer_addr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.members[member_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cluster/cluster.rs:78:38 [INFO] [stderr] | [INFO] [stderr] 78 | remote_client_addrs.push(self.members.get(member_id).unwrap().get_client_addr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.members[member_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cluster/cluster.rs:101:44 [INFO] [stderr] | [INFO] [stderr] 101 | pub fn get_peer_addr(&self, member_id: &NodeId) -> Option { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `NodeId` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cluster/cluster.rs:106:46 [INFO] [stderr] | [INFO] [stderr] 106 | pub fn get_client_addr(&self, member_id: &NodeId) -> Option { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `NodeId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cluster/cluster.rs:118:33 [INFO] [stderr] | [INFO] [stderr] 118 | let local_node_id: u8 = config [INFO] [stderr] | _________________________________^ [INFO] [stderr] 119 | | .get_table("local") [INFO] [stderr] 120 | | .unwrap() [INFO] [stderr] 121 | | .get("id") [INFO] [stderr] 122 | | .unwrap() [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 118 | let local_node_id: u8 = &config [INFO] [stderr] 119 | .get_table("local") [INFO] [stderr] 120 | .unwrap()["id"] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cluster/cluster.rs:133:17 [INFO] [stderr] | [INFO] [stderr] 133 | member.get("id").unwrap().clone().try_into().unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&member["id"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cluster/cluster.rs:135:21 [INFO] [stderr] | [INFO] [stderr] 135 | / member [INFO] [stderr] 136 | | .get("ip_addr") [INFO] [stderr] 137 | | .unwrap() [INFO] [stderr] | |_________________________________^ help: try this: `&member["ip_addr"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cluster/cluster.rs:143:21 [INFO] [stderr] | [INFO] [stderr] 143 | / member [INFO] [stderr] 144 | | .get("client_port") [INFO] [stderr] 145 | | .unwrap() [INFO] [stderr] | |_________________________________^ help: try this: `&member["client_port"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cluster/cluster.rs:149:21 [INFO] [stderr] | [INFO] [stderr] 149 | member.get("peer_port").unwrap().clone().try_into().unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&member["peer_port"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 48 [INFO] [stderr] --> src/consensus/state_machine.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | / pub fn handle_peer_request( [INFO] [stderr] 38 | | &self, [INFO] [stderr] 39 | | request: PeerRequest, [INFO] [stderr] 40 | | timeout: Timeout, [INFO] [stderr] ... | [INFO] [stderr] 413 | | } [INFO] [stderr] 414 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/consensus/state_machine.rs:604:29 [INFO] [stderr] | [INFO] [stderr] 604 | *next_index = *next_index - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*next_index -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/consensus/timeout.rs:167:40 [INFO] [stderr] | [INFO] [stderr] 167 | Some((instant, _)) => Some(instant.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `instant` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/consensus/timeout.rs:172:48 [INFO] [stderr] | [INFO] [stderr] 172 | pub fn get_request_timeout(&self, node_id: &NodeId) -> Option { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `NodeId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/consensus/timeout.rs:177:40 [INFO] [stderr] | [INFO] [stderr] 177 | Some((instant, _)) => Some(instant.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*instant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/executor/peer_server_executor.rs:27:30 [INFO] [stderr] | [INFO] [stderr] 27 | fn init_broadcaster() -> ( [INFO] [stderr] | ______________________________^ [INFO] [stderr] 28 | | Sender<(NodeId, PeerRequest)>, [INFO] [stderr] 29 | | Receiver<(NodeId, PeerRequest)>, [INFO] [stderr] 30 | | ) { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/executor/peer_server_executor.rs:183:5 [INFO] [stderr] | [INFO] [stderr] 183 | / fn readable( [INFO] [stderr] 184 | | index: usize, [INFO] [stderr] 185 | | buf: &mut [u8; BUF_SIZE], [INFO] [stderr] 186 | | poll: &Poll, [INFO] [stderr] ... | [INFO] [stderr] 250 | | } [INFO] [stderr] 251 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.71s [INFO] running `"docker" "inspect" "3252bb68bc105adbba2a2a8a6daa4f83129d13df139bf131c87d8393d798f13b"` [INFO] running `"docker" "rm" "-f" "3252bb68bc105adbba2a2a8a6daa4f83129d13df139bf131c87d8393d798f13b"` [INFO] [stdout] 3252bb68bc105adbba2a2a8a6daa4f83129d13df139bf131c87d8393d798f13b