[INFO] crate conllx 0.11.0 is already in cache
[INFO] extracting crate conllx 0.11.0 into work/ex/clippy-test-run/sources/stable/reg/conllx/0.11.0
[INFO] extracting crate conllx 0.11.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/conllx/0.11.0
[INFO] validating manifest of conllx-0.11.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of conllx-0.11.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing conllx-0.11.0
[INFO] finished frobbing conllx-0.11.0
[INFO] frobbed toml for conllx-0.11.0 written to work/ex/clippy-test-run/sources/stable/reg/conllx/0.11.0/Cargo.toml
[INFO] started frobbing conllx-0.11.0
[INFO] finished frobbing conllx-0.11.0
[INFO] frobbed toml for conllx-0.11.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/conllx/0.11.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting conllx-0.11.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/conllx/0.11.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 9c2dc231f3cdd46bd1a9259cb00d0daeff59272b9737773c095f3b774ca96805
[INFO] running `"docker" "start" "-a" "9c2dc231f3cdd46bd1a9259cb00d0daeff59272b9737773c095f3b774ca96805"`
[INFO] [stderr]     Checking lazy-init v0.3.0
[INFO] [stderr]     Checking quickcheck v0.7.2
[INFO] [stderr]     Checking conllx v0.11.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/io.rs:39:18
[INFO] [stderr]    |
[INFO] [stderr] 39 |         Reader { read: read }
[INFO] [stderr]    |                  ^^^^^^^^^^ help: replace it with: `read`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/io.rs:232:13
[INFO] [stderr]     |
[INFO] [stderr] 232 |             write: write,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `write`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/io.rs:303:13
[INFO] [stderr]     |
[INFO] [stderr] 303 |             writers: writers,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `writers`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/io.rs:172:13
[INFO] [stderr]     |
[INFO] [stderr] 172 | /             return Err(ReadError::ParseIdentifierField {
[INFO] [stderr] 173 | |                 value: "A token identifier should be present".to_owned(),
[INFO] [stderr] 174 | |             }.into())
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 172 |             Err(ReadError::ParseIdentifierField {
[INFO] [stderr] 173 |                 value: "A token identifier should be present".to_owned(),
[INFO] [stderr] 174 |             }.into())
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/token.rs:12:25
[INFO] [stderr]    |
[INFO] [stderr] 12 | pub const EMPTY_TOKEN: &'static str = "_";
[INFO] [stderr]    |                        -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/io.rs:39:18
[INFO] [stderr]    |
[INFO] [stderr] 39 |         Reader { read: read }
[INFO] [stderr]    |                  ^^^^^^^^^^ help: replace it with: `read`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/io.rs:232:13
[INFO] [stderr]     |
[INFO] [stderr] 232 |             write: write,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `write`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/io.rs:303:13
[INFO] [stderr]     |
[INFO] [stderr] 303 |             writers: writers,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `writers`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: item `graph::Sentence` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/graph.rs:121:1
[INFO] [stderr]     |
[INFO] [stderr] 121 | / impl Sentence {
[INFO] [stderr] 122 | |     /// Construct a new sentence.
[INFO] [stderr] 123 | |     ///
[INFO] [stderr] 124 | |     /// The sentence will be constructed such that the first token is
[INFO] [stderr] ...   |
[INFO] [stderr] 211 | |     }
[INFO] [stderr] 212 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/graph.rs:240:22
[INFO] [stderr]     |
[INFO] [stderr] 240 |                 head.unwrap_or("_".to_string()),
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "_".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/graph.rs:241:26
[INFO] [stderr]     |
[INFO] [stderr] 241 |                 head_rel.unwrap_or("_".to_string()),
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "_".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/graph.rs:242:23
[INFO] [stderr]     |
[INFO] [stderr] 242 |                 phead.unwrap_or("_".to_string()),
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "_".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/graph.rs:243:27
[INFO] [stderr]     |
[INFO] [stderr] 243 |                 phead_rel.unwrap_or("_".to_string()),
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "_".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: item `graph::DepGraph<'a>` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/graph.rs:349:1
[INFO] [stderr]     |
[INFO] [stderr] 349 | / impl<'a> DepGraph<'a> {
[INFO] [stderr] 350 | |     /// Return an iterator over the dependents of `head`.
[INFO] [stderr] 351 | |     pub fn dependents(&self, head: usize) -> impl Iterator<Item = DepTriple<&'a str>> {
[INFO] [stderr] 352 | |         dependents_impl(self.inner, self.proj, head)
[INFO] [stderr] ...   |
[INFO] [stderr] 365 | |     }
[INFO] [stderr] 366 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: item `graph::DepGraphMut<'a>` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/graph.rs:414:1
[INFO] [stderr]     |
[INFO] [stderr] 414 | / impl<'a> DepGraphMut<'a> {
[INFO] [stderr] 415 | |     /// Add a dependency relation between `head` and `dependent`.
[INFO] [stderr] 416 | |     ///
[INFO] [stderr] 417 | |     /// If `dependent` already has a head relation, this relation is removed
[INFO] [stderr] ...   |
[INFO] [stderr] 465 | |     }
[INFO] [stderr] 466 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
[INFO] [stderr]    --> src/graph.rs:504:5
[INFO] [stderr]     |
[INFO] [stderr] 504 | /     graph
[INFO] [stderr] 505 | |         .edges_directed(node_index(dependent), Direction::Incoming)
[INFO] [stderr] 506 | |         .filter(|e| e.weight().0 == proj)
[INFO] [stderr] 507 | |         .next()
[INFO] [stderr]     | |_______________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::filter_next)] on by default
[INFO] [stderr]     = note: replace `filter(|e| e.weight().0 == proj).next()` with `find(|e| e.weight().0 == proj)`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next
[INFO] [stderr] 
[INFO] [stderr] error: this loop never actually loops
[INFO] [stderr]   --> src/graph_algo.rs:44:9
[INFO] [stderr]    |
[INFO] [stderr] 44 | /         while let Some(node) = self.cur_stack.pop_front() {
[INFO] [stderr] 45 | |             for succ in graph.neighbors(node) {
[INFO] [stderr] 46 | |                 if self.discovered.visit(succ) {
[INFO] [stderr] 47 | |                     self.next_stack.push_back(succ)
[INFO] [stderr] ...  |
[INFO] [stderr] 51 | |             return Some((node, self.depth));
[INFO] [stderr] 52 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::never_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/io.rs:172:24
[INFO] [stderr]     |
[INFO] [stderr] 172 |               return Err(ReadError::ParseIdentifierField {
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 173 | |                 value: "A token identifier should be present".to_owned(),
[INFO] [stderr] 174 | |             }.into())
[INFO] [stderr]     | |____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] help: consider removing `.into()`
[INFO] [stderr]     |
[INFO] [stderr] 172 |             return Err(ReadError::ParseIdentifierField {
[INFO] [stderr] 173 |                 value: "A token identifier should be present".to_owned(),
[INFO] [stderr] 174 |             })
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/io.rs:178:28
[INFO] [stderr]     |
[INFO] [stderr] 178 |                   return Err(ReadError::ParseIdentifierField {
[INFO] [stderr]     |  ____________________________^
[INFO] [stderr] 179 | |                     value: s.to_owned(),
[INFO] [stderr] 180 | |                 }.into());
[INFO] [stderr]     | |________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] help: consider removing `.into()`
[INFO] [stderr]     |
[INFO] [stderr] 178 |                 return Err(ReadError::ParseIdentifierField {
[INFO] [stderr] 179 |                     value: s.to_owned(),
[INFO] [stderr] 180 |                 });
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `proj::HeadProjectivizer`
[INFO] [stderr]   --> src/proj.rs:27:5
[INFO] [stderr]    |
[INFO] [stderr] 27 | /     pub fn new() -> Self {
[INFO] [stderr] 28 | |         HeadProjectivizer {}
[INFO] [stderr] 29 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 24 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/proj.rs:200:12
[INFO] [stderr]     |
[INFO] [stderr] 200 |         Ok(update_sentence(&graph, sentence))
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 200 |         Ok(())
[INFO] [stderr]     |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/proj.rs:226:9
[INFO] [stderr]     |
[INFO] [stderr] 226 | /         loop {
[INFO] [stderr] 227 | |             match self.deprojectivize_next(&mut graph, &lifted_sorted, &head_labels) {
[INFO] [stderr] 228 | |                 Some(idx) => lifted_sorted.remove(idx),
[INFO] [stderr] 229 | |                 None => break,
[INFO] [stderr] 230 | |             };
[INFO] [stderr] 231 | |         }
[INFO] [stderr]     | |_________^ help: try: `while let Some(idx) = self.deprojectivize_next(&mut graph, &lifted_sorted, &head_labels) { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/proj.rs:233:12
[INFO] [stderr]     |
[INFO] [stderr] 233 |         Ok(update_sentence(&graph, sentence))
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 233 |         Ok(())
[INFO] [stderr]     |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `from_iter` on this type; consider implementing the `std::iter::FromIterator` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/token.rs:211:5
[INFO] [stderr]     |
[INFO] [stderr] 211 | /     pub fn from_iter<I, S, T>(iter: I) -> Self
[INFO] [stderr] 212 | |     where
[INFO] [stderr] 213 | |         I: IntoIterator<Item = (S, Option<T>)>,
[INFO] [stderr] 214 | |         S: Into<String>,
[INFO] [stderr] ...   |
[INFO] [stderr] 227 | |         }
[INFO] [stderr] 228 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `conllx`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/io.rs:172:13
[INFO] [stderr]     |
[INFO] [stderr] 172 | /             return Err(ReadError::ParseIdentifierField {
[INFO] [stderr] 173 | |                 value: "A token identifier should be present".to_owned(),
[INFO] [stderr] 174 | |             }.into())
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 172 |             Err(ReadError::ParseIdentifierField {
[INFO] [stderr] 173 |                 value: "A token identifier should be present".to_owned(),
[INFO] [stderr] 174 |             }.into())
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/token.rs:12:25
[INFO] [stderr]    |
[INFO] [stderr] 12 | pub const EMPTY_TOKEN: &'static str = "_";
[INFO] [stderr]    |                        -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: item `graph::Sentence` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/graph.rs:121:1
[INFO] [stderr]     |
[INFO] [stderr] 121 | / impl Sentence {
[INFO] [stderr] 122 | |     /// Construct a new sentence.
[INFO] [stderr] 123 | |     ///
[INFO] [stderr] 124 | |     /// The sentence will be constructed such that the first token is
[INFO] [stderr] ...   |
[INFO] [stderr] 211 | |     }
[INFO] [stderr] 212 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/graph.rs:240:22
[INFO] [stderr]     |
[INFO] [stderr] 240 |                 head.unwrap_or("_".to_string()),
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "_".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/graph.rs:241:26
[INFO] [stderr]     |
[INFO] [stderr] 241 |                 head_rel.unwrap_or("_".to_string()),
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "_".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/graph.rs:242:23
[INFO] [stderr]     |
[INFO] [stderr] 242 |                 phead.unwrap_or("_".to_string()),
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "_".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/graph.rs:243:27
[INFO] [stderr]     |
[INFO] [stderr] 243 |                 phead_rel.unwrap_or("_".to_string()),
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "_".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: item `graph::DepGraph<'a>` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/graph.rs:349:1
[INFO] [stderr]     |
[INFO] [stderr] 349 | / impl<'a> DepGraph<'a> {
[INFO] [stderr] 350 | |     /// Return an iterator over the dependents of `head`.
[INFO] [stderr] 351 | |     pub fn dependents(&self, head: usize) -> impl Iterator<Item = DepTriple<&'a str>> {
[INFO] [stderr] 352 | |         dependents_impl(self.inner, self.proj, head)
[INFO] [stderr] ...   |
[INFO] [stderr] 365 | |     }
[INFO] [stderr] 366 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: item `graph::DepGraphMut<'a>` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/graph.rs:414:1
[INFO] [stderr]     |
[INFO] [stderr] 414 | / impl<'a> DepGraphMut<'a> {
[INFO] [stderr] 415 | |     /// Add a dependency relation between `head` and `dependent`.
[INFO] [stderr] 416 | |     ///
[INFO] [stderr] 417 | |     /// If `dependent` already has a head relation, this relation is removed
[INFO] [stderr] ...   |
[INFO] [stderr] 465 | |     }
[INFO] [stderr] 466 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
[INFO] [stderr]    --> src/graph.rs:504:5
[INFO] [stderr]     |
[INFO] [stderr] 504 | /     graph
[INFO] [stderr] 505 | |         .edges_directed(node_index(dependent), Direction::Incoming)
[INFO] [stderr] 506 | |         .filter(|e| e.weight().0 == proj)
[INFO] [stderr] 507 | |         .next()
[INFO] [stderr]     | |_______________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::filter_next)] on by default
[INFO] [stderr]     = note: replace `filter(|e| e.weight().0 == proj).next()` with `find(|e| e.weight().0 == proj)`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next
[INFO] [stderr] 
[INFO] [stderr] error: this loop never actually loops
[INFO] [stderr]   --> src/graph_algo.rs:44:9
[INFO] [stderr]    |
[INFO] [stderr] 44 | /         while let Some(node) = self.cur_stack.pop_front() {
[INFO] [stderr] 45 | |             for succ in graph.neighbors(node) {
[INFO] [stderr] 46 | |                 if self.discovered.visit(succ) {
[INFO] [stderr] 47 | |                     self.next_stack.push_back(succ)
[INFO] [stderr] ...  |
[INFO] [stderr] 51 | |             return Some((node, self.depth));
[INFO] [stderr] 52 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::never_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/io.rs:172:24
[INFO] [stderr]     |
[INFO] [stderr] 172 |               return Err(ReadError::ParseIdentifierField {
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 173 | |                 value: "A token identifier should be present".to_owned(),
[INFO] [stderr] 174 | |             }.into())
[INFO] [stderr]     | |____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] help: consider removing `.into()`
[INFO] [stderr]     |
[INFO] [stderr] 172 |             return Err(ReadError::ParseIdentifierField {
[INFO] [stderr] 173 |                 value: "A token identifier should be present".to_owned(),
[INFO] [stderr] 174 |             })
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/io.rs:178:28
[INFO] [stderr]     |
[INFO] [stderr] 178 |                   return Err(ReadError::ParseIdentifierField {
[INFO] [stderr]     |  ____________________________^
[INFO] [stderr] 179 | |                     value: s.to_owned(),
[INFO] [stderr] 180 | |                 }.into());
[INFO] [stderr]     | |________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] help: consider removing `.into()`
[INFO] [stderr]     |
[INFO] [stderr] 178 |                 return Err(ReadError::ParseIdentifierField {
[INFO] [stderr] 179 |                     value: s.to_owned(),
[INFO] [stderr] 180 |                 });
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this call to `as_ref` does nothing
[INFO] [stderr]    --> src/io.rs:356:20
[INFO] [stderr]     |
[INFO] [stderr] 356 |         assert_eq!(correct.as_ref(), sentences.as_slice());
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^ help: try this: `correct`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_asref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `proj::HeadProjectivizer`
[INFO] [stderr]   --> src/proj.rs:27:5
[INFO] [stderr]    |
[INFO] [stderr] 27 | /     pub fn new() -> Self {
[INFO] [stderr] 28 | |         HeadProjectivizer {}
[INFO] [stderr] 29 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 24 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/proj.rs:200:12
[INFO] [stderr]     |
[INFO] [stderr] 200 |         Ok(update_sentence(&graph, sentence))
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 200 |         Ok(())
[INFO] [stderr]     |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/proj.rs:226:9
[INFO] [stderr]     |
[INFO] [stderr] 226 | /         loop {
[INFO] [stderr] 227 | |             match self.deprojectivize_next(&mut graph, &lifted_sorted, &head_labels) {
[INFO] [stderr] 228 | |                 Some(idx) => lifted_sorted.remove(idx),
[INFO] [stderr] 229 | |                 None => break,
[INFO] [stderr] 230 | |             };
[INFO] [stderr] 231 | |         }
[INFO] [stderr]     | |_________^ help: try: `while let Some(idx) = self.deprojectivize_next(&mut graph, &lifted_sorted, &head_labels) { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/proj.rs:233:12
[INFO] [stderr]     |
[INFO] [stderr] 233 |         Ok(update_sentence(&graph, sentence))
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 233 |         Ok(())
[INFO] [stderr]     |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `from_iter` on this type; consider implementing the `std::iter::FromIterator` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/token.rs:211:5
[INFO] [stderr]     |
[INFO] [stderr] 211 | /     pub fn from_iter<I, S, T>(iter: I) -> Self
[INFO] [stderr] 212 | |     where
[INFO] [stderr] 213 | |         I: IntoIterator<Item = (S, Option<T>)>,
[INFO] [stderr] 214 | |         S: Into<String>,
[INFO] [stderr] ...   |
[INFO] [stderr] 227 | |         }
[INFO] [stderr] 228 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `conllx`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "9c2dc231f3cdd46bd1a9259cb00d0daeff59272b9737773c095f3b774ca96805"`
[INFO] running `"docker" "rm" "-f" "9c2dc231f3cdd46bd1a9259cb00d0daeff59272b9737773c095f3b774ca96805"`
[INFO] [stdout] 9c2dc231f3cdd46bd1a9259cb00d0daeff59272b9737773c095f3b774ca96805