[INFO] crate conjecture 0.4.0 is already in cache [INFO] extracting crate conjecture 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/conjecture/0.4.0 [INFO] extracting crate conjecture 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/conjecture/0.4.0 [INFO] validating manifest of conjecture-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of conjecture-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing conjecture-0.4.0 [INFO] finished frobbing conjecture-0.4.0 [INFO] frobbed toml for conjecture-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/conjecture/0.4.0/Cargo.toml [INFO] started frobbing conjecture-0.4.0 [INFO] finished frobbing conjecture-0.4.0 [INFO] frobbed toml for conjecture-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/conjecture/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting conjecture-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/conjecture/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6efde60543ba055032eec73a18535a7afc96346275ceb9c6b67fbab46d09dd17 [INFO] running `"docker" "start" "-a" "6efde60543ba055032eec73a18535a7afc96346275ceb9c6b67fbab46d09dd17"` [INFO] [stderr] Checking conjecture v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | status: status, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `status` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data.rs:138:29 [INFO] [stderr] | [INFO] [stderr] 138 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data.rs:139:29 [INFO] [stderr] | [INFO] [stderr] 139 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data.rs:140:29 [INFO] [stderr] | [INFO] [stderr] 140 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:112:40 [INFO] [stderr] | [INFO] [stderr] 112 | TestDatabase { _temp: dir, db: db } [INFO] [stderr] | ^^^^^^ help: replace it with: `db` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/distributions.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | min_count: min_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `min_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/distributions.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | max_count: max_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/distributions.rs:202:26 [INFO] [stderr] | [INFO] [stderr] 202 | return Sampler { table: table }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:200:13 [INFO] [stderr] | [INFO] [stderr] 200 | main_loop: main_loop, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `main_loop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:202:13 [INFO] [stderr] | [INFO] [stderr] 202 | shrink_target: shrink_target, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `shrink_target` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/engine.rs:312:17 [INFO] [stderr] | [INFO] [stderr] 312 | let n = target.draws[j].end; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/engine.rs:322:21 [INFO] [stderr] | [INFO] [stderr] 322 | let (m, n) = stack.pop().unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:586:13 [INFO] [stderr] | [INFO] [stderr] 586 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:587:13 [INFO] [stderr] | [INFO] [stderr] 587 | max_examples: max_examples, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_examples` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | status: status, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `status` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data.rs:138:29 [INFO] [stderr] | [INFO] [stderr] 138 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data.rs:139:29 [INFO] [stderr] | [INFO] [stderr] 139 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data.rs:140:29 [INFO] [stderr] | [INFO] [stderr] 140 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:112:40 [INFO] [stderr] | [INFO] [stderr] 112 | TestDatabase { _temp: dir, db: db } [INFO] [stderr] | ^^^^^^ help: replace it with: `db` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/distributions.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | min_count: min_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `min_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/distributions.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | max_count: max_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/distributions.rs:202:26 [INFO] [stderr] | [INFO] [stderr] 202 | return Sampler { table: table }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:200:13 [INFO] [stderr] | [INFO] [stderr] 200 | main_loop: main_loop, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `main_loop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:202:13 [INFO] [stderr] | [INFO] [stderr] 202 | shrink_target: shrink_target, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `shrink_target` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/engine.rs:312:17 [INFO] [stderr] | [INFO] [stderr] 312 | let n = target.draws[j].end; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/engine.rs:322:21 [INFO] [stderr] | [INFO] [stderr] 322 | let (m, n) = stack.pop().unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:586:13 [INFO] [stderr] | [INFO] [stderr] 586 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine.rs:587:13 [INFO] [stderr] | [INFO] [stderr] 587 | max_examples: max_examples, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_examples` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / return DataSource { [INFO] [stderr] 52 | | bitgenerator: generator, [INFO] [stderr] 53 | | record: DataStream::new(), [INFO] [stderr] 54 | | sizes: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 57 | | written_indices: HashSet::new(), [INFO] [stderr] 58 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 51 | DataSource { [INFO] [stderr] 52 | bitgenerator: generator, [INFO] [stderr] 53 | record: DataStream::new(), [INFO] [stderr] 54 | sizes: Vec::new(), [INFO] [stderr] 55 | draws: Vec::new(), [INFO] [stderr] 56 | draw_stack: Vec::new(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | return DataSource::new(BitGenerator::Random(random)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DataSource::new(BitGenerator::Random(random))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | return DataSource::new(BitGenerator::Recorded(record)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DataSource::new(BitGenerator::Recorded(record))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | return Ok(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/database.rs:23:51 [INFO] [stderr] | [INFO] [stderr] 23 | fn save(&mut self, _key: &Key, _value: &[u8]) -> () {} [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/database.rs:24:53 [INFO] [stderr] | [INFO] [stderr] 24 | fn delete(&mut self, _key: &Key, _value: &[u8]) -> () {} [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/database.rs:72:49 [INFO] [stderr] | [INFO] [stderr] 72 | fn save(&mut self, key: &Key, value: &[u8]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/database.rs:78:51 [INFO] [stderr] | [INFO] [stderr] 78 | fn delete(&mut self, key: &Key, value: &[u8]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/distributions.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | return Ok(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/distributions.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | / return self.primary [INFO] [stderr] 109 | | .cmp(&other.primary) [INFO] [stderr] 110 | | .then(self.alternate.cmp(&other.alternate)); [INFO] [stderr] | |________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 108 | self.primary [INFO] [stderr] 109 | .cmp(&other.primary) [INFO] [stderr] 110 | .then(self.alternate.cmp(&other.alternate)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/distributions.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | return Some(self.cmp(other)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(self.cmp(other))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/distributions.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | return self.cmp(other) == Ordering::Equal; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.cmp(other) == Ordering::Equal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/distributions.rs:202:9 [INFO] [stderr] | [INFO] [stderr] 202 | return Sampler { table: table }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Sampler { table: table }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/engine.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | return Err(LoopExitReason::Complete); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(LoopExitReason::Complete)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/engine.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | return Err(LoopExitReason::MaxExamples); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(LoopExitReason::MaxExamples)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/engine.rs:389:9 [INFO] [stderr] | [INFO] [stderr] 389 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/engine.rs:615:73 [INFO] [stderr] | [INFO] [stderr] 615 | pub fn mark_finished(&mut self, source: DataSource, status: Status) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/engine.rs:629:51 [INFO] [stderr] | [INFO] [stderr] 629 | Some(LoopCommand::RunThis(source)) => return Some(source), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(source)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/engine.rs:633:17 [INFO] [stderr] | [INFO] [stderr] 633 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/engine.rs:669:59 [INFO] [stderr] | [INFO] [stderr] 669 | fn consume_test_result(&mut self, result: TestResult) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/engine.rs:674:20 [INFO] [stderr] | [INFO] [stderr] 674 | return (); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/engine.rs:721:39 [INFO] [stderr] | [INFO] [stderr] 721 | fn await_loop_response(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / return DataSource { [INFO] [stderr] 52 | | bitgenerator: generator, [INFO] [stderr] 53 | | record: DataStream::new(), [INFO] [stderr] 54 | | sizes: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 57 | | written_indices: HashSet::new(), [INFO] [stderr] 58 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 51 | DataSource { [INFO] [stderr] 52 | bitgenerator: generator, [INFO] [stderr] 53 | record: DataStream::new(), [INFO] [stderr] 54 | sizes: Vec::new(), [INFO] [stderr] 55 | draws: Vec::new(), [INFO] [stderr] 56 | draw_stack: Vec::new(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | return DataSource::new(BitGenerator::Random(random)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DataSource::new(BitGenerator::Random(random))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | return DataSource::new(BitGenerator::Recorded(record)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DataSource::new(BitGenerator::Recorded(record))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | return Ok(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/database.rs:23:51 [INFO] [stderr] | [INFO] [stderr] 23 | fn save(&mut self, _key: &Key, _value: &[u8]) -> () {} [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/database.rs:24:53 [INFO] [stderr] | [INFO] [stderr] 24 | fn delete(&mut self, _key: &Key, _value: &[u8]) -> () {} [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/database.rs:72:49 [INFO] [stderr] | [INFO] [stderr] 72 | fn save(&mut self, key: &Key, value: &[u8]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/database.rs:78:51 [INFO] [stderr] | [INFO] [stderr] 78 | fn delete(&mut self, key: &Key, value: &[u8]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/database.rs:117:53 [INFO] [stderr] | [INFO] [stderr] 117 | fn save(&mut self, key: &Key, value: &[u8]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/database.rs:121:55 [INFO] [stderr] | [INFO] [stderr] 121 | fn delete(&mut self, key: &Key, value: &[u8]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/distributions.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | return Ok(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/distributions.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | / return self.primary [INFO] [stderr] 109 | | .cmp(&other.primary) [INFO] [stderr] 110 | | .then(self.alternate.cmp(&other.alternate)); [INFO] [stderr] | |________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 108 | self.primary [INFO] [stderr] 109 | .cmp(&other.primary) [INFO] [stderr] 110 | .then(self.alternate.cmp(&other.alternate)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/distributions.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | return Some(self.cmp(other)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(self.cmp(other))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/distributions.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | return self.cmp(other) == Ordering::Equal; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.cmp(other) == Ordering::Equal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/distributions.rs:202:9 [INFO] [stderr] | [INFO] [stderr] 202 | return Sampler { table: table }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Sampler { table: table }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/engine.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | return Err(LoopExitReason::Complete); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(LoopExitReason::Complete)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/engine.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | return Err(LoopExitReason::MaxExamples); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(LoopExitReason::MaxExamples)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/engine.rs:389:9 [INFO] [stderr] | [INFO] [stderr] 389 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/engine.rs:615:73 [INFO] [stderr] | [INFO] [stderr] 615 | pub fn mark_finished(&mut self, source: DataSource, status: Status) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/engine.rs:629:51 [INFO] [stderr] | [INFO] [stderr] 629 | Some(LoopCommand::RunThis(source)) => return Some(source), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(source)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/engine.rs:633:17 [INFO] [stderr] | [INFO] [stderr] 633 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/engine.rs:669:59 [INFO] [stderr] | [INFO] [stderr] 669 | fn consume_test_result(&mut self, result: TestResult) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/engine.rs:674:20 [INFO] [stderr] | [INFO] [stderr] 674 | return (); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/engine.rs:721:39 [INFO] [stderr] | [INFO] [stderr] 721 | fn await_loop_response(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/intminimize.rs:133:17 [INFO] [stderr] | [INFO] [stderr] 133 | let x = 0b101010101010; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0b1010_1010_1010` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/intminimize.rs:134:17 [INFO] [stderr] | [INFO] [stderr] 134 | let y = 0b111111111111; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0b1111_1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/intminimize.rs:141:22 [INFO] [stderr] | [INFO] [stderr] 141 | let x: u64 = 0b1011011011000111; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b1011_0110_1100_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/intminimize.rs:142:22 [INFO] [stderr] | [INFO] [stderr] 142 | let y: u64 = 0b0000001111111111; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0011_1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/data.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | assert!(self.draws.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.draws.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/data.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | assert!(self.draw_stack.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.draw_stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/data.rs:122:22 [INFO] [stderr] | [INFO] [stderr] 122 | pub fn to_result(mut self, status: Status) -> TestResult { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/distributions.rs:26:26 [INFO] [stderr] | [INFO] [stderr] 26 | let bitlength = 64 - max.leading_zeros() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(max.leading_zeros())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/distributions.rs:138:17 [INFO] [stderr] | [INFO] [stderr] 138 | assert!(weights.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!weights.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/distributions.rs:154:16 [INFO] [stderr] | [INFO] [stderr] 154 | if scaled == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider comparing them within some error: `(scaled - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/distributions.rs:154:16 [INFO] [stderr] | [INFO] [stderr] 154 | if scaled == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/distributions.rs:193:13 [INFO] [stderr] | [INFO] [stderr] 193 | for ref mut entry in table.iter_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^ ---------------- help: try: `let entry = &mut table.iter_mut();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/distributions.rs:201:17 [INFO] [stderr] | [INFO] [stderr] 201 | assert!(table.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!table.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/distributions.rs:206:17 [INFO] [stderr] | [INFO] [stderr] 206 | assert!(self.table.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.table.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/distributions.rs:209:46 [INFO] [stderr] | [INFO] [stderr] 209 | let use_alternate = weighted(source, entry.use_alternate as f64)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(entry.use_alternate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/engine.rs:111:32 [INFO] [stderr] | [INFO] [stderr] 111 | let keys: Vec = self.minimized_examples.keys().map(|i| *i).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.minimized_examples.keys().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/engine.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | / match result.status { [INFO] [stderr] 135 | | Status::Interesting(_) => return Ok(result), [INFO] [stderr] 136 | | _ => (), [INFO] [stderr] 137 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Status::Interesting(_) = result.status { return Ok(result) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/engine.rs:314:26 [INFO] [stderr] | [INFO] [stderr] 314 | if m < n && (stack.len() == 0 || stack[stack.len() - 1].1 <= m) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/engine.rs:321:15 [INFO] [stderr] | [INFO] [stderr] 321 | while stack.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/engine.rs:426:27 [INFO] [stderr] | [INFO] [stderr] 426 | attempt.drain(i + 1..i + lost_bytes + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `i + 1..=i + lost_bytes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/engine.rs:462:37 [INFO] [stderr] | [INFO] [stderr] 462 | .or_insert_with(|| Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/engine.rs:490:21 [INFO] [stderr] | [INFO] [stderr] 490 | assert!(target.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!target.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/engine.rs:510:32 [INFO] [stderr] | [INFO] [stderr] 510 | fn execute(&mut self, buf: &DataStream) -> Result<(bool, TestResult), LoopExitReason> { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/engine.rs:516:36 [INFO] [stderr] | [INFO] [stderr] 516 | fn incorporate(&mut self, buf: &DataStream) -> Result { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/engine.rs:525:21 [INFO] [stderr] | [INFO] [stderr] 525 | assert!(buf < &self.shrink_target.record); [INFO] [stderr] | ^^^^^^-------------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `self.shrink_target.record` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/engine.rs:639:9 [INFO] [stderr] | [INFO] [stderr] 639 | / match &self.loop_response { [INFO] [stderr] 640 | | &Some(LoopCommand::Finished( [INFO] [stderr] 641 | | _, [INFO] [stderr] 642 | | MainGenerationLoop { [INFO] [stderr] ... | [INFO] [stderr] 651 | | _ => Vec::new(), [INFO] [stderr] 652 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 639 | match self.loop_response { [INFO] [stderr] 640 | Some(LoopCommand::Finished( [INFO] [stderr] 641 | _, [INFO] [stderr] 642 | MainGenerationLoop { [INFO] [stderr] 643 | ref minimized_examples, [INFO] [stderr] 644 | .. [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/engine.rs:647:50 [INFO] [stderr] | [INFO] [stderr] 647 | let mut results: Vec = minimized_examples.values().map(|v| v.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `minimized_examples.values().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/engine.rs:656:9 [INFO] [stderr] | [INFO] [stderr] 656 | / match &self.loop_response { [INFO] [stderr] 657 | | &Some(LoopCommand::Finished( [INFO] [stderr] 658 | | _, [INFO] [stderr] 659 | | MainGenerationLoop { [INFO] [stderr] ... | [INFO] [stderr] 664 | | _ => None, [INFO] [stderr] 665 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 656 | match self.loop_response { [INFO] [stderr] 657 | Some(LoopCommand::Finished( [INFO] [stderr] 658 | _, [INFO] [stderr] 659 | MainGenerationLoop { [INFO] [stderr] 660 | best_example: Some(ref result), [INFO] [stderr] 661 | .. [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/engine.rs:684:9 [INFO] [stderr] | [INFO] [stderr] 684 | / match &self.loop_response { [INFO] [stderr] 685 | | &Some(LoopCommand::Finished(_, ref main_loop)) => { [INFO] [stderr] 686 | | main_loop.interesting_examples == 0 && main_loop.valid_examples == 0 [INFO] [stderr] 687 | | } [INFO] [stderr] 688 | | _ => false, [INFO] [stderr] 689 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 684 | match self.loop_response { [INFO] [stderr] 685 | Some(LoopCommand::Finished(_, ref main_loop)) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/engine.rs:693:9 [INFO] [stderr] | [INFO] [stderr] 693 | / match &self.loop_response { [INFO] [stderr] 694 | | &Some(LoopCommand::Finished(..)) => true, [INFO] [stderr] 695 | | _ => false, [INFO] [stderr] 696 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 693 | match self.loop_response { [INFO] [stderr] 694 | Some(LoopCommand::Finished(..)) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `conjecture`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/data.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | assert!(self.draws.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.draws.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/data.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | assert!(self.draw_stack.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.draw_stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/data.rs:122:22 [INFO] [stderr] | [INFO] [stderr] 122 | pub fn to_result(mut self, status: Status) -> TestResult { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/database.rs:151:17 [INFO] [stderr] | [INFO] [stderr] 151 | assert!(results.len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `results.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/distributions.rs:26:26 [INFO] [stderr] | [INFO] [stderr] 26 | let bitlength = 64 - max.leading_zeros() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(max.leading_zeros())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/distributions.rs:138:17 [INFO] [stderr] | [INFO] [stderr] 138 | assert!(weights.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!weights.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/distributions.rs:154:16 [INFO] [stderr] | [INFO] [stderr] 154 | if scaled == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider comparing them within some error: `(scaled - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/distributions.rs:154:16 [INFO] [stderr] | [INFO] [stderr] 154 | if scaled == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/distributions.rs:193:13 [INFO] [stderr] | [INFO] [stderr] 193 | for ref mut entry in table.iter_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^ ---------------- help: try: `let entry = &mut table.iter_mut();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/distributions.rs:201:17 [INFO] [stderr] | [INFO] [stderr] 201 | assert!(table.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!table.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/distributions.rs:206:17 [INFO] [stderr] | [INFO] [stderr] 206 | assert!(self.table.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.table.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/distributions.rs:209:46 [INFO] [stderr] | [INFO] [stderr] 209 | let use_alternate = weighted(source, entry.use_alternate as f64)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(entry.use_alternate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/engine.rs:111:32 [INFO] [stderr] | [INFO] [stderr] 111 | let keys: Vec = self.minimized_examples.keys().map(|i| *i).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.minimized_examples.keys().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/engine.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | / match result.status { [INFO] [stderr] 135 | | Status::Interesting(_) => return Ok(result), [INFO] [stderr] 136 | | _ => (), [INFO] [stderr] 137 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Status::Interesting(_) = result.status { return Ok(result) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/engine.rs:314:26 [INFO] [stderr] | [INFO] [stderr] 314 | if m < n && (stack.len() == 0 || stack[stack.len() - 1].1 <= m) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/engine.rs:321:15 [INFO] [stderr] | [INFO] [stderr] 321 | while stack.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/engine.rs:426:27 [INFO] [stderr] | [INFO] [stderr] 426 | attempt.drain(i + 1..i + lost_bytes + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `i + 1..=i + lost_bytes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/engine.rs:462:37 [INFO] [stderr] | [INFO] [stderr] 462 | .or_insert_with(|| Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/engine.rs:490:21 [INFO] [stderr] | [INFO] [stderr] 490 | assert!(target.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!target.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/engine.rs:510:32 [INFO] [stderr] | [INFO] [stderr] 510 | fn execute(&mut self, buf: &DataStream) -> Result<(bool, TestResult), LoopExitReason> { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/engine.rs:516:36 [INFO] [stderr] | [INFO] [stderr] 516 | fn incorporate(&mut self, buf: &DataStream) -> Result { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/engine.rs:525:21 [INFO] [stderr] | [INFO] [stderr] 525 | assert!(buf < &self.shrink_target.record); [INFO] [stderr] | ^^^^^^-------------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `self.shrink_target.record` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/engine.rs:639:9 [INFO] [stderr] | [INFO] [stderr] 639 | / match &self.loop_response { [INFO] [stderr] 640 | | &Some(LoopCommand::Finished( [INFO] [stderr] 641 | | _, [INFO] [stderr] 642 | | MainGenerationLoop { [INFO] [stderr] ... | [INFO] [stderr] 651 | | _ => Vec::new(), [INFO] [stderr] 652 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 639 | match self.loop_response { [INFO] [stderr] 640 | Some(LoopCommand::Finished( [INFO] [stderr] 641 | _, [INFO] [stderr] 642 | MainGenerationLoop { [INFO] [stderr] 643 | ref minimized_examples, [INFO] [stderr] 644 | .. [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/engine.rs:647:50 [INFO] [stderr] | [INFO] [stderr] 647 | let mut results: Vec = minimized_examples.values().map(|v| v.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `minimized_examples.values().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/engine.rs:656:9 [INFO] [stderr] | [INFO] [stderr] 656 | / match &self.loop_response { [INFO] [stderr] 657 | | &Some(LoopCommand::Finished( [INFO] [stderr] 658 | | _, [INFO] [stderr] 659 | | MainGenerationLoop { [INFO] [stderr] ... | [INFO] [stderr] 664 | | _ => None, [INFO] [stderr] 665 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 656 | match self.loop_response { [INFO] [stderr] 657 | Some(LoopCommand::Finished( [INFO] [stderr] 658 | _, [INFO] [stderr] 659 | MainGenerationLoop { [INFO] [stderr] 660 | best_example: Some(ref result), [INFO] [stderr] 661 | .. [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/engine.rs:684:9 [INFO] [stderr] | [INFO] [stderr] 684 | / match &self.loop_response { [INFO] [stderr] 685 | | &Some(LoopCommand::Finished(_, ref main_loop)) => { [INFO] [stderr] 686 | | main_loop.interesting_examples == 0 && main_loop.valid_examples == 0 [INFO] [stderr] 687 | | } [INFO] [stderr] 688 | | _ => false, [INFO] [stderr] 689 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 684 | match self.loop_response { [INFO] [stderr] 685 | Some(LoopCommand::Finished(_, ref main_loop)) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/engine.rs:693:9 [INFO] [stderr] | [INFO] [stderr] 693 | / match &self.loop_response { [INFO] [stderr] 694 | | &Some(LoopCommand::Finished(..)) => true, [INFO] [stderr] 695 | | _ => false, [INFO] [stderr] 696 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 693 | match self.loop_response { [INFO] [stderr] 694 | Some(LoopCommand::Finished(..)) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `conjecture`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "6efde60543ba055032eec73a18535a7afc96346275ceb9c6b67fbab46d09dd17"` [INFO] running `"docker" "rm" "-f" "6efde60543ba055032eec73a18535a7afc96346275ceb9c6b67fbab46d09dd17"` [INFO] [stdout] 6efde60543ba055032eec73a18535a7afc96346275ceb9c6b67fbab46d09dd17