[INFO] crate coniferous 0.2.1 is already in cache [INFO] extracting crate coniferous 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/coniferous/0.2.1 [INFO] extracting crate coniferous 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/coniferous/0.2.1 [INFO] validating manifest of coniferous-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of coniferous-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing coniferous-0.2.1 [INFO] finished frobbing coniferous-0.2.1 [INFO] frobbed toml for coniferous-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/coniferous/0.2.1/Cargo.toml [INFO] started frobbing coniferous-0.2.1 [INFO] finished frobbing coniferous-0.2.1 [INFO] frobbed toml for coniferous-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/coniferous/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting coniferous-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/coniferous/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b7f53e95c026a4a305725e49505c510c3c4170951f307197ca47329d810b4066 [INFO] running `"docker" "start" "-a" "b7f53e95c026a4a305725e49505c510c3c4170951f307197ca47329d810b4066"` [INFO] [stderr] Checking parsnip v0.1.3 [INFO] [stderr] Checking coniferous v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / return count [INFO] [stderr] 45 | | .into_iter() [INFO] [stderr] 46 | | .max_by_key(|&(_, c)| c) [INFO] [stderr] 47 | | .map(|(val, _)| val) [INFO] [stderr] 48 | | .expect("Cannot compute the mode of nothing"); [INFO] [stderr] | |______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 44 | count [INFO] [stderr] 45 | .into_iter() [INFO] [stderr] 46 | .max_by_key(|&(_, c)| c) [INFO] [stderr] 47 | .map(|(val, _)| val) [INFO] [stderr] 48 | .expect("Cannot compute the mode of nothing") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | return matrix[node.index as usize] < node.value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `matrix[node.index as usize] < node.value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:64:22 [INFO] [stderr] | [INFO] [stderr] 64 | _ => return node.category.unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `node.category.unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:68:22 [INFO] [stderr] | [INFO] [stderr] 68 | _ => return node.category.unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `node.category.unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | return CARTree::traverse(&self.root_node, &x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CARTree::traverse(&self.root_node, &x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | / return CARTree { [INFO] [stderr] 90 | | root_node: CARTree::best_criteria(x, &y, ¶ms, 0), [INFO] [stderr] 91 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 89 | CARTree { [INFO] [stderr] 90 | root_node: CARTree::best_criteria(x, &y, ¶ms, 0), [INFO] [stderr] 91 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | / return potential_criteria [INFO] [stderr] 109 | | .iter() [INFO] [stderr] 110 | | .flat_map(|v| v.iter()) [INFO] [stderr] 111 | | .cloned() [INFO] [stderr] 112 | | .collect(); [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 108 | potential_criteria [INFO] [stderr] 109 | .iter() [INFO] [stderr] 110 | .flat_map(|v| v.iter()) [INFO] [stderr] 111 | .cloned() [INFO] [stderr] 112 | .collect() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:100:17 [INFO] [stderr] | [INFO] [stderr] 100 | / return rand::thread_rng().gen::() [INFO] [stderr] 101 | | < params.max_features as f64 / x[0].len() as f64; [INFO] [stderr] | |_____________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 100 | rand::thread_rng().gen::() [INFO] [stderr] 101 | < params.max_features as f64 / x[0].len() as f64 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:106:17 [INFO] [stderr] | [INFO] [stderr] 106 | return column; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | return (y1, y2, index1, index2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(y1, y2, index1, index2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | return indicies.par_iter().map(|index| x[*index].clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `indicies.par_iter().map(|index| x[*index].clone()).collect()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | return gini_left + gini_right; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `gini_left + gini_right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:167:17 [INFO] [stderr] | [INFO] [stderr] 167 | / return *CARTree::criteria_options(x, params) [INFO] [stderr] 168 | | .par_iter() [INFO] [stderr] 169 | | .min_by(|a, b| { [INFO] [stderr] 170 | | let gini_a = CARTree::weighted_gini(**a, x, y); [INFO] [stderr] 171 | | let gini_b = CARTree::weighted_gini(**b, x, y); [INFO] [stderr] 172 | | return gini_a.partial_cmp(&gini_b).unwrap_or(Equal); [INFO] [stderr] 173 | | }).unwrap(); [INFO] [stderr] | |________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 167 | *CARTree::criteria_options(x, params) [INFO] [stderr] 168 | .par_iter() [INFO] [stderr] 169 | .min_by(|a, b| { [INFO] [stderr] 170 | let gini_a = CARTree::weighted_gini(**a, x, y); [INFO] [stderr] 171 | let gini_b = CARTree::weighted_gini(**b, x, y); [INFO] [stderr] 172 | return gini_a.partial_cmp(&gini_b).unwrap_or(Equal); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:177:17 [INFO] [stderr] | [INFO] [stderr] 177 | return options[rand::thread_rng().gen_range(0, options.len())]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `options[rand::thread_rng().gen_range(0, options.len())]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:172:25 [INFO] [stderr] | [INFO] [stderr] 172 | return gini_a.partial_cmp(&gini_b).unwrap_or(Equal); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `gini_a.partial_cmp(&gini_b).unwrap_or(Equal)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:211:13 [INFO] [stderr] | [INFO] [stderr] 211 | / return Node { [INFO] [stderr] 212 | | value: best_choice.0, [INFO] [stderr] 213 | | index: best_choice.1, [INFO] [stderr] 214 | | l: Some(left), [INFO] [stderr] 215 | | r: Some(right), [INFO] [stderr] 216 | | category: None, [INFO] [stderr] 217 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 211 | Node { [INFO] [stderr] 212 | value: best_choice.0, [INFO] [stderr] 213 | index: best_choice.1, [INFO] [stderr] 214 | l: Some(left), [INFO] [stderr] 215 | r: Some(right), [INFO] [stderr] 216 | category: None, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:225:13 [INFO] [stderr] | [INFO] [stderr] 225 | / return Node { [INFO] [stderr] 226 | | value: best_choice.0, [INFO] [stderr] 227 | | index: best_choice.1, [INFO] [stderr] 228 | | l: None, [INFO] [stderr] 229 | | r: Some(Arc::new(right)), [INFO] [stderr] 230 | | category: Some(split.0[0]), [INFO] [stderr] 231 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 225 | Node { [INFO] [stderr] 226 | value: best_choice.0, [INFO] [stderr] 227 | index: best_choice.1, [INFO] [stderr] 228 | l: None, [INFO] [stderr] 229 | r: Some(Arc::new(right)), [INFO] [stderr] 230 | category: Some(split.0[0]), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:239:13 [INFO] [stderr] | [INFO] [stderr] 239 | / return Node { [INFO] [stderr] 240 | | value: best_choice.0, [INFO] [stderr] 241 | | index: best_choice.1, [INFO] [stderr] 242 | | l: Some(Arc::new(left)), [INFO] [stderr] 243 | | r: None, [INFO] [stderr] 244 | | category: Some(split.1[0]), [INFO] [stderr] 245 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 239 | Node { [INFO] [stderr] 240 | value: best_choice.0, [INFO] [stderr] 241 | index: best_choice.1, [INFO] [stderr] 242 | l: Some(Arc::new(left)), [INFO] [stderr] 243 | r: None, [INFO] [stderr] 244 | category: Some(split.1[0]), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:259:13 [INFO] [stderr] | [INFO] [stderr] 259 | / return Node { [INFO] [stderr] 260 | | value: best_choice.0, [INFO] [stderr] 261 | | index: best_choice.1, [INFO] [stderr] 262 | | l: Some(Arc::new(left)), [INFO] [stderr] 263 | | r: Some(Arc::new(right)), [INFO] [stderr] 264 | | category: None, [INFO] [stderr] 265 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 259 | Node { [INFO] [stderr] 260 | value: best_choice.0, [INFO] [stderr] 261 | index: best_choice.1, [INFO] [stderr] 262 | l: Some(Arc::new(left)), [INFO] [stderr] 263 | r: Some(Arc::new(right)), [INFO] [stderr] 264 | category: None, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / return count [INFO] [stderr] 45 | | .into_iter() [INFO] [stderr] 46 | | .max_by_key(|&(_, c)| c) [INFO] [stderr] 47 | | .map(|(val, _)| val) [INFO] [stderr] 48 | | .expect("Cannot compute the mode of nothing"); [INFO] [stderr] | |______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 44 | count [INFO] [stderr] 45 | .into_iter() [INFO] [stderr] 46 | .max_by_key(|&(_, c)| c) [INFO] [stderr] 47 | .map(|(val, _)| val) [INFO] [stderr] 48 | .expect("Cannot compute the mode of nothing") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | return matrix[node.index as usize] < node.value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `matrix[node.index as usize] < node.value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:64:22 [INFO] [stderr] | [INFO] [stderr] 64 | _ => return node.category.unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `node.category.unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:68:22 [INFO] [stderr] | [INFO] [stderr] 68 | _ => return node.category.unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `node.category.unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | return CARTree::traverse(&self.root_node, &x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CARTree::traverse(&self.root_node, &x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | / return CARTree { [INFO] [stderr] 90 | | root_node: CARTree::best_criteria(x, &y, ¶ms, 0), [INFO] [stderr] 91 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 89 | CARTree { [INFO] [stderr] 90 | root_node: CARTree::best_criteria(x, &y, ¶ms, 0), [INFO] [stderr] 91 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | / return potential_criteria [INFO] [stderr] 109 | | .iter() [INFO] [stderr] 110 | | .flat_map(|v| v.iter()) [INFO] [stderr] 111 | | .cloned() [INFO] [stderr] 112 | | .collect(); [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 108 | potential_criteria [INFO] [stderr] 109 | .iter() [INFO] [stderr] 110 | .flat_map(|v| v.iter()) [INFO] [stderr] 111 | .cloned() [INFO] [stderr] 112 | .collect() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:100:17 [INFO] [stderr] | [INFO] [stderr] 100 | / return rand::thread_rng().gen::() [INFO] [stderr] 101 | | < params.max_features as f64 / x[0].len() as f64; [INFO] [stderr] | |_____________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 100 | rand::thread_rng().gen::() [INFO] [stderr] 101 | < params.max_features as f64 / x[0].len() as f64 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:106:17 [INFO] [stderr] | [INFO] [stderr] 106 | return column; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | return (y1, y2, index1, index2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(y1, y2, index1, index2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | return indicies.par_iter().map(|index| x[*index].clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `indicies.par_iter().map(|index| x[*index].clone()).collect()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | return gini_left + gini_right; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `gini_left + gini_right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:167:17 [INFO] [stderr] | [INFO] [stderr] 167 | / return *CARTree::criteria_options(x, params) [INFO] [stderr] 168 | | .par_iter() [INFO] [stderr] 169 | | .min_by(|a, b| { [INFO] [stderr] 170 | | let gini_a = CARTree::weighted_gini(**a, x, y); [INFO] [stderr] 171 | | let gini_b = CARTree::weighted_gini(**b, x, y); [INFO] [stderr] 172 | | return gini_a.partial_cmp(&gini_b).unwrap_or(Equal); [INFO] [stderr] 173 | | }).unwrap(); [INFO] [stderr] | |________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 167 | *CARTree::criteria_options(x, params) [INFO] [stderr] 168 | .par_iter() [INFO] [stderr] 169 | .min_by(|a, b| { [INFO] [stderr] 170 | let gini_a = CARTree::weighted_gini(**a, x, y); [INFO] [stderr] 171 | let gini_b = CARTree::weighted_gini(**b, x, y); [INFO] [stderr] 172 | return gini_a.partial_cmp(&gini_b).unwrap_or(Equal); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:177:17 [INFO] [stderr] | [INFO] [stderr] 177 | return options[rand::thread_rng().gen_range(0, options.len())]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `options[rand::thread_rng().gen_range(0, options.len())]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:172:25 [INFO] [stderr] | [INFO] [stderr] 172 | return gini_a.partial_cmp(&gini_b).unwrap_or(Equal); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `gini_a.partial_cmp(&gini_b).unwrap_or(Equal)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:211:13 [INFO] [stderr] | [INFO] [stderr] 211 | / return Node { [INFO] [stderr] 212 | | value: best_choice.0, [INFO] [stderr] 213 | | index: best_choice.1, [INFO] [stderr] 214 | | l: Some(left), [INFO] [stderr] 215 | | r: Some(right), [INFO] [stderr] 216 | | category: None, [INFO] [stderr] 217 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 211 | Node { [INFO] [stderr] 212 | value: best_choice.0, [INFO] [stderr] 213 | index: best_choice.1, [INFO] [stderr] 214 | l: Some(left), [INFO] [stderr] 215 | r: Some(right), [INFO] [stderr] 216 | category: None, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:225:13 [INFO] [stderr] | [INFO] [stderr] 225 | / return Node { [INFO] [stderr] 226 | | value: best_choice.0, [INFO] [stderr] 227 | | index: best_choice.1, [INFO] [stderr] 228 | | l: None, [INFO] [stderr] 229 | | r: Some(Arc::new(right)), [INFO] [stderr] 230 | | category: Some(split.0[0]), [INFO] [stderr] 231 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 225 | Node { [INFO] [stderr] 226 | value: best_choice.0, [INFO] [stderr] 227 | index: best_choice.1, [INFO] [stderr] 228 | l: None, [INFO] [stderr] 229 | r: Some(Arc::new(right)), [INFO] [stderr] 230 | category: Some(split.0[0]), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:239:13 [INFO] [stderr] | [INFO] [stderr] 239 | / return Node { [INFO] [stderr] 240 | | value: best_choice.0, [INFO] [stderr] 241 | | index: best_choice.1, [INFO] [stderr] 242 | | l: Some(Arc::new(left)), [INFO] [stderr] 243 | | r: None, [INFO] [stderr] 244 | | category: Some(split.1[0]), [INFO] [stderr] 245 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 239 | Node { [INFO] [stderr] 240 | value: best_choice.0, [INFO] [stderr] 241 | index: best_choice.1, [INFO] [stderr] 242 | l: Some(Arc::new(left)), [INFO] [stderr] 243 | r: None, [INFO] [stderr] 244 | category: Some(split.1[0]), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:259:13 [INFO] [stderr] | [INFO] [stderr] 259 | / return Node { [INFO] [stderr] 260 | | value: best_choice.0, [INFO] [stderr] 261 | | index: best_choice.1, [INFO] [stderr] 262 | | l: Some(Arc::new(left)), [INFO] [stderr] 263 | | r: Some(Arc::new(right)), [INFO] [stderr] 264 | | category: None, [INFO] [stderr] 265 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 259 | Node { [INFO] [stderr] 260 | value: best_choice.0, [INFO] [stderr] 261 | index: best_choice.1, [INFO] [stderr] 262 | l: Some(Arc::new(left)), [INFO] [stderr] 263 | r: Some(Arc::new(right)), [INFO] [stderr] 264 | category: None, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | / match CARTree::eval_node(node, matrix) { [INFO] [stderr] 62 | | true => match node.l { [INFO] [stderr] 63 | | Some(ref n) => CARTree::traverse(&n, matrix), [INFO] [stderr] 64 | | _ => return node.category.unwrap(), [INFO] [stderr] ... | [INFO] [stderr] 69 | | }, [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 61 | if CARTree::eval_node(node, matrix) { match node.l { [INFO] [stderr] 62 | Some(ref n) => CARTree::traverse(&n, matrix), [INFO] [stderr] 63 | _ => return node.category.unwrap(), [INFO] [stderr] 64 | } } else { match node.r { [INFO] [stderr] 65 | Some(ref n) => CARTree::traverse(&n, matrix), [INFO] [stderr] 66 | _ => return node.category.unwrap(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | / let indicies; [INFO] [stderr] 149 | | if left { [INFO] [stderr] 150 | | indicies = split.2.clone(); [INFO] [stderr] 151 | | } else { [INFO] [stderr] 152 | | indicies = split.3.clone(); [INFO] [stderr] 153 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let indicies = if left { split.2.clone() } else { split.3.clone() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:159:25 [INFO] [stderr] | [INFO] [stderr] 159 | let gini_left = parsnip::gini(&split.0) as f64 * (split.0.len() + 1) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(parsnip::gini(&split.0))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:160:26 [INFO] [stderr] | [INFO] [stderr] 160 | let gini_right = parsnip::gini(&split.1) as f64 * (split.1.len() + 1) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(parsnip::gini(&split.1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | / match CARTree::eval_node(node, matrix) { [INFO] [stderr] 62 | | true => match node.l { [INFO] [stderr] 63 | | Some(ref n) => CARTree::traverse(&n, matrix), [INFO] [stderr] 64 | | _ => return node.category.unwrap(), [INFO] [stderr] ... | [INFO] [stderr] 69 | | }, [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 61 | if CARTree::eval_node(node, matrix) { match node.l { [INFO] [stderr] 62 | Some(ref n) => CARTree::traverse(&n, matrix), [INFO] [stderr] 63 | _ => return node.category.unwrap(), [INFO] [stderr] 64 | } } else { match node.r { [INFO] [stderr] 65 | Some(ref n) => CARTree::traverse(&n, matrix), [INFO] [stderr] 66 | _ => return node.category.unwrap(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | / let indicies; [INFO] [stderr] 149 | | if left { [INFO] [stderr] 150 | | indicies = split.2.clone(); [INFO] [stderr] 151 | | } else { [INFO] [stderr] 152 | | indicies = split.3.clone(); [INFO] [stderr] 153 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let indicies = if left { split.2.clone() } else { split.3.clone() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:159:25 [INFO] [stderr] | [INFO] [stderr] 159 | let gini_left = parsnip::gini(&split.0) as f64 * (split.0.len() + 1) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(parsnip::gini(&split.0))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:160:26 [INFO] [stderr] | [INFO] [stderr] 160 | let gini_right = parsnip::gini(&split.1) as f64 * (split.1.len() + 1) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(parsnip::gini(&split.1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:287:45 [INFO] [stderr] | [INFO] [stderr] 287 | assert_eq!(CARTree::eval_node(>e, &vec![0.01]), false); [INFO] [stderr] | ^^^^^^^^^^^ help: you can use a slice directly: `&[0.01]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:315:51 [INFO] [stderr] | [INFO] [stderr] 315 | let result = CARTree::best_split(&vector, &vec![0, 1, 0], ¶ms); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0, 1, 0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:316:9 [INFO] [stderr] | [INFO] [stderr] 316 | assert_eq!(result.0, 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:316:9 [INFO] [stderr] | [INFO] [stderr] 316 | assert_eq!(result.0, 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:329:57 [INFO] [stderr] | [INFO] [stderr] 329 | let root_node = CARTree::best_criteria(&vector, &vec![0, 1, 0], ¶ms, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0, 1, 0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:343:40 [INFO] [stderr] | [INFO] [stderr] 343 | let dt = CARTree::fit(&vector, &vec![0, 1, 0], params); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0, 1, 0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:344:30 [INFO] [stderr] | [INFO] [stderr] 344 | let res = dt.predict(&vec![0.0, 0.0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0.0, 0.0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `coniferous`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "b7f53e95c026a4a305725e49505c510c3c4170951f307197ca47329d810b4066"` [INFO] running `"docker" "rm" "-f" "b7f53e95c026a4a305725e49505c510c3c4170951f307197ca47329d810b4066"` [INFO] [stdout] b7f53e95c026a4a305725e49505c510c3c4170951f307197ca47329d810b4066