[INFO] crate configure_me_codegen 0.3.2 is already in cache [INFO] extracting crate configure_me_codegen 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/configure_me_codegen/0.3.2 [INFO] extracting crate configure_me_codegen 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/configure_me_codegen/0.3.2 [INFO] validating manifest of configure_me_codegen-0.3.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of configure_me_codegen-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing configure_me_codegen-0.3.2 [INFO] finished frobbing configure_me_codegen-0.3.2 [INFO] frobbed toml for configure_me_codegen-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/configure_me_codegen/0.3.2/Cargo.toml [INFO] started frobbing configure_me_codegen-0.3.2 [INFO] finished frobbing configure_me_codegen-0.3.2 [INFO] frobbed toml for configure_me_codegen-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/configure_me_codegen/0.3.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting configure_me_codegen-0.3.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/configure_me_codegen/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c815187496199224ab3e222b64970f53ab2c1547f27925c8830759e554da2d65 [INFO] running `"docker" "start" "-a" "c815187496199224ab3e222b64970f53ab2c1547f27925c8830759e554da2d65"` [INFO] [stderr] Compiling configure_me_codegen v0.3.2 (/opt/crater/workdir) [INFO] [stderr] Checking roff v0.1.0 [INFO] [stderr] Checking fmt2io v0.1.0 [INFO] [stderr] Checking parse_arg v0.1.2 [INFO] [stderr] Checking semver v0.6.0 [INFO] [stderr] Checking man v0.1.1 [INFO] [stderr] Checking configure_me v0.3.1 [INFO] [stderr] Checking build-helper v0.1.1 [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/codegen.rs:142:21 [INFO] [stderr] | [INFO] [stderr] 142 | write!(output, "\\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/codegen.rs:142:21 [INFO] [stderr] | [INFO] [stderr] 142 | write!(output, "\\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/gen_man.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | opt [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/gen_man.rs:50:23 [INFO] [stderr] | [INFO] [stderr] 50 | let opt = if let ::config::Optionality::DefaultValue(default) = ¶m.optionality { [INFO] [stderr] | _______________________^ [INFO] [stderr] 51 | | opt.default_value(&default) [INFO] [stderr] 52 | | } else { [INFO] [stderr] 53 | | opt [INFO] [stderr] 54 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/gen_man.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | flag [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/gen_man.rs:67:24 [INFO] [stderr] | [INFO] [stderr] 67 | let flag = if let Some(doc) = &switch.doc { [INFO] [stderr] | ________________________^ [INFO] [stderr] 68 | | flag.help(&doc) [INFO] [stderr] 69 | | } else { [INFO] [stderr] 70 | | flag [INFO] [stderr] 71 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/gen_man.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | opt [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/gen_man.rs:50:23 [INFO] [stderr] | [INFO] [stderr] 50 | let opt = if let ::config::Optionality::DefaultValue(default) = ¶m.optionality { [INFO] [stderr] | _______________________^ [INFO] [stderr] 51 | | opt.default_value(&default) [INFO] [stderr] 52 | | } else { [INFO] [stderr] 53 | | opt [INFO] [stderr] 54 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/gen_man.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | flag [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/gen_man.rs:67:24 [INFO] [stderr] | [INFO] [stderr] 67 | let flag = if let Some(doc) = &switch.doc { [INFO] [stderr] | ________________________^ [INFO] [stderr] 68 | | flag.help(&doc) [INFO] [stderr] 69 | | } else { [INFO] [stderr] 70 | | flag [INFO] [stderr] 71 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config.rs:88:20 [INFO] [stderr] | [INFO] [stderr] 88 | if abbr.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!abbr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config.rs:132:34 [INFO] [stderr] | [INFO] [stderr] 132 | Some(chr) if abbr.len() == 0 && ((chr >= 'a' && chr <= 'z') || (chr >= 'A' && chr <= 'Z')) => SwitchKind::WithAbbr(chr), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `abbr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/codegen.rs:109:20 [INFO] [stderr] | [INFO] [stderr] 109 | if doc.len() > 0 || sum_arg_len > (80 - 7) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!doc.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/codegen.rs:133:30 [INFO] [stderr] | [INFO] [stderr] 133 | if !(word.trim().len() == 0 && pos == doc_start) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `word.trim().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/codegen.rs:146:5 [INFO] [stderr] | [INFO] [stderr] 146 | writeln!(output, "\", program_name),"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config.rs:88:20 [INFO] [stderr] | [INFO] [stderr] 88 | if abbr.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!abbr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config.rs:132:34 [INFO] [stderr] | [INFO] [stderr] 132 | Some(chr) if abbr.len() == 0 && ((chr >= 'a' && chr <= 'z') || (chr >= 'A' && chr <= 'Z')) => SwitchKind::WithAbbr(chr), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `abbr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/codegen.rs:109:20 [INFO] [stderr] | [INFO] [stderr] 109 | if doc.len() > 0 || sum_arg_len > (80 - 7) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!doc.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/codegen.rs:133:30 [INFO] [stderr] | [INFO] [stderr] 133 | if !(word.trim().len() == 0 && pos == doc_start) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `word.trim().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/codegen.rs:146:5 [INFO] [stderr] | [INFO] [stderr] 146 | writeln!(output, "\", program_name),"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> /opt/crater/target/debug/build/configure_me_codegen-195df11e31b991fc/out/expected_outputs/single_optional_param-config.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | let foo = self.foo; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> /opt/crater/target/debug/build/configure_me_codegen-195df11e31b991fc/out/expected_outputs/single_optional_param-config.rs:128:25 [INFO] [stderr] | [INFO] [stderr] 128 | let foo = value.map_err(|err| err.map_or(ArgParseError::MissingArgument("--foo"), ArgParseError::FieldFoo))?; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> /opt/crater/target/debug/build/configure_me_codegen-195df11e31b991fc/out/expected_outputs/empty-config.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | / while let Some(arg) = iter.next() { [INFO] [stderr] 115 | | if arg == *"--" { [INFO] [stderr] 116 | | return Ok(None.into_iter().chain(iter)); [INFO] [stderr] 117 | | } else if (arg == *"--help") || (arg == *"-h") { [INFO] [stderr] ... | [INFO] [stderr] 123 | | } [INFO] [stderr] 124 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `configure_me_codegen`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> /opt/crater/target/debug/build/configure_me_codegen-195df11e31b991fc/out/expected_outputs/single_optional_param-config.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | let foo = self.foo; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> /opt/crater/target/debug/build/configure_me_codegen-195df11e31b991fc/out/expected_outputs/single_optional_param-config.rs:128:25 [INFO] [stderr] | [INFO] [stderr] 128 | let foo = value.map_err(|err| err.map_or(ArgParseError::MissingArgument("--foo"), ArgParseError::FieldFoo))?; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> /opt/crater/target/debug/build/configure_me_codegen-195df11e31b991fc/out/expected_outputs/single_mandatory_param-config.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | let foo = self.foo.ok_or(ValidationError::MissingField("foo"))?; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> /opt/crater/target/debug/build/configure_me_codegen-195df11e31b991fc/out/expected_outputs/single_mandatory_param-config.rs:128:25 [INFO] [stderr] | [INFO] [stderr] 128 | let foo = value.map_err(|err| err.map_or(ArgParseError::MissingArgument("--foo"), ArgParseError::FieldFoo))?; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> /opt/crater/target/debug/build/configure_me_codegen-195df11e31b991fc/out/expected_outputs/multiple_params-config.rs:113:17 [INFO] [stderr] | [INFO] [stderr] 113 | let foo = self.foo.unwrap_or_else(|| { 42 }); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> /opt/crater/target/debug/build/configure_me_codegen-195df11e31b991fc/out/expected_outputs/multiple_params-config.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | let bar = self.bar; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `baz` [INFO] [stderr] --> /opt/crater/target/debug/build/configure_me_codegen-195df11e31b991fc/out/expected_outputs/multiple_params-config.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | let baz = self.baz.ok_or(ValidationError::MissingField("baz"))?; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> /opt/crater/target/debug/build/configure_me_codegen-195df11e31b991fc/out/expected_outputs/multiple_params-config.rs:154:25 [INFO] [stderr] | [INFO] [stderr] 154 | let foo = value.map_err(|err| err.map_or(ArgParseError::MissingArgument("--foo"), ArgParseError::FieldFoo))?; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> /opt/crater/target/debug/build/configure_me_codegen-195df11e31b991fc/out/expected_outputs/multiple_params-config.rs:158:25 [INFO] [stderr] | [INFO] [stderr] 158 | let bar = value.map_err(|err| err.map_or(ArgParseError::MissingArgument("--bar"), ArgParseError::FieldBar))?; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `baz` [INFO] [stderr] --> /opt/crater/target/debug/build/configure_me_codegen-195df11e31b991fc/out/expected_outputs/multiple_params-config.rs:162:25 [INFO] [stderr] | [INFO] [stderr] 162 | let baz = value.map_err(|err| err.map_or(ArgParseError::MissingArgument("--baz"), ArgParseError::FieldBaz))?; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "c815187496199224ab3e222b64970f53ab2c1547f27925c8830759e554da2d65"` [INFO] running `"docker" "rm" "-f" "c815187496199224ab3e222b64970f53ab2c1547f27925c8830759e554da2d65"` [INFO] [stdout] c815187496199224ab3e222b64970f53ab2c1547f27925c8830759e554da2d65