[INFO] crate config 0.9.1 is already in cache [INFO] extracting crate config 0.9.1 into work/ex/clippy-test-run/sources/stable/reg/config/0.9.1 [INFO] extracting crate config 0.9.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/config/0.9.1 [INFO] validating manifest of config-0.9.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of config-0.9.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing config-0.9.1 [INFO] finished frobbing config-0.9.1 [INFO] frobbed toml for config-0.9.1 written to work/ex/clippy-test-run/sources/stable/reg/config/0.9.1/Cargo.toml [INFO] started frobbing config-0.9.1 [INFO] finished frobbing config-0.9.1 [INFO] frobbed toml for config-0.9.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/config/0.9.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting config-0.9.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/config/0.9.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 90dd7866b5fbcb58dd0fb7c15cb712e5da01006b24d02da3c47aaeca18d97bf7 [INFO] running `"docker" "start" "-a" "90dd7866b5fbcb58dd0fb7c15cb712e5da01006b24d02da3c47aaeca18d97bf7"` [INFO] [stderr] Checking config v0.9.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | origin: origin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | unexpected: unexpected, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unexpected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | expected: expected, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `expected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:108:17 [INFO] [stderr] | [INFO] [stderr] 108 | origin: origin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:109:17 [INFO] [stderr] | [INFO] [stderr] 109 | unexpected: unexpected, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unexpected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | expected: expected, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `expected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file/source/file.rs:24:26 [INFO] [stderr] | [INFO] [stderr] 24 | FileSourceFile { name: name } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file/mod.rs:120:17 [INFO] [stderr] | [INFO] [stderr] 120 | uri: uri, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `uri` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file/mod.rs:121:17 [INFO] [stderr] | [INFO] [stderr] 121 | cause: cause, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cause` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `cyclomatic_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/path/parser.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | #[allow(cyclomatic_complexity)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cyclomatic_complexity` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | origin: origin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | unexpected: unexpected, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unexpected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | expected: expected, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `expected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:108:17 [INFO] [stderr] | [INFO] [stderr] 108 | origin: origin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:109:17 [INFO] [stderr] | [INFO] [stderr] 109 | unexpected: unexpected, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unexpected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | expected: expected, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `expected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file/source/file.rs:24:26 [INFO] [stderr] | [INFO] [stderr] 24 | FileSourceFile { name: name } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file/mod.rs:120:17 [INFO] [stderr] | [INFO] [stderr] 120 | uri: uri, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `uri` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file/mod.rs:121:17 [INFO] [stderr] | [INFO] [stderr] 121 | cause: cause, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cause` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `cyclomatic_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/path/parser.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | #[allow(cyclomatic_complexity)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cyclomatic_complexity` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `cyclomatic_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/path/parser.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | #[allow(cyclomatic_complexity)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cyclomatic_complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `cyclomatic_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/path/parser.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | #[allow(cyclomatic_complexity)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cyclomatic_complexity` [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/file/format/mod.rs:75:23 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn extensions(&self) -> &'static Vec<&'static str> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/file/format/mod.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | &self, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/path/mod.rs:247:21 [INFO] [stderr] | [INFO] [stderr] 247 | / match parent.kind { [INFO] [stderr] 248 | | ValueKind::Array(ref mut array) => { [INFO] [stderr] 249 | | let uindex = sindex_to_uindex(index, array.len()); [INFO] [stderr] 250 | | if uindex >= array.len() { [INFO] [stderr] ... | [INFO] [stderr] 260 | | _ => (), [INFO] [stderr] 261 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 247 | if let ValueKind::Array(ref mut array) = parent.kind { [INFO] [stderr] 248 | let uindex = sindex_to_uindex(index, array.len()); [INFO] [stderr] 249 | if uindex >= array.len() { [INFO] [stderr] 250 | array.resize( [INFO] [stderr] 251 | (uindex + 1) as usize, [INFO] [stderr] 252 | Value::new(None, ValueKind::Nil), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ser.rs:51:18 [INFO] [stderr] | [INFO] [stderr] 51 | .ok_or(ConfigError::Message(format!( [INFO] [stderr] | __________________^ [INFO] [stderr] 52 | | "last key is not found in {} keys", [INFO] [stderr] 53 | | len [INFO] [stderr] 54 | | ))) [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 51 | .ok_or_else(|| ConfigError::Message(format!( [INFO] [stderr] 52 | "last key is not found in {} keys", [INFO] [stderr] 53 | len [INFO] [stderr] 54 | ))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:100:28 [INFO] [stderr] | [INFO] [stderr] 100 | self.serialize_i64(v as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(v)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:104:28 [INFO] [stderr] | [INFO] [stderr] 104 | self.serialize_i64(v as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:108:28 [INFO] [stderr] | [INFO] [stderr] 108 | self.serialize_i64(v as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:116:28 [INFO] [stderr] | [INFO] [stderr] 116 | self.serialize_u64(v as u64) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:120:28 [INFO] [stderr] | [INFO] [stderr] 120 | self.serialize_u64(v as u64) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:124:28 [INFO] [stderr] | [INFO] [stderr] 124 | self.serialize_u64(v as u64) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:140:28 [INFO] [stderr] | [INFO] [stderr] 140 | self.serialize_f64(v as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/value.rs:42:27 [INFO] [stderr] | [INFO] [stderr] 42 | ValueKind::String(value.into()) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider removing `.into()`: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:421:20 [INFO] [stderr] | [INFO] [stderr] 421 | Ok((value as i64).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:426:20 [INFO] [stderr] | [INFO] [stderr] 426 | Ok((value as i64).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:431:20 [INFO] [stderr] | [INFO] [stderr] 431 | Ok((value as i64).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:441:20 [INFO] [stderr] | [INFO] [stderr] 441 | Ok((value as i64).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:446:20 [INFO] [stderr] | [INFO] [stderr] 446 | Ok((value as i64).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:451:20 [INFO] [stderr] | [INFO] [stderr] 451 | Ok((value as i64).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/file/format/mod.rs:75:23 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn extensions(&self) -> &'static Vec<&'static str> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/file/format/mod.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | &self, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/path/mod.rs:247:21 [INFO] [stderr] | [INFO] [stderr] 247 | / match parent.kind { [INFO] [stderr] 248 | | ValueKind::Array(ref mut array) => { [INFO] [stderr] 249 | | let uindex = sindex_to_uindex(index, array.len()); [INFO] [stderr] 250 | | if uindex >= array.len() { [INFO] [stderr] ... | [INFO] [stderr] 260 | | _ => (), [INFO] [stderr] 261 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 247 | if let ValueKind::Array(ref mut array) = parent.kind { [INFO] [stderr] 248 | let uindex = sindex_to_uindex(index, array.len()); [INFO] [stderr] 249 | if uindex >= array.len() { [INFO] [stderr] 250 | array.resize( [INFO] [stderr] 251 | (uindex + 1) as usize, [INFO] [stderr] 252 | Value::new(None, ValueKind::Nil), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ser.rs:51:18 [INFO] [stderr] | [INFO] [stderr] 51 | .ok_or(ConfigError::Message(format!( [INFO] [stderr] | __________________^ [INFO] [stderr] 52 | | "last key is not found in {} keys", [INFO] [stderr] 53 | | len [INFO] [stderr] 54 | | ))) [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 51 | .ok_or_else(|| ConfigError::Message(format!( [INFO] [stderr] 52 | "last key is not found in {} keys", [INFO] [stderr] 53 | len [INFO] [stderr] 54 | ))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:100:28 [INFO] [stderr] | [INFO] [stderr] 100 | self.serialize_i64(v as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(v)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:104:28 [INFO] [stderr] | [INFO] [stderr] 104 | self.serialize_i64(v as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:108:28 [INFO] [stderr] | [INFO] [stderr] 108 | self.serialize_i64(v as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:116:28 [INFO] [stderr] | [INFO] [stderr] 116 | self.serialize_u64(v as u64) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:120:28 [INFO] [stderr] | [INFO] [stderr] 120 | self.serialize_u64(v as u64) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:124:28 [INFO] [stderr] | [INFO] [stderr] 124 | self.serialize_u64(v as u64) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:140:28 [INFO] [stderr] | [INFO] [stderr] 140 | self.serialize_f64(v as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/value.rs:42:27 [INFO] [stderr] | [INFO] [stderr] 42 | ValueKind::String(value.into()) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider removing `.into()`: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:421:20 [INFO] [stderr] | [INFO] [stderr] 421 | Ok((value as i64).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:426:20 [INFO] [stderr] | [INFO] [stderr] 426 | Ok((value as i64).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:431:20 [INFO] [stderr] | [INFO] [stderr] 431 | Ok((value as i64).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:441:20 [INFO] [stderr] | [INFO] [stderr] 441 | Ok((value as i64).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:446:20 [INFO] [stderr] | [INFO] [stderr] 446 | Ok((value as i64).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:451:20 [INFO] [stderr] | [INFO] [stderr] 451 | Ok((value as i64).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/file_toml.rs:61:47 [INFO] [stderr] | [INFO] [stderr] 61 | assert!(s.place.longitude.approx_eq_ulps(&43.7224985, 2)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `43.722_498_5` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/file_toml.rs:62:46 [INFO] [stderr] | [INFO] [stderr] 62 | assert!(s.place.latitude.approx_eq_ulps(&10.3970522, 2)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `10.397_052_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/file_hjson.rs:51:47 [INFO] [stderr] | [INFO] [stderr] 51 | assert!(s.place.longitude.approx_eq_ulps(&43.7224985, 2)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `43.722_498_5` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/file_hjson.rs:52:46 [INFO] [stderr] | [INFO] [stderr] 52 | assert!(s.place.latitude.approx_eq_ulps(&10.3970522, 2)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `10.397_052_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/get.rs:155:47 [INFO] [stderr] | [INFO] [stderr] 155 | assert!(s.place.longitude.approx_eq_ulps(&43.7224985, 2)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `43.722_498_5` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/get.rs:156:46 [INFO] [stderr] | [INFO] [stderr] 156 | assert!(s.place.latitude.approx_eq_ulps(&10.3970522, 2)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `10.397_052_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/get.rs:172:41 [INFO] [stderr] | [INFO] [stderr] 172 | assert!(p.longitude.approx_eq_ulps(&43.7224985, 2)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `43.722_498_5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/get.rs:173:40 [INFO] [stderr] | [INFO] [stderr] 173 | assert!(p.latitude.approx_eq_ulps(&10.3970522, 2)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `10.397_052_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/file_yaml.rs:51:47 [INFO] [stderr] | [INFO] [stderr] 51 | assert!(s.place.longitude.approx_eq_ulps(&43.7224985, 2)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `43.722_498_5` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/file_yaml.rs:52:46 [INFO] [stderr] | [INFO] [stderr] 52 | assert!(s.place.latitude.approx_eq_ulps(&10.3970522, 2)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `10.397_052_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/file_ini.rs:43:28 [INFO] [stderr] | [INFO] [stderr] 43 | longitude: 43.7224985, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `43.722_498_5` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/file_ini.rs:44:27 [INFO] [stderr] | [INFO] [stderr] 44 | latitude: 10.3970522, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `10.397_052_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/file_json.rs:51:47 [INFO] [stderr] | [INFO] [stderr] 51 | assert!(s.place.longitude.approx_eq_ulps(&43.7224985, 2)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `43.722_498_5` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/file_json.rs:52:46 [INFO] [stderr] | [INFO] [stderr] 52 | assert!(s.place.latitude.approx_eq_ulps(&10.3970522, 2)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `10.397_052_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.15s [INFO] running `"docker" "inspect" "90dd7866b5fbcb58dd0fb7c15cb712e5da01006b24d02da3c47aaeca18d97bf7"` [INFO] running `"docker" "rm" "-f" "90dd7866b5fbcb58dd0fb7c15cb712e5da01006b24d02da3c47aaeca18d97bf7"` [INFO] [stdout] 90dd7866b5fbcb58dd0fb7c15cb712e5da01006b24d02da3c47aaeca18d97bf7