[INFO] crate condvar 0.1.1 is already in cache [INFO] extracting crate condvar 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/condvar/0.1.1 [INFO] extracting crate condvar 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/condvar/0.1.1 [INFO] validating manifest of condvar-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of condvar-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing condvar-0.1.1 [INFO] finished frobbing condvar-0.1.1 [INFO] frobbed toml for condvar-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/condvar/0.1.1/Cargo.toml [INFO] started frobbing condvar-0.1.1 [INFO] finished frobbing condvar-0.1.1 [INFO] frobbed toml for condvar-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/condvar/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting condvar-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/condvar/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 57c54713908c7eabe3cc3e0b9b11fc9001c047a7362295dccd9e8310154982ee [INFO] running `"docker" "start" "-a" "57c54713908c7eabe3cc3e0b9b11fc9001c047a7362295dccd9e8310154982ee"` [INFO] [stderr] Checking condvar v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'std::sync::Condvar::wait_timeout_ms': replaced by `std::sync::Condvar::wait_timeout` [INFO] [stderr] --> src/lib.rs:67:29 [INFO] [stderr] | [INFO] [stderr] 67 | let (new, _) = try!(cvar.wait_timeout_ms(predicate, remaining_ms as u32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `CondVar` [INFO] [stderr] --> src/lib.rs:17:2 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn new() -> ::CondVar { [INFO] [stderr] | _____^ [INFO] [stderr] 18 | | ::CondVar { [INFO] [stderr] 19 | | pair: (Mutex::new(false), Condvar::new()) [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/lib.rs:19:11 [INFO] [stderr] | [INFO] [stderr] 19 | pair: (Mutex::new(false), Condvar::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | / match predicate { [INFO] [stderr] 58 | | Err(poison) => return Err(PoisonError::new((poison.into_inner(),false))), [INFO] [stderr] 59 | | _ => () [INFO] [stderr] 60 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Err(poison) = predicate { return Err(PoisonError::new((poison.into_inner(),false))) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::thread::sleep_ms': replaced by `std::thread::sleep` [INFO] [stderr] --> src/lib.rs:81:20 [INFO] [stderr] | [INFO] [stderr] 81 | use std::thread::{sleep_ms, spawn}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::thread::sleep_ms': replaced by `std::thread::sleep` [INFO] [stderr] --> src/lib.rs:104:4 [INFO] [stderr] | [INFO] [stderr] 104 | sleep_ms(500); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::thread::sleep_ms': replaced by `std::thread::sleep` [INFO] [stderr] --> src/lib.rs:117:4 [INFO] [stderr] | [INFO] [stderr] 117 | sleep_ms(1000); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::sync::Condvar::wait_timeout_ms': replaced by `std::sync::Condvar::wait_timeout` [INFO] [stderr] --> src/lib.rs:67:29 [INFO] [stderr] | [INFO] [stderr] 67 | let (new, _) = try!(cvar.wait_timeout_ms(predicate, remaining_ms as u32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `CondVar` [INFO] [stderr] --> src/lib.rs:17:2 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn new() -> ::CondVar { [INFO] [stderr] | _____^ [INFO] [stderr] 18 | | ::CondVar { [INFO] [stderr] 19 | | pair: (Mutex::new(false), Condvar::new()) [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/lib.rs:19:11 [INFO] [stderr] | [INFO] [stderr] 19 | pair: (Mutex::new(false), Condvar::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | / match predicate { [INFO] [stderr] 58 | | Err(poison) => return Err(PoisonError::new((poison.into_inner(),false))), [INFO] [stderr] 59 | | _ => () [INFO] [stderr] 60 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Err(poison) = predicate { return Err(PoisonError::new((poison.into_inner(),false))) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.00s [INFO] running `"docker" "inspect" "57c54713908c7eabe3cc3e0b9b11fc9001c047a7362295dccd9e8310154982ee"` [INFO] running `"docker" "rm" "-f" "57c54713908c7eabe3cc3e0b9b11fc9001c047a7362295dccd9e8310154982ee"` [INFO] [stdout] 57c54713908c7eabe3cc3e0b9b11fc9001c047a7362295dccd9e8310154982ee