[INFO] crate conch-runtime 0.1.5 is already in cache [INFO] extracting crate conch-runtime 0.1.5 into work/ex/clippy-test-run/sources/stable/reg/conch-runtime/0.1.5 [INFO] extracting crate conch-runtime 0.1.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/conch-runtime/0.1.5 [INFO] validating manifest of conch-runtime-0.1.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of conch-runtime-0.1.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing conch-runtime-0.1.5 [INFO] finished frobbing conch-runtime-0.1.5 [INFO] frobbed toml for conch-runtime-0.1.5 written to work/ex/clippy-test-run/sources/stable/reg/conch-runtime/0.1.5/Cargo.toml [INFO] started frobbing conch-runtime-0.1.5 [INFO] finished frobbing conch-runtime-0.1.5 [INFO] frobbed toml for conch-runtime-0.1.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/conch-runtime/0.1.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting conch-runtime-0.1.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/conch-runtime/0.1.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b4a476486f6be18e8e70bf72547c377ab4fe1def693cc33b29230e28e09c86f1 [INFO] running `"docker" "start" "-a" "b4a476486f6be18e8e70bf72547c377ab4fe1def693cc33b29230e28e09c86f1"` [INFO] [stderr] Checking owned_chars v0.2.1 [INFO] [stderr] Checking conch-parser v0.1.0 [INFO] [stderr] Compiling rental-impl v0.4.15 [INFO] [stderr] Checking tokio-signal v0.1.5 [INFO] [stderr] Checking tokio-process v0.1.6 [INFO] [stderr] Checking rental v0.4.16 [INFO] [stderr] Checking conch-runtime v0.1.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/env/env_impl.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | args_env: args_env, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `args_env` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/env/env_impl.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | async_io_env: async_io_env, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `async_io_env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/env/env_impl.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | file_desc_env: file_desc_env, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_desc_env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/env/env_impl.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | last_status_env: last_status_env, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `last_status_env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/env/env_impl.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | var_env: var_env, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `var_env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/env/env_impl.rs:164:13 [INFO] [stderr] | [INFO] [stderr] 164 | exec_env: exec_env, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `exec_env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/env/env_impl.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | working_dir_env: working_dir_env, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `working_dir_env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/env/env_impl.rs:871:17 [INFO] [stderr] | [INFO] [stderr] 871 | interactive: interactive, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interactive` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/env/executable.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/env/executable.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | env_vars: env_vars, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `env_vars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/env/executable.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | remote: remote, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `remote` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/env/executable.rs:187:13 [INFO] [stderr] | [INFO] [stderr] 187 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval/concat.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | future: future, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `future` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval/param_subst/alternative.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval/param_subst/assign.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval/param_subst/default.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval/param_subst/error.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval/param_subst/split.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | split_fields_further: split_fields_further, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `split_fields_further` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval/param_subst/split.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | future: future, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `future` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval/redirect_or_var_assig.rs:286:9 [INFO] [stderr] | [INFO] [stderr] 286 | export_vars: export_vars, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `export_vars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval/ast_impl/complex_word.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval/ast_impl/complex_word.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval/ast_impl/word.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval/ast_impl/word.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/future/invert.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | invert_status: invert_status, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `invert_status` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/future/pinned.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | env: env, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/future/pinned.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | future: future, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `future` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/path.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | normalized_path: normalized_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `normalized_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/for_cmd.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | words: words, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `words` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/for_cmd.rs:36:17 [INFO] [stderr] | [INFO] [stderr] 36 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/for_cmd.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/for_cmd.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/if_cmd.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | else_branch: else_branch, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `else_branch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/loop_cmd.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | invert_guard_status: invert_guard_status, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `invert_guard_status` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/pipeline.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | pipeline: pipeline, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `pipeline` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/pipeline.rs:178:9 [INFO] [stderr] | [INFO] [stderr] 178 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/simple.rs:471:9 [INFO] [stderr] | [INFO] [stderr] 471 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/simple.rs:472:9 [INFO] [stderr] | [INFO] [stderr] 472 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/simple.rs:473:9 [INFO] [stderr] | [INFO] [stderr] 473 | env_vars: env_vars, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `env_vars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/swallow_non_fatal.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/vec_sequence.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | commands: commands, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `commands` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/ast_impl/command.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/ast_impl/command.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/ast_impl/compound.rs:185:21 [INFO] [stderr] | [INFO] [stderr] 185 | guard: guard, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `guard` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/ast_impl/compound.rs:186:21 [INFO] [stderr] | [INFO] [stderr] 186 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/ast_impl/compound.rs:193:21 [INFO] [stderr] | [INFO] [stderr] 193 | guard: guard, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `guard` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/ast_impl/compound.rs:194:21 [INFO] [stderr] | [INFO] [stderr] 194 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/ast_impl/compound.rs:202:13 [INFO] [stderr] | [INFO] [stderr] 202 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/ast_impl/compound.rs:277:13 [INFO] [stderr] | [INFO] [stderr] 277 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sys/unix/async_io.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | remote: remote, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `remote` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sys/unix/async_io.rs:249:13 [INFO] [stderr] | [INFO] [stderr] 249 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sys/unix/io/mod.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | fd: fd, [INFO] [stderr] | ^^^^^^ help: replace it with: `fd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/env/env_impl.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | args_env: args_env, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `args_env` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/env/env_impl.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | async_io_env: async_io_env, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `async_io_env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/env/env_impl.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | file_desc_env: file_desc_env, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_desc_env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/env/env_impl.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | last_status_env: last_status_env, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `last_status_env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/env/env_impl.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | var_env: var_env, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `var_env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/env/env_impl.rs:164:13 [INFO] [stderr] | [INFO] [stderr] 164 | exec_env: exec_env, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `exec_env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/env/env_impl.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | working_dir_env: working_dir_env, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `working_dir_env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/env/env_impl.rs:871:17 [INFO] [stderr] | [INFO] [stderr] 871 | interactive: interactive, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interactive` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/env/executable.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/env/executable.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | env_vars: env_vars, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `env_vars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/env/executable.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | remote: remote, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `remote` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/env/executable.rs:187:13 [INFO] [stderr] | [INFO] [stderr] 187 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval/concat.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | future: future, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `future` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval/param_subst/alternative.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval/param_subst/assign.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval/param_subst/default.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval/param_subst/error.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval/param_subst/split.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | split_fields_further: split_fields_further, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `split_fields_further` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval/param_subst/split.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | future: future, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `future` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval/redirect_or_var_assig.rs:286:9 [INFO] [stderr] | [INFO] [stderr] 286 | export_vars: export_vars, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `export_vars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval/ast_impl/complex_word.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval/ast_impl/complex_word.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval/ast_impl/word.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval/ast_impl/word.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/future/invert.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | invert_status: invert_status, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `invert_status` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/future/pinned.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | env: env, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/future/pinned.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | future: future, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `future` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/path.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | normalized_path: normalized_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `normalized_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/for_cmd.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | words: words, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `words` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/for_cmd.rs:36:17 [INFO] [stderr] | [INFO] [stderr] 36 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/for_cmd.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/for_cmd.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/if_cmd.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | else_branch: else_branch, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `else_branch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/loop_cmd.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | invert_guard_status: invert_guard_status, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `invert_guard_status` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/pipeline.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | pipeline: pipeline, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `pipeline` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/pipeline.rs:178:9 [INFO] [stderr] | [INFO] [stderr] 178 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/simple.rs:471:9 [INFO] [stderr] | [INFO] [stderr] 471 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/simple.rs:472:9 [INFO] [stderr] | [INFO] [stderr] 472 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/simple.rs:473:9 [INFO] [stderr] | [INFO] [stderr] 473 | env_vars: env_vars, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `env_vars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/swallow_non_fatal.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/vec_sequence.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | commands: commands, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `commands` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/ast_impl/command.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/ast_impl/command.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/ast_impl/compound.rs:185:21 [INFO] [stderr] | [INFO] [stderr] 185 | guard: guard, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `guard` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/ast_impl/compound.rs:186:21 [INFO] [stderr] | [INFO] [stderr] 186 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/ast_impl/compound.rs:193:21 [INFO] [stderr] | [INFO] [stderr] 193 | guard: guard, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `guard` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/ast_impl/compound.rs:194:21 [INFO] [stderr] | [INFO] [stderr] 194 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/ast_impl/compound.rs:202:13 [INFO] [stderr] | [INFO] [stderr] 202 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spawn/ast_impl/compound.rs:277:13 [INFO] [stderr] | [INFO] [stderr] 277 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sys/unix/async_io.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | remote: remote, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `remote` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sys/unix/async_io.rs:249:13 [INFO] [stderr] | [INFO] [stderr] 249 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sys/unix/io/mod.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | fd: fd, [INFO] [stderr] | ^^^^^^ help: replace it with: `fd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `VarRestorer` [INFO] [stderr] --> src/eval/redirect_or_var_assig.rs:3:67 [INFO] [stderr] | [INFO] [stderr] 3 | RedirectRestorer, VarEnvRestorer2, VariableEnvironment, VarRestorer}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/eval/redirect_or_var_assig.rs:374:17 [INFO] [stderr] | [INFO] [stderr] 374 | ($var_insert)($self, $env, key, val); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 412 | / poll_impl!( [INFO] [stderr] 413 | | self, [INFO] [stderr] 414 | | env, [INFO] [stderr] 415 | | |slf: &mut Self, _: &mut E, key, val| slf.vars.insert(key, val), [INFO] [stderr] 416 | | |_, _: &mut E| {}, [INFO] [stderr] 417 | | |slf: &mut Self| mem::replace(&mut slf.vars, HashMap::new()) [INFO] [stderr] 418 | | ) [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/eval/redirect_or_var_assig.rs:383:17 [INFO] [stderr] | [INFO] [stderr] 383 | ($var_restore)($self, $env); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 412 | / poll_impl!( [INFO] [stderr] 413 | | self, [INFO] [stderr] 414 | | env, [INFO] [stderr] 415 | | |slf: &mut Self, _: &mut E, key, val| slf.vars.insert(key, val), [INFO] [stderr] 416 | | |_, _: &mut E| {}, [INFO] [stderr] 417 | | |slf: &mut Self| mem::replace(&mut slf.vars, HashMap::new()) [INFO] [stderr] 418 | | ) [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/eval/redirect_or_var_assig.rs:387:28 [INFO] [stderr] | [INFO] [stderr] 387 | let vars = ($get_vars)($self); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 412 | / poll_impl!( [INFO] [stderr] 413 | | self, [INFO] [stderr] 414 | | env, [INFO] [stderr] 415 | | |slf: &mut Self, _: &mut E, key, val| slf.vars.insert(key, val), [INFO] [stderr] 416 | | |_, _: &mut E| {}, [INFO] [stderr] 417 | | |slf: &mut Self| mem::replace(&mut slf.vars, HashMap::new()) [INFO] [stderr] 418 | | ) [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/eval/redirect_or_var_assig.rs:374:17 [INFO] [stderr] | [INFO] [stderr] 374 | ($var_insert)($self, $env, key, val); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 451 | / poll_impl!( [INFO] [stderr] 452 | | self, [INFO] [stderr] 453 | | env, [INFO] [stderr] 454 | | |slf: &mut Self, env: &mut E, key, val: W::EvalResult| { [INFO] [stderr] ... | [INFO] [stderr] 464 | | |slf: &mut Self| slf.var_restorer.take().expect(POLLED_TWICE) [INFO] [stderr] 465 | | ) [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/eval/redirect_or_var_assig.rs:383:17 [INFO] [stderr] | [INFO] [stderr] 383 | ($var_restore)($self, $env); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 451 | / poll_impl!( [INFO] [stderr] 452 | | self, [INFO] [stderr] 453 | | env, [INFO] [stderr] 454 | | |slf: &mut Self, env: &mut E, key, val: W::EvalResult| { [INFO] [stderr] ... | [INFO] [stderr] 464 | | |slf: &mut Self| slf.var_restorer.take().expect(POLLED_TWICE) [INFO] [stderr] 465 | | ) [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/eval/redirect_or_var_assig.rs:387:28 [INFO] [stderr] | [INFO] [stderr] 387 | let vars = ($get_vars)($self); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 451 | / poll_impl!( [INFO] [stderr] 452 | | self, [INFO] [stderr] 453 | | env, [INFO] [stderr] 454 | | |slf: &mut Self, env: &mut E, key, val: W::EvalResult| { [INFO] [stderr] ... | [INFO] [stderr] 464 | | |slf: &mut Self| slf.var_restorer.take().expect(POLLED_TWICE) [INFO] [stderr] 465 | | ) [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: unused import: `VarRestorer` [INFO] [stderr] --> src/eval/redirect_or_var_assig.rs:3:67 [INFO] [stderr] | [INFO] [stderr] 3 | RedirectRestorer, VarEnvRestorer2, VariableEnvironment, VarRestorer}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/eval/redirect_or_var_assig.rs:374:17 [INFO] [stderr] | [INFO] [stderr] 374 | ($var_insert)($self, $env, key, val); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 412 | / poll_impl!( [INFO] [stderr] 413 | | self, [INFO] [stderr] 414 | | env, [INFO] [stderr] 415 | | |slf: &mut Self, _: &mut E, key, val| slf.vars.insert(key, val), [INFO] [stderr] 416 | | |_, _: &mut E| {}, [INFO] [stderr] 417 | | |slf: &mut Self| mem::replace(&mut slf.vars, HashMap::new()) [INFO] [stderr] 418 | | ) [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/eval/redirect_or_var_assig.rs:383:17 [INFO] [stderr] | [INFO] [stderr] 383 | ($var_restore)($self, $env); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 412 | / poll_impl!( [INFO] [stderr] 413 | | self, [INFO] [stderr] 414 | | env, [INFO] [stderr] 415 | | |slf: &mut Self, _: &mut E, key, val| slf.vars.insert(key, val), [INFO] [stderr] 416 | | |_, _: &mut E| {}, [INFO] [stderr] 417 | | |slf: &mut Self| mem::replace(&mut slf.vars, HashMap::new()) [INFO] [stderr] 418 | | ) [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/eval/redirect_or_var_assig.rs:387:28 [INFO] [stderr] | [INFO] [stderr] 387 | let vars = ($get_vars)($self); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 412 | / poll_impl!( [INFO] [stderr] 413 | | self, [INFO] [stderr] 414 | | env, [INFO] [stderr] 415 | | |slf: &mut Self, _: &mut E, key, val| slf.vars.insert(key, val), [INFO] [stderr] 416 | | |_, _: &mut E| {}, [INFO] [stderr] 417 | | |slf: &mut Self| mem::replace(&mut slf.vars, HashMap::new()) [INFO] [stderr] 418 | | ) [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/eval/redirect_or_var_assig.rs:374:17 [INFO] [stderr] | [INFO] [stderr] 374 | ($var_insert)($self, $env, key, val); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 451 | / poll_impl!( [INFO] [stderr] 452 | | self, [INFO] [stderr] 453 | | env, [INFO] [stderr] 454 | | |slf: &mut Self, env: &mut E, key, val: W::EvalResult| { [INFO] [stderr] ... | [INFO] [stderr] 464 | | |slf: &mut Self| slf.var_restorer.take().expect(POLLED_TWICE) [INFO] [stderr] 465 | | ) [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/eval/redirect_or_var_assig.rs:383:17 [INFO] [stderr] | [INFO] [stderr] 383 | ($var_restore)($self, $env); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 451 | / poll_impl!( [INFO] [stderr] 452 | | self, [INFO] [stderr] 453 | | env, [INFO] [stderr] 454 | | |slf: &mut Self, env: &mut E, key, val: W::EvalResult| { [INFO] [stderr] ... | [INFO] [stderr] 464 | | |slf: &mut Self| slf.var_restorer.take().expect(POLLED_TWICE) [INFO] [stderr] 465 | | ) [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/eval/redirect_or_var_assig.rs:387:28 [INFO] [stderr] | [INFO] [stderr] 387 | let vars = ($get_vars)($self); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 451 | / poll_impl!( [INFO] [stderr] 452 | | self, [INFO] [stderr] 453 | | env, [INFO] [stderr] 454 | | |slf: &mut Self, env: &mut E, key, val: W::EvalResult| { [INFO] [stderr] ... | [INFO] [stderr] 464 | | |slf: &mut Self| slf.var_restorer.take().expect(POLLED_TWICE) [INFO] [stderr] 465 | | ) [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::backup': use the `RedirectEnvRestorer` trait instead [INFO] [stderr] --> src/env/reversible_redirect.rs:186:52 [INFO] [stderr] | [INFO] [stderr] 186 | RedirectAction::HereDoc(fd, _) => self.backup(fd, env), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::backup': use the `RedirectEnvRestorer` trait instead [INFO] [stderr] --> src/env/reversible_redirect.rs:186:52 [INFO] [stderr] | [INFO] [stderr] 186 | RedirectAction::HereDoc(fd, _) => self.backup(fd, env), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::restore': use the `RedirectEnvRestorer` trait instead [INFO] [stderr] --> src/spawn/simple.rs:331:52 [INFO] [stderr] | [INFO] [stderr] 331 | red_restorer_inner.restore(env); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::restore': use the `RedirectEnvRestorer` trait instead [INFO] [stderr] --> src/spawn/simple.rs:358:47 [INFO] [stderr] | [INFO] [stderr] 358 | redirect_restorer.restore(env); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::restore': use the `VarEnvRestorer` trait instead [INFO] [stderr] --> src/spawn/simple.rs:359:42 [INFO] [stderr] | [INFO] [stderr] 359 | var_restorer.restore(env); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::restore': use the `RedirectEnvRestorer` trait instead [INFO] [stderr] --> src/spawn/simple.rs:387:27 [INFO] [stderr] | [INFO] [stderr] 387 | redirect_restorer.restore(env); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::restore': use the `VarEnvRestorer` trait instead [INFO] [stderr] --> src/spawn/simple.rs:397:22 [INFO] [stderr] | [INFO] [stderr] 397 | var_restorer.restore(env); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::restore': use the `RedirectEnvRestorer` trait instead [INFO] [stderr] --> src/spawn/simple.rs:415:35 [INFO] [stderr] | [INFO] [stderr] 415 | redirect_restorer.restore(env); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::restore': use the `VarEnvRestorer` trait instead [INFO] [stderr] --> src/spawn/simple.rs:416:30 [INFO] [stderr] | [INFO] [stderr] 416 | var_restorer.restore(env); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::restore': use the `RedirectEnvRestorer` trait instead [INFO] [stderr] --> src/spawn/simple.rs:331:52 [INFO] [stderr] | [INFO] [stderr] 331 | red_restorer_inner.restore(env); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::restore': use the `RedirectEnvRestorer` trait instead [INFO] [stderr] --> src/spawn/simple.rs:358:47 [INFO] [stderr] | [INFO] [stderr] 358 | redirect_restorer.restore(env); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::restore': use the `VarEnvRestorer` trait instead [INFO] [stderr] --> src/spawn/simple.rs:359:42 [INFO] [stderr] | [INFO] [stderr] 359 | var_restorer.restore(env); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::restore': use the `RedirectEnvRestorer` trait instead [INFO] [stderr] --> src/spawn/simple.rs:387:27 [INFO] [stderr] | [INFO] [stderr] 387 | redirect_restorer.restore(env); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::restore': use the `VarEnvRestorer` trait instead [INFO] [stderr] --> src/spawn/simple.rs:397:22 [INFO] [stderr] | [INFO] [stderr] 397 | var_restorer.restore(env); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::restore': use the `RedirectEnvRestorer` trait instead [INFO] [stderr] --> src/spawn/simple.rs:415:35 [INFO] [stderr] | [INFO] [stderr] 415 | redirect_restorer.restore(env); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::restore': use the `VarEnvRestorer` trait instead [INFO] [stderr] --> src/spawn/simple.rs:416:30 [INFO] [stderr] | [INFO] [stderr] 416 | var_restorer.restore(env); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'sys::io::fd_ext::FileDescExt::into_evented': does not handle regular files, use `into_evented2` instead [INFO] [stderr] --> src/sys/unix/io/fd_ext.rs:73:14 [INFO] [stderr] | [INFO] [stderr] 73 | self.into_evented(handle).map(MaybeEventedFd::Registered) [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `VarEnvRestorer` [INFO] [stderr] --> src/spawn/simple.rs:5:36 [INFO] [stderr] | [INFO] [stderr] 5 | SetArgumentsEnvironment, VarEnvRestorer, VarEnvRestorer2, VarRestorer, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'sys::io::fd_ext::FileDescExt::into_evented': does not handle regular files, use `into_evented2` instead [INFO] [stderr] --> src/sys/unix/io/fd_ext.rs:73:14 [INFO] [stderr] | [INFO] [stderr] 73 | self.into_evented(handle).map(MaybeEventedFd::Registered) [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `VarEnvRestorer` [INFO] [stderr] --> src/spawn/simple.rs:5:36 [INFO] [stderr] | [INFO] [stderr] 5 | SetArgumentsEnvironment, VarEnvRestorer, VarEnvRestorer2, VarRestorer, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/eval/redirect_or_cmd_word.rs:137:5 [INFO] [stderr] | [INFO] [stderr] 137 | mut restorer: RR, [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/eval/redirect_or_var_assig.rs:260:5 [INFO] [stderr] | [INFO] [stderr] 260 | mut redirect_restorer: RR, [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/spawn/simple.rs:386:13 [INFO] [stderr] | [INFO] [stderr] 386 | let mut redirect_restorer = redirect_restorer; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/eval/redirect_or_cmd_word.rs:137:5 [INFO] [stderr] | [INFO] [stderr] 137 | mut restorer: RR, [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/eval/redirect_or_var_assig.rs:260:5 [INFO] [stderr] | [INFO] [stderr] 260 | mut redirect_restorer: RR, [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/spawn/simple.rs:386:13 [INFO] [stderr] | [INFO] [stderr] 386 | let mut redirect_restorer = redirect_restorer; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_cloexec` [INFO] [stderr] --> src/sys/unix/io/mod.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | pub fn set_cloexec(&self, set: bool) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/eval/concat.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | self.future.as_mut().map(|f| f.cancel(env)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(f) = self.future.as_mut() { f.cancel(env) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/eval/double_quoted.rs:70:21 [INFO] [stderr] | [INFO] [stderr] 70 | self.cur_field.take().map(|s| self.fields.push(s.into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(s) = self.cur_field.take() { self.fields.push(s.into()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/eval/double_quoted.rs:99:25 [INFO] [stderr] | [INFO] [stderr] 99 | iter.next().map(|s| self.append_to_cur_field(s)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(s) = iter.next() { self.append_to_cur_field(s) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/eval/double_quoted.rs:101:25 [INFO] [stderr] | [INFO] [stderr] 101 | self.cur_field.take().map(|s| self.fields.push(s.into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(s) = self.cur_field.take() { self.fields.push(s.into()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/eval/double_quoted.rs:109:25 [INFO] [stderr] | [INFO] [stderr] 109 | last.map(|s| self.append_to_cur_field(s)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(s) = last { self.append_to_cur_field(s) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/eval/double_quoted.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | self.future.as_mut().map(|f| f.cancel(env)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(f) = self.future.as_mut() { f.cancel(env) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: this `.filter_map` can be written more simply using `.filter` [INFO] [stderr] --> src/eval/fields.rs:54:33 [INFO] [stderr] | [INFO] [stderr] 54 | Fields::Split(v) => v.iter() [INFO] [stderr] | _________________________________^ [INFO] [stderr] 55 | | .map(StringWrapper::as_str) [INFO] [stderr] 56 | | .filter_map(|s| if s.is_empty() { None } else { Some(s) }) [INFO] [stderr] | |__________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_filter_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/eval/redirect_or_cmd_word.rs:250:9 [INFO] [stderr] | [INFO] [stderr] 250 | self.current.as_mut().map(|cur| match *cur { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 251 | || RedirectOrCmdWord::Redirect(ref mut f) => f.cancel(env), [INFO] [stderr] 252 | || RedirectOrCmdWord::CmdWord(ref mut f) => f.cancel(env), [INFO] [stderr] 253 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(cur) = self.current.as_mut() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/eval/redirect_or_var_assig.rs:422:9 [INFO] [stderr] | [INFO] [stderr] 422 | self.current.as_mut().map(|cur| match *cur { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 423 | || RedirectOrVarAssig::Redirect(ref mut f) => f.cancel(env), [INFO] [stderr] 424 | || RedirectOrVarAssig::VarAssig(_, ref mut f) => { [INFO] [stderr] 425 | || f.as_mut().map(|f| f.cancel(env)); [INFO] [stderr] 426 | || }, [INFO] [stderr] 427 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(cur) = self.current.as_mut() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/eval/redirect_or_var_assig.rs:425:17 [INFO] [stderr] | [INFO] [stderr] 425 | f.as_mut().map(|f| f.cancel(env)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(f) = f.as_mut() { f.cancel(env) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/eval/redirect_or_var_assig.rs:469:9 [INFO] [stderr] | [INFO] [stderr] 469 | self.current.as_mut().map(|cur| match *cur { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 470 | || RedirectOrVarAssig::Redirect(ref mut f) => f.cancel(env), [INFO] [stderr] 471 | || RedirectOrVarAssig::VarAssig(_, ref mut f) => { [INFO] [stderr] 472 | || f.as_mut().map(|f| f.cancel(env)); [INFO] [stderr] 473 | || }, [INFO] [stderr] 474 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(cur) = self.current.as_mut() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/eval/redirect_or_var_assig.rs:472:17 [INFO] [stderr] | [INFO] [stderr] 472 | f.as_mut().map(|f| f.cancel(env)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(f) = f.as_mut() { f.cancel(env) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/eval/ast_impl/param_subst.rs:94:23 [INFO] [stderr] | [INFO] [stderr] 94 | type EvalFuture = ParameterSubstitution< [INFO] [stderr] | _______________________^ [INFO] [stderr] 95 | | T, [INFO] [stderr] 96 | | <&'a W as WordEval>::EvalFuture, [INFO] [stderr] 97 | | slice::Iter<'a, C>, [INFO] [stderr] ... | [INFO] [stderr] 100 | | E::Read [INFO] [stderr] 101 | | >; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_cloexec` [INFO] [stderr] --> src/sys/unix/io/mod.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | pub fn set_cloexec(&self, set: bool) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/future/fuse.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | self.future.take().map(|mut f| f.cancel(env)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(mut f) = self.future.take() { f.cancel(env) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/io/permissions.rs:31:21 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn readable(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/io/permissions.rs:40:21 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn writable(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/spawn/case.rs:295:9 [INFO] [stderr] | [INFO] [stderr] 295 | self.current.as_mut().map(|f| f.cancel(env)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(f) = self.current.as_mut() { f.cancel(env) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/spawn/for_cmd.rs:59:10 [INFO] [stderr] | [INFO] [stderr] 59 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/spawn/for_cmd.rs:109:11 [INFO] [stderr] | [INFO] [stderr] 109 | kind: ForKind>::EvalFuture, E::VarName, S, E>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/spawn/for_cmd.rs:186:53 [INFO] [stderr] | [INFO] [stderr] 186 | Kind::Word { ref mut current, .. } => { current.as_mut().map(|f| f.cancel(env)); }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(f) = current.as_mut() { f.cancel(env) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/spawn/for_cmd.rs:307:9 [INFO] [stderr] | [INFO] [stderr] 307 | self.state.as_mut().map(|state| match *state { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 308 | || State::Init(ref mut f) => f.cancel(env), [INFO] [stderr] 309 | || State::Last(ref mut f) => f.cancel(env), [INFO] [stderr] 310 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(state) = self.state.as_mut() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/spawn/local_redirections.rs:199:17 [INFO] [stderr] | [INFO] [stderr] 199 | cur_redirect.as_mut().map(|r| r.cancel(env)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(r) = cur_redirect.as_mut() { r.cancel(env) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/spawn/local_redirections.rs:206:9 [INFO] [stderr] | [INFO] [stderr] 206 | self.restorer.take().map(|mut restorer| restorer.restore(env)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(mut restorer) = self.restorer.take() { restorer.restore(env) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/spawn/simple.rs:102:10 [INFO] [stderr] | [INFO] [stderr] 102 | Eval(EvalState, PeekedWords, E, RR, VR>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/spawn/simple.rs:519:29 [INFO] [stderr] | [INFO] [stderr] 519 | var_restorer.take().as_mut().map(|vr| vr.restore(env)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(vr) = var_restorer.take().as_mut() { vr.restore(env) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/spawn/vec_sequence.rs:183:9 [INFO] [stderr] | [INFO] [stderr] 183 | self.current.as_mut().map(|f| f.cancel(env)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(f) = self.current.as_mut() { f.cancel(env) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/spawn/builtin/cd.rs:128:24 [INFO] [stderr] | [INFO] [stderr] 128 | let app_args = self.args.take() [INFO] [stderr] | ________________________^ [INFO] [stderr] 129 | | .expect(POLLED_TWICE) [INFO] [stderr] 130 | | .into_iter() [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into_iter()` [INFO] [stderr] | [INFO] [stderr] 128 | let app_args = self.args.take() [INFO] [stderr] 129 | .expect(POLLED_TWICE) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/spawn/builtin/echo.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | interpret_escapes.map(|ie| flags.interpret_escapes = ie); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(ie) = interpret_escapes { ... }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/spawn/builtin/echo.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | suppress_newline.map(|sn| flags.suppress_newline = sn); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(sn) = suppress_newline { ... }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/spawn/builtin/echo.rs:138:5 [INFO] [stderr] | [INFO] [stderr] 138 | args.next().map(|first| push!(first)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(first) = args.next() { ... }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/spawn/builtin/echo.rs:175:26 [INFO] [stderr] | [INFO] [stderr] 175 | for i in (0..cmp::min(s.len(), $max_len) + 1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=cmp::min(s.len(), $max_len))` [INFO] [stderr] ... [INFO] [stderr] 198 | parse_numeric!(3, 8); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/spawn/builtin/echo.rs:175:26 [INFO] [stderr] | [INFO] [stderr] 175 | for i in (0..cmp::min(s.len(), $max_len) + 1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=cmp::min(s.len(), $max_len))` [INFO] [stderr] ... [INFO] [stderr] 202 | parse_numeric!(2, 16); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/spawn/builtin/pwd.rs:66:24 [INFO] [stderr] | [INFO] [stderr] 66 | let app_args = self.args.take() [INFO] [stderr] | ________________________^ [INFO] [stderr] 67 | | .expect(POLLED_TWICE) [INFO] [stderr] 68 | | .into_iter() [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into_iter()` [INFO] [stderr] | [INFO] [stderr] 66 | let app_args = self.args.take() [INFO] [stderr] 67 | .expect(POLLED_TWICE) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/spawn/builtin/shift.rs:98:24 [INFO] [stderr] | [INFO] [stderr] 98 | let app_args = self.args.take() [INFO] [stderr] | ________________________^ [INFO] [stderr] 99 | | .expect(POLLED_TWICE) [INFO] [stderr] 100 | | .into_iter() [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into_iter()` [INFO] [stderr] | [INFO] [stderr] 98 | let app_args = self.args.take() [INFO] [stderr] 99 | .expect(POLLED_TWICE) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/spawn/ast_impl/compound.rs:52:12 [INFO] [stderr] | [INFO] [stderr] 52 | state: State< [INFO] [stderr] | ____________^ [INFO] [stderr] 53 | | Sequence, [INFO] [stderr] 54 | | If, [INFO] [stderr] 55 | | Loop, [INFO] [stderr] ... | [INFO] [stderr] 58 | | Subshell, [INFO] [stderr] 59 | | >, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/spawn/ast_impl/compound.rs:225:19 [INFO] [stderr] | [INFO] [stderr] 225 | type Future = ExitResult>::Future, <&'a S as Spawn>::Future>>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/exit_status.rs:31:20 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn success(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/eval/concat.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | self.future.as_mut().map(|f| f.cancel(env)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(f) = self.future.as_mut() { f.cancel(env) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/eval/double_quoted.rs:70:21 [INFO] [stderr] | [INFO] [stderr] 70 | self.cur_field.take().map(|s| self.fields.push(s.into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(s) = self.cur_field.take() { self.fields.push(s.into()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/eval/double_quoted.rs:99:25 [INFO] [stderr] | [INFO] [stderr] 99 | iter.next().map(|s| self.append_to_cur_field(s)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(s) = iter.next() { self.append_to_cur_field(s) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/eval/double_quoted.rs:101:25 [INFO] [stderr] | [INFO] [stderr] 101 | self.cur_field.take().map(|s| self.fields.push(s.into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(s) = self.cur_field.take() { self.fields.push(s.into()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/eval/double_quoted.rs:109:25 [INFO] [stderr] | [INFO] [stderr] 109 | last.map(|s| self.append_to_cur_field(s)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(s) = last { self.append_to_cur_field(s) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/eval/double_quoted.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | self.future.as_mut().map(|f| f.cancel(env)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(f) = self.future.as_mut() { f.cancel(env) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: this `.filter_map` can be written more simply using `.filter` [INFO] [stderr] --> src/eval/fields.rs:54:33 [INFO] [stderr] | [INFO] [stderr] 54 | Fields::Split(v) => v.iter() [INFO] [stderr] | _________________________________^ [INFO] [stderr] 55 | | .map(StringWrapper::as_str) [INFO] [stderr] 56 | | .filter_map(|s| if s.is_empty() { None } else { Some(s) }) [INFO] [stderr] | |__________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_filter_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/eval/redirect_or_cmd_word.rs:250:9 [INFO] [stderr] | [INFO] [stderr] 250 | self.current.as_mut().map(|cur| match *cur { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 251 | || RedirectOrCmdWord::Redirect(ref mut f) => f.cancel(env), [INFO] [stderr] 252 | || RedirectOrCmdWord::CmdWord(ref mut f) => f.cancel(env), [INFO] [stderr] 253 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(cur) = self.current.as_mut() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/eval/redirect_or_var_assig.rs:422:9 [INFO] [stderr] | [INFO] [stderr] 422 | self.current.as_mut().map(|cur| match *cur { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 423 | || RedirectOrVarAssig::Redirect(ref mut f) => f.cancel(env), [INFO] [stderr] 424 | || RedirectOrVarAssig::VarAssig(_, ref mut f) => { [INFO] [stderr] 425 | || f.as_mut().map(|f| f.cancel(env)); [INFO] [stderr] 426 | || }, [INFO] [stderr] 427 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(cur) = self.current.as_mut() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/eval/redirect_or_var_assig.rs:425:17 [INFO] [stderr] | [INFO] [stderr] 425 | f.as_mut().map(|f| f.cancel(env)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(f) = f.as_mut() { f.cancel(env) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/eval/redirect_or_var_assig.rs:469:9 [INFO] [stderr] | [INFO] [stderr] 469 | self.current.as_mut().map(|cur| match *cur { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 470 | || RedirectOrVarAssig::Redirect(ref mut f) => f.cancel(env), [INFO] [stderr] 471 | || RedirectOrVarAssig::VarAssig(_, ref mut f) => { [INFO] [stderr] 472 | || f.as_mut().map(|f| f.cancel(env)); [INFO] [stderr] 473 | || }, [INFO] [stderr] 474 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(cur) = self.current.as_mut() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/eval/redirect_or_var_assig.rs:472:17 [INFO] [stderr] | [INFO] [stderr] 472 | f.as_mut().map(|f| f.cancel(env)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(f) = f.as_mut() { f.cancel(env) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/cd.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | initial_cwd: initial_cwd, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `initial_cwd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/cd.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | final_cwd: final_cwd, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `final_cwd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/eval/ast_impl/param_subst.rs:94:23 [INFO] [stderr] | [INFO] [stderr] 94 | type EvalFuture = ParameterSubstitution< [INFO] [stderr] | _______________________^ [INFO] [stderr] 95 | | T, [INFO] [stderr] 96 | | <&'a W as WordEval>::EvalFuture, [INFO] [stderr] 97 | | slice::Iter<'a, C>, [INFO] [stderr] ... | [INFO] [stderr] 100 | | E::Read [INFO] [stderr] 101 | | >; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/future/fuse.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | self.future.take().map(|mut f| f.cancel(env)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(mut f) = self.future.take() { f.cancel(env) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/io/permissions.rs:31:21 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn readable(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/io/permissions.rs:40:21 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn writable(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/spawn/case.rs:295:9 [INFO] [stderr] | [INFO] [stderr] 295 | self.current.as_mut().map(|f| f.cancel(env)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(f) = self.current.as_mut() { f.cancel(env) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/spawn/for_cmd.rs:59:10 [INFO] [stderr] | [INFO] [stderr] 59 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/spawn/for_cmd.rs:109:11 [INFO] [stderr] | [INFO] [stderr] 109 | kind: ForKind>::EvalFuture, E::VarName, S, E>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/spawn/for_cmd.rs:186:53 [INFO] [stderr] | [INFO] [stderr] 186 | Kind::Word { ref mut current, .. } => { current.as_mut().map(|f| f.cancel(env)); }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(f) = current.as_mut() { f.cancel(env) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/spawn/for_cmd.rs:307:9 [INFO] [stderr] | [INFO] [stderr] 307 | self.state.as_mut().map(|state| match *state { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 308 | || State::Init(ref mut f) => f.cancel(env), [INFO] [stderr] 309 | || State::Last(ref mut f) => f.cancel(env), [INFO] [stderr] 310 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(state) = self.state.as_mut() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/spawn/local_redirections.rs:199:17 [INFO] [stderr] | [INFO] [stderr] 199 | cur_redirect.as_mut().map(|r| r.cancel(env)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(r) = cur_redirect.as_mut() { r.cancel(env) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/spawn/local_redirections.rs:206:9 [INFO] [stderr] | [INFO] [stderr] 206 | self.restorer.take().map(|mut restorer| restorer.restore(env)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(mut restorer) = self.restorer.take() { restorer.restore(env) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/spawn/simple.rs:102:10 [INFO] [stderr] | [INFO] [stderr] 102 | Eval(EvalState, PeekedWords, E, RR, VR>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/spawn/simple.rs:519:29 [INFO] [stderr] | [INFO] [stderr] 519 | var_restorer.take().as_mut().map(|vr| vr.restore(env)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(vr) = var_restorer.take().as_mut() { vr.restore(env) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/spawn/vec_sequence.rs:183:9 [INFO] [stderr] | [INFO] [stderr] 183 | self.current.as_mut().map(|f| f.cancel(env)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(f) = self.current.as_mut() { f.cancel(env) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/spawn/builtin/cd.rs:128:24 [INFO] [stderr] | [INFO] [stderr] 128 | let app_args = self.args.take() [INFO] [stderr] | ________________________^ [INFO] [stderr] 129 | | .expect(POLLED_TWICE) [INFO] [stderr] 130 | | .into_iter() [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into_iter()` [INFO] [stderr] | [INFO] [stderr] 128 | let app_args = self.args.take() [INFO] [stderr] 129 | .expect(POLLED_TWICE) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/spawn/builtin/echo.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | interpret_escapes.map(|ie| flags.interpret_escapes = ie); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(ie) = interpret_escapes { ... }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/spawn/builtin/echo.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | suppress_newline.map(|sn| flags.suppress_newline = sn); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(sn) = suppress_newline { ... }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/spawn/builtin/echo.rs:138:5 [INFO] [stderr] | [INFO] [stderr] 138 | args.next().map(|first| push!(first)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(first) = args.next() { ... }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/spawn/builtin/echo.rs:175:26 [INFO] [stderr] | [INFO] [stderr] 175 | for i in (0..cmp::min(s.len(), $max_len) + 1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=cmp::min(s.len(), $max_len))` [INFO] [stderr] ... [INFO] [stderr] 198 | parse_numeric!(3, 8); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/spawn/builtin/echo.rs:175:26 [INFO] [stderr] | [INFO] [stderr] 175 | for i in (0..cmp::min(s.len(), $max_len) + 1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=cmp::min(s.len(), $max_len))` [INFO] [stderr] ... [INFO] [stderr] 202 | parse_numeric!(2, 16); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/spawn/builtin/pwd.rs:66:24 [INFO] [stderr] | [INFO] [stderr] 66 | let app_args = self.args.take() [INFO] [stderr] | ________________________^ [INFO] [stderr] 67 | | .expect(POLLED_TWICE) [INFO] [stderr] 68 | | .into_iter() [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into_iter()` [INFO] [stderr] | [INFO] [stderr] 66 | let app_args = self.args.take() [INFO] [stderr] 67 | .expect(POLLED_TWICE) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/spawn/builtin/shift.rs:98:24 [INFO] [stderr] | [INFO] [stderr] 98 | let app_args = self.args.take() [INFO] [stderr] | ________________________^ [INFO] [stderr] 99 | | .expect(POLLED_TWICE) [INFO] [stderr] 100 | | .into_iter() [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into_iter()` [INFO] [stderr] | [INFO] [stderr] 98 | let app_args = self.args.take() [INFO] [stderr] 99 | .expect(POLLED_TWICE) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/spawn/ast_impl/compound.rs:52:12 [INFO] [stderr] | [INFO] [stderr] 52 | state: State< [INFO] [stderr] | ____________^ [INFO] [stderr] 53 | | Sequence, [INFO] [stderr] 54 | | If, [INFO] [stderr] 55 | | Loop, [INFO] [stderr] ... | [INFO] [stderr] 58 | | Subshell, [INFO] [stderr] 59 | | >, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/spawn/ast_impl/compound.rs:225:19 [INFO] [stderr] | [INFO] [stderr] 225 | type Future = ExitResult>::Future, <&'a S as Spawn>::Future>>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/exit_status.rs:31:20 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn success(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `support::MustCancel` [INFO] [stderr] --> tests/support.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | / pub fn new() -> Self { [INFO] [stderr] 155 | | MustCancel { [INFO] [stderr] 156 | | was_polled: false, [INFO] [stderr] 157 | | was_canceled: false, [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 146 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `support::MustCancel` [INFO] [stderr] --> tests/support.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | / pub fn new() -> Self { [INFO] [stderr] 155 | | MustCancel { [INFO] [stderr] 156 | | was_polled: false, [INFO] [stderr] 157 | | was_canceled: false, [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 146 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `support::MustCancel` [INFO] [stderr] --> tests/support.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | / pub fn new() -> Self { [INFO] [stderr] 155 | | MustCancel { [INFO] [stderr] 156 | | was_polled: false, [INFO] [stderr] 157 | | was_canceled: false, [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 146 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `support::MustCancel` [INFO] [stderr] --> tests/support.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | / pub fn new() -> Self { [INFO] [stderr] 155 | | MustCancel { [INFO] [stderr] 156 | | was_polled: false, [INFO] [stderr] 157 | | was_canceled: false, [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 146 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `support::MustCancel` [INFO] [stderr] --> tests/support.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | / pub fn new() -> Self { [INFO] [stderr] 155 | | MustCancel { [INFO] [stderr] 156 | | was_polled: false, [INFO] [stderr] 157 | | was_canceled: false, [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 146 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `support::MustCancel` [INFO] [stderr] --> tests/support.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | / pub fn new() -> Self { [INFO] [stderr] 155 | | MustCancel { [INFO] [stderr] 156 | | was_polled: false, [INFO] [stderr] 157 | | was_canceled: false, [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 146 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `support::MustCancel` [INFO] [stderr] --> tests/support.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | / pub fn new() -> Self { [INFO] [stderr] 155 | | MustCancel { [INFO] [stderr] 156 | | was_polled: false, [INFO] [stderr] 157 | | was_canceled: false, [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 146 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let mut env =` [INFO] [stderr] --> tests/param_subst_remove_largest_prefix.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | let mut env = (); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> tests/param_subst_remove_largest_prefix.rs:16:18 [INFO] [stderr] | [INFO] [stderr] 16 | .pin_env(env) [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 16 | .pin_env(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_largest_prefix` doesn't need a mutable reference [INFO] [stderr] --> tests/param_subst_remove_largest_prefix.rs:15:47 [INFO] [stderr] | [INFO] [stderr] 15 | remove_largest_prefix(param, word.into(), &mut env) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `support::MustCancel` [INFO] [stderr] --> tests/support.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | / pub fn new() -> Self { [INFO] [stderr] 155 | | MustCancel { [INFO] [stderr] 156 | | was_polled: false, [INFO] [stderr] 157 | | was_canceled: false, [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 146 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/redirect.rs:300:28 [INFO] [stderr] | [INFO] [stderr] 300 | let joined = Vec::from("firstsecond".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"firstsecond"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> tests/redirect.rs:410:63 [INFO] [stderr] | [INFO] [stderr] 410 | let err = Err(MockErr::RedirectionError(Arc::new(BadFdSrc("foo".to_string().into())))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"foo".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `MustCancel` [INFO] [stderr] --> tests/support.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | / pub fn new() -> Self { [INFO] [stderr] 155 | | MustCancel { [INFO] [stderr] 156 | | was_polled: false, [INFO] [stderr] 157 | | was_canceled: false, [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 146 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/evented_fd.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `support::MustCancel` [INFO] [stderr] --> tests/support.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | / pub fn new() -> Self { [INFO] [stderr] 155 | | MustCancel { [INFO] [stderr] 156 | | was_polled: false, [INFO] [stderr] 157 | | was_canceled: false, [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 146 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> tests/pinned.rs:21:49 [INFO] [stderr] | [INFO] [stderr] 21 | let mut future = mock_must_cancel().pin_env(env.clone()); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `env` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `support::MustCancel` [INFO] [stderr] --> tests/support.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | / pub fn new() -> Self { [INFO] [stderr] 155 | | MustCancel { [INFO] [stderr] 156 | | was_polled: false, [INFO] [stderr] 157 | | was_canceled: false, [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 146 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `support::MustCancel` [INFO] [stderr] --> tests/support.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | / pub fn new() -> Self { [INFO] [stderr] 155 | | MustCancel { [INFO] [stderr] 156 | | was_polled: false, [INFO] [stderr] 157 | | was_canceled: false, [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 146 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `support::MustCancel` [INFO] [stderr] --> tests/support.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | / pub fn new() -> Self { [INFO] [stderr] 155 | | MustCancel { [INFO] [stderr] 156 | | was_polled: false, [INFO] [stderr] 157 | | was_canceled: false, [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 146 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let env =` [INFO] [stderr] --> tests/param_subst_remove_smallest_prefix.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | let env = (); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> tests/param_subst_remove_smallest_prefix.rs:16:18 [INFO] [stderr] | [INFO] [stderr] 16 | .pin_env(env) [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 16 | .pin_env(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `support::MustCancel` [INFO] [stderr] --> tests/support.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | / pub fn new() -> Self { [INFO] [stderr] 155 | | MustCancel { [INFO] [stderr] 156 | | was_polled: false, [INFO] [stderr] 157 | | was_canceled: false, [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 146 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> tests/evented_fd.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | writer.write(&[*c]).expect("failed to write byte"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `conch-runtime`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: the function has a cyclomatic complexity of 75 [INFO] [stderr] --> tests/arith.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / fn test_eval_arith() { [INFO] [stderr] 13 | | use conch_parser::ast::Arithmetic::*; [INFO] [stderr] 14 | | use std::isize::MAX; [INFO] [stderr] 15 | | [INFO] [stderr] ... | [INFO] [stderr] 136 | | assert_eq!(env.var("y").map(|s| &**s), Some("9")); [INFO] [stderr] 137 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `support::MustCancel` [INFO] [stderr] --> tests/support.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | / pub fn new() -> Self { [INFO] [stderr] 155 | | MustCancel { [INFO] [stderr] 156 | | was_polled: false, [INFO] [stderr] 157 | | was_canceled: false, [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 146 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `support::MustCancel` [INFO] [stderr] --> tests/support.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | / pub fn new() -> Self { [INFO] [stderr] 155 | | MustCancel { [INFO] [stderr] 156 | | was_polled: false, [INFO] [stderr] 157 | | was_canceled: false, [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 146 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::marker::PhantomData` [INFO] [stderr] --> tests/simple.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | use std::marker::PhantomData; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `support::MustCancel` [INFO] [stderr] --> tests/support.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | / pub fn new() -> Self { [INFO] [stderr] 155 | | MustCancel { [INFO] [stderr] 156 | | was_polled: false, [INFO] [stderr] 157 | | was_canceled: false, [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 146 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let env =` [INFO] [stderr] --> tests/param_subst_remove_smallest_suffix.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | let env = (); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> tests/param_subst_remove_smallest_suffix.rs:16:18 [INFO] [stderr] | [INFO] [stderr] 16 | .pin_env(env) [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 16 | .pin_env(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `support::MustCancel` [INFO] [stderr] --> tests/support.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | / pub fn new() -> Self { [INFO] [stderr] 155 | | MustCancel { [INFO] [stderr] 156 | | was_polled: false, [INFO] [stderr] 157 | | was_canceled: false, [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 146 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `support::MustCancel` [INFO] [stderr] --> tests/support.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | / pub fn new() -> Self { [INFO] [stderr] 155 | | MustCancel { [INFO] [stderr] 156 | | was_polled: false, [INFO] [stderr] 157 | | was_canceled: false, [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 146 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "b4a476486f6be18e8e70bf72547c377ab4fe1def693cc33b29230e28e09c86f1"` [INFO] running `"docker" "rm" "-f" "b4a476486f6be18e8e70bf72547c377ab4fe1def693cc33b29230e28e09c86f1"` [INFO] [stdout] b4a476486f6be18e8e70bf72547c377ab4fe1def693cc33b29230e28e09c86f1