[INFO] crate comrak 0.4.0 is already in cache [INFO] extracting crate comrak 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/comrak/0.4.0 [INFO] extracting crate comrak 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/comrak/0.4.0 [INFO] validating manifest of comrak-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of comrak-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing comrak-0.4.0 [INFO] finished frobbing comrak-0.4.0 [INFO] frobbed toml for comrak-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/comrak/0.4.0/Cargo.toml [INFO] started frobbing comrak-0.4.0 [INFO] finished frobbing comrak-0.4.0 [INFO] frobbed toml for comrak-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/comrak/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting comrak-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/comrak/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 512b42a6e741b0f0090970bfc90f0391601834b02db8f2608986e82f045aced1 [INFO] running `"docker" "start" "-a" "512b42a6e741b0f0090970bfc90f0391601834b02db8f2608986e82f045aced1"` [INFO] [stderr] Checking pulse v0.5.3 [INFO] [stderr] Checking comrak v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:72:25 [INFO] [stderr] | [INFO] [stderr] 72 | #![allow(unknown_lints, doc_markdown, cyclomatic_complexity)] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `cyclomatic_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:72:39 [INFO] [stderr] | [INFO] [stderr] 72 | #![allow(unknown_lints, doc_markdown, cyclomatic_complexity)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cyclomatic_complexity` [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/arena_tree.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cm.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | node: node, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cm.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/cm.rs:585:17 [INFO] [stderr] | [INFO] [stderr] 585 | write!(self, "[^{}]:\n", footnote_ix).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/ctype.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/html.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | output: output, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/html.rs:57:1 [INFO] [stderr] | [INFO] [stderr] 57 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/html.rs:169:13 [INFO] [stderr] | [INFO] [stderr] 169 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/html.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | output: output, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/html.rs:349:21 [INFO] [stderr] | [INFO] [stderr] 349 | write!(self.output, "
    \n", nl.start)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/html.rs:424:21 [INFO] [stderr] | [INFO] [stderr] 424 | write!(self.output, "\n", nch.level)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/html.rs:655:17 [INFO] [stderr] | [INFO] [stderr] 655 | write!(self.output, "
  1. \n", self.footnote_ix)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nodes.rs:368:9 [INFO] [stderr] | [INFO] [stderr] 368 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nodes.rs:370:9 [INFO] [stderr] | [INFO] [stderr] 370 | start_line: start_line, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/autolink.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/autolink.rs:328:13 [INFO] [stderr] | [INFO] [stderr] 328 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/inlines.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | arena: arena, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arena` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/inlines.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/inlines.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/inlines.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | refmap: refmap, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `refmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/inlines.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | delimiter_arena: delimiter_arena, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `delimiter_arena` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/inlines.rs:686:13 [INFO] [stderr] | [INFO] [stderr] 686 | inl: inl, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `inl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/inlines.rs:689:13 [INFO] [stderr] | [INFO] [stderr] 689 | can_open: can_open, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `can_open` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/inlines.rs:690:13 [INFO] [stderr] | [INFO] [stderr] 690 | can_close: can_close, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `can_close` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/inlines.rs:871:13 [INFO] [stderr] | [INFO] [stderr] 871 | inl_text: inl_text, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `inl_text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/inlines.rs:873:13 [INFO] [stderr] | [INFO] [stderr] 873 | image: image, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/inlines.rs:987:13 [INFO] [stderr] | [INFO] [stderr] 987 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/inlines.rs:988:13 [INFO] [stderr] | [INFO] [stderr] 988 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/inlines.rs:1140:9 [INFO] [stderr] | [INFO] [stderr] 1140 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/mod.rs:350:13 [INFO] [stderr] | [INFO] [stderr] 350 | arena: arena, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arena` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/mod.rs:352:13 [INFO] [stderr] | [INFO] [stderr] 352 | root: root, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/mod.rs:363:13 [INFO] [stderr] | [INFO] [stderr] 363 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/mod.rs:613:21 [INFO] [stderr] | [INFO] [stderr] 613 | level: level, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/mod.rs:1303:25 [INFO] [stderr] | [INFO] [stderr] 1303 | node: node, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/mod.rs:1608:17 [INFO] [stderr] | [INFO] [stderr] 1608 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] Checking timebomb v0.1.2 [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:72:25 [INFO] [stderr] | [INFO] [stderr] 72 | #![allow(unknown_lints, doc_markdown, cyclomatic_complexity)] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `cyclomatic_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:72:39 [INFO] [stderr] | [INFO] [stderr] 72 | #![allow(unknown_lints, doc_markdown, cyclomatic_complexity)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cyclomatic_complexity` [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/arena_tree.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cm.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | node: node, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cm.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/cm.rs:585:17 [INFO] [stderr] | [INFO] [stderr] 585 | write!(self, "[^{}]:\n", footnote_ix).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/ctype.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/html.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | output: output, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/html.rs:57:1 [INFO] [stderr] | [INFO] [stderr] 57 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/html.rs:169:13 [INFO] [stderr] | [INFO] [stderr] 169 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/html.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | output: output, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/html.rs:349:21 [INFO] [stderr] | [INFO] [stderr] 349 | write!(self.output, "
      \n", nl.start)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/html.rs:424:21 [INFO] [stderr] | [INFO] [stderr] 424 | write!(self.output, "\n", nch.level)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/html.rs:655:17 [INFO] [stderr] | [INFO] [stderr] 655 | write!(self.output, "
    1. \n", self.footnote_ix)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nodes.rs:368:9 [INFO] [stderr] | [INFO] [stderr] 368 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nodes.rs:370:9 [INFO] [stderr] | [INFO] [stderr] 370 | start_line: start_line, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/autolink.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/autolink.rs:328:13 [INFO] [stderr] | [INFO] [stderr] 328 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/inlines.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | arena: arena, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arena` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/inlines.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/inlines.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/inlines.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | refmap: refmap, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `refmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/inlines.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | delimiter_arena: delimiter_arena, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `delimiter_arena` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/inlines.rs:686:13 [INFO] [stderr] | [INFO] [stderr] 686 | inl: inl, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `inl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/inlines.rs:689:13 [INFO] [stderr] | [INFO] [stderr] 689 | can_open: can_open, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `can_open` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/inlines.rs:690:13 [INFO] [stderr] | [INFO] [stderr] 690 | can_close: can_close, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `can_close` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/inlines.rs:871:13 [INFO] [stderr] | [INFO] [stderr] 871 | inl_text: inl_text, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `inl_text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/inlines.rs:873:13 [INFO] [stderr] | [INFO] [stderr] 873 | image: image, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/inlines.rs:987:13 [INFO] [stderr] | [INFO] [stderr] 987 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/inlines.rs:988:13 [INFO] [stderr] | [INFO] [stderr] 988 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/inlines.rs:1140:9 [INFO] [stderr] | [INFO] [stderr] 1140 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/mod.rs:350:13 [INFO] [stderr] | [INFO] [stderr] 350 | arena: arena, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arena` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/mod.rs:352:13 [INFO] [stderr] | [INFO] [stderr] 352 | root: root, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/mod.rs:363:13 [INFO] [stderr] | [INFO] [stderr] 363 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/mod.rs:613:21 [INFO] [stderr] | [INFO] [stderr] 613 | level: level, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/mod.rs:1303:25 [INFO] [stderr] | [INFO] [stderr] 1303 | node: node, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/mod.rs:1608:17 [INFO] [stderr] | [INFO] [stderr] 1608 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:72:25 [INFO] [stderr] | [INFO] [stderr] 72 | #![allow(unknown_lints, doc_markdown, cyclomatic_complexity)] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/entity.rs:42:33 [INFO] [stderr] | [INFO] [stderr] 42 | || codepoint >= 0x110000 [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0011_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/parser/inlines.rs:720:9 [INFO] [stderr] | [INFO] [stderr] 720 | / if self.options.ext_strikethrough && opener_char == b'~' { [INFO] [stderr] 721 | | if opener_num_chars != closer_num_chars || [INFO] [stderr] 722 | | opener_num_chars > 0 { [INFO] [stderr] 723 | | return None [INFO] [stderr] 724 | | } [INFO] [stderr] 725 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 720 | if self.options.ext_strikethrough && opener_char == b'~' && (opener_num_chars != closer_num_chars || [INFO] [stderr] 721 | opener_num_chars > 0) { [INFO] [stderr] 722 | return None [INFO] [stderr] 723 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:72:25 [INFO] [stderr] | [INFO] [stderr] 72 | #![allow(unknown_lints, doc_markdown, cyclomatic_complexity)] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/entity.rs:42:33 [INFO] [stderr] | [INFO] [stderr] 42 | || codepoint >= 0x110000 [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0011_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/parser/inlines.rs:720:9 [INFO] [stderr] | [INFO] [stderr] 720 | / if self.options.ext_strikethrough && opener_char == b'~' { [INFO] [stderr] 721 | | if opener_num_chars != closer_num_chars || [INFO] [stderr] 722 | | opener_num_chars > 0 { [INFO] [stderr] 723 | | return None [INFO] [stderr] 724 | | } [INFO] [stderr] 725 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 720 | if self.options.ext_strikethrough && opener_char == b'~' && (opener_num_chars != closer_num_chars || [INFO] [stderr] 721 | opener_num_chars > 0) { [INFO] [stderr] 722 | return None [INFO] [stderr] 723 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/cm.rs:470:20 [INFO] [stderr] | [INFO] [stderr] 470 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 471 | | write!(self, "**").unwrap(); [INFO] [stderr] 472 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/cm.rs:468:46 [INFO] [stderr] | [INFO] [stderr] 468 | NodeValue::Strong => if entering { [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 469 | | write!(self, "**").unwrap(); [INFO] [stderr] 470 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/cm.rs:492:20 [INFO] [stderr] | [INFO] [stderr] 492 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 493 | | write!(self, "~").unwrap(); [INFO] [stderr] 494 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/cm.rs:490:53 [INFO] [stderr] | [INFO] [stderr] 490 | NodeValue::Strikethrough => if entering { [INFO] [stderr] | _____________________________________________________^ [INFO] [stderr] 491 | | write!(self, "~").unwrap(); [INFO] [stderr] 492 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/cm.rs:497:20 [INFO] [stderr] | [INFO] [stderr] 497 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 498 | | write!(self, "^").unwrap(); [INFO] [stderr] 499 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/cm.rs:495:51 [INFO] [stderr] | [INFO] [stderr] 495 | NodeValue::Superscript => if entering { [INFO] [stderr] | ___________________________________________________^ [INFO] [stderr] 496 | | write!(self, "^").unwrap(); [INFO] [stderr] 497 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/entity.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | fn isxdigit(ch: &u8) -> bool { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/entity.rs:22:49 [INFO] [stderr] | [INFO] [stderr] 22 | codepoint = (codepoint * 10) + (text[i] as u32 - '0' as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(text[i])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/entity.rs:30:50 [INFO] [stderr] | [INFO] [stderr] 30 | codepoint = (codepoint * 16) + ((text[i] as u32 | 32) % 39 - 9); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(text[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/html.rs:287:21 [INFO] [stderr] | [INFO] [stderr] 287 | / let new_plain; [INFO] [stderr] 288 | | if plain { [INFO] [stderr] 289 | | match node.data.borrow().value { [INFO] [stderr] 290 | | NodeValue::Text(ref literal) [INFO] [stderr] ... | [INFO] [stderr] 303 | | new_plain = self.format_node(node, true)?; [INFO] [stderr] 304 | | } [INFO] [stderr] | |_____________________^ help: it is more idiomatic to write: `let new_plain = if plain { ..; plain } else { ..; self.format_node(node, true)? };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/parser/mod.rs:393:42 [INFO] [stderr] | [INFO] [stderr] 393 | self.process_line(&s[i..eol + 1]); [INFO] [stderr] | ^^^^^^^^^^ help: use: `i..=eol` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you should use the `starts_with` method [INFO] [stderr] --> src/parser/mod.rs:462:16 [INFO] [stderr] | [INFO] [stderr] 462 | && unsafe { str::from_utf8_unchecked(line) } [INFO] [stderr] | ________________^ [INFO] [stderr] 463 | | .chars() [INFO] [stderr] 464 | | .next() [INFO] [stderr] 465 | | .unwrap() == '\u{feff}' [INFO] [stderr] | |_______________________________________^ help: like this: `unsafe { str::from_utf8_unchecked(line) }.starts_with('')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_next_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/strings.rs:70:8 [INFO] [stderr] | [INFO] [stderr] 70 | if r.len() > 0 && r[0] == b' ' && r[r.len() - 1] == b' ' { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!r.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/strings.rs:182:19 [INFO] [stderr] | [INFO] [stderr] 182 | let src = dst.offset(n as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `dst.add(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `comrak`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/cm.rs:470:20 [INFO] [stderr] | [INFO] [stderr] 470 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 471 | | write!(self, "**").unwrap(); [INFO] [stderr] 472 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/cm.rs:468:46 [INFO] [stderr] | [INFO] [stderr] 468 | NodeValue::Strong => if entering { [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 469 | | write!(self, "**").unwrap(); [INFO] [stderr] 470 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/cm.rs:492:20 [INFO] [stderr] | [INFO] [stderr] 492 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 493 | | write!(self, "~").unwrap(); [INFO] [stderr] 494 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/cm.rs:490:53 [INFO] [stderr] | [INFO] [stderr] 490 | NodeValue::Strikethrough => if entering { [INFO] [stderr] | _____________________________________________________^ [INFO] [stderr] 491 | | write!(self, "~").unwrap(); [INFO] [stderr] 492 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/cm.rs:497:20 [INFO] [stderr] | [INFO] [stderr] 497 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 498 | | write!(self, "^").unwrap(); [INFO] [stderr] 499 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/cm.rs:495:51 [INFO] [stderr] | [INFO] [stderr] 495 | NodeValue::Superscript => if entering { [INFO] [stderr] | ___________________________________________________^ [INFO] [stderr] 496 | | write!(self, "^").unwrap(); [INFO] [stderr] 497 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/entity.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | fn isxdigit(ch: &u8) -> bool { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/entity.rs:22:49 [INFO] [stderr] | [INFO] [stderr] 22 | codepoint = (codepoint * 10) + (text[i] as u32 - '0' as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(text[i])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/entity.rs:30:50 [INFO] [stderr] | [INFO] [stderr] 30 | codepoint = (codepoint * 16) + ((text[i] as u32 | 32) % 39 - 9); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(text[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/html.rs:287:21 [INFO] [stderr] | [INFO] [stderr] 287 | / let new_plain; [INFO] [stderr] 288 | | if plain { [INFO] [stderr] 289 | | match node.data.borrow().value { [INFO] [stderr] 290 | | NodeValue::Text(ref literal) [INFO] [stderr] ... | [INFO] [stderr] 303 | | new_plain = self.format_node(node, true)?; [INFO] [stderr] 304 | | } [INFO] [stderr] | |_____________________^ help: it is more idiomatic to write: `let new_plain = if plain { ..; plain } else { ..; self.format_node(node, true)? };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/parser/mod.rs:393:42 [INFO] [stderr] | [INFO] [stderr] 393 | self.process_line(&s[i..eol + 1]); [INFO] [stderr] | ^^^^^^^^^^ help: use: `i..=eol` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you should use the `starts_with` method [INFO] [stderr] --> src/parser/mod.rs:462:16 [INFO] [stderr] | [INFO] [stderr] 462 | && unsafe { str::from_utf8_unchecked(line) } [INFO] [stderr] | ________________^ [INFO] [stderr] 463 | | .chars() [INFO] [stderr] 464 | | .next() [INFO] [stderr] 465 | | .unwrap() == '\u{feff}' [INFO] [stderr] | |_______________________________________^ help: like this: `unsafe { str::from_utf8_unchecked(line) }.starts_with('')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_next_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/strings.rs:70:8 [INFO] [stderr] | [INFO] [stderr] 70 | if r.len() > 0 && r[0] == b' ' && r[r.len() - 1] == b' ' { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!r.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/strings.rs:182:19 [INFO] [stderr] | [INFO] [stderr] 182 | let src = dst.offset(n as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `dst.add(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `comrak`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "512b42a6e741b0f0090970bfc90f0391601834b02db8f2608986e82f045aced1"` [INFO] running `"docker" "rm" "-f" "512b42a6e741b0f0090970bfc90f0391601834b02db8f2608986e82f045aced1"` [INFO] [stdout] 512b42a6e741b0f0090970bfc90f0391601834b02db8f2608986e82f045aced1