[INFO] crate compression 0.1.2 is already in cache [INFO] extracting crate compression 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/compression/0.1.2 [INFO] extracting crate compression 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/compression/0.1.2 [INFO] validating manifest of compression-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of compression-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing compression-0.1.2 [INFO] finished frobbing compression-0.1.2 [INFO] frobbed toml for compression-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/compression/0.1.2/Cargo.toml [INFO] started frobbing compression-0.1.2 [INFO] finished frobbing compression-0.1.2 [INFO] frobbed toml for compression-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/compression/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting compression-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/compression/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 126b488fa2112ea37c4c994dc3d15318696b066f8a53152069580bcd87d671fd [INFO] running `"docker" "start" "-a" "126b488fa2112ea37c4c994dc3d15318696b066f8a53152069580bcd87d671fd"` [INFO] [stderr] Checking compression v0.1.2 (/opt/crater/workdir) [INFO] [stderr] Checking simple_logger v1.0.1 [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/bitset.rs:100:16 [INFO] [stderr] | [INFO] [stderr] 100 | if l & 63 == 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `l.trailing_zeros() >= 6` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::verbose_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/suffix_array/sais.rs:230:18 [INFO] [stderr] | [INFO] [stderr] 230 | for i in (n1..j + 1).rev() { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `(n1..=j)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/suffix_array/sais.rs:242:13 [INFO] [stderr] | [INFO] [stderr] 242 | / suffix_array [INFO] [stderr] 243 | | .as_mut_ptr() [INFO] [stderr] 244 | | .offset((count - n1) as isize), [INFO] [stderr] | |______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 242 | suffix_array [INFO] [stderr] 243 | .as_mut_ptr().add((count - n1)), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/huffman/cano_huff_table.rs:207:45 [INFO] [stderr] | [INFO] [stderr] 207 | let (s, l): (Vec<_>, Vec<_>) = freq.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/huffman/decoder.rs:97:14 [INFO] [stderr] | [INFO] [stderr] 97 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/huffman/mod.rs:29:10 [INFO] [stderr] | [INFO] [stderr] 29 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lzss/encoder.rs:147:17 [INFO] [stderr] | [INFO] [stderr] 147 | action: &Action, [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Action` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lzss/slidedict.rs:196:22 [INFO] [stderr] | [INFO] [stderr] 196 | for i in 0..(self.append_buf.len() - mm + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=self.append_buf.len() - mm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzss/slidedict.rs:199:25 [INFO] [stderr] | [INFO] [stderr] 199 | self.append_buf.as_ptr().offset(i as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.append_buf.as_ptr().add(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/traits/decoder.rs:31:10 [INFO] [stderr] | [INFO] [stderr] 31 | ) -> DecodeIterator, E, BitReader> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/traits/encoder.rs:88:17 [INFO] [stderr] | [INFO] [stderr] 88 | action: &Action, [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Action` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/bzip2/decoder.rs:153:5 [INFO] [stderr] | [INFO] [stderr] 153 | / fn init_block>( [INFO] [stderr] 154 | | &mut self, [INFO] [stderr] 155 | | reader: &mut R, [INFO] [stderr] 156 | | ) -> Result { [INFO] [stderr] ... | [INFO] [stderr] 537 | | } [INFO] [stderr] 538 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bzip2/encoder.rs:73:17 [INFO] [stderr] | [INFO] [stderr] 73 | action: &Action, [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Action` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/bzip2/encoder.rs:296:5 [INFO] [stderr] | [INFO] [stderr] 296 | / fn write_blockdata( [INFO] [stderr] 297 | | &mut self, [INFO] [stderr] 298 | | queue: &mut VecDeque>, [INFO] [stderr] 299 | | ) -> Result<(), CompressionError> { [INFO] [stderr] ... | [INFO] [stderr] 635 | | Ok(()) [INFO] [stderr] 636 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bzip2/mtf.rs:19:19 [INFO] [stderr] | [INFO] [stderr] 19 | data: (0..count).into_iter().collect::>(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..count)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bzip2/mtf.rs:48:19 [INFO] [stderr] | [INFO] [stderr] 48 | data: (0..count).into_iter().collect::>(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/deflate/decoder.rs:99:29 [INFO] [stderr] | [INFO] [stderr] 99 | for &i in len_index.into_iter().take(hclen as usize) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/deflate/encoder.rs:156:17 [INFO] [stderr] | [INFO] [stderr] 156 | action: &Action, [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Action` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/deflate/encoder.rs:478:22 [INFO] [stderr] | [INFO] [stderr] 478 | for i in 1..(self.decompress_len + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=self.decompress_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/gzip/decoder.rs:130:30 [INFO] [stderr] | [INFO] [stderr] 130 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/gzip/decoder.rs:149:30 [INFO] [stderr] | [INFO] [stderr] 149 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/zlib/decoder.rs:99:30 [INFO] [stderr] | [INFO] [stderr] 99 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `compression`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of deprecated item 'rand::XorShiftRng': import from rand_xorshift crate instead [INFO] [stderr] --> src/deflate/mod.rs:132:34 [INFO] [stderr] | [INFO] [stderr] 132 | use rand::{Rng, SeedableRng, XorShiftRng}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rand::XorShiftRng': import from rand_xorshift crate instead [INFO] [stderr] --> src/deflate/mod.rs:217:23 [INFO] [stderr] | [INFO] [stderr] 217 | let mut rng = XorShiftRng::from_seed([ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rand::XorShiftRng': import from rand_xorshift crate instead [INFO] [stderr] --> src/gzip/mod.rs:19:34 [INFO] [stderr] | [INFO] [stderr] 19 | use rand::{Rng, SeedableRng, XorShiftRng}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rand::XorShiftRng': import from rand_xorshift crate instead [INFO] [stderr] --> src/gzip/mod.rs:104:23 [INFO] [stderr] | [INFO] [stderr] 104 | let mut rng = XorShiftRng::from_seed([ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rand::XorShiftRng': import from rand_xorshift crate instead [INFO] [stderr] --> src/zlib/mod.rs:17:34 [INFO] [stderr] | [INFO] [stderr] 17 | use rand::{Rng, SeedableRng, XorShiftRng}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rand::XorShiftRng': import from rand_xorshift crate instead [INFO] [stderr] --> src/zlib/mod.rs:104:23 [INFO] [stderr] | [INFO] [stderr] 104 | let mut rng = XorShiftRng::from_seed([ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rand::XorShiftRng': import from rand_xorshift crate instead [INFO] [stderr] --> src/deflate/mod.rs:184:23 [INFO] [stderr] | [INFO] [stderr] 184 | let mut rng = XorShiftRng::from_seed([ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rand::XorShiftRng': import from rand_xorshift crate instead [INFO] [stderr] --> src/deflate/mod.rs:194:23 [INFO] [stderr] | [INFO] [stderr] 194 | let mut rng = XorShiftRng::from_seed([ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rand::XorShiftRng': import from rand_xorshift crate instead [INFO] [stderr] --> src/deflate/mod.rs:204:23 [INFO] [stderr] | [INFO] [stderr] 204 | let mut rng = XorShiftRng::from_seed([ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rand::XorShiftRng': import from rand_xorshift crate instead [INFO] [stderr] --> src/gzip/mod.rs:71:23 [INFO] [stderr] | [INFO] [stderr] 71 | let mut rng = XorShiftRng::from_seed([ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rand::XorShiftRng': import from rand_xorshift crate instead [INFO] [stderr] --> src/gzip/mod.rs:81:23 [INFO] [stderr] | [INFO] [stderr] 81 | let mut rng = XorShiftRng::from_seed([ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rand::XorShiftRng': import from rand_xorshift crate instead [INFO] [stderr] --> src/gzip/mod.rs:91:23 [INFO] [stderr] | [INFO] [stderr] 91 | let mut rng = XorShiftRng::from_seed([ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rand::XorShiftRng': import from rand_xorshift crate instead [INFO] [stderr] --> src/zlib/mod.rs:71:23 [INFO] [stderr] | [INFO] [stderr] 71 | let mut rng = XorShiftRng::from_seed([ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rand::XorShiftRng': import from rand_xorshift crate instead [INFO] [stderr] --> src/zlib/mod.rs:81:23 [INFO] [stderr] | [INFO] [stderr] 81 | let mut rng = XorShiftRng::from_seed([ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rand::XorShiftRng': import from rand_xorshift crate instead [INFO] [stderr] --> src/zlib/mod.rs:91:23 [INFO] [stderr] | [INFO] [stderr] 91 | let mut rng = XorShiftRng::from_seed([ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/bitset.rs:100:16 [INFO] [stderr] | [INFO] [stderr] 100 | if l & 63 == 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `l.trailing_zeros() >= 6` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::verbose_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/suffix_array/ls_type.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | / fn is_lms() { [INFO] [stderr] 100 | | // LLSSLLSSLLSSLLLLS [INFO] [stderr] 101 | | let test_str = b"mmiissiissiippii"; [INFO] [stderr] 102 | | let type_arr = LSTypeArray::with_shift(test_str, 0); [INFO] [stderr] ... | [INFO] [stderr] 135 | | assert!(!type_arr.is_lms(15)); [INFO] [stderr] 136 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/suffix_array/sais.rs:230:18 [INFO] [stderr] | [INFO] [stderr] 230 | for i in (n1..j + 1).rev() { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `(n1..=j)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/suffix_array/sais.rs:242:13 [INFO] [stderr] | [INFO] [stderr] 242 | / suffix_array [INFO] [stderr] 243 | | .as_mut_ptr() [INFO] [stderr] 244 | | .offset((count - n1) as isize), [INFO] [stderr] | |______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 242 | suffix_array [INFO] [stderr] 243 | .as_mut_ptr().add((count - n1)), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/huffman/cano_huff_table.rs:207:45 [INFO] [stderr] | [INFO] [stderr] 207 | let (s, l): (Vec<_>, Vec<_>) = freq.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/huffman/decoder.rs:97:14 [INFO] [stderr] | [INFO] [stderr] 97 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/huffman/encoder.rs:162:18 [INFO] [stderr] | [INFO] [stderr] 162 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/huffman/mod.rs:29:10 [INFO] [stderr] | [INFO] [stderr] 29 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/huffman/mod.rs:96:14 [INFO] [stderr] | [INFO] [stderr] 96 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/lzss/decoder.rs:72:32 [INFO] [stderr] | [INFO] [stderr] 72 | let mut iter = testvec.into_iter().cloned(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lzss/decoder.rs:73:23 [INFO] [stderr] | [INFO] [stderr] 73 | let enc_ret = (0..) [INFO] [stderr] | _______________________^ [INFO] [stderr] 74 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lzss/decoder.rs:82:19 [INFO] [stderr] | [INFO] [stderr] 82 | let ret = (0..) [INFO] [stderr] | ___________________^ [INFO] [stderr] 83 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lzss/encoder.rs:147:17 [INFO] [stderr] | [INFO] [stderr] 147 | action: &Action, [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Action` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/lzss/encoder.rs:197:29 [INFO] [stderr] | [INFO] [stderr] 197 | let mut iter = b"a".into_iter().cloned(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lzss/encoder.rs:198:19 [INFO] [stderr] | [INFO] [stderr] 198 | let ret = (0..) [INFO] [stderr] | ___________________^ [INFO] [stderr] 199 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/lzss/encoder.rs:211:29 [INFO] [stderr] | [INFO] [stderr] 211 | let mut iter = b"a".into_iter().cloned(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lzss/encoder.rs:212:23 [INFO] [stderr] | [INFO] [stderr] 212 | let mut ret = (0..) [INFO] [stderr] | _______________________^ [INFO] [stderr] 213 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/lzss/encoder.rs:216:29 [INFO] [stderr] | [INFO] [stderr] 216 | let mut iter = b"a".into_iter().cloned(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lzss/encoder.rs:217:25 [INFO] [stderr] | [INFO] [stderr] 217 | ret.append(&mut (0..) [INFO] [stderr] | _________________________^ [INFO] [stderr] 218 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/lzss/encoder.rs:233:31 [INFO] [stderr] | [INFO] [stderr] 233 | let mut iter = b"aaa".into_iter().cloned(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lzss/encoder.rs:234:19 [INFO] [stderr] | [INFO] [stderr] 234 | let ret = (0..) [INFO] [stderr] | ___________________^ [INFO] [stderr] 235 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/lzss/encoder.rs:255:32 [INFO] [stderr] | [INFO] [stderr] 255 | let mut iter = b"aaaa".into_iter().cloned(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lzss/encoder.rs:256:19 [INFO] [stderr] | [INFO] [stderr] 256 | let ret = (0..) [INFO] [stderr] | ___________________^ [INFO] [stderr] 257 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/lzss/encoder.rs:275:39 [INFO] [stderr] | [INFO] [stderr] 275 | let mut iter = b"aaaaaaaaaaa".into_iter().cloned(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lzss/encoder.rs:276:19 [INFO] [stderr] | [INFO] [stderr] 276 | let ret = (0..) [INFO] [stderr] | ___________________^ [INFO] [stderr] 277 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/lzss/encoder.rs:299:29 [INFO] [stderr] | [INFO] [stderr] 299 | let mut iter = b"a".into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lzss/encoder.rs:305:19 [INFO] [stderr] | [INFO] [stderr] 305 | let ret = (0..) [INFO] [stderr] | ___________________^ [INFO] [stderr] 306 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/lzss/encoder.rs:327:29 [INFO] [stderr] | [INFO] [stderr] 327 | let mut iter = b"a".into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lzss/encoder.rs:333:19 [INFO] [stderr] | [INFO] [stderr] 333 | let ret = (0..) [INFO] [stderr] | ___________________^ [INFO] [stderr] 334 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/lzss/encoder.rs:357:29 [INFO] [stderr] | [INFO] [stderr] 357 | let mut iter = b"a".into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lzss/encoder.rs:363:19 [INFO] [stderr] | [INFO] [stderr] 363 | let ret = (0..) [INFO] [stderr] | ___________________^ [INFO] [stderr] 364 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/lzss/encoder.rs:386:40 [INFO] [stderr] | [INFO] [stderr] 386 | let mut iter = b"aaabbbaaabbb".into_iter().cloned(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lzss/encoder.rs:387:19 [INFO] [stderr] | [INFO] [stderr] 387 | let ret = (0..) [INFO] [stderr] | ___________________^ [INFO] [stderr] 388 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/lzss/encoder.rs:412:14 [INFO] [stderr] | [INFO] [stderr] 412 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lzss/encoder.rs:414:19 [INFO] [stderr] | [INFO] [stderr] 414 | let ret = (0..) [INFO] [stderr] | ___________________^ [INFO] [stderr] 415 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lzss/encoder.rs:443:24 [INFO] [stderr] | [INFO] [stderr] 443 | let mut iter = (0..256) [INFO] [stderr] | ________________________^ [INFO] [stderr] 444 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..256)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lzss/encoder.rs:450:19 [INFO] [stderr] | [INFO] [stderr] 450 | let ret = (0..) [INFO] [stderr] | ___________________^ [INFO] [stderr] 451 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lzss/encoder.rs:473:24 [INFO] [stderr] | [INFO] [stderr] 473 | let mut iter = (0..256) [INFO] [stderr] | ________________________^ [INFO] [stderr] 474 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..256)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lzss/encoder.rs:480:19 [INFO] [stderr] | [INFO] [stderr] 480 | let ret = (0..) [INFO] [stderr] | ___________________^ [INFO] [stderr] 481 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lzss/encoder.rs:508:15 [INFO] [stderr] | [INFO] [stderr] 508 | &((0..256) [INFO] [stderr] | _______________^ [INFO] [stderr] 509 | | .into_iter() [INFO] [stderr] | |____________________________^ help: consider removing `.into_iter()`: `(0..256)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lzss/encoder.rs:514:24 [INFO] [stderr] | [INFO] [stderr] 514 | let mut iter = (0..256) [INFO] [stderr] | ________________________^ [INFO] [stderr] 515 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..256)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lzss/encoder.rs:521:19 [INFO] [stderr] | [INFO] [stderr] 521 | let ret = (0..) [INFO] [stderr] | ___________________^ [INFO] [stderr] 522 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lzss/encoder.rs:548:15 [INFO] [stderr] | [INFO] [stderr] 548 | &((0..256) [INFO] [stderr] | _______________^ [INFO] [stderr] 549 | | .into_iter() [INFO] [stderr] | |____________________________^ help: consider removing `.into_iter()`: `(0..256)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lzss/encoder.rs:556:24 [INFO] [stderr] | [INFO] [stderr] 556 | let mut iter = (0..256) [INFO] [stderr] | ________________________^ [INFO] [stderr] 557 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..256)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lzss/encoder.rs:563:19 [INFO] [stderr] | [INFO] [stderr] 563 | let ret = (0..) [INFO] [stderr] | ___________________^ [INFO] [stderr] 564 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lzss/slidedict.rs:196:22 [INFO] [stderr] | [INFO] [stderr] 196 | for i in 0..(self.append_buf.len() - mm + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=self.append_buf.len() - mm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzss/slidedict.rs:199:25 [INFO] [stderr] | [INFO] [stderr] 199 | self.append_buf.as_ptr().offset(i as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.append_buf.as_ptr().add(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/traits/decoder.rs:31:10 [INFO] [stderr] | [INFO] [stderr] 31 | ) -> DecodeIterator, E, BitReader> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/traits/encoder.rs:88:17 [INFO] [stderr] | [INFO] [stderr] 88 | action: &Action, [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Action` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/bzip2/decoder.rs:153:5 [INFO] [stderr] | [INFO] [stderr] 153 | / fn init_block>( [INFO] [stderr] 154 | | &mut self, [INFO] [stderr] 155 | | reader: &mut R, [INFO] [stderr] 156 | | ) -> Result { [INFO] [stderr] ... | [INFO] [stderr] 537 | | } [INFO] [stderr] 538 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bzip2/encoder.rs:73:17 [INFO] [stderr] | [INFO] [stderr] 73 | action: &Action, [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Action` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/bzip2/encoder.rs:296:5 [INFO] [stderr] | [INFO] [stderr] 296 | / fn write_blockdata( [INFO] [stderr] 297 | | &mut self, [INFO] [stderr] 298 | | queue: &mut VecDeque>, [INFO] [stderr] 299 | | ) -> Result<(), CompressionError> { [INFO] [stderr] ... | [INFO] [stderr] 635 | | Ok(()) [INFO] [stderr] 636 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bzip2/mtf.rs:19:19 [INFO] [stderr] | [INFO] [stderr] 19 | data: (0..count).into_iter().collect::>(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bzip2/mtf.rs:48:19 [INFO] [stderr] | [INFO] [stderr] 48 | data: (0..count).into_iter().collect::>(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/bzip2/mod.rs:41:14 [INFO] [stderr] | [INFO] [stderr] 41 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/bzip2/mod.rs:85:14 [INFO] [stderr] | [INFO] [stderr] 85 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/bzip2/mod.rs:104:14 [INFO] [stderr] | [INFO] [stderr] 104 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/bzip2/mod.rs:123:14 [INFO] [stderr] | [INFO] [stderr] 123 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/deflate/decoder.rs:99:29 [INFO] [stderr] | [INFO] [stderr] 99 | for &i in len_index.into_iter().take(hclen as usize) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/deflate/encoder.rs:156:17 [INFO] [stderr] | [INFO] [stderr] 156 | action: &Action, [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Action` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/deflate/encoder.rs:478:22 [INFO] [stderr] | [INFO] [stderr] 478 | for i in 1..(self.decompress_len + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=self.decompress_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/deflate/encoder.rs:655:22 [INFO] [stderr] | [INFO] [stderr] 655 | let ret = [].into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/deflate/encoder.rs:672:24 [INFO] [stderr] | [INFO] [stderr] 672 | let ret = b"a".into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/deflate/encoder.rs:691:14 [INFO] [stderr] | [INFO] [stderr] 691 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/deflate/encoder.rs:715:14 [INFO] [stderr] | [INFO] [stderr] 715 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/deflate/mod.rs:174:20 [INFO] [stderr] | [INFO] [stderr] 174 | &(b"a".into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/gzip/decoder.rs:130:30 [INFO] [stderr] | [INFO] [stderr] 130 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/gzip/decoder.rs:149:30 [INFO] [stderr] | [INFO] [stderr] 149 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/gzip/encoder.rs:144:24 [INFO] [stderr] | [INFO] [stderr] 144 | let ret = b"a".into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/gzip/mod.rs:61:20 [INFO] [stderr] | [INFO] [stderr] 61 | &(b"a".into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/zlib/decoder.rs:99:30 [INFO] [stderr] | [INFO] [stderr] 99 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/zlib/encoder.rs:158:24 [INFO] [stderr] | [INFO] [stderr] 158 | let ret = b"a".into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/zlib/encoder.rs:174:24 [INFO] [stderr] | [INFO] [stderr] 174 | let ret = b"a".into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/zlib/mod.rs:61:20 [INFO] [stderr] | [INFO] [stderr] 61 | &(b"a".into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: aborting due to 25 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `compression`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "126b488fa2112ea37c4c994dc3d15318696b066f8a53152069580bcd87d671fd"` [INFO] running `"docker" "rm" "-f" "126b488fa2112ea37c4c994dc3d15318696b066f8a53152069580bcd87d671fd"` [INFO] [stdout] 126b488fa2112ea37c4c994dc3d15318696b066f8a53152069580bcd87d671fd