[INFO] crate completable_future 0.1.0 is already in cache [INFO] extracting crate completable_future 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/completable_future/0.1.0 [INFO] extracting crate completable_future 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/completable_future/0.1.0 [INFO] validating manifest of completable_future-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of completable_future-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing completable_future-0.1.0 [INFO] finished frobbing completable_future-0.1.0 [INFO] frobbed toml for completable_future-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/completable_future/0.1.0/Cargo.toml [INFO] started frobbing completable_future-0.1.0 [INFO] finished frobbing completable_future-0.1.0 [INFO] frobbed toml for completable_future-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/completable_future/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting completable_future-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/completable_future/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1e0d2bf60456cddbfdfeb406fee27ca65269ccdf816e97b5716b6bfe03409ab0 [INFO] running `"docker" "start" "-a" "1e0d2bf60456cddbfdfeb406fee27ca65269ccdf816e97b5716b6bfe03409ab0"` [INFO] [stderr] Checking completable_future v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | / match self { [INFO] [stderr] 75 | | &mut WakerWrapper::Registered(ref _dont_care) => (), [INFO] [stderr] 76 | | &mut WakerWrapper::NotRegistered => { [INFO] [stderr] 77 | | mem::replace(self, WakerWrapper::Registered(waker)); [INFO] [stderr] 78 | | }, [INFO] [stderr] 79 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 74 | match *self { [INFO] [stderr] 75 | WakerWrapper::Registered(ref _dont_care) => (), [INFO] [stderr] 76 | WakerWrapper::NotRegistered => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | / match self { [INFO] [stderr] 84 | | &WakerWrapper::Registered(ref w) => w.notify(), [INFO] [stderr] 85 | | &WakerWrapper::NotRegistered => (), [INFO] [stderr] 86 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 83 | match *self { [INFO] [stderr] 84 | WakerWrapper::Registered(ref w) => w.notify(), [INFO] [stderr] 85 | WakerWrapper::NotRegistered => (), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `CompletableFuture` [INFO] [stderr] --> src/lib.rs:179:5 [INFO] [stderr] | [INFO] [stderr] 179 | / pub fn new() -> CompletableFuture { [INFO] [stderr] 180 | | CompletableFuture { [INFO] [stderr] 181 | | internal: Arc::new(Mutex::new(SignalInternal{ [INFO] [stderr] 182 | | waker: WakerWrapper::NotRegistered, [INFO] [stderr] ... | [INFO] [stderr] 185 | | } [INFO] [stderr] 186 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 177 | impl Default for CompletableFuture { [INFO] [stderr] 178 | fn default() -> Self { [INFO] [stderr] 179 | Self::new() [INFO] [stderr] 180 | } [INFO] [stderr] 181 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:230:9 [INFO] [stderr] | [INFO] [stderr] 230 | / match state { [INFO] [stderr] 231 | | &mut FutureState::Pending => Ok(Async::NotReady), [INFO] [stderr] 232 | | &mut FutureState::Taken => panic!("bug: the value has been taken, yet I'm still polled again"), [INFO] [stderr] 233 | | &mut FutureState::Completed(_) => Ok(Async::Ready(state.unwrap_val())), [INFO] [stderr] 234 | | &mut FutureState::Errored(_) => Err(state.unwrap_err()), [INFO] [stderr] 235 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 230 | match *state { [INFO] [stderr] 231 | FutureState::Pending => Ok(Async::NotReady), [INFO] [stderr] 232 | FutureState::Taken => panic!("bug: the value has been taken, yet I'm still polled again"), [INFO] [stderr] 233 | FutureState::Completed(_) => Ok(Async::Ready(state.unwrap_val())), [INFO] [stderr] 234 | FutureState::Errored(_) => Err(state.unwrap_err()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | / match self { [INFO] [stderr] 75 | | &mut WakerWrapper::Registered(ref _dont_care) => (), [INFO] [stderr] 76 | | &mut WakerWrapper::NotRegistered => { [INFO] [stderr] 77 | | mem::replace(self, WakerWrapper::Registered(waker)); [INFO] [stderr] 78 | | }, [INFO] [stderr] 79 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 74 | match *self { [INFO] [stderr] 75 | WakerWrapper::Registered(ref _dont_care) => (), [INFO] [stderr] 76 | WakerWrapper::NotRegistered => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | / match self { [INFO] [stderr] 84 | | &WakerWrapper::Registered(ref w) => w.notify(), [INFO] [stderr] 85 | | &WakerWrapper::NotRegistered => (), [INFO] [stderr] 86 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 83 | match *self { [INFO] [stderr] 84 | WakerWrapper::Registered(ref w) => w.notify(), [INFO] [stderr] 85 | WakerWrapper::NotRegistered => (), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `CompletableFuture` [INFO] [stderr] --> src/lib.rs:179:5 [INFO] [stderr] | [INFO] [stderr] 179 | / pub fn new() -> CompletableFuture { [INFO] [stderr] 180 | | CompletableFuture { [INFO] [stderr] 181 | | internal: Arc::new(Mutex::new(SignalInternal{ [INFO] [stderr] 182 | | waker: WakerWrapper::NotRegistered, [INFO] [stderr] ... | [INFO] [stderr] 185 | | } [INFO] [stderr] 186 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 177 | impl Default for CompletableFuture { [INFO] [stderr] 178 | fn default() -> Self { [INFO] [stderr] 179 | Self::new() [INFO] [stderr] 180 | } [INFO] [stderr] 181 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:230:9 [INFO] [stderr] | [INFO] [stderr] 230 | / match state { [INFO] [stderr] 231 | | &mut FutureState::Pending => Ok(Async::NotReady), [INFO] [stderr] 232 | | &mut FutureState::Taken => panic!("bug: the value has been taken, yet I'm still polled again"), [INFO] [stderr] 233 | | &mut FutureState::Completed(_) => Ok(Async::Ready(state.unwrap_val())), [INFO] [stderr] 234 | | &mut FutureState::Errored(_) => Err(state.unwrap_err()), [INFO] [stderr] 235 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 230 | match *state { [INFO] [stderr] 231 | FutureState::Pending => Ok(Async::NotReady), [INFO] [stderr] 232 | FutureState::Taken => panic!("bug: the value has been taken, yet I'm still polled again"), [INFO] [stderr] 233 | FutureState::Completed(_) => Ok(Async::Ready(state.unwrap_val())), [INFO] [stderr] 234 | FutureState::Errored(_) => Err(state.unwrap_err()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.30s [INFO] running `"docker" "inspect" "1e0d2bf60456cddbfdfeb406fee27ca65269ccdf816e97b5716b6bfe03409ab0"` [INFO] running `"docker" "rm" "-f" "1e0d2bf60456cddbfdfeb406fee27ca65269ccdf816e97b5716b6bfe03409ab0"` [INFO] [stdout] 1e0d2bf60456cddbfdfeb406fee27ca65269ccdf816e97b5716b6bfe03409ab0