[INFO] crate comp 0.2.1 is already in cache [INFO] extracting crate comp 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/comp/0.2.1 [INFO] extracting crate comp 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/comp/0.2.1 [INFO] validating manifest of comp-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of comp-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing comp-0.2.1 [INFO] finished frobbing comp-0.2.1 [INFO] frobbed toml for comp-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/comp/0.2.1/Cargo.toml [INFO] started frobbing comp-0.2.1 [INFO] finished frobbing comp-0.2.1 [INFO] frobbed toml for comp-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/comp/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting comp-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/comp/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c48036d2813b8be9225e8fba2b925d384e8052198921095335e025206840a00c [INFO] running `"docker" "start" "-a" "c48036d2813b8be9225e8fba2b925d384e8052198921095335e025206840a00c"` [INFO] [stderr] Checking comp v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/lib.rs:470:62 [INFO] [stderr] | [INFO] [stderr] 470 | $e.and_then(move | option! (@as_pat $p { $( $para )* } ) | { option! { $( $t )* } } ) [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 860 | let option = option! { [INFO] [stderr] | ______________________- [INFO] [stderr] 861 | | let Struct { x: _ } <- Some(Struct { x: 8 }); [INFO] [stderr] 862 | | }; [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Struct { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lib.rs:866:30 [INFO] [stderr] | [INFO] [stderr] 866 | let Struct2 { x, y: _ } <- Some(Struct2 { x: 9, y: 10 }); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Struct2 { x, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:902:25 [INFO] [stderr] | [INFO] [stderr] 902 | assert!(iter.eq(expected.into_iter())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `expected` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:935:13 [INFO] [stderr] | [INFO] [stderr] 935 | a = a + 10; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `a += 10` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:938:13 [INFO] [stderr] | [INFO] [stderr] 938 | b = b + 10; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `b += 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:946:13 [INFO] [stderr] | [INFO] [stderr] 946 | a = a + 10; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `a += 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:949:13 [INFO] [stderr] | [INFO] [stderr] 949 | b = b + 10; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `b += 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:957:13 [INFO] [stderr] | [INFO] [stderr] 957 | a = a + 10; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `a += 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.11s [INFO] running `"docker" "inspect" "c48036d2813b8be9225e8fba2b925d384e8052198921095335e025206840a00c"` [INFO] running `"docker" "rm" "-f" "c48036d2813b8be9225e8fba2b925d384e8052198921095335e025206840a00c"` [INFO] [stdout] c48036d2813b8be9225e8fba2b925d384e8052198921095335e025206840a00c