[INFO] crate commandlines 0.8.0 is already in cache [INFO] extracting crate commandlines 0.8.0 into work/ex/clippy-test-run/sources/stable/reg/commandlines/0.8.0 [INFO] extracting crate commandlines 0.8.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/commandlines/0.8.0 [INFO] validating manifest of commandlines-0.8.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of commandlines-0.8.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing commandlines-0.8.0 [INFO] finished frobbing commandlines-0.8.0 [INFO] frobbed toml for commandlines-0.8.0 written to work/ex/clippy-test-run/sources/stable/reg/commandlines/0.8.0/Cargo.toml [INFO] started frobbing commandlines-0.8.0 [INFO] finished frobbing commandlines-0.8.0 [INFO] frobbed toml for commandlines-0.8.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/commandlines/0.8.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting commandlines-0.8.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/commandlines/0.8.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5b030703e23993499ecbdf1e8c9b42adc4384023ab570679953ab1d31bc983d2 [INFO] running `"docker" "start" "-a" "5b030703e23993499ecbdf1e8c9b42adc4384023ab570679953ab1d31bc983d2"` [INFO] [stderr] Checking commandlines v0.8.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `new_without_default_derive` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:8:45 [INFO] [stderr] | [INFO] [stderr] 8 | #![cfg_attr(feature = "cargo-clippy", allow(new_without_default_derive))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::new_without_default_derive` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `new_without_default_derive` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:8:45 [INFO] [stderr] | [INFO] [stderr] 8 | #![cfg_attr(feature = "cargo-clippy", allow(new_without_default_derive))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::new_without_default_derive` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `new_without_default_derive` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:8:45 [INFO] [stderr] | [INFO] [stderr] 8 | #![cfg_attr(feature = "cargo-clippy", allow(new_without_default_derive))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::new_without_default_derive` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:106:48 [INFO] [stderr] | [INFO] [stderr] 106 | #[cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:416:48 [INFO] [stderr] | [INFO] [stderr] 416 | #[cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: lint name `new_without_default_derive` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:8:45 [INFO] [stderr] | [INFO] [stderr] 8 | #![cfg_attr(feature = "cargo-clippy", allow(new_without_default_derive))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::new_without_default_derive` [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | / match &self.double_hyphen_argv { [INFO] [stderr] 183 | | Some(_) => true, [INFO] [stderr] 184 | | None => false, [INFO] [stderr] 185 | | } [INFO] [stderr] | |_________^ help: try this: `&self.double_hyphen_argv.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:258:9 [INFO] [stderr] | [INFO] [stderr] 258 | / match self.definitions.get(&String::from(needle)) { [INFO] [stderr] 259 | | Some(_) => true, [INFO] [stderr] 260 | | None => false, [INFO] [stderr] 261 | | } [INFO] [stderr] | |_________^ help: try this: `self.definitions.get(&String::from(needle)).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:106:48 [INFO] [stderr] | [INFO] [stderr] 106 | #[cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:416:48 [INFO] [stderr] | [INFO] [stderr] 416 | #[cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | / match &self.double_hyphen_argv { [INFO] [stderr] 183 | | Some(_) => true, [INFO] [stderr] 184 | | None => false, [INFO] [stderr] 185 | | } [INFO] [stderr] | |_________^ help: try this: `&self.double_hyphen_argv.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:258:9 [INFO] [stderr] | [INFO] [stderr] 258 | / match self.definitions.get(&String::from(needle)) { [INFO] [stderr] 259 | | Some(_) => true, [INFO] [stderr] 260 | | None => false, [INFO] [stderr] 261 | | } [INFO] [stderr] | |_________^ help: try this: `self.definitions.get(&String::from(needle)).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.07s [INFO] running `"docker" "inspect" "5b030703e23993499ecbdf1e8c9b42adc4384023ab570679953ab1d31bc983d2"` [INFO] running `"docker" "rm" "-f" "5b030703e23993499ecbdf1e8c9b42adc4384023ab570679953ab1d31bc983d2"` [INFO] [stdout] 5b030703e23993499ecbdf1e8c9b42adc4384023ab570679953ab1d31bc983d2