[INFO] crate comcart 0.1.0 is already in cache [INFO] extracting crate comcart 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/comcart/0.1.0 [INFO] extracting crate comcart 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/comcart/0.1.0 [INFO] validating manifest of comcart-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of comcart-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing comcart-0.1.0 [INFO] finished frobbing comcart-0.1.0 [INFO] frobbed toml for comcart-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/comcart/0.1.0/Cargo.toml [INFO] started frobbing comcart-0.1.0 [INFO] finished frobbing comcart-0.1.0 [INFO] frobbed toml for comcart-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/comcart/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting comcart-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/comcart/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a758dbef761cb8f5b6c12efd9d1fed954ff0d94cada05be319815c806001d4a7 [INFO] running `"docker" "start" "-a" "a758dbef761cb8f5b6c12efd9d1fed954ff0d94cada05be319815c806001d4a7"` [INFO] [stderr] Checking comcart v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/summarize/utils.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | modules: modules, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `modules` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | resources: resources, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `resources` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | items: items, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `items` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | identifier: identifier, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `identifier` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | item_type: item_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `item_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/summarize/utils.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | modules: modules, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `modules` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | resources: resources, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `resources` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | items: items, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `items` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | identifier: identifier, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `identifier` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | item_type: item_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `item_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/summarize/manifest/handler.rs:130:12 [INFO] [stderr] | [INFO] [stderr] 130 | } else if category.has_name("rights") { [INFO] [stderr] | ____________^ [INFO] [stderr] 131 | | if parent_tag.has_name("description") && current_tag.has_name("string") { [INFO] [stderr] 132 | | handler.builder.general.copyright(chars); [INFO] [stderr] 133 | | } [INFO] [stderr] 134 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 130 | } else if category.has_name("rights") && parent_tag.has_name("description") && current_tag.has_name("string") { [INFO] [stderr] 131 | handler.builder.general.copyright(chars); [INFO] [stderr] 132 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/summarize/manifest/handler.rs:130:12 [INFO] [stderr] | [INFO] [stderr] 130 | } else if category.has_name("rights") { [INFO] [stderr] | ____________^ [INFO] [stderr] 131 | | if parent_tag.has_name("description") && current_tag.has_name("string") { [INFO] [stderr] 132 | | handler.builder.general.copyright(chars); [INFO] [stderr] 133 | | } [INFO] [stderr] 134 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 130 | } else if category.has_name("rights") && parent_tag.has_name("description") && current_tag.has_name("string") { [INFO] [stderr] 131 | handler.builder.general.copyright(chars); [INFO] [stderr] 132 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/summarize/manifest/handler.rs:93:16 [INFO] [stderr] | [INFO] [stderr] 93 | && self.stack.get(num_ancestors - 2).unwrap().has_name("item") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.stack[num_ancestors - 2]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/summarize/manifest/handler.rs:102:12 [INFO] [stderr] | [INFO] [stderr] 102 | if self.stack.get(num_ancestors - 4).unwrap().has_name("lom") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.stack[num_ancestors - 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/summarize/manifest/handler.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | let ref current_tag = handler.stack.last().unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^--------------------------------- help: try: `let current_tag = &handler.stack.last().unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/summarize/manifest/handler.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | let ref parent_tag = handler.stack.get(num_ancestors - 2).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^------------------------------------------------- help: try: `let parent_tag = &handler.stack.get(num_ancestors - 2).unwrap();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/summarize/manifest/handler.rs:121:26 [INFO] [stderr] | [INFO] [stderr] 121 | let ref parent_tag = handler.stack.get(num_ancestors - 2).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `handler.stack[num_ancestors - 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/summarize/manifest/handler.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | let ref category = handler.stack.get(num_ancestors - 3).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^------------------------------------------------- help: try: `let category = &handler.stack.get(num_ancestors - 3).unwrap();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/summarize/manifest/handler.rs:122:24 [INFO] [stderr] | [INFO] [stderr] 122 | let ref category = handler.stack.get(num_ancestors - 3).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `handler.stack[num_ancestors - 3]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/summarize/utils.rs:47:53 [INFO] [stderr] | [INFO] [stderr] 47 | static ref DISCUSSION_R: Regex = Regex::new(r"imsdt").unwrap(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/summarize/utils.rs:48:53 [INFO] [stderr] | [INFO] [stderr] 48 | static ref WEBCONTENT_R: Regex = Regex::new(r"webcontent").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/summarize/utils.rs:49:50 [INFO] [stderr] | [INFO] [stderr] 49 | static ref WEBLINK_R: Regex = Regex::new(r"wl").unwrap(); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/common.rs:196:35 [INFO] [stderr] | [INFO] [stderr] 196 | identifier_ref: i_ref.unwrap_or("".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/common.rs:222:66 [INFO] [stderr] | [INFO] [stderr] 222 | let item_type = utils::typestr_to_type(node.find("type").unwrap_or("".to_string()).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/summarize/manifest/handler.rs:93:16 [INFO] [stderr] | [INFO] [stderr] 93 | && self.stack.get(num_ancestors - 2).unwrap().has_name("item") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.stack[num_ancestors - 2]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/summarize/manifest/handler.rs:102:12 [INFO] [stderr] | [INFO] [stderr] 102 | if self.stack.get(num_ancestors - 4).unwrap().has_name("lom") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.stack[num_ancestors - 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/summarize/manifest/handler.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | let ref current_tag = handler.stack.last().unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^--------------------------------- help: try: `let current_tag = &handler.stack.last().unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/summarize/manifest/handler.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | let ref parent_tag = handler.stack.get(num_ancestors - 2).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^------------------------------------------------- help: try: `let parent_tag = &handler.stack.get(num_ancestors - 2).unwrap();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/summarize/manifest/handler.rs:121:26 [INFO] [stderr] | [INFO] [stderr] 121 | let ref parent_tag = handler.stack.get(num_ancestors - 2).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `handler.stack[num_ancestors - 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/summarize/manifest/handler.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | let ref category = handler.stack.get(num_ancestors - 3).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^------------------------------------------------- help: try: `let category = &handler.stack.get(num_ancestors - 3).unwrap();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/summarize/manifest/handler.rs:122:24 [INFO] [stderr] | [INFO] [stderr] 122 | let ref category = handler.stack.get(num_ancestors - 3).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `handler.stack[num_ancestors - 3]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/summarize/utils.rs:47:53 [INFO] [stderr] | [INFO] [stderr] 47 | static ref DISCUSSION_R: Regex = Regex::new(r"imsdt").unwrap(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/summarize/utils.rs:48:53 [INFO] [stderr] | [INFO] [stderr] 48 | static ref WEBCONTENT_R: Regex = Regex::new(r"webcontent").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/summarize/utils.rs:49:50 [INFO] [stderr] | [INFO] [stderr] 49 | static ref WEBLINK_R: Regex = Regex::new(r"wl").unwrap(); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/common.rs:196:35 [INFO] [stderr] | [INFO] [stderr] 196 | identifier_ref: i_ref.unwrap_or("".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/common.rs:222:66 [INFO] [stderr] | [INFO] [stderr] 222 | let item_type = utils::typestr_to_type(node.find("type").unwrap_or("".to_string()).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.24s [INFO] running `"docker" "inspect" "a758dbef761cb8f5b6c12efd9d1fed954ff0d94cada05be319815c806001d4a7"` [INFO] running `"docker" "rm" "-f" "a758dbef761cb8f5b6c12efd9d1fed954ff0d94cada05be319815c806001d4a7"` [INFO] [stdout] a758dbef761cb8f5b6c12efd9d1fed954ff0d94cada05be319815c806001d4a7