[INFO] crate combpop 0.0.3 is already in cache [INFO] extracting crate combpop 0.0.3 into work/ex/clippy-test-run/sources/stable/reg/combpop/0.0.3 [INFO] extracting crate combpop 0.0.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/combpop/0.0.3 [INFO] validating manifest of combpop-0.0.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of combpop-0.0.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing combpop-0.0.3 [INFO] finished frobbing combpop-0.0.3 [INFO] frobbed toml for combpop-0.0.3 written to work/ex/clippy-test-run/sources/stable/reg/combpop/0.0.3/Cargo.toml [INFO] started frobbing combpop-0.0.3 [INFO] finished frobbing combpop-0.0.3 [INFO] frobbed toml for combpop-0.0.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/combpop/0.0.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting combpop-0.0.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/combpop/0.0.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 557063dbc293344a7aea53b32742b3609b58f4fbf31e55454370d641b07060ad [INFO] running `"docker" "start" "-a" "557063dbc293344a7aea53b32742b3609b58f4fbf31e55454370d641b07060ad"` [INFO] [stderr] Checking combpop v0.0.3 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / match self { [INFO] [stderr] 14 | | &ParseError::EOF | &ParseError::SyntaxError => true, [INFO] [stderr] 15 | | &ParseError::NotReady => false, [INFO] [stderr] 16 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 13 | match *self { [INFO] [stderr] 14 | ParseError::EOF | ParseError::SyntaxError => true, [INFO] [stderr] 15 | ParseError::NotReady => false, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/byte.rs:76:22 [INFO] [stderr] | [INFO] [stderr] 76 | let b0 = b0 as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(b0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/byte.rs:77:22 [INFO] [stderr] | [INFO] [stderr] 77 | let b1 = get!(1, 0x80, 0xC0) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 77 | let b1 = u32::from({ [INFO] [stderr] 78 | let b = match stream.lookahead($i + 1) { [INFO] [stderr] 79 | Ok(()) => *stream.get($i), [INFO] [stderr] 80 | Err(ParseError::EOF) => return Ok(None), [INFO] [stderr] 81 | Err(e) => return Err(e), [INFO] [stderr] 82 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/byte.rs:82:22 [INFO] [stderr] | [INFO] [stderr] 82 | let b0 = b0 as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(b0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/byte.rs:83:22 [INFO] [stderr] | [INFO] [stderr] 83 | let b1 = get!(1, b1lim, 0xC0) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 83 | let b1 = u32::from({ [INFO] [stderr] 84 | let b = match stream.lookahead($i + 1) { [INFO] [stderr] 85 | Ok(()) => *stream.get($i), [INFO] [stderr] 86 | Err(ParseError::EOF) => return Ok(None), [INFO] [stderr] 87 | Err(e) => return Err(e), [INFO] [stderr] 88 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/byte.rs:88:22 [INFO] [stderr] | [INFO] [stderr] 88 | let b2 = get!(2, 0x80, 0xC0) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 88 | let b2 = u32::from({ [INFO] [stderr] 89 | let b = match stream.lookahead($i + 1) { [INFO] [stderr] 90 | Ok(()) => *stream.get($i), [INFO] [stderr] 91 | Err(ParseError::EOF) => return Ok(None), [INFO] [stderr] 92 | Err(e) => return Err(e), [INFO] [stderr] 93 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/byte.rs:93:22 [INFO] [stderr] | [INFO] [stderr] 93 | let b0 = b0 as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(b0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/byte.rs:94:22 [INFO] [stderr] | [INFO] [stderr] 94 | let b1 = get!(1, b1lim, 0xC0) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 94 | let b1 = u32::from({ [INFO] [stderr] 95 | let b = match stream.lookahead($i + 1) { [INFO] [stderr] 96 | Ok(()) => *stream.get($i), [INFO] [stderr] 97 | Err(ParseError::EOF) => return Ok(None), [INFO] [stderr] 98 | Err(e) => return Err(e), [INFO] [stderr] 99 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/byte.rs:95:22 [INFO] [stderr] | [INFO] [stderr] 95 | let b2 = get!(2, 0x80, 0xC0) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 95 | let b2 = u32::from({ [INFO] [stderr] 96 | let b = match stream.lookahead($i + 1) { [INFO] [stderr] 97 | Ok(()) => *stream.get($i), [INFO] [stderr] 98 | Err(ParseError::EOF) => return Ok(None), [INFO] [stderr] 99 | Err(e) => return Err(e), [INFO] [stderr] 100| }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/byte.rs:96:22 [INFO] [stderr] | [INFO] [stderr] 96 | let b3 = get!(3, 0x80, 0xC0) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 96 | let b3 = u32::from({ [INFO] [stderr] 97 | let b = match stream.lookahead($i + 1) { [INFO] [stderr] 98 | Ok(()) => *stream.get($i), [INFO] [stderr] 99 | Err(ParseError::EOF) => return Ok(None), [INFO] [stderr] 100| Err(e) => return Err(e), [INFO] [stderr] 101| }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / match self { [INFO] [stderr] 14 | | &ParseError::EOF | &ParseError::SyntaxError => true, [INFO] [stderr] 15 | | &ParseError::NotReady => false, [INFO] [stderr] 16 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 13 | match *self { [INFO] [stderr] 14 | ParseError::EOF | ParseError::SyntaxError => true, [INFO] [stderr] 15 | ParseError::NotReady => false, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/byte.rs:76:22 [INFO] [stderr] | [INFO] [stderr] 76 | let b0 = b0 as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(b0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/byte.rs:77:22 [INFO] [stderr] | [INFO] [stderr] 77 | let b1 = get!(1, 0x80, 0xC0) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 77 | let b1 = u32::from({ [INFO] [stderr] 78 | let b = match stream.lookahead($i + 1) { [INFO] [stderr] 79 | Ok(()) => *stream.get($i), [INFO] [stderr] 80 | Err(ParseError::EOF) => return Ok(None), [INFO] [stderr] 81 | Err(e) => return Err(e), [INFO] [stderr] 82 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/byte.rs:82:22 [INFO] [stderr] | [INFO] [stderr] 82 | let b0 = b0 as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(b0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/byte.rs:83:22 [INFO] [stderr] | [INFO] [stderr] 83 | let b1 = get!(1, b1lim, 0xC0) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 83 | let b1 = u32::from({ [INFO] [stderr] 84 | let b = match stream.lookahead($i + 1) { [INFO] [stderr] 85 | Ok(()) => *stream.get($i), [INFO] [stderr] 86 | Err(ParseError::EOF) => return Ok(None), [INFO] [stderr] 87 | Err(e) => return Err(e), [INFO] [stderr] 88 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/byte.rs:88:22 [INFO] [stderr] | [INFO] [stderr] 88 | let b2 = get!(2, 0x80, 0xC0) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 88 | let b2 = u32::from({ [INFO] [stderr] 89 | let b = match stream.lookahead($i + 1) { [INFO] [stderr] 90 | Ok(()) => *stream.get($i), [INFO] [stderr] 91 | Err(ParseError::EOF) => return Ok(None), [INFO] [stderr] 92 | Err(e) => return Err(e), [INFO] [stderr] 93 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/byte.rs:93:22 [INFO] [stderr] | [INFO] [stderr] 93 | let b0 = b0 as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(b0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/byte.rs:94:22 [INFO] [stderr] | [INFO] [stderr] 94 | let b1 = get!(1, b1lim, 0xC0) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 94 | let b1 = u32::from({ [INFO] [stderr] 95 | let b = match stream.lookahead($i + 1) { [INFO] [stderr] 96 | Ok(()) => *stream.get($i), [INFO] [stderr] 97 | Err(ParseError::EOF) => return Ok(None), [INFO] [stderr] 98 | Err(e) => return Err(e), [INFO] [stderr] 99 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/byte.rs:95:22 [INFO] [stderr] | [INFO] [stderr] 95 | let b2 = get!(2, 0x80, 0xC0) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 95 | let b2 = u32::from({ [INFO] [stderr] 96 | let b = match stream.lookahead($i + 1) { [INFO] [stderr] 97 | Ok(()) => *stream.get($i), [INFO] [stderr] 98 | Err(ParseError::EOF) => return Ok(None), [INFO] [stderr] 99 | Err(e) => return Err(e), [INFO] [stderr] 100| }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/byte.rs:96:22 [INFO] [stderr] | [INFO] [stderr] 96 | let b3 = get!(3, 0x80, 0xC0) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 96 | let b3 = u32::from({ [INFO] [stderr] 97 | let b = match stream.lookahead($i + 1) { [INFO] [stderr] 98 | Ok(()) => *stream.get($i), [INFO] [stderr] 99 | Err(ParseError::EOF) => return Ok(None), [INFO] [stderr] 100| Err(e) => return Err(e), [INFO] [stderr] 101| }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.16s [INFO] running `"docker" "inspect" "557063dbc293344a7aea53b32742b3609b58f4fbf31e55454370d641b07060ad"` [INFO] running `"docker" "rm" "-f" "557063dbc293344a7aea53b32742b3609b58f4fbf31e55454370d641b07060ad"` [INFO] [stdout] 557063dbc293344a7aea53b32742b3609b58f4fbf31e55454370d641b07060ad