[INFO] crate combine 3.6.3 is already in cache [INFO] extracting crate combine 3.6.3 into work/ex/clippy-test-run/sources/stable/reg/combine/3.6.3 [INFO] extracting crate combine 3.6.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/combine/3.6.3 [INFO] validating manifest of combine-3.6.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of combine-3.6.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing combine-3.6.3 [INFO] removed 5 missing examples [INFO] finished frobbing combine-3.6.3 [INFO] frobbed toml for combine-3.6.3 written to work/ex/clippy-test-run/sources/stable/reg/combine/3.6.3/Cargo.toml [INFO] started frobbing combine-3.6.3 [INFO] removed 5 missing examples [INFO] finished frobbing combine-3.6.3 [INFO] frobbed toml for combine-3.6.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/combine/3.6.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting combine-3.6.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/combine/3.6.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2c8d65ee4c8ff92f006c29dfb3647c376c9cb6a9114233027aec51781710b8e0 [INFO] running `"docker" "start" "-a" "2c8d65ee4c8ff92f006c29dfb3647c376c9cb6a9114233027aec51781710b8e0"` [INFO] [stderr] warning: An explicit [[example]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other example targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a example target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/examples/date.rs [INFO] [stderr] * /opt/crater/workdir/examples/async.rs [INFO] [stderr] * /opt/crater/workdir/examples/readme.rs [INFO] [stderr] * /opt/crater/workdir/examples/number.rs [INFO] [stderr] * /opt/crater/workdir/examples/ini.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a example target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autoexamples = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] Checking combine v3.6.3 (/opt/crater/workdir) [INFO] [stderr] Checking partial-io v0.3.0 [INFO] [stderr] warning: lint name `inline_always` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:191:11 [INFO] [stderr] | [INFO] [stderr] 191 | allow(inline_always, type_complexity, too_many_arguments) [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::inline_always` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:191:26 [INFO] [stderr] | [INFO] [stderr] 191 | allow(inline_always, type_complexity, too_many_arguments) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:191:43 [INFO] [stderr] | [INFO] [stderr] 191 | allow(inline_always, type_complexity, too_many_arguments) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments` [INFO] [stderr] [INFO] [stderr] warning: unknown lint: `clippy_lint` [INFO] [stderr] --> src/lib.rs:193:45 [INFO] [stderr] | [INFO] [stderr] 193 | #![cfg_attr(feature = "cargo-clippy", allow(clippy_lint))] [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unknown_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:623:13 [INFO] [stderr] | [INFO] [stderr] 623 | error: error, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `error` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream/buffered.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream/easy.rs:591:13 [INFO] [stderr] | [INFO] [stderr] 591 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream/easy.rs:592:13 [INFO] [stderr] | [INFO] [stderr] 592 | errors: errors, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/function.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 177 | env: env, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/function.rs:178:9 [INFO] [stderr] | [INFO] [stderr] 178 | parser: parser, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/item.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | predicate: predicate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `predicate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/item.rs:170:9 [INFO] [stderr] | [INFO] [stderr] 170 | predicate: predicate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `predicate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/item.rs:222:9 [INFO] [stderr] | [INFO] [stderr] 222 | c: c, [INFO] [stderr] | ^^^^ help: replace it with: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/item.rs:327:9 [INFO] [stderr] | [INFO] [stderr] 327 | cmp: cmp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cmp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/item.rs:328:9 [INFO] [stderr] | [INFO] [stderr] 328 | expected: expected, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `expected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/item.rs:329:9 [INFO] [stderr] | [INFO] [stderr] 329 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/item.rs:429:9 [INFO] [stderr] | [INFO] [stderr] 429 | cmp: cmp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cmp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/item.rs:430:9 [INFO] [stderr] | [INFO] [stderr] 430 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/item.rs:532:9 [INFO] [stderr] | [INFO] [stderr] 532 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/item.rs:592:9 [INFO] [stderr] | [INFO] [stderr] 592 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/repeat.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | min: min, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/repeat.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | max: max, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `inline_always` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:191:11 [INFO] [stderr] | [INFO] [stderr] 191 | allow(inline_always, type_complexity, too_many_arguments) [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::inline_always` [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/parser/range.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | / if !mode.is_first() { [INFO] [stderr] 162 | | if input.uncons_range(*distance_state).is_err() { [INFO] [stderr] 163 | | panic!("recognize errored when restoring the input stream to its expected state"); [INFO] [stderr] 164 | | } [INFO] [stderr] 165 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 161 | if !mode.is_first() && input.uncons_range(*distance_state).is_err() { [INFO] [stderr] 162 | panic!("recognize errored when restoring the input stream to its expected state"); [INFO] [stderr] 163 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: lint name `inline_always` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:191:11 [INFO] [stderr] | [INFO] [stderr] 191 | allow(inline_always, type_complexity, too_many_arguments) [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::inline_always` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:191:26 [INFO] [stderr] | [INFO] [stderr] 191 | allow(inline_always, type_complexity, too_many_arguments) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:191:43 [INFO] [stderr] | [INFO] [stderr] 191 | allow(inline_always, type_complexity, too_many_arguments) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments` [INFO] [stderr] [INFO] [stderr] warning: unknown lint: `clippy_lint` [INFO] [stderr] --> src/lib.rs:193:45 [INFO] [stderr] | [INFO] [stderr] 193 | #![cfg_attr(feature = "cargo-clippy", allow(clippy_lint))] [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unknown_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:623:13 [INFO] [stderr] | [INFO] [stderr] 623 | error: error, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `error` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream/buffered.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream/easy.rs:591:13 [INFO] [stderr] | [INFO] [stderr] 591 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream/easy.rs:592:13 [INFO] [stderr] | [INFO] [stderr] 592 | errors: errors, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/function.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 177 | env: env, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/function.rs:178:9 [INFO] [stderr] | [INFO] [stderr] 178 | parser: parser, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/item.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | predicate: predicate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `predicate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/item.rs:170:9 [INFO] [stderr] | [INFO] [stderr] 170 | predicate: predicate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `predicate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/item.rs:222:9 [INFO] [stderr] | [INFO] [stderr] 222 | c: c, [INFO] [stderr] | ^^^^ help: replace it with: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/item.rs:327:9 [INFO] [stderr] | [INFO] [stderr] 327 | cmp: cmp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cmp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/item.rs:328:9 [INFO] [stderr] | [INFO] [stderr] 328 | expected: expected, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `expected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/item.rs:329:9 [INFO] [stderr] | [INFO] [stderr] 329 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/item.rs:429:9 [INFO] [stderr] | [INFO] [stderr] 429 | cmp: cmp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cmp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/item.rs:430:9 [INFO] [stderr] | [INFO] [stderr] 430 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/item.rs:532:9 [INFO] [stderr] | [INFO] [stderr] 532 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/item.rs:592:9 [INFO] [stderr] | [INFO] [stderr] 592 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/repeat.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | min: min, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/repeat.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | max: max, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `inline_always` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:191:11 [INFO] [stderr] | [INFO] [stderr] 191 | allow(inline_always, type_complexity, too_many_arguments) [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::inline_always` [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/parser/range.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | / if !mode.is_first() { [INFO] [stderr] 162 | | if input.uncons_range(*distance_state).is_err() { [INFO] [stderr] 163 | | panic!("recognize errored when restoring the input stream to its expected state"); [INFO] [stderr] 164 | | } [INFO] [stderr] 165 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 161 | if !mode.is_first() && input.uncons_range(*distance_state).is_err() { [INFO] [stderr] 162 | panic!("recognize errored when restoring the input stream to its expected state"); [INFO] [stderr] 163 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/error.rs:175:77 [INFO] [stderr] | [INFO] [stderr] 175 | Ok((v, Consumed::Empty(rest))) => Ok((v, Consumed::Consumed(rest))), [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 175 | Ok((v, Consumed::Empty(rest))) => Ok((v, Consumed::Consumed(()))), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/stream/buffered.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | "Backtracked to far".into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"Backtracked to far"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/stream/easy.rs:365:29 [INFO] [stderr] | [INFO] [stderr] 365 | Self::new(position, Error::from(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `Error::from()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/stream/state.rs:222:9 [INFO] [stderr] | [INFO] [stderr] 222 | self.clone() [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/stream/mod.rs:374:5 [INFO] [stderr] | [INFO] [stderr] 374 | / loop { [INFO] [stderr] 375 | | test_next!(); [INFO] [stderr] 376 | | test_next!(); [INFO] [stderr] 377 | | test_next!(); [INFO] [stderr] ... | [INFO] [stderr] 382 | | test_next!(); [INFO] [stderr] 383 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(c) = chars.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:584:31 [INFO] [stderr] | [INFO] [stderr] 584 | pub fn $func_name<'a, B, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 615 | / integer_parser!( [INFO] [stderr] 616 | | /// Reads a u16 out of the byte stream with the specified endianess [INFO] [stderr] 617 | | /// [INFO] [stderr] 618 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 626 | | pub U16, u16, be_u16, le_u16, read_u16 [INFO] [stderr] 627 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:595:29 [INFO] [stderr] | [INFO] [stderr] 595 | pub fn $be_name<'a, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 615 | / integer_parser!( [INFO] [stderr] 616 | | /// Reads a u16 out of the byte stream with the specified endianess [INFO] [stderr] 617 | | /// [INFO] [stderr] 618 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 626 | | pub U16, u16, be_u16, le_u16, read_u16 [INFO] [stderr] 627 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:605:29 [INFO] [stderr] | [INFO] [stderr] 605 | pub fn $le_name<'a, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 615 | / integer_parser!( [INFO] [stderr] 616 | | /// Reads a u16 out of the byte stream with the specified endianess [INFO] [stderr] 617 | | /// [INFO] [stderr] 618 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 626 | | pub U16, u16, be_u16, le_u16, read_u16 [INFO] [stderr] 627 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:584:31 [INFO] [stderr] | [INFO] [stderr] 584 | pub fn $func_name<'a, B, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 628 | / integer_parser!( [INFO] [stderr] 629 | | /// Reads a u32 out of the byte stream with the specified endianess [INFO] [stderr] 630 | | /// [INFO] [stderr] 631 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 639 | | pub U32, u32, be_u32, le_u32, read_u32 [INFO] [stderr] 640 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:595:29 [INFO] [stderr] | [INFO] [stderr] 595 | pub fn $be_name<'a, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 628 | / integer_parser!( [INFO] [stderr] 629 | | /// Reads a u32 out of the byte stream with the specified endianess [INFO] [stderr] 630 | | /// [INFO] [stderr] 631 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 639 | | pub U32, u32, be_u32, le_u32, read_u32 [INFO] [stderr] 640 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:605:29 [INFO] [stderr] | [INFO] [stderr] 605 | pub fn $le_name<'a, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 628 | / integer_parser!( [INFO] [stderr] 629 | | /// Reads a u32 out of the byte stream with the specified endianess [INFO] [stderr] 630 | | /// [INFO] [stderr] 631 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 639 | | pub U32, u32, be_u32, le_u32, read_u32 [INFO] [stderr] 640 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:584:31 [INFO] [stderr] | [INFO] [stderr] 584 | pub fn $func_name<'a, B, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 641 | / integer_parser!( [INFO] [stderr] 642 | | /// Reads a u64 out of the byte stream with the specified endianess [INFO] [stderr] 643 | | /// [INFO] [stderr] 644 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 652 | | pub U64, u64, be_u64, le_u64, read_u64 [INFO] [stderr] 653 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:595:29 [INFO] [stderr] | [INFO] [stderr] 595 | pub fn $be_name<'a, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 641 | / integer_parser!( [INFO] [stderr] 642 | | /// Reads a u64 out of the byte stream with the specified endianess [INFO] [stderr] 643 | | /// [INFO] [stderr] 644 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 652 | | pub U64, u64, be_u64, le_u64, read_u64 [INFO] [stderr] 653 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:605:29 [INFO] [stderr] | [INFO] [stderr] 605 | pub fn $le_name<'a, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 641 | / integer_parser!( [INFO] [stderr] 642 | | /// Reads a u64 out of the byte stream with the specified endianess [INFO] [stderr] 643 | | /// [INFO] [stderr] 644 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 652 | | pub U64, u64, be_u64, le_u64, read_u64 [INFO] [stderr] 653 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:584:31 [INFO] [stderr] | [INFO] [stderr] 584 | pub fn $func_name<'a, B, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 655 | / integer_parser!( [INFO] [stderr] 656 | | /// Reads a i16 out of the byte stream with the specified endianess [INFO] [stderr] 657 | | /// [INFO] [stderr] 658 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 666 | | pub I16, i16, be_i16, le_i16, read_i16 [INFO] [stderr] 667 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:595:29 [INFO] [stderr] | [INFO] [stderr] 595 | pub fn $be_name<'a, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 655 | / integer_parser!( [INFO] [stderr] 656 | | /// Reads a i16 out of the byte stream with the specified endianess [INFO] [stderr] 657 | | /// [INFO] [stderr] 658 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 666 | | pub I16, i16, be_i16, le_i16, read_i16 [INFO] [stderr] 667 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:605:29 [INFO] [stderr] | [INFO] [stderr] 605 | pub fn $le_name<'a, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 655 | / integer_parser!( [INFO] [stderr] 656 | | /// Reads a i16 out of the byte stream with the specified endianess [INFO] [stderr] 657 | | /// [INFO] [stderr] 658 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 666 | | pub I16, i16, be_i16, le_i16, read_i16 [INFO] [stderr] 667 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:584:31 [INFO] [stderr] | [INFO] [stderr] 584 | pub fn $func_name<'a, B, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 669 | / integer_parser!( [INFO] [stderr] 670 | | /// Reads a i32 out of the byte stream with the specified endianess [INFO] [stderr] 671 | | /// [INFO] [stderr] 672 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 680 | | pub I32, i32, be_i32, le_i32, read_i32 [INFO] [stderr] 681 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:595:29 [INFO] [stderr] | [INFO] [stderr] 595 | pub fn $be_name<'a, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 669 | / integer_parser!( [INFO] [stderr] 670 | | /// Reads a i32 out of the byte stream with the specified endianess [INFO] [stderr] 671 | | /// [INFO] [stderr] 672 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 680 | | pub I32, i32, be_i32, le_i32, read_i32 [INFO] [stderr] 681 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:605:29 [INFO] [stderr] | [INFO] [stderr] 605 | pub fn $le_name<'a, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 669 | / integer_parser!( [INFO] [stderr] 670 | | /// Reads a i32 out of the byte stream with the specified endianess [INFO] [stderr] 671 | | /// [INFO] [stderr] 672 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 680 | | pub I32, i32, be_i32, le_i32, read_i32 [INFO] [stderr] 681 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:584:31 [INFO] [stderr] | [INFO] [stderr] 584 | pub fn $func_name<'a, B, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 682 | / integer_parser!( [INFO] [stderr] 683 | | /// Reads a i64 out of the byte stream with the specified endianess [INFO] [stderr] 684 | | /// [INFO] [stderr] 685 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 693 | | pub I64, i64, be_i64, le_i64, read_i64 [INFO] [stderr] 694 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:595:29 [INFO] [stderr] | [INFO] [stderr] 595 | pub fn $be_name<'a, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 682 | / integer_parser!( [INFO] [stderr] 683 | | /// Reads a i64 out of the byte stream with the specified endianess [INFO] [stderr] 684 | | /// [INFO] [stderr] 685 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 693 | | pub I64, i64, be_i64, le_i64, read_i64 [INFO] [stderr] 694 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:605:29 [INFO] [stderr] | [INFO] [stderr] 605 | pub fn $le_name<'a, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 682 | / integer_parser!( [INFO] [stderr] 683 | | /// Reads a i64 out of the byte stream with the specified endianess [INFO] [stderr] 684 | | /// [INFO] [stderr] 685 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 693 | | pub I64, i64, be_i64, le_i64, read_i64 [INFO] [stderr] 694 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:584:31 [INFO] [stderr] | [INFO] [stderr] 584 | pub fn $func_name<'a, B, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 696 | / integer_parser!( [INFO] [stderr] 697 | | /// Reads a i32 out of the byte stream with the specified endianess [INFO] [stderr] 698 | | /// [INFO] [stderr] 699 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 709 | | pub F32, f32, be_f32, le_f32, read_f32 [INFO] [stderr] 710 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:595:29 [INFO] [stderr] | [INFO] [stderr] 595 | pub fn $be_name<'a, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 696 | / integer_parser!( [INFO] [stderr] 697 | | /// Reads a i32 out of the byte stream with the specified endianess [INFO] [stderr] 698 | | /// [INFO] [stderr] 699 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 709 | | pub F32, f32, be_f32, le_f32, read_f32 [INFO] [stderr] 710 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:605:29 [INFO] [stderr] | [INFO] [stderr] 605 | pub fn $le_name<'a, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 696 | / integer_parser!( [INFO] [stderr] 697 | | /// Reads a i32 out of the byte stream with the specified endianess [INFO] [stderr] 698 | | /// [INFO] [stderr] 699 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 709 | | pub F32, f32, be_f32, le_f32, read_f32 [INFO] [stderr] 710 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:584:31 [INFO] [stderr] | [INFO] [stderr] 584 | pub fn $func_name<'a, B, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 711 | / integer_parser!( [INFO] [stderr] 712 | | /// Reads a i64 out of the byte stream with the specified endianess [INFO] [stderr] 713 | | /// [INFO] [stderr] 714 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 724 | | pub F64, f64, be_f64, le_f64, read_f64 [INFO] [stderr] 725 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:595:29 [INFO] [stderr] | [INFO] [stderr] 595 | pub fn $be_name<'a, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 711 | / integer_parser!( [INFO] [stderr] 712 | | /// Reads a i64 out of the byte stream with the specified endianess [INFO] [stderr] 713 | | /// [INFO] [stderr] 714 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 724 | | pub F64, f64, be_f64, le_f64, read_f64 [INFO] [stderr] 725 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:605:29 [INFO] [stderr] | [INFO] [stderr] 605 | pub fn $le_name<'a, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 711 | / integer_parser!( [INFO] [stderr] 712 | | /// Reads a i64 out of the byte stream with the specified endianess [INFO] [stderr] 713 | | /// [INFO] [stderr] 714 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 724 | | pub F64, f64, be_f64, le_f64, read_f64 [INFO] [stderr] 725 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/parser/combinator.rs:290:41 [INFO] [stderr] | [INFO] [stderr] 290 | Err(err) => ConsumedErr(err.into()), [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/parser/combinator.rs:359:25 [INFO] [stderr] | [INFO] [stderr] 359 | ::Error::from_error(position, err.into()).into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `::Error::from_error(position, err.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/parser/combinator.rs:788:38 [INFO] [stderr] | [INFO] [stderr] 788 | let child_state = if let None = state.0 { [INFO] [stderr] | _______________________________- ^^^^ [INFO] [stderr] 789 | | new_child_state = Some(Default::default()); [INFO] [stderr] 790 | | new_child_state.as_mut().unwrap() [INFO] [stderr] 791 | | } else { [INFO] [stderr] 792 | | new_child_state = None; [INFO] [stderr] 793 | | state.0.as_mut().unwrap().downcast_mut().unwrap() [INFO] [stderr] 794 | | }; [INFO] [stderr] | |_____________- help: try this: `if state.0.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/parser/item.rs:273:34 [INFO] [stderr] | [INFO] [stderr] 273 | EmptyErr(error.into()) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider removing `.into()`: `error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/error.rs:175:77 [INFO] [stderr] | [INFO] [stderr] 175 | Ok((v, Consumed::Empty(rest))) => Ok((v, Consumed::Consumed(rest))), [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 175 | Ok((v, Consumed::Empty(rest))) => Ok((v, Consumed::Consumed(()))), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/error.rs:763:63 [INFO] [stderr] | [INFO] [stderr] 763 | ::parser::range::take_while(|c: CloneOnly| c.s == "x".to_string()).parse(input); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `"x"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/stream/buffered.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | "Backtracked to far".into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"Backtracked to far"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/stream/easy.rs:365:29 [INFO] [stderr] | [INFO] [stderr] 365 | Self::new(position, Error::from(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `Error::from()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/stream/state.rs:222:9 [INFO] [stderr] | [INFO] [stderr] 222 | self.clone() [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/stream/mod.rs:374:5 [INFO] [stderr] | [INFO] [stderr] 374 | / loop { [INFO] [stderr] 375 | | test_next!(); [INFO] [stderr] 376 | | test_next!(); [INFO] [stderr] 377 | | test_next!(); [INFO] [stderr] ... | [INFO] [stderr] 382 | | test_next!(); [INFO] [stderr] 383 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(c) = chars.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> tests/parser_macro.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | let _ = (); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> tests/parser_macro.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | / match Some(1) { [INFO] [stderr] 12 | | Some(_) => (), [INFO] [stderr] 13 | | None => (), [INFO] [stderr] 14 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(_) = Some(1) { () }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> tests/parser_macro.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | let _ = (); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> tests/parser_macro.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | / match Some(1) { [INFO] [stderr] 12 | | Some(_) => (), [INFO] [stderr] 13 | | None => (), [INFO] [stderr] 14 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(_) = Some(1) { () }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/stream/mod.rs:1037:21 [INFO] [stderr] | [INFO] [stderr] 1037 | input.reset(before.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 1037 | input.reset(&(*before).clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 1037 | input.reset(&[i32]::clone(before)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:584:31 [INFO] [stderr] | [INFO] [stderr] 584 | pub fn $func_name<'a, B, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 615 | / integer_parser!( [INFO] [stderr] 616 | | /// Reads a u16 out of the byte stream with the specified endianess [INFO] [stderr] 617 | | /// [INFO] [stderr] 618 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 626 | | pub U16, u16, be_u16, le_u16, read_u16 [INFO] [stderr] 627 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:595:29 [INFO] [stderr] | [INFO] [stderr] 595 | pub fn $be_name<'a, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 615 | / integer_parser!( [INFO] [stderr] 616 | | /// Reads a u16 out of the byte stream with the specified endianess [INFO] [stderr] 617 | | /// [INFO] [stderr] 618 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 626 | | pub U16, u16, be_u16, le_u16, read_u16 [INFO] [stderr] 627 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:605:29 [INFO] [stderr] | [INFO] [stderr] 605 | pub fn $le_name<'a, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 615 | / integer_parser!( [INFO] [stderr] 616 | | /// Reads a u16 out of the byte stream with the specified endianess [INFO] [stderr] 617 | | /// [INFO] [stderr] 618 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 626 | | pub U16, u16, be_u16, le_u16, read_u16 [INFO] [stderr] 627 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:584:31 [INFO] [stderr] | [INFO] [stderr] 584 | pub fn $func_name<'a, B, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 628 | / integer_parser!( [INFO] [stderr] 629 | | /// Reads a u32 out of the byte stream with the specified endianess [INFO] [stderr] 630 | | /// [INFO] [stderr] 631 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 639 | | pub U32, u32, be_u32, le_u32, read_u32 [INFO] [stderr] 640 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:595:29 [INFO] [stderr] | [INFO] [stderr] 595 | pub fn $be_name<'a, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 628 | / integer_parser!( [INFO] [stderr] 629 | | /// Reads a u32 out of the byte stream with the specified endianess [INFO] [stderr] 630 | | /// [INFO] [stderr] 631 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 639 | | pub U32, u32, be_u32, le_u32, read_u32 [INFO] [stderr] 640 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:605:29 [INFO] [stderr] | [INFO] [stderr] 605 | pub fn $le_name<'a, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 628 | / integer_parser!( [INFO] [stderr] 629 | | /// Reads a u32 out of the byte stream with the specified endianess [INFO] [stderr] 630 | | /// [INFO] [stderr] 631 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 639 | | pub U32, u32, be_u32, le_u32, read_u32 [INFO] [stderr] 640 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:584:31 [INFO] [stderr] | [INFO] [stderr] 584 | pub fn $func_name<'a, B, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 641 | / integer_parser!( [INFO] [stderr] 642 | | /// Reads a u64 out of the byte stream with the specified endianess [INFO] [stderr] 643 | | /// [INFO] [stderr] 644 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 652 | | pub U64, u64, be_u64, le_u64, read_u64 [INFO] [stderr] 653 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:595:29 [INFO] [stderr] | [INFO] [stderr] 595 | pub fn $be_name<'a, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 641 | / integer_parser!( [INFO] [stderr] 642 | | /// Reads a u64 out of the byte stream with the specified endianess [INFO] [stderr] 643 | | /// [INFO] [stderr] 644 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 652 | | pub U64, u64, be_u64, le_u64, read_u64 [INFO] [stderr] 653 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:605:29 [INFO] [stderr] | [INFO] [stderr] 605 | pub fn $le_name<'a, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 641 | / integer_parser!( [INFO] [stderr] 642 | | /// Reads a u64 out of the byte stream with the specified endianess [INFO] [stderr] 643 | | /// [INFO] [stderr] 644 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 652 | | pub U64, u64, be_u64, le_u64, read_u64 [INFO] [stderr] 653 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:584:31 [INFO] [stderr] | [INFO] [stderr] 584 | pub fn $func_name<'a, B, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 655 | / integer_parser!( [INFO] [stderr] 656 | | /// Reads a i16 out of the byte stream with the specified endianess [INFO] [stderr] 657 | | /// [INFO] [stderr] 658 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 666 | | pub I16, i16, be_i16, le_i16, read_i16 [INFO] [stderr] 667 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:595:29 [INFO] [stderr] | [INFO] [stderr] 595 | pub fn $be_name<'a, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 655 | / integer_parser!( [INFO] [stderr] 656 | | /// Reads a i16 out of the byte stream with the specified endianess [INFO] [stderr] 657 | | /// [INFO] [stderr] 658 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 666 | | pub I16, i16, be_i16, le_i16, read_i16 [INFO] [stderr] 667 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:605:29 [INFO] [stderr] | [INFO] [stderr] 605 | pub fn $le_name<'a, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 655 | / integer_parser!( [INFO] [stderr] 656 | | /// Reads a i16 out of the byte stream with the specified endianess [INFO] [stderr] 657 | | /// [INFO] [stderr] 658 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 666 | | pub I16, i16, be_i16, le_i16, read_i16 [INFO] [stderr] 667 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:584:31 [INFO] [stderr] | [INFO] [stderr] 584 | pub fn $func_name<'a, B, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 669 | / integer_parser!( [INFO] [stderr] 670 | | /// Reads a i32 out of the byte stream with the specified endianess [INFO] [stderr] 671 | | /// [INFO] [stderr] 672 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 680 | | pub I32, i32, be_i32, le_i32, read_i32 [INFO] [stderr] 681 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:595:29 [INFO] [stderr] | [INFO] [stderr] 595 | pub fn $be_name<'a, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 669 | / integer_parser!( [INFO] [stderr] 670 | | /// Reads a i32 out of the byte stream with the specified endianess [INFO] [stderr] 671 | | /// [INFO] [stderr] 672 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 680 | | pub I32, i32, be_i32, le_i32, read_i32 [INFO] [stderr] 681 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:605:29 [INFO] [stderr] | [INFO] [stderr] 605 | pub fn $le_name<'a, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 669 | / integer_parser!( [INFO] [stderr] 670 | | /// Reads a i32 out of the byte stream with the specified endianess [INFO] [stderr] 671 | | /// [INFO] [stderr] 672 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 680 | | pub I32, i32, be_i32, le_i32, read_i32 [INFO] [stderr] 681 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:584:31 [INFO] [stderr] | [INFO] [stderr] 584 | pub fn $func_name<'a, B, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 682 | / integer_parser!( [INFO] [stderr] 683 | | /// Reads a i64 out of the byte stream with the specified endianess [INFO] [stderr] 684 | | /// [INFO] [stderr] 685 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 693 | | pub I64, i64, be_i64, le_i64, read_i64 [INFO] [stderr] 694 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:595:29 [INFO] [stderr] | [INFO] [stderr] 595 | pub fn $be_name<'a, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 682 | / integer_parser!( [INFO] [stderr] 683 | | /// Reads a i64 out of the byte stream with the specified endianess [INFO] [stderr] 684 | | /// [INFO] [stderr] 685 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 693 | | pub I64, i64, be_i64, le_i64, read_i64 [INFO] [stderr] 694 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:605:29 [INFO] [stderr] | [INFO] [stderr] 605 | pub fn $le_name<'a, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 682 | / integer_parser!( [INFO] [stderr] 683 | | /// Reads a i64 out of the byte stream with the specified endianess [INFO] [stderr] 684 | | /// [INFO] [stderr] 685 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 693 | | pub I64, i64, be_i64, le_i64, read_i64 [INFO] [stderr] 694 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:584:31 [INFO] [stderr] | [INFO] [stderr] 584 | pub fn $func_name<'a, B, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 696 | / integer_parser!( [INFO] [stderr] 697 | | /// Reads a i32 out of the byte stream with the specified endianess [INFO] [stderr] 698 | | /// [INFO] [stderr] 699 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 709 | | pub F32, f32, be_f32, le_f32, read_f32 [INFO] [stderr] 710 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:595:29 [INFO] [stderr] | [INFO] [stderr] 595 | pub fn $be_name<'a, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 696 | / integer_parser!( [INFO] [stderr] 697 | | /// Reads a i32 out of the byte stream with the specified endianess [INFO] [stderr] 698 | | /// [INFO] [stderr] 699 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 709 | | pub F32, f32, be_f32, le_f32, read_f32 [INFO] [stderr] 710 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:605:29 [INFO] [stderr] | [INFO] [stderr] 605 | pub fn $le_name<'a, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 696 | / integer_parser!( [INFO] [stderr] 697 | | /// Reads a i32 out of the byte stream with the specified endianess [INFO] [stderr] 698 | | /// [INFO] [stderr] 699 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 709 | | pub F32, f32, be_f32, le_f32, read_f32 [INFO] [stderr] 710 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:584:31 [INFO] [stderr] | [INFO] [stderr] 584 | pub fn $func_name<'a, B, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 711 | / integer_parser!( [INFO] [stderr] 712 | | /// Reads a i64 out of the byte stream with the specified endianess [INFO] [stderr] 713 | | /// [INFO] [stderr] 714 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 724 | | pub F64, f64, be_f64, le_f64, read_f64 [INFO] [stderr] 725 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:595:29 [INFO] [stderr] | [INFO] [stderr] 595 | pub fn $be_name<'a, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 711 | / integer_parser!( [INFO] [stderr] 712 | | /// Reads a i64 out of the byte stream with the specified endianess [INFO] [stderr] 713 | | /// [INFO] [stderr] 714 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 724 | | pub F64, f64, be_f64, le_f64, read_f64 [INFO] [stderr] 725 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser/byte.rs:605:29 [INFO] [stderr] | [INFO] [stderr] 605 | pub fn $le_name<'a, I>() -> $type_name [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 711 | / integer_parser!( [INFO] [stderr] 712 | | /// Reads a i64 out of the byte stream with the specified endianess [INFO] [stderr] 713 | | /// [INFO] [stderr] 714 | | /// ``` [INFO] [stderr] ... | [INFO] [stderr] 724 | | pub F64, f64, be_f64, le_f64, read_f64 [INFO] [stderr] 725 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> benches/http.rs:93:43 [INFO] [stderr] | [INFO] [stderr] 93 | fn parse_http_request<'a, I>(input: I) -> Result<((Request<'a>, Vec>), I), I::Error> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/parser/combinator.rs:290:41 [INFO] [stderr] | [INFO] [stderr] 290 | Err(err) => ConsumedErr(err.into()), [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/parser/combinator.rs:359:25 [INFO] [stderr] | [INFO] [stderr] 359 | ::Error::from_error(position, err.into()).into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `::Error::from_error(position, err.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/parser/combinator.rs:788:38 [INFO] [stderr] | [INFO] [stderr] 788 | let child_state = if let None = state.0 { [INFO] [stderr] | _______________________________- ^^^^ [INFO] [stderr] 789 | | new_child_state = Some(Default::default()); [INFO] [stderr] 790 | | new_child_state.as_mut().unwrap() [INFO] [stderr] 791 | | } else { [INFO] [stderr] 792 | | new_child_state = None; [INFO] [stderr] 793 | | state.0.as_mut().unwrap().downcast_mut().unwrap() [INFO] [stderr] 794 | | }; [INFO] [stderr] | |_____________- help: try this: `if state.0.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/parser/item.rs:273:34 [INFO] [stderr] | [INFO] [stderr] 273 | EmptyErr(error.into()) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider removing `.into()`: `error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> benches/json.rs:81:34 [INFO] [stderr] | [INFO] [stderr] 81 | Some(d) => acc + (d as f64) * magnitude, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(d)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> tests/parser.rs:79:25 [INFO] [stderr] | [INFO] [stderr] 79 | let result_err: Result<(Vec<(char, char)>, &str), ParseError<&str>> = [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:903:16 [INFO] [stderr] | [INFO] [stderr] 903 | fn integer<'a, I>(input: &mut I) -> ParseResult [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `combine`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> tests/async.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | let ref mut reader = Cursor::new(input.as_ref()); [INFO] [stderr] | ----^^^^^^^^^^^^^^------------------------------- help: try: `let reader = &mut Cursor::new(input.as_ref());` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "2c8d65ee4c8ff92f006c29dfb3647c376c9cb6a9114233027aec51781710b8e0"` [INFO] running `"docker" "rm" "-f" "2c8d65ee4c8ff92f006c29dfb3647c376c9cb6a9114233027aec51781710b8e0"` [INFO] [stdout] 2c8d65ee4c8ff92f006c29dfb3647c376c9cb6a9114233027aec51781710b8e0