[INFO] crate column_derive 0.0.1 is already in cache [INFO] extracting crate column_derive 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/column_derive/0.0.1 [INFO] extracting crate column_derive 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/column_derive/0.0.1 [INFO] validating manifest of column_derive-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of column_derive-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing column_derive-0.0.1 [INFO] finished frobbing column_derive-0.0.1 [INFO] frobbed toml for column_derive-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/column_derive/0.0.1/Cargo.toml [INFO] started frobbing column_derive-0.0.1 [INFO] finished frobbing column_derive-0.0.1 [INFO] frobbed toml for column_derive-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/column_derive/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting column_derive-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/column_derive/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cb9c21523454a5478dca8a1a26d7608a15365f8ae26767f547a5b2b4b80da279 [INFO] running `"docker" "start" "-a" "cb9c21523454a5478dca8a1a26d7608a15365f8ae26767f547a5b2b4b80da279"` [INFO] [stderr] Checking column_derive v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | / match print_generated_code(&result_string, &ast, source) { [INFO] [stderr] 53 | | Err(reason) => panic!(reason), [INFO] [stderr] 54 | | Ok(_) => {}, [INFO] [stderr] 55 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(reason) = print_generated_code(&result_string, &ast, source) { panic!(reason) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:87:41 [INFO] [stderr] | [INFO] [stderr] 87 | fn print_generated_code(_result_string: &String, _ast: &syn::MacroInput, _source: String) -> ::std::io::Result<()> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:210:13 [INFO] [stderr] | [INFO] [stderr] 210 | let ref name = self.type_ref; [INFO] [stderr] | ----^^^^^^^^----------------- help: try: `let name = &self.type_ref;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:219:13 [INFO] [stderr] | [INFO] [stderr] 219 | let ref vis = self.ast.vis; [INFO] [stderr] | ----^^^^^^^---------------- help: try: `let vis = &self.ast.vis;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:231:13 [INFO] [stderr] | [INFO] [stderr] 231 | let ref name = self.type_ref_mut; [INFO] [stderr] | ----^^^^^^^^--------------------- help: try: `let name = &self.type_ref_mut;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:240:13 [INFO] [stderr] | [INFO] [stderr] 240 | let ref vis = self.ast.vis; [INFO] [stderr] | ----^^^^^^^---------------- help: try: `let vis = &self.ast.vis;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:251:13 [INFO] [stderr] | [INFO] [stderr] 251 | let ref name = self.type_container; [INFO] [stderr] | ----^^^^^^^^----------------------- help: try: `let name = &self.type_container;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:267:13 [INFO] [stderr] | [INFO] [stderr] 267 | let ref vis = self.ast.vis; [INFO] [stderr] | ----^^^^^^^---------------- help: try: `let vis = &self.ast.vis;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:296:13 [INFO] [stderr] | [INFO] [stderr] 296 | let ref vis = self.ast.vis; [INFO] [stderr] | ----^^^^^^^---------------- help: try: `let vis = &self.ast.vis;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:307:13 [INFO] [stderr] | [INFO] [stderr] 307 | let ref type_continer = self.type_container; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^----------------------- help: try: `let type_continer = &self.type_container;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:308:13 [INFO] [stderr] | [INFO] [stderr] 308 | let ref type_column = self.ast.ident; [INFO] [stderr] | ----^^^^^^^^^^^^^^^------------------ help: try: `let type_column = &self.ast.ident;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:325:13 [INFO] [stderr] | [INFO] [stderr] 325 | let ref type_container = self.type_container; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^----------------------- help: try: `let type_container = &self.type_container;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:356:13 [INFO] [stderr] | [INFO] [stderr] 356 | let ref name = self.type_container; [INFO] [stderr] | ----^^^^^^^^----------------------- help: try: `let name = &self.type_container;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:370:13 [INFO] [stderr] | [INFO] [stderr] 370 | let ref name = self.type_container; [INFO] [stderr] | ----^^^^^^^^----------------------- help: try: `let name = &self.type_container;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:408:13 [INFO] [stderr] | [INFO] [stderr] 408 | let ref type_column = self.ast.ident; [INFO] [stderr] | ----^^^^^^^^^^^^^^^------------------ help: try: `let type_column = &self.ast.ident;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:421:13 [INFO] [stderr] | [INFO] [stderr] 421 | let ref type_ref_mut = self.type_ref_mut; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^--------------------- help: try: `let type_ref_mut = &self.type_ref_mut;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:475:13 [INFO] [stderr] | [INFO] [stderr] 475 | let ref name = self.ast.ident; [INFO] [stderr] | ----^^^^^^^^------------------ help: try: `let name = &self.ast.ident;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:476:13 [INFO] [stderr] | [INFO] [stderr] 476 | let ref type_container = self.type_container; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^----------------------- help: try: `let type_container = &self.type_container;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:494:13 [INFO] [stderr] | [INFO] [stderr] 494 | let ref type_container = self.type_container; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^----------------------- help: try: `let type_container = &self.type_container;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:520:13 [INFO] [stderr] | [INFO] [stderr] 520 | let ref name = self.ast.ident; [INFO] [stderr] | ----^^^^^^^^------------------ help: try: `let name = &self.ast.ident;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.44s [INFO] running `"docker" "inspect" "cb9c21523454a5478dca8a1a26d7608a15365f8ae26767f547a5b2b4b80da279"` [INFO] running `"docker" "rm" "-f" "cb9c21523454a5478dca8a1a26d7608a15365f8ae26767f547a5b2b4b80da279"` [INFO] [stdout] cb9c21523454a5478dca8a1a26d7608a15365f8ae26767f547a5b2b4b80da279