[INFO] crate colosseum 0.2.2 is already in cache [INFO] extracting crate colosseum 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/colosseum/0.2.2 [INFO] extracting crate colosseum 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/colosseum/0.2.2 [INFO] validating manifest of colosseum-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of colosseum-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing colosseum-0.2.2 [INFO] finished frobbing colosseum-0.2.2 [INFO] frobbed toml for colosseum-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/colosseum/0.2.2/Cargo.toml [INFO] started frobbing colosseum-0.2.2 [INFO] finished frobbing colosseum-0.2.2 [INFO] frobbed toml for colosseum-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/colosseum/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting colosseum-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/colosseum/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d1e4d6fee9344592e32a7d0f15cb127a2c2cdefd81ee174e30105490517c10b9 [INFO] running `"docker" "start" "-a" "d1e4d6fee9344592e32a7d0f15cb127a2c2cdefd81ee174e30105490517c10b9"` [INFO] [stderr] Checking colosseum v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider adding a `Default` implementation for `sync::Arena` [INFO] [stderr] --> src/sync.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> Arena { [INFO] [stderr] 17 | | Arena { chunks: Mutex::new(ChunkList::new()) } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | impl Default for sync::Arena { [INFO] [stderr] 15 | fn default() -> Self { [INFO] [stderr] 16 | Self::new() [INFO] [stderr] 17 | } [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/sync.rs:27:34 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn alloc(&self, t: T) -> &mut T { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::mut_from_ref)] on by default [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/sync.rs:27:18 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn alloc(&self, t: T) -> &mut T { [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/sync.rs:38:71 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn alloc_extend>(&self, iterable: I) -> &mut [T] { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/sync.rs:38:48 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn alloc_extend>(&self, iterable: I) -> &mut [T] { [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `unsync::Arena` [INFO] [stderr] --> src/unsync.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> Arena { [INFO] [stderr] 17 | | Arena { chunks: RefCell::new(ChunkList::new()) } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | impl Default for unsync::Arena { [INFO] [stderr] 15 | fn default() -> Self { [INFO] [stderr] 16 | Self::new() [INFO] [stderr] 17 | } [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/unsync.rs:27:34 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn alloc(&self, t: T) -> &mut T { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/unsync.rs:27:18 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn alloc(&self, t: T) -> &mut T { [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/unsync.rs:37:71 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn alloc_extend>(&self, iterable: I) -> &mut [T] { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/unsync.rs:37:48 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn alloc_extend>(&self, iterable: I) -> &mut [T] { [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `colosseum`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you should consider adding a `Default` implementation for `sync::Arena` [INFO] [stderr] --> src/sync.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> Arena { [INFO] [stderr] 17 | | Arena { chunks: Mutex::new(ChunkList::new()) } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | impl Default for sync::Arena { [INFO] [stderr] 15 | fn default() -> Self { [INFO] [stderr] 16 | Self::new() [INFO] [stderr] 17 | } [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/sync.rs:27:34 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn alloc(&self, t: T) -> &mut T { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::mut_from_ref)] on by default [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/sync.rs:27:18 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn alloc(&self, t: T) -> &mut T { [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/sync.rs:38:71 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn alloc_extend>(&self, iterable: I) -> &mut [T] { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/sync.rs:38:48 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn alloc_extend>(&self, iterable: I) -> &mut [T] { [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/sync.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | mem::drop(node); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_ref)] on by default [INFO] [stderr] note: argument has type &sync::test::Node<'_, '_> [INFO] [stderr] --> src/sync.rs:97:23 [INFO] [stderr] | [INFO] [stderr] 97 | mem::drop(node); [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `unsync::Arena` [INFO] [stderr] --> src/unsync.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> Arena { [INFO] [stderr] 17 | | Arena { chunks: RefCell::new(ChunkList::new()) } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | impl Default for unsync::Arena { [INFO] [stderr] 15 | fn default() -> Self { [INFO] [stderr] 16 | Self::new() [INFO] [stderr] 17 | } [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/unsync.rs:27:34 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn alloc(&self, t: T) -> &mut T { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/unsync.rs:27:18 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn alloc(&self, t: T) -> &mut T { [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/unsync.rs:37:71 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn alloc_extend>(&self, iterable: I) -> &mut [T] { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/unsync.rs:37:48 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn alloc_extend>(&self, iterable: I) -> &mut [T] { [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/unsync.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | mem::drop(node); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type &unsync::test::Node<'_, '_> [INFO] [stderr] --> src/unsync.rs:89:23 [INFO] [stderr] | [INFO] [stderr] 89 | mem::drop(node); [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `colosseum`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d1e4d6fee9344592e32a7d0f15cb127a2c2cdefd81ee174e30105490517c10b9"` [INFO] running `"docker" "rm" "-f" "d1e4d6fee9344592e32a7d0f15cb127a2c2cdefd81ee174e30105490517c10b9"` [INFO] [stdout] d1e4d6fee9344592e32a7d0f15cb127a2c2cdefd81ee174e30105490517c10b9