[INFO] crate colortemp 0.1.0 is already in cache [INFO] extracting crate colortemp 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/colortemp/0.1.0 [INFO] extracting crate colortemp 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/colortemp/0.1.0 [INFO] validating manifest of colortemp-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of colortemp-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing colortemp-0.1.0 [INFO] finished frobbing colortemp-0.1.0 [INFO] frobbed toml for colortemp-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/colortemp/0.1.0/Cargo.toml [INFO] started frobbing colortemp-0.1.0 [INFO] finished frobbing colortemp-0.1.0 [INFO] frobbed toml for colortemp-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/colortemp/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting colortemp-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/colortemp/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bbc6af13f2ad154863415aeda2bca387cb975b25dfd69d5ca4ca559944ecc020 [INFO] running `"docker" "start" "-a" "bbc6af13f2ad154863415aeda2bca387cb975b25dfd69d5ca4ca559944ecc020"` [INFO] [stderr] Checking colortemp v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `colortemp::*` [INFO] [stderr] --> src/tests.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use colortemp::*; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | / return RGB { [INFO] [stderr] 90 | | r: r.round(), [INFO] [stderr] 91 | | g: g.round(), [INFO] [stderr] 92 | | b: b.round(), [INFO] [stderr] 93 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 89 | RGB { [INFO] [stderr] 90 | r: r.round(), [INFO] [stderr] 91 | g: g.round(), [INFO] [stderr] 92 | b: b.round(), [INFO] [stderr] 93 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:60:17 [INFO] [stderr] | [INFO] [stderr] 60 | r = 329.698727446 * r.powf(-329.698727446); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `329.698_727_446` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:60:41 [INFO] [stderr] | [INFO] [stderr] 60 | r = 329.698727446 * r.powf(-329.698727446); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `329.698_727_446` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:67:17 [INFO] [stderr] | [INFO] [stderr] 67 | g = 99.4708025861 * g.ln() - 161.1195681661; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `99.470_802_586_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:67:42 [INFO] [stderr] | [INFO] [stderr] 67 | g = 99.4708025861 * g.ln() - 161.1195681661; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `161.119_568_166_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:71:17 [INFO] [stderr] | [INFO] [stderr] 71 | g = 288.1221695283 * g.powf(-0.0755148492); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `288.122_169_528_3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:71:42 [INFO] [stderr] | [INFO] [stderr] 71 | g = 288.1221695283 * g.powf(-0.0755148492); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.075_514_849_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:78:16 [INFO] [stderr] | [INFO] [stderr] 78 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 79 | | [INFO] [stderr] 80 | | if temp <= 19 { [INFO] [stderr] 81 | | b = 0.; [INFO] [stderr] ... | [INFO] [stderr] 86 | | } [INFO] [stderr] 87 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 78 | } else if temp <= 19 { [INFO] [stderr] 79 | b = 0.; [INFO] [stderr] 80 | } else { [INFO] [stderr] 81 | b = temp as f64 - 10.; [INFO] [stderr] 82 | b = 138.5177312231 * b.ln() - 305.0447927307; [INFO] [stderr] 83 | normalise!(b); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:84:21 [INFO] [stderr] | [INFO] [stderr] 84 | b = 138.5177312231 * b.ln() - 305.0447927307; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `138.517_731_223_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:84:47 [INFO] [stderr] | [INFO] [stderr] 84 | b = 138.5177312231 * b.ln() - 305.0447927307; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `305.044_792_730_7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | return temp; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `temp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | / return RGB { [INFO] [stderr] 90 | | r: r.round(), [INFO] [stderr] 91 | | g: g.round(), [INFO] [stderr] 92 | | b: b.round(), [INFO] [stderr] 93 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 89 | RGB { [INFO] [stderr] 90 | r: r.round(), [INFO] [stderr] 91 | g: g.round(), [INFO] [stderr] 92 | b: b.round(), [INFO] [stderr] 93 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:60:17 [INFO] [stderr] | [INFO] [stderr] 60 | r = 329.698727446 * r.powf(-329.698727446); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `329.698_727_446` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:60:41 [INFO] [stderr] | [INFO] [stderr] 60 | r = 329.698727446 * r.powf(-329.698727446); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `329.698_727_446` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:67:17 [INFO] [stderr] | [INFO] [stderr] 67 | g = 99.4708025861 * g.ln() - 161.1195681661; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `99.470_802_586_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:67:42 [INFO] [stderr] | [INFO] [stderr] 67 | g = 99.4708025861 * g.ln() - 161.1195681661; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `161.119_568_166_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:71:17 [INFO] [stderr] | [INFO] [stderr] 71 | g = 288.1221695283 * g.powf(-0.0755148492); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `288.122_169_528_3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:71:42 [INFO] [stderr] | [INFO] [stderr] 71 | g = 288.1221695283 * g.powf(-0.0755148492); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.075_514_849_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:78:16 [INFO] [stderr] | [INFO] [stderr] 78 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 79 | | [INFO] [stderr] 80 | | if temp <= 19 { [INFO] [stderr] 81 | | b = 0.; [INFO] [stderr] ... | [INFO] [stderr] 86 | | } [INFO] [stderr] 87 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 78 | } else if temp <= 19 { [INFO] [stderr] 79 | b = 0.; [INFO] [stderr] 80 | } else { [INFO] [stderr] 81 | b = temp as f64 - 10.; [INFO] [stderr] 82 | b = 138.5177312231 * b.ln() - 305.0447927307; [INFO] [stderr] 83 | normalise!(b); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:84:21 [INFO] [stderr] | [INFO] [stderr] 84 | b = 138.5177312231 * b.ln() - 305.0447927307; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `138.517_731_223_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:84:47 [INFO] [stderr] | [INFO] [stderr] 84 | b = 138.5177312231 * b.ln() - 305.0447927307; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `305.044_792_730_7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | return temp; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `temp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.97s [INFO] running `"docker" "inspect" "bbc6af13f2ad154863415aeda2bca387cb975b25dfd69d5ca4ca559944ecc020"` [INFO] running `"docker" "rm" "-f" "bbc6af13f2ad154863415aeda2bca387cb975b25dfd69d5ca4ca559944ecc020"` [INFO] [stdout] bbc6af13f2ad154863415aeda2bca387cb975b25dfd69d5ca4ca559944ecc020